From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 21 16:27:36 2015 Received: (at submit) by debbugs.gnu.org; 21 Nov 2015 21:27:36 +0000 Received: from localhost ([127.0.0.1]:47382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0Fh1-0001Rx-KK for submit@debbugs.gnu.org; Sat, 21 Nov 2015 16:27:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47610) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0Fgz-0001Ro-G9 for submit@debbugs.gnu.org; Sat, 21 Nov 2015 16:27:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0Fgy-0002Ag-IT for submit@debbugs.gnu.org; Sat, 21 Nov 2015 16:27:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Fgy-0002Ac-FR for submit@debbugs.gnu.org; Sat, 21 Nov 2015 16:27:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Fgx-0007q1-MG for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 16:27:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0Fgt-0002AN-Ih for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 16:27:31 -0500 Received: from mail.nullprogram.com ([192.241.191.137]:36963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Fgt-00029Z-FI for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 16:27:27 -0500 Received: from localhost ([127.0.0.1] helo=tengu.zeus.nullprogram.com) by mail.nullprogram.com with esmtp (Exim 4.84) (envelope-from ) id 1a0Fgm-0004bn-V5; Sat, 21 Nov 2015 16:27:21 -0500 From: Christopher Wellons To: bug-gnu-emacs@gnu.org Subject: [PATCH] Update gv setter for frame-width and frame-height. Date: Sat, 21 Nov 2015 16:26:23 -0500 Message-Id: <1448141183-12418-1-git-send-email-wellons@nullprogram.com> X-Mailer: git-send-email 2.1.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Christopher Wellons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Neither set-screen-width nor set-screen-height still exist, having been replaced by set-frame-width and set-frame-height. These newer functions take a frame as a second argument, so a simple setter will no longer work. --- lisp/emacs-lisp/cl-lib.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index 2dd0519..5a90c19 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -660,10 +660,12 @@ cl-pairlis (gv-define-setter face-underline-p (x f &optional s) `(set-face-underline ,f ,x ,s)) (gv-define-simple-setter file-modes set-file-modes t) -(gv-define-simple-setter frame-height set-screen-height t) +(gv-define-setter frame-height (x &optional frame) + `(set-frame-height (or ,frame (selected-frame)) ,x)) (gv-define-simple-setter frame-parameters modify-frame-parameters t) (gv-define-simple-setter frame-visible-p cl--set-frame-visible-p) -(gv-define-simple-setter frame-width set-screen-width t) +(gv-define-setter frame-width (x &optional frame) + `(set-frame-width (or ,frame (selected-frame)) ,x)) (gv-define-simple-setter getenv setenv t) (gv-define-simple-setter get-register set-register) (gv-define-simple-setter global-key-binding global-set-key) -- 2.1.4 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 23:46:07 2016 Received: (at 21979) by debbugs.gnu.org; 23 Feb 2016 04:46:07 +0000 Received: from localhost ([127.0.0.1]:38782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY4rO-0001ci-UB for submit@debbugs.gnu.org; Mon, 22 Feb 2016 23:46:07 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:36646) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY4rM-0001Zp-UY for 21979@debbugs.gnu.org; Mon, 22 Feb 2016 23:46:06 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aY4qy-0000Gf-7m; Tue, 23 Feb 2016 05:45:40 +0100 From: Lars Ingebrigtsen To: Christopher Wellons Subject: Re: bug#21979: [PATCH] Update gv setter for frame-width and frame-height. References: <1448141183-12418-1-git-send-email-wellons@nullprogram.com> Date: Tue, 23 Feb 2016 15:45:35 +1100 In-Reply-To: <1448141183-12418-1-git-send-email-wellons@nullprogram.com> (Christopher Wellons's message of "Sat, 21 Nov 2015 16:26:23 -0500") Message-ID: <87fuwk2fww.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aY4qy-0000Gf-7m X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456807541.30981@ZZmn8rZYPPe9bDuHKXA25A X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21979 Cc: 21979@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Christopher Wellons writes: > Neither set-screen-width nor set-screen-height still exist, having been > replaced by set-frame-width and set-frame-height. These newer functions > take a frame as a second argument, so a simple setter will no longer > work. Thanks; applied to emacs-25. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 23:46:13 2016 Received: (at control) by debbugs.gnu.org; 23 Feb 2016 04:46:13 +0000 Received: from localhost ([127.0.0.1]:38785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY4rV-0001iT-6h for submit@debbugs.gnu.org; Mon, 22 Feb 2016 23:46:13 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:36652) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY4rS-0001gN-Uq for control@debbugs.gnu.org; Mon, 22 Feb 2016 23:46:11 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aY4r6-0000Gq-DZ for control@debbugs.gnu.org; Tue, 23 Feb 2016 05:45:49 +0100 Date: Tue, 23 Feb 2016 15:45:44 +1100 Message-Id: <87egc42fwn.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21979 X-MailScanner-ID: 1aY4r6-0000Gq-DZ X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456807549.19021@3D7x+2/k4AhkSyz268suUg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 21979 fixed close 21979 25.1 From unknown Tue Jun 24 20:53:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 22 Mar 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator