Subject: bug#21971: 25.1.50; EUDC conversion to BBDB 3 incompatibility

From: Thomas Fitzsimmons <[email-masked]>
Date: Sat, 21 Nov 2015 21:44:05 -0500

Hi George,

George McNinch <[email-masked]> writes:

[...]

> In fact, a record *has* been inserted into the bbdb; in this case it
> looks like
>
> ["George" "McNinch" nil "[email-masked]" nil nil nil nil ((creation-date . "2015-11-21 14:13:29 +0000") (timestamp . "2015-11-21 14:13:29 +0000")) nil]
>
> (assuming McNinch was not already in the bbdb, of course).
>
> This record seems "mangled" from the point-of-view of BBDB3 - the email
> address should be "in a list" inside this record-vector. Perhaps other
> things are amiss, as well.

Thank you for the detailed description of how to replicate the issue.

> Note also that the setting of eudc-ldap-bbdb-conversion-alist I made
> above isn't quite the original value. If I instead use the original
> value, e.g. by instead using the original value
>
> [which amounts to:
>
>   (setq eudc-ldap-bbdb-conversion-alist
> 	`((name . cn)
> 	  (net . mail)
> 	  (address eudc-bbdbify-address postaladdress "Address")
> 	  (phone
> 	   (eudc-bbdbify-phone telephonenumber "Phone")))
>
>
> in the initialization of EUDC],
>
> then when I press "b" on a record
> in the *Directory Query Results* buffer, I get the error
>
> eudc-bbdbify-phone: Symbol’s function definition is void:
> bbdb-parse-phone-number

OK, this seems like a separate issue.  I haven't investigated it yet.

With your eudc-ldap-bbdb-conversion-alist workaround still enabled, can
you try the attached patch to see if it fixes exporting for you?

Thanks,
Thomas

>From 3a4870a3076467c8465df9ba5dd0646acf1d6fd0 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons <[email-masked]>
Date: Sat, 21 Nov 2015 21:24:27 -0500
Subject: [PATCH] Add BBDB 3 support for EUDC export

* eudc.el: Add bbdb-version defvar.
(eudc--using-bbdb-3-or-newer-p): New function.
* eudc-export.el (eudc-create-bbdb-record): Add support for
bbdb-create-internal argument list changes introduced in BBDB 3.
* eudcb-bbdb.el: Remove bbdb-version defvar.
(eudc-bbdb-field): Call eudc--using-bbdb-3-or-newer-p.
---
 lisp/net/eudc-export.el | 19 +++++++++++++------
 lisp/net/eudc.el        | 12 ++++++++++++
 lisp/net/eudcb-bbdb.el  | 10 +---------
 3 files changed, 26 insertions(+), 15 deletions(-)

diff --git a/lisp/net/eudc-export.el b/lisp/net/eudc-export.el
index c60911f..a65f555 100644
--- a/lisp/net/eudc-export.el
+++ b/lisp/net/eudc-export.el
@@ -86,12 +86,19 @@ eudc-create-bbdb-record
 					      (cons (car mapping) value))))
 				       conversion-alist)))
       (setq bbdb-notes (delq nil bbdb-notes))
-      (setq bbdb-record (bbdb-create-internal bbdb-name
-					      bbdb-company
-					      bbdb-net
-					      bbdb-address
-					      bbdb-phones
-					      bbdb-notes))
+      (setq bbdb-record (bbdb-create-internal
+			 bbdb-name
+			 ,@(when (eudc--using-bbdb-3-or-newer-p)
+			     '(nil
+			       nil))
+			 bbdb-company
+			 bbdb-net
+			 ,@(if (eudc--using-bbdb-3-or-newer-p)
+			       '(bbdb-phones
+				 bbdb-address)
+			     '(bbdb-address
+			       bbdb-phones))
+			 bbdb-notes))
       (or silent
 	  (bbdb-display-records (list bbdb-record))))))
 
diff --git a/lisp/net/eudc.el b/lisp/net/eudc.el
index 7280d9d..25a26bd 100644
--- a/lisp/net/eudc.el
+++ b/lisp/net/eudc.el
@@ -107,6 +107,18 @@ eudc-switch-from-server-hook
 ;; attribute name
 (defvar eudc-protocol-has-default-query-attributes nil)
 
+(defvar bbdb-version)
+
+(defun eudc--using-bbdb-3-or-newer-p ()
+  "Return non-nil if BBDB version is 3 or greater."
+  (or
+   ;; MELPA versions of BBDB may have a bad package version, but
+   ;; they're all version 3 or later.
+   (equal bbdb-version "@PACKAGE_VERSION@")
+   ;; Development versions of BBDB can have the format "X.YZ devo".
+   ;; Split the string just in case.
+   (version<= "3" (car (split-string bbdb-version)))))
+
 (defun eudc-plist-member (plist prop)
   "Return t if PROP has a value specified in PLIST."
   (if (not (= 0 (% (length plist) 2)))
diff --git a/lisp/net/eudcb-bbdb.el b/lisp/net/eudcb-bbdb.el
index 0545304..1972fc1 100644
--- a/lisp/net/eudcb-bbdb.el
+++ b/lisp/net/eudcb-bbdb.el
@@ -42,21 +42,13 @@
 (defvar eudc-bbdb-current-query nil)
 (defvar eudc-bbdb-current-return-attributes nil)
 
-(defvar bbdb-version)
-
 (defun eudc-bbdb-field (field-symbol)
   "Convert FIELD-SYMBOL so that it is recognized by the current BBDB version.
 BBDB < 3 used `net'; BBDB >= 3 uses `mail'."
   ;; This just-in-time translation permits upgrading from BBDB 2 to
   ;; BBDB 3 without restarting Emacs.
   (if (and (eq field-symbol 'net)
-	   (or
-	    ;; MELPA versions of BBDB may have a bad package version,
-	    ;; but they're all version 3 or later.
-	    (equal bbdb-version "@PACKAGE_VERSION@")
-	    ;; Development versions of BBDB can have the format "X.YZ
-	    ;; devo".  Split the string just in case.
-	    (version<= "3" (car (split-string bbdb-version)))))
+	   (eudc--using-bbdb-3-or-newer-p))
       'mail
     field-symbol))
 
-- 
1.8.3.1