From unknown Sat Sep 06 00:10:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer Resent-From: Sven Joachim Original-Sender: "Debbugs-submit" Resent-CC: svenjoac@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2015 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21955@debbugs.gnu.org Cc: Sven Joachim X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Sven Joachim Received: via spool by submit@debbugs.gnu.org id=B.14478724816914 (code B ref -1); Wed, 18 Nov 2015 18:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Nov 2015 18:48:01 +0000 Received: from localhost ([127.0.0.1]:43668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz7lw-0001nS-QM for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:48:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47983) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz7lu-0001nH-GJ for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:47:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz7lt-0000KR-0A for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:47:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7ls-0000KN-U4 for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:47:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7lr-00045O-Kx for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 13:47:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz7lo-0000JJ-Co for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 13:47:55 -0500 Received: from mout.gmx.net ([212.227.15.18]:65025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7lo-0000Ir-3b for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 13:47:52 -0500 Received: from localhost.localdomain ([79.224.41.247]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MBWTO-1a7OyW1e6Q-00AUEy for ; Wed, 18 Nov 2015 19:47:50 +0100 Received: by localhost.localdomain (Postfix, from userid 1000) id BE1DA3F250; Wed, 18 Nov 2015 19:47:48 +0100 (CET) From: Sven Joachim Date: Wed, 18 Nov 2015 19:47:48 +0100 Message-ID: <877flfi1pn.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:ba/nnPxA5hpflTaON+A0xwlQkz/k20PNwhcxo2QUxGIT1ZO/6iW SfJ8NrjwdYJWqQ/42WBBAzjnQnLEsIZ+Qa7GthvEbMWjOGSmM/H50GDb/aUurnJmf3d9CZ/ s9akTtPp8+Bq646ZhzYl6iQ+2j/IC1UXb9Hu9S75DRR5hhIQxvxMRsBeLu71CZaPg/nx12Q g0zA3A69j4GFJhomR8UVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:/JAxWD5GyQY=:LD6ZKujhvIh9iVsMtL+vD1 EeknwmtomRcSB157Dnjq9hvzJ0XJU6xdI1DtwTaNDZRHv+byAY/jD/fLRlLNbVH8HmuOpUY2G S5fqKPoB1eSXCAzlh9cdMmF0IMP9GLdYVaqjWU8P4lYZaALN+UXzlyalS6r54soEX/rlTB9oe JE6ODA2BJJwEa4vP+iPXINXe47m4Km2HJVLiH0MCmq74rm8ONlenGeET18bNJ2zM4UyAlcFcN RTdKL9AcSmd+lP9bGyYSDIv+cnHzm9z5BCsZZSuGxPdEH9Wr7cRbhPZRndG8ijBU21nvjzyYv 2rEO1nrFBw7FU0RxgVhRrTFB/zoCrbZkODGEPv4RsBFAJEuvvY5BvrWygsZxfsvrx8gRLMSL6 5YJYewcc6DKbP2npbuYJ3WIylY/l3M1pFZHKpBtGFN70o6ZbsH69P/QC8FDpJvJ2LBT0zizP3 qkfbEYmbSDuP+z2AoWw1irYfMuCi0Cz10JOEPcFDqWFi1uOQUoD44B3bem9YtKTK874LJvCMr zTZRdBoErCmqLo2Nh4IkI72bA6ZIsJBAh/lg4zcpMsfspDRAQokgEfEpoeqeXDO3SFT7b/1bF JKm/aFJZzSLeqBeIbtk2PXSuDIvd7FPjGNbE8VPG6ASeCaQmXVzjGQDOfWO1MBhRvE5+LLnAN +x5h+9yX4l1QOPa89OacnhGcIUplbjm+/nsGqfmU+rj1IAPqnJfipJOfzV5ONkgc7VLIYmdq3 8CMKzHjkM3U6GBHvDbAq8rBubpz2zC8dyu1IMDMdFcRPnUTMlSDtjOj9Fq6nWFY6AW7f7btiG +DuQk1b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Visit some file in a git repository, make a change and save it. Press C-x v l do view the file's version history. Press C-x v v to commit your changes. Result is an error: vc-next-action: Wrong type argument: listp, "/usr/local/src/emacs/" Of course, the last argument is the default-directory here. In GNU Emacs 25.0.50.2 (i586-pc-linux-gnu, GTK+ Version 2.24.28) of 2015-11-18 Repository revision: bb4303c536a2ac5fe683a711ef8072074f77670e Windowing system distributor 'The X.Org Foundation', version 11.0.11703000 System Description: Debian GNU/Linux Configured using: 'configure --build i586-linux-gnu --host i586-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var --infodir=/usr/share/info/emacs-snapshot --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/25.0.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.0.50/site-lisp:/usr/share/emacs/site-lisp --without-wide-int --disable-silent-rules --without-compress-install --with-x=yes --with-x-toolkit=gtk2 --without-gconf --without-gsettings build_alias=i586-linux-gnu host_alias=i586-linux-gnu 'CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security' 'LDFLAGS=-Wl,-z,relro -Wl,--as-needed' 'CPPFLAGS=-D_FORTIFY_SOURCE=2 -DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LC_COLLATE: C value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Git-Log-View Minor modes in effect: diff-auto-refine-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Saving file /usr/local/src/emacs/BUGS... Wrote /usr/local/src/emacs/BUGS vc-next-action: Wrong type argument: listp, "/usr/local/src/emacs/" Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs add-log log-view pcvs-util vc vc-dispatcher vc-git diff-mode easy-mmode map seq byte-opt gv bytecomp byte-compile cconv cl-extra help-mode easymenu cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 95807 6514) (symbols 24 20842 0) (miscs 20 58 118) (strings 16 19201 3353) (string-bytes 1 551091) (vectors 8 14402) (vector-slots 4 457909 2418) (floats 8 176 70) (intervals 28 337 7) (buffers 520 13) (heap 1024 29332 521)) From unknown Sat Sep 06 00:10:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2015 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sven Joachim , 21955@debbugs.gnu.org Received: via spool by 21955-submit@debbugs.gnu.org id=B21955.14478727907545 (code B ref 21955); Wed, 18 Nov 2015 18:54:02 +0000 Received: (at 21955) by debbugs.gnu.org; 18 Nov 2015 18:53:10 +0000 Received: from localhost ([127.0.0.1]:43679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz7qw-0001xa-BM for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:53:10 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36541) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz7qu-0001xQ-Oe for 21955@debbugs.gnu.org; Wed, 18 Nov 2015 13:53:09 -0500 Received: by wmww144 with SMTP id w144so209891878wmw.1 for <21955@debbugs.gnu.org>; Wed, 18 Nov 2015 10:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=ODsq7TmetuS4Xcjq4+whI3uZRscHIKcZHu9OP0itKNw=; b=npAKxAtxkYRDz1a/uYJjXzj8SUAMmjELSixoH4nhilpNRySK5CnrIXQ9zQcndP65i7 26SNZajej2lK1A6Rn2XSm00nuMYyCxqptJJDgJbAs8kvBuNB/AKf4g08l8q90Tv50OYl aMz5pj31kbFv11WvV6ud5TzTYbTnf2SpQbNgwR4y6UiIOuQ0tAr3C31oP/yhlr00DHlE MbYRK6rNL7P99kYis9lfY92mTyNRF6Ws9j42TpzgxrSsDpWTLs/Lsj/eEmA0h5mQTBu4 AcMdu34M/9Z844+5UxQa2nuSeunAUD4/h1uvpRXW0fJYZ7uflTPvGSg2cwlYRhT8u2D/ 0zOw== X-Received: by 10.194.120.226 with SMTP id lf2mr3684220wjb.108.1447872787836; Wed, 18 Nov 2015 10:53:07 -0800 (PST) Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id c4sm4148014wjs.36.2015.11.18.10.53.06 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Nov 2015 10:53:07 -0800 (PST) References: <877flfi1pn.fsf@turtle.gmx.de> From: Dmitry Gutov Message-ID: <564CC911.7090702@yandex.ru> Date: Wed, 18 Nov 2015 20:53:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 MIME-Version: 1.0 In-Reply-To: <877flfi1pn.fsf@turtle.gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 11/18/2015 08:47 PM, Sven Joachim wrote: > Visit some file in a git repository, make a change and save it. Press > C-x v l do view the file's version history. Press C-x v v to commit > your changes. Result is an error: I'm sure it should work that way. `C-x v v' committing the current file is fine, but you've switched to a different buffer. Do we promise the behavior you want somewhere in the documentation? > vc-next-action: Wrong type argument: listp, "/usr/local/src/emacs/" I can make it fail with a more comprehensible error message. From unknown Sat Sep 06 00:10:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer Resent-From: Sven Joachim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2015 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 21955@debbugs.gnu.org Received: via spool by 21955-submit@debbugs.gnu.org id=B21955.144787578313173 (code B ref 21955); Wed, 18 Nov 2015 19:44:02 +0000 Received: (at 21955) by debbugs.gnu.org; 18 Nov 2015 19:43:03 +0000 Received: from localhost ([127.0.0.1]:43739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz8dC-0003QO-OQ for submit@debbugs.gnu.org; Wed, 18 Nov 2015 14:43:03 -0500 Received: from mout.gmx.net ([212.227.15.18]:58473) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz8d9-0003Py-MA for 21955@debbugs.gnu.org; Wed, 18 Nov 2015 14:43:00 -0500 Received: from localhost.localdomain ([79.224.41.247]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MC4y8-1a7yKo1jpQ-008qA2; Wed, 18 Nov 2015 20:42:58 +0100 Received: by localhost.localdomain (Postfix, from userid 1000) id 50B763F250; Wed, 18 Nov 2015 20:42:57 +0100 (CET) From: Sven Joachim References: <877flfi1pn.fsf@turtle.gmx.de> <564CC911.7090702@yandex.ru> Date: Wed, 18 Nov 2015 20:42:57 +0100 In-Reply-To: <564CC911.7090702@yandex.ru> (Dmitry Gutov's message of "Wed, 18 Nov 2015 20:53:05 +0200") Message-ID: <87y4dvgkla.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:6O4enWDeVTCA9qc8jx/rFr+M6cZy4Vo7L30PiM0Yb9x0vzm52vz qhARrkOZjrEy1PhLh1IHyIrX06CJxePPxj4UGqOOCR8PGvALWJXoEbmAYqx2Hm6o42br4La Lcro4Hf1k10DBSUKnkbGVUjM3wZDs7JMUqGQJ0F9yXVSPEyjl4q3YVMvtZHgJYSX4Zo7sIw U2/zbWxg7eV+SPe4av4Ww== X-UI-Out-Filterresults: notjunk:1;V01:K0:6tO5RpMEgEM=:oYOBJUaGyOoaTLUimWZPlJ Iw10vdJPe341PJWt2Ixscv5FZ36oHkvXsd3fxU0oGbq8/sapILata3/+EHQzUVLNOGXc7GK31 xE1SgYGyFkyzspKtN5Okie1ClfNZpVBr+GYcdlM5wnqj52i5iQ/sXCIdWJqbysi/rCOHPxwFO jRx+g60EQj8sClkbvsjYodTr2dH8jPDfwY1yz5LCBJacFipEAWyS0FDBDiczPytHL3E85N4vp IU9ogDNx6Xhc0VaGF6C/jFJm+i7mbjpoLmHZ8vUg3eCFtrsj3LpITZvApj4EQkILXYwL+cO4c /DBd1B67RjbPcPMH0o2TPTZ46RrjNxDrlY5rtcLjEnu9acruZgTV+XrgzAQcSzNuV/4xnEC9k jvd29indFGcImp/e9szZiu3wgH1D9c51EWM/r8b9tmD5AQhQ0KDrhWtkORIUL2Pl6EQ5izL0Z unF1pS43iuIsYKKK5mhbaqEi9xnFpBDIgDz9eamUvt6aed+mIx4IdxmfPlYBN16YmW6ac2JPO O4SV9wVjg/e8ELHu/jG8W64qWA1yPS/qkUoantPjWdicWRq/XWU2ln8Za1jidJfSPTQ2sEJIj L0LossRN2qR1RCmQEdT4bDTAuAx0B77eklZbcYHixNZssH3vwxl4SyxiV0OIz4QxGa3gXaq5T H44YoJzE6HtbG/sc/mOKoLFrZVC9v/hYvPx3WmvNGcoCEetwBadn4MZXQ01pYdXGu68JWU7ZL qrORzN19QNDLNyGjPQuCE6/KqyHG9YXxoo33RSPGmfCtqg2HulyKjiEKx+wYf5QK7nqJo03c9 RTjrzon X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2015-11-18 20:53 +0200, Dmitry Gutov wrote: > On 11/18/2015 08:47 PM, Sven Joachim wrote: >> Visit some file in a git repository, make a change and save it. Press >> C-x v l do view the file's version history. Press C-x v v to commit >> your changes. Result is an error: > > I'm sure it should work that way. `C-x v v' committing the current > file is fine, but you've switched to a different buffer. It used to work in Emacs 24, and I have come to rely on that behavior. Apparently the fix for bug #19084 changed it, vc-deduce-fileset in the *vc-change-log* buffer no longer returns the file whose history is displayed, but rather the directory it is in. > Do we promise > the behavior you want somewhere in the documentation? Not explicitly, but I find it a bit surprising (and annoying) that the command to list the changelog of a fileset does not preserve that same fileset in the log buffer. Certainly the behavior of C-x v L is more correct now, but the one of C-x v l has regressed. >> vc-next-action: Wrong type argument: listp, "/usr/local/src/emacs/" > > I can make it fail with a more comprehensible error message. That's the least I would expect. Cheers, Sven From unknown Sat Sep 06 00:10:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Nov 2015 01:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sven Joachim Cc: 21955@debbugs.gnu.org Received: via spool by 21955-submit@debbugs.gnu.org id=B21955.144789725828582 (code B ref 21955); Thu, 19 Nov 2015 01:41:02 +0000 Received: (at 21955) by debbugs.gnu.org; 19 Nov 2015 01:40:58 +0000 Received: from localhost ([127.0.0.1]:43912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzEDZ-0007Qw-Dx for submit@debbugs.gnu.org; Wed, 18 Nov 2015 20:40:57 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38323) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzEDX-0007Ql-DA for 21955@debbugs.gnu.org; Wed, 18 Nov 2015 20:40:55 -0500 Received: by wmec201 with SMTP id c201so97854223wme.1 for <21955@debbugs.gnu.org>; Wed, 18 Nov 2015 17:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=eDk3WiFIew4uuhyeAm5g+IDyG1YqzQF1e4fEQLjELwI=; b=NcJiK17kgBX49Vssgazok1zNhelk3CQLAFNRf7JcGh3JtG9mLVVvMfAHqdSaT6ijqS tgyHhE/LJuUtErXKdqtlcJhS7lQvc8OqMzrBbbzNWp3yhhOQCt5PvtdN4/00gdwmj0Pa 7gwLadv8IgMIo3VB3LIKrP4rWitJ5QB24jm3EV4XVzMQkfgmZfEsV/7kjrkaexM/kNr9 zdmttBjhtSAjDUT0eiN43552bV2ZO5qKiBF/6PPqQDj/n9lTg9zgUAV0MG5TmFpUM6oF dioMwiYb6skytODRqcSSNbRyu0urD8aAd2HEPlBqUmrDllg1kQiDbNV6vurUmHcoqwcs dMKw== X-Received: by 10.194.112.131 with SMTP id iq3mr5130915wjb.35.1447897254577; Wed, 18 Nov 2015 17:40:54 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id h4sm5367057wjx.41.2015.11.18.17.40.52 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Nov 2015 17:40:53 -0800 (PST) References: <877flfi1pn.fsf@turtle.gmx.de> <564CC911.7090702@yandex.ru> <87y4dvgkla.fsf@turtle.gmx.de> From: Dmitry Gutov Message-ID: <564D28A3.3030806@yandex.ru> Date: Thu, 19 Nov 2015 03:40:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0 MIME-Version: 1.0 In-Reply-To: <87y4dvgkla.fsf@turtle.gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 11/18/2015 09:42 PM, Sven Joachim wrote: > It used to work in Emacs 24, and I have come to rely on that behavior. > Apparently the fix for bug #19084 changed it, vc-deduce-fileset in the > *vc-change-log* buffer no longer returns the file whose history is > displayed, but rather the directory it is in. All right, I've tweaked the fix to the above bug, so that both behaviors work. Pushed to emacs-25. Please check and mark it as done, if everything works fine. But I don't think this behavior makes a lot of sense, in general. So e.g. vc-print-root-log displays the log for the whole repository, but vc-next-action will offer you to commit the changes to the file you opened the log buffer from, and not the whole repository. Same for vc-root-diff. > Certainly the behavior of C-x v L is more correct now, but the one of > C-x v l has regressed. Indeed, it also regressed the more sensible scenario: when vc-print-log was called after selecting a few items in vc-dir buffer. From unknown Sat Sep 06 00:10:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sven Joachim Subject: bug#21955: closed (Re: bug#21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer) Message-ID: References: <87lh9thmp8.fsf@turtle.gmx.de> <877flfi1pn.fsf@turtle.gmx.de> X-Gnu-PR-Message: they-closed 21955 X-Gnu-PR-Package: emacs Reply-To: 21955@debbugs.gnu.org Date: Thu, 19 Nov 2015 18:25:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1447957503-28713-1" This is a multi-part message in MIME format... ------------=_1447957503-28713-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 21955@debbugs.gnu.org. --=20 21955: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21955 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1447957503-28713-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 21955-done) by debbugs.gnu.org; 19 Nov 2015 18:24:44 +0000 Received: from localhost ([127.0.0.1]:45181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzTsx-0007SI-Ko for submit@debbugs.gnu.org; Thu, 19 Nov 2015 13:24:43 -0500 Received: from mout.gmx.net ([212.227.17.20]:65456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzTsd-0007RV-0f for 21955-done@debbugs.gnu.org; Thu, 19 Nov 2015 13:24:41 -0500 Received: from localhost.localdomain ([79.224.41.247]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LoKHN-1abHTA3oSX-00gDY0; Thu, 19 Nov 2015 19:24:21 +0100 Received: by localhost.localdomain (Postfix, from userid 1000) id C20D53F28F; Thu, 19 Nov 2015 19:24:19 +0100 (CET) From: Sven Joachim To: Dmitry Gutov Subject: Re: bug#21955: 25.0.50; vc-next-action fails from *vc-change-log* buffer References: <877flfi1pn.fsf@turtle.gmx.de> <564CC911.7090702@yandex.ru> <87y4dvgkla.fsf@turtle.gmx.de> <564D28A3.3030806@yandex.ru> Date: Thu, 19 Nov 2015 19:24:19 +0100 In-Reply-To: <564D28A3.3030806@yandex.ru> (Dmitry Gutov's message of "Thu, 19 Nov 2015 03:40:51 +0200") Message-ID: <87lh9thmp8.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:kE2szSnPqycK8iKpxJDn6Tk2dfRJapIBFsMTa956QMYD0Do12Qw k5e1kxr5nSJ02lWZszV/6QNRsdAZS0TlzXcBzXTie6dKuyfdhw1RCEG0iwzN1ygOcg/AAWr kS9TTWnja6A9i5Fws/L2g5fI8TYf89jJtG3hNoO38p42OWJV7zg+/tUDNBAdYblZ7CxwPgi iyF5vznCOkf6Tw8DYVhbA== X-UI-Out-Filterresults: notjunk:1;V01:K0:omPbW3L8eUE=:BoA5mqt7ZSsMkt3JtixAJL SvOeSImusbkrXwLmWuVBW8O0bTSpRTkfWEzfqf+6WuNDv2heOyKuV+5jv+5PLbszDnRzB6rhX aOx/Lr+wYNcMLqwcO92bf77UfnGCVRg9xR8lqp8X8Xpyg9vR8Ktrn9nDnX3DCB+rVuU2CjHbs KQBO4twUKjCj+t0yT1BQ6jmKnYEd8NaccF07B+RyOpKH2iu7jOE4E0i/6+KlprV9gvamE64l4 GSBTCr3ae1VPGaP2twUmzJcX/qunANMLZqN6qrz7aIfqfY3zvJ+FpzxcabIMmNLJnAi17LYPD DpU1uwaYdDfFkoLKx28MEgqAKq1s6kNT763H5cbs1AOSFraUCCwGyoudGiZOJyiCbtQw9x+Da LsPOUaWj6i0SJsm8eCGE5kqTz0K6cIkhgW7FqX0sP2IEVIgTKrM7N22BmxFIazzScVv4yVtbT rGrtUYeDxoYlmK0t/yiBXzcwRLS8xji7uXQWgs6GcLAcw0l6tBceOHdXAnkPUncWLKL4DsVGn It8nZkM0gBqD3ttopmBYkdM08RlpWQsHFracUolg2XSiauqeoOqI4IAm9n+qlg2Co2cYv5vyK v9kW9KJatVWkj//8IAeE4bHy9QF+cxSMcjGeRKBP9mmSqQoWOuDQRs+9U07jbnhmzkzzHk88q fXRJMRba49xnTEauct6Z0rVPVvZCuLIJyb0E4EepRh6ycE8IW9aq1NW4jXbqs0h33NWB/k1PI O4JjJYH2ZyRoataZfKpfVuVTVq2lyiB2E34VEoj5s2/jyGW5fTTQhpa6KHtSUzqsCMg6KLlOP jbUlr7a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21955-done Cc: 21955-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 25.1 On 2015-11-19 03:40 +0200, Dmitry Gutov wrote: > On 11/18/2015 09:42 PM, Sven Joachim wrote: > >> It used to work in Emacs 24, and I have come to rely on that behavior. >> Apparently the fix for bug #19084 changed it, vc-deduce-fileset in the >> *vc-change-log* buffer no longer returns the file whose history is >> displayed, but rather the directory it is in. > > All right, I've tweaked the fix to the above bug, so that both > behaviors work. Pushed to emacs-25. Please check and mark it as done, > if everything works fine. It does, thank you. :-) Cheers, Sven ------------=_1447957503-28713-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Nov 2015 18:48:01 +0000 Received: from localhost ([127.0.0.1]:43668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz7lw-0001nS-QM for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:48:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47983) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz7lu-0001nH-GJ for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:47:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz7lt-0000KR-0A for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:47:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7ls-0000KN-U4 for submit@debbugs.gnu.org; Wed, 18 Nov 2015 13:47:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7lr-00045O-Kx for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 13:47:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz7lo-0000JJ-Co for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 13:47:55 -0500 Received: from mout.gmx.net ([212.227.15.18]:65025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7lo-0000Ir-3b for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2015 13:47:52 -0500 Received: from localhost.localdomain ([79.224.41.247]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MBWTO-1a7OyW1e6Q-00AUEy for ; Wed, 18 Nov 2015 19:47:50 +0100 Received: by localhost.localdomain (Postfix, from userid 1000) id BE1DA3F250; Wed, 18 Nov 2015 19:47:48 +0100 (CET) From: Sven Joachim To: bug-gnu-emacs@gnu.org Subject: 25.0.50; vc-next-action fails from *vc-change-log* buffer X-Debbugs-Cc: Sven Joachim Date: Wed, 18 Nov 2015 19:47:48 +0100 Message-ID: <877flfi1pn.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:ba/nnPxA5hpflTaON+A0xwlQkz/k20PNwhcxo2QUxGIT1ZO/6iW SfJ8NrjwdYJWqQ/42WBBAzjnQnLEsIZ+Qa7GthvEbMWjOGSmM/H50GDb/aUurnJmf3d9CZ/ s9akTtPp8+Bq646ZhzYl6iQ+2j/IC1UXb9Hu9S75DRR5hhIQxvxMRsBeLu71CZaPg/nx12Q g0zA3A69j4GFJhomR8UVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:/JAxWD5GyQY=:LD6ZKujhvIh9iVsMtL+vD1 EeknwmtomRcSB157Dnjq9hvzJ0XJU6xdI1DtwTaNDZRHv+byAY/jD/fLRlLNbVH8HmuOpUY2G S5fqKPoB1eSXCAzlh9cdMmF0IMP9GLdYVaqjWU8P4lYZaALN+UXzlyalS6r54soEX/rlTB9oe JE6ODA2BJJwEa4vP+iPXINXe47m4Km2HJVLiH0MCmq74rm8ONlenGeET18bNJ2zM4UyAlcFcN RTdKL9AcSmd+lP9bGyYSDIv+cnHzm9z5BCsZZSuGxPdEH9Wr7cRbhPZRndG8ijBU21nvjzyYv 2rEO1nrFBw7FU0RxgVhRrTFB/zoCrbZkODGEPv4RsBFAJEuvvY5BvrWygsZxfsvrx8gRLMSL6 5YJYewcc6DKbP2npbuYJ3WIylY/l3M1pFZHKpBtGFN70o6ZbsH69P/QC8FDpJvJ2LBT0zizP3 qkfbEYmbSDuP+z2AoWw1irYfMuCi0Cz10JOEPcFDqWFi1uOQUoD44B3bem9YtKTK874LJvCMr zTZRdBoErCmqLo2Nh4IkI72bA6ZIsJBAh/lg4zcpMsfspDRAQokgEfEpoeqeXDO3SFT7b/1bF JKm/aFJZzSLeqBeIbtk2PXSuDIvd7FPjGNbE8VPG6ASeCaQmXVzjGQDOfWO1MBhRvE5+LLnAN +x5h+9yX4l1QOPa89OacnhGcIUplbjm+/nsGqfmU+rj1IAPqnJfipJOfzV5ONkgc7VLIYmdq3 8CMKzHjkM3U6GBHvDbAq8rBubpz2zC8dyu1IMDMdFcRPnUTMlSDtjOj9Fq6nWFY6AW7f7btiG +DuQk1b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Visit some file in a git repository, make a change and save it. Press C-x v l do view the file's version history. Press C-x v v to commit your changes. Result is an error: vc-next-action: Wrong type argument: listp, "/usr/local/src/emacs/" Of course, the last argument is the default-directory here. In GNU Emacs 25.0.50.2 (i586-pc-linux-gnu, GTK+ Version 2.24.28) of 2015-11-18 Repository revision: bb4303c536a2ac5fe683a711ef8072074f77670e Windowing system distributor 'The X.Org Foundation', version 11.0.11703000 System Description: Debian GNU/Linux Configured using: 'configure --build i586-linux-gnu --host i586-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var --infodir=/usr/share/info/emacs-snapshot --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/25.0.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.0.50/site-lisp:/usr/share/emacs/site-lisp --without-wide-int --disable-silent-rules --without-compress-install --with-x=yes --with-x-toolkit=gtk2 --without-gconf --without-gsettings build_alias=i586-linux-gnu host_alias=i586-linux-gnu 'CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security' 'LDFLAGS=-Wl,-z,relro -Wl,--as-needed' 'CPPFLAGS=-D_FORTIFY_SOURCE=2 -DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LC_COLLATE: C value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Git-Log-View Minor modes in effect: diff-auto-refine-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Saving file /usr/local/src/emacs/BUGS... Wrote /usr/local/src/emacs/BUGS vc-next-action: Wrong type argument: listp, "/usr/local/src/emacs/" Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs add-log log-view pcvs-util vc vc-dispatcher vc-git diff-mode easy-mmode map seq byte-opt gv bytecomp byte-compile cconv cl-extra help-mode easymenu cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 95807 6514) (symbols 24 20842 0) (miscs 20 58 118) (strings 16 19201 3353) (string-bytes 1 551091) (vectors 8 14402) (vector-slots 4 457909 2418) (floats 8 176 70) (intervals 28 337 7) (buffers 520 13) (heap 1024 29332 521)) ------------=_1447957503-28713-1--