From unknown Thu Jun 19 14:02:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#21946 <21946@debbugs.gnu.org> To: bug#21946 <21946@debbugs.gnu.org> Subject: Status: 25.1.50; Saving games fails in dunnet Reply-To: bug#21946 <21946@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:02:57 +0000 retitle 21946 25.1.50; Saving games fails in dunnet reassign 21946 emacs submitter 21946 peder@klingenberg.no (Peder O. Klingenberg) severity 21946 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 16:38:36 2015 Received: (at submit) by debbugs.gnu.org; 17 Nov 2015 21:38:36 +0000 Received: from localhost ([127.0.0.1]:42063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZynxT-0008LR-MH for submit@debbugs.gnu.org; Tue, 17 Nov 2015 16:38:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37127) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zynx8-0008Kc-VV for submit@debbugs.gnu.org; Tue, 17 Nov 2015 16:38:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zynx6-0004wk-Qi for submit@debbugs.gnu.org; Tue, 17 Nov 2015 16:38:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zynx6-0004wd-Nw for submit@debbugs.gnu.org; Tue, 17 Nov 2015 16:38:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zynx4-0007h5-JL for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 16:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zynx2-0004uL-Lh for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 16:38:10 -0500 Received: from [2001:4661:ffd:0:358e:534e:4d0:5827] (port=62496 helo=modesty.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zynx2-0004qh-67 for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 16:38:08 -0500 Received: by modesty.localdomain (Postfix, from userid 502) id 0E938EBC4E9; Tue, 17 Nov 2015 22:14:28 +0100 (CET) From: peder@klingenberg.no (Peder O. Klingenberg) To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Saving games fails in dunnet Date: Tue, 17 Nov 2015 22:14:28 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain While plaing dunnet, saving games via the "save"-command fails with the message "Error saving to file". To reproduce: $ ~/src/emacs/src/emacs -batch -l dunnet Dead end You are at a dead end of a dirt road. The road goes to the east. In the distance you can see that it will eventually fork off. The trees here are very tall royal palms, and they are spaced equidistant from each other. There is a shovel here. >save /tmp/foo.txt Error saving to file. > The reason is that dunnet uses its own implementation of ROT13 to obfuscate the savefile, and this implementation breaks when it encounters characters outside the 0-255 range. On 2015-08-24, Paul Eggert introduced some curly quotes in data normally saved to this file. Attached is a patch that makes dun-rot13 use rot13-region instead of its own implementation. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-savegames-in-dunnet.patch >From 94208031216879eeb8c04e11118b666a10af6860 Mon Sep 17 00:00:00 2001 From: "Peder O. Klingenberg" Date: Tue, 17 Nov 2015 21:47:27 +0100 Subject: [PATCH] Fix savegames in dunnet * lisp/play/dunnet.el (dun-rot13): Use the standard rot13-region instead of separate implementation. --- lisp/play/dunnet.el | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/lisp/play/dunnet.el b/lisp/play/dunnet.el index ba137f5..8aba50b 100644 --- a/lisp/play/dunnet.el +++ b/lisp/play/dunnet.el @@ -1321,29 +1321,8 @@ dun-remove-obj-from-inven (setq new-inven (append new-inven (list x))))) (setq dun-inventory new-inven))) - -(let ((i 0) (lower "abcdefghijklmnopqrstuvwxyz") upper) - (setq dun-translate-table (make-vector 256 0)) - (while (< i 256) - (aset dun-translate-table i i) - (setq i (1+ i))) - (setq lower (concat lower lower)) - (setq upper (upcase lower)) - (setq i 0) - (while (< i 26) - (aset dun-translate-table (+ ?a i) (aref lower (+ i 13))) - (aset dun-translate-table (+ ?A i) (aref upper (+ i 13))) - (setq i (1+ i)))) - (defun dun-rot13 () - (let (str len (i 0)) - (setq str (buffer-substring (point-min) (point-max))) - (setq len (length str)) - (while (< i len) - (aset str i (aref dun-translate-table (aref str i))) - (setq i (1+ i))) - (erase-buffer) - (insert str))) + (rot13-region (point-min) (point-max))) ;;;; ;;;; This section defines the globals that are used in dunnet. -- 2.4.0 --=-=-= Content-Type: text/plain In GNU Emacs 25.1.50.1 (x86_64-apple-darwin14.5.0, NS appkit-1348.17 Version 10.10.5 (Build 14F1021)) of 2015-11-17 Repository revision: 58e6235007e6761fb9734b942ecff94bf4e9ba68 Windowing system distributor 'Apple', version 10.3.1348 Configured features: RSVG DBUS ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t diff-auto-refine-mode: t linum-mode: t show-paren-mode: t paredit-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Type C-c C-c to finish, or C-c C-k to cancel Auto-saving...done Auto-saving...done Mark set Saving file /Users/pok/src/emacs/.git/COMMIT_EDITMSG... Wrote /Users/pok/src/emacs/.git/COMMIT_EDITMSG Git finished [2 times] Reverting (up to) 3 file-visiting buffer(s)... (No buffers need to be reverted) Type C-h i to view popup manual, ? to describe an argument or action. [2 times] Load-path shadows: ./zone hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/zone ./tetris hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/tetris ./studly hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/studly ./spook hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/spook ./solitaire hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/solitaire ./snake hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/snake ./pong hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/pong ./mpuz hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/mpuz ./morse hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/morse ./life hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/life ./hanoi hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/hanoi ./handwrite hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/handwrite ./gomoku hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/gomoku ./gametree hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/gametree ./gamegrid hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/gamegrid ./fortune hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/fortune ./dunnet hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/dunnet ./doctor hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/doctor ./dissociate hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/dissociate ./decipher hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/decipher ./cookie1 hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/cookie1 ./bubbles hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/bubbles ./blackbox hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/blackbox ./animate hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/animate ./5x5 hides /Users/pok/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play/5x5 Features: (shadow sort mail-extr emacsbug mm-archive network-stream nsm starttls url-cache debbugs-gnu wid-edit debbugs soap-client url-http tls url-auth url-gw url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap rng-xsd rng-dt rng-util xsd-regexp xml magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-process magit-popup magit-mode magit-git crm magit-section magit-utils git-commit log-edit message sendmail dired rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async tramp-sh dash warnings derived rot13 disp-table apropos vc-annotate cus-start cus-load eieio-opt speedbar sb-image ezimage dframe edebug debug pulse dunnet tramp-cache tramp tramp-compat auth-source gnus-util mm-util help-fns mail-prsvr password-cache tramp-loaddefs trampver shell advice dabbrev xref cl-seq project eieio eieio-core character-fold misearch multi-isearch vc vc-dispatcher vc-git diff-mode map jka-compr thingatpt linum paren paredit pok-init org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs gedcom slime-autoloads reftex reftex-vars edmacro kmacro ido seq byte-opt cl-macs server dmacro cl gv compile comint ansi-color ring bytecomp byte-compile cl-extra help-mode cl-loaddefs pcase cl-lib cconv finder-inf tex-site info package easymenu epg-config time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 374279 78364) (symbols 48 39069 2) (miscs 40 1910 2700) (strings 32 85339 32771) (string-bytes 1 2585328) (vectors 16 38829) (vector-slots 8 1204135 24354) (floats 8 519 409) (intervals 56 15896 519) (buffers 976 34)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 20:59:54 2015 Received: (at control) by debbugs.gnu.org; 18 Nov 2015 01:59:54 +0000 Received: from localhost ([127.0.0.1]:42181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zys2M-000062-2w for submit@debbugs.gnu.org; Tue, 17 Nov 2015 20:59:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zys2K-00005r-GH for control@debbugs.gnu.org; Tue, 17 Nov 2015 20:59:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zys2J-0006F0-IK for control@debbugs.gnu.org; Tue, 17 Nov 2015 20:59:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zys2J-0006Ew-FR for control@debbugs.gnu.org; Tue, 17 Nov 2015 20:59:51 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Zys2J-0003D6-4k for control@debbugs.gnu.org; Tue, 17 Nov 2015 20:59:51 -0500 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 17 Nov 2015 20:59:51 -0500 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) block 19759 by 21946 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 18 07:30:47 2015 Received: (at 21946-done) by debbugs.gnu.org; 18 Nov 2015 12:30:47 +0000 Received: from localhost ([127.0.0.1]:42457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz1st-0000g5-6q for submit@debbugs.gnu.org; Wed, 18 Nov 2015 07:30:47 -0500 Received: from mxin.ulb.ac.be ([164.15.128.112]:12446) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zz1sp-0000b5-U1 for 21946-done@debbugs.gnu.org; Wed, 18 Nov 2015 07:30:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgkGAKhuTFakD4Xx/2dsb2JhbABegmmCFKtWAQEEBpRyhg8CghEBAQEBAQGBC4Q1AQEEeRAIAyElDwEEXIguvkcBAQEBBgIBIIYNhUWJOQWWSpY4hjaNAmOEBT00hQwBAQE Received: from mathsrv4.ulb.ac.be (HELO localhost) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 18 Nov 2015 13:30:13 +0100 From: Nicolas Richard To: peder@klingenberg.no (Peder O. Klingenberg) Subject: Re: bug#21946: 25.1.50; Saving games fails in dunnet References: Date: Wed, 18 Nov 2015 13:30:26 +0100 In-Reply-To: (Peder O. Klingenberg's message of "Tue, 17 Nov 2015 22:14:28 +0100") Message-ID: <87r3jnxzfh.fsf@members.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21946-done Cc: 21946-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) peder@klingenberg.no (Peder O. Klingenberg) writes: > Attached is a patch that makes dun-rot13 use rot13-region instead of its > own implementation. Thanks for the analysis and the patch, I applied it to emacs-25. Nicolas. From unknown Thu Jun 19 14:02:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Dec 2015 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator