GNU bug report logs - #21930
emacs-repository-get-version fails on linked worktrees

Previous Next

Full log

Message #11 received at 21930 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Stephen Leake <stephen_leake <at> stephe-leake.org>
Cc: 21930 <at> debbugs.gnu.org
Subject: Re: bug#21930: emacs-repository-get-version fails on linked worktrees
Date: Tue, 17 Nov 2015 01:20:15 +0100

[Message part 1 (text/plain, inline)]

On Tue, Nov 17, 2015 at 12:01 AM, Stephen Leake <
stephen_leake <at> stephe-leake.org> wrote:

> I'm guessing because running any background process doesn't work during
> dumping; they don't work in general in batch mode.

The code refers to bug#20799, which states that git (and other external
processes) cannot be run while dumping because `exec-path' is nil.

So the function, to be usable on a linked worktree while dumping, needs to
directly read the .git file. That's what my patch does. Calls to
`emacs-repository-get-version' with EXTERNAL = t already work (when not
dumping) without my patch, of course.

> Looks good to me.

Great.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.