GNU bug report logs - #21928
25.0.50; verilog-mode.el fails to compile, Symbol’s function definition is void: \,@

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21928 in the body.
You can then email your comments to 21928 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Samer Masterson <samer <at> samertm.com>
To: bug-gnu-emacs <at> gnu.org, monnier <at> iro.umontreal.ca
Subject: 25.0.50; verilog-mode.el fails to compile, Symbol’s function definition is void: \,@
Date: Sun, 15 Nov 2015 19:32:11 -0800

Hi,

There's a compile error in verilog-mode.el. I believe it was introduced
by commit 353f5e76641c338dc4bfe0ac8e9aa84d23bac1fe.

Fixed with the following path. Not sure if it's correct, stefan can
probably tell tho.

----------------------------patch start
diff --git a/lisp/progmodes/verilog-mode.el
b/lisp/progmodes/verilog-mode.el
index fa93633..3081060 100644
--- a/lisp/progmodes/verilog-mode.el
+++ b/lisp/progmodes/verilog-mode.el
@@ -3237,7 +3237,7 @@ verilog-save-buffer-state
   `(let ((inhibit-point-motion-hooks t)
          (verilog-no-change-functions t))
      ,(if (fboundp 'with-silent-modifications)
-          (with-silent-modifications ,@body)
+          `(with-silent-modifications ,@body)
         ;; From c-save-buffer-state
         `(let* ((modified (buffer-modified-p))
                 (buffer-undo-list t)
----------------------------patch end

Best,
Samer

Message #10 received at 21928-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Samer Masterson <samer <at> samertm.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 21928-done <at> debbugs.gnu.org
Subject: Re: bug#21928: 25.0.50; verilog-mode.el fails to compile, Symbol’s function definition is void: \,@
Date: Tue, 17 Nov 2015 01:28:21 +0100

[Message part 1 (text/plain, inline)]

On Mon, Nov 16, 2015 at 4:32 AM, Samer Masterson <samer <at> samertm.com> wrote:

> Fixed with the following path. Not sure if it's correct, stefan can
> probably tell tho.

I hope it is the correct patch, as I fixed it yesterday with a patch
identical to yours.

Commit 937565268a5dc3377d4c9bff6d48eb3645a77160

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.