GNU bug report logs - #21922
Indentation of Emacs Lisp list constants is surprising

Previous Next

Package: emacs;

Reported by: Clément Pit--Claudel <clement.pitclaudel <at> live.com>

Date: Sat, 14 Nov 2015 18:31:01 UTC

Severity: minor

Merged with 27646

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> gmail.com>
To: Luis Henriquez-Perez <luishenriquezperez <at> gmail.com>
Cc: 21922 <at> debbugs.gnu.org
Subject: bug#21922: Patch for fixing the "straight-quote" case
Date: Tue, 08 Oct 2019 23:41:34 -0400

Luis Henriquez-Perez <luishenriquezperez <at> gmail.com> writes:

>  (when-let (point (char-before containing-sexp))
>    (char-equal point ?'))

>             (and (char-before point)
>                  (char-equal (char-before point) ?'))

You can use eq instead of char-equal, and then the extra check for nil
isn't needed.

>             (save-excursion
>               (goto-char (1+ point))
>               (looking-at-p "quote[\t\n\f\s]+(")))))

I would suggest (looking-at-p "[[:whitespace:]\n]*quote\_>") instead,
and maybe move the save-excursion outside of the loop.

Overall, the approach looks reasonable to me.
This bug report was last modified 3 years and 169 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.