From unknown Fri Aug 15 20:51:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21921: New function comment-line also comments first line after region Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2015 18:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21921@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144752547628894 (code B ref -1); Sat, 14 Nov 2015 18:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2015 18:24:36 +0000 Received: from localhost ([127.0.0.1]:38171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxfV5-0007Vy-Eh for submit@debbugs.gnu.org; Sat, 14 Nov 2015 13:24:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51991) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxfV3-0007Vq-Dw for submit@debbugs.gnu.org; Sat, 14 Nov 2015 13:24:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxfV2-0001nf-78 for submit@debbugs.gnu.org; Sat, 14 Nov 2015 13:24:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxfV2-0001nb-3a for submit@debbugs.gnu.org; Sat, 14 Nov 2015 13:24:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxfV0-0002gg-SV for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 13:24:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxfUw-0001nA-SA for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 13:24:30 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:55327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxfUw-0001lx-JS for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 13:24:26 -0500 Received: from [18.189.78.159] ([18.189.78.159]) by mrelayeu.kundenserver.de (mreue001) with ESMTPSA (Nemesis) id 0Lgywx-1aiE3y1f8h-00oZOo for ; Sat, 14 Nov 2015 19:24:25 +0100 From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Message-ID: <56477C57.6090109@live.com> Date: Sat, 14 Nov 2015 13:24:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hAJs3FCddFbblGRHbGmNvIWoew1ih52eX" X-Provags-ID: V03:K0:43Ztg/W5b2EaEmja7vmsermwzH8+8CuTaikI20qNaxGR9N8oL6b rxle9jJcZrsX6ps5dkXb2LqMgDskzJYqBEgUC2hj+YFojC4uLuJj6ayfkPR3p0prHL8ckWi g0wE+iZN5MP0zhnSM0oZZVo5/SKgZQ6iVzvHW1QDHoJAiCzjpwrEWcb69IhPH9/F0dCe3QL JqVxvuPovp51Gk/V9pm8w== X-UI-Out-Filterresults: notjunk:1;V01:K0:gFb74YLBNDE=:0aZgk9LwuKdDPHE0IXBA/j jcWTzd8iSsUDsQnafaaVv6DxoZgM3k6gxp0wEIniU4aTY+TE3o5UKP/+3+kpy2/pYly6Ks5HC WER4Js7uYc2KfPIjuIUaOYXuFLLmFSBgJYEKvW288SBl6Hx593YrTZ+yj/HssAnKyOTGeOTbP F+DIN4Kh/cC9TuIZ1hRUrYginLBEZ6mxobLXLvQFELMZ1vmvc+ACRsOYLbxFN+GB16n3m4By/ 5TEl9QKI+AFIbSV49DoO+qSaszdS45OwyOrNX6S9Ye7sdGW60j5VAJrL/NhzGO/uf3MhkyPhe sL7gGrXWY28AN/+n+F6gCDm0AukHpw6tryrU8o3EqMu1vx04vS9MEhanQXzp8AA3MKVTJobJ4 uWjjYcYjbxAbcspwFrkBCTxG4udMRr+1LV0oChqSdCdVFQd4DPO3YgPe1Ar8K8khqhmLMFXyS 5ZT0TXsJpgX7OT304ZEnNVpEWYIBiHNKFAXh1pcllGTiD/S+5sxNH3P2nrstEsVEuA4OiyTWB GiSaREIr2WUPqyi8ZAWgWIcuA03Ehclnng6J51K+wYqaa+J0Bj1tLQt4gRbIUH2W9s03jDGpB OfWx4Z/UglO8Hm61xaIba6y170SDSK3RCxqvpP01AzUWi2zmD3dswtYB5uRkwIu8nd+YXCDCN G7yEzwuces6vgaxMkOpxh26Vh7+ylg6LKKk1MlA6eNKr4JZur/elSNj7hk4cYEXdFGT8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hAJs3FCddFbblGRHbGmNvIWoew1ih52eX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi all, The new comment-line feature is very convenient, but I find its operation= slightly confusing wrt the "comment out region" feature. Its documentation says: If region is active, comment lines in active region instead. However, it seems that it also comments out the line just after the end of the region. For example, given the following text abc def ghi Placing the cursor before `a', then pressing C-SPC C-n C-n, causes two lines to be marked: (> is highlighting, | is point) >abc >def |ghi Yet pressing C-x C-; (comment-region) comments out all three lines. Similarly, again starting from=20 abc def ghi placing the point before `g' and pressing C-SPC C-p C-p causes two lines to be marked: >|abc >def ghi Yet pressing C-x C-; comments out all three lines. I find this second exa= mple especially confusing. Is this behaviour only surprising to me? Cheers, Cl=C3=A9ment. In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2015-11-14 Repository revision: 02bf89f857e04b8023ce03eadcfa87c82918e957 Windowing system distributor 'The X.Org Foundation', version 11.0.1150100= 0 System Description: Linux Mint 17.2 Rafaela Configured using: 'configure --with-x-toolkit=3Dgtk3' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LC_TIME: en_DK.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 80441 7581) (symbols 48 19255 0) (miscs 40 38 110) (strings 32 12779 4612) (string-bytes 1 365820) (vectors 16 10757) (vector-slots 8 419611 2876) (floats 8 143 70) (intervals 56 194 0) (buffers 976 11) (heap 1024 25940 1037)) --hAJs3FCddFbblGRHbGmNvIWoew1ih52eX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWR3xXAAoJEPqg+cTm90wjtNMP/0kB0jeQxfEQidALy5IZFNJT ZePBeNdI66IYICrkgWXITwjNafwPLD+E85CAE7r9rVClaU+Wifdy+mHWmw7r4/xh DaJ7/GeNAy+pIPH0quEhfnu4w79g1al5HZVBLKbArmYVSQIrZco6/MJxNhc0ihVr 1F+TBSjL+mDakUCAwzgJtQRfY7fJaE+hpVcP/O+a3N3kPXYTRvc7DPcPPXWW+stf T8tY1gWXeV5Q7a55ARShpvCof3yJUc3t5xGepjV2Z0lperAe4R+VoO7bcbkMry6f BYNu+eUQuHsDZrWgYGoYphZhKBmVAdzYoHLfnZ8ebVijW94fHYUTRt2c+/uPMNvT k+UJ622olKEtdaUTW5wy4h286buapydcaNV+b9oKhkn4PdjergZvVlzGLM/PLuCj sNNPOm0aklrUtFYFhHDFyV5FHpYt1uGzexgPjA1Wown7mDcRUs19F8wXaeHqBsOl xvphJEu1SfJcMI4hAfX3GReyNNLZ9vdmpmUDsegEtst1nSPET8T2409MdeXhxRXI Fy5ZMTUBdtsrn0894Ls1wV185IcOtoFuEKxHP6uRGFt4cy2Jplp8JdwhB+RPpEIO C+sXsKTcmIbw6hUET1Q6pnNw97PSskgumYqapIewamC/Q1EeIM7wjOmgiLgwvxMF GB3jt6QR6TXF1vWpgk8j =RiqX -----END PGP SIGNATURE----- --hAJs3FCddFbblGRHbGmNvIWoew1ih52eX-- From unknown Fri Aug 15 20:51:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21921: New function comment-line also comments first line after region In-Reply-To: <56477C57.6090109@live.com> Resent-From: Rasmus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Nov 2015 11:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21921@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144758801631626 (code B ref -1); Sun, 15 Nov 2015 11:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2015 11:46:56 +0000 Received: from localhost ([127.0.0.1]:38481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zxvln-0008E2-JC for submit@debbugs.gnu.org; Sun, 15 Nov 2015 06:46:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37118) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxvlT-0008DZ-2p for submit@debbugs.gnu.org; Sun, 15 Nov 2015 06:46:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxvlR-00081p-SN for submit@debbugs.gnu.org; Sun, 15 Nov 2015 06:46:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxvlR-00081l-PB for submit@debbugs.gnu.org; Sun, 15 Nov 2015 06:46:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxvlQ-0002VR-Ps for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 06:46:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxvlN-00081Q-Il for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 06:46:32 -0500 Received: from plane.gmane.org ([80.91.229.3]:54047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxvlN-000819-Bo for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 06:46:29 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Zxvkr-0007L5-4Y for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2015 12:45:57 +0100 Received: from x4db26f62.dyn.telefonica.de ([77.178.111.98]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Nov 2015 12:45:52 +0100 Received: from rasmus by x4db26f62.dyn.telefonica.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Nov 2015 12:45:52 +0100 X-Injected-Via-Gmane: http://gmane.org/ From: Rasmus Date: Sun, 15 Nov 2015 12:45:02 +0100 Lines: 70 Message-ID: <87a8qffpvl.fsf@gmx.us> References: <56477C57.6090109@live.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: x4db26f62.dyn.telefonica.de Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAAAAAByaaZbAAAAAmJLR0QA/4ePzL8AAAAJcEhZ cwAAAEgAAABIAEbJaz4AAAIMSURBVEjHvZbLleswDEPDjlgKOkEnKAWFoBYW8RayEydRJvM246WO rkjw61v953f7M6DRIFlVBUeSJAIfAYCSLdmWk0QCuj8BTUpKrCQzEfuLSw3IiZRJ1L8S3czYMc8D VH+JkuKMUFXV8kzid9euAOyZiKjqhkRKb+7dqqoosquq9fJsg682LhpQ1Y4toTSnsFfi4pK6SpJo wqMqopoStnmoaldBImgRVCSSErm3QKIKJAGKlGxbfiuQszRIdBVAAAS16iOxXkQ8Mo0jKsR6P5mZ xNoA3QD6AEDK8mFhD1T3chQkAMpJDsTWRsPpEUX0ASRJJtkCIPHIeB+XZ5ngO9AAu6plk6jynF8m vpcTLgBZVcpMzC7Og3g0U9R9ACBV6+HEAi/3fTYITeEOSFXFjAUQugI6AEe8u0RZVVVo2oKzAWZd uR0z4zAM6Z7lmYm9TxyOU655tPIwyWeARyfLJrW4lW57XxqrhSyvVyVatmNb22o9tMuZWLIkKbb2 Fup+2A1099KffAaeGnGVSZzVctsW9arvZncDa3Am0iquLbCKSpRFyqfiT8CSDZz3EzuWVq9/3kD9 aLjY8jegu7rB5Y9Mifi+43oNDWvj0DuAopZkiW+D9QXoLhK0csjdLbnbs+RV3ZYJ9LmB+kdghUcX 5/tJxwtAre17GcBN/BDWNSqvsemXSP3dv8avv39wgAhOeVDQLwAAAABJRU5ErkJggg== User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:j+j8KQHnqQEmJuVSwkN7Z8Y5Nt4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hi Clément, Thanks for details report. Clément Pit--Claudel writes: > Its documentation says: > > If region is active, comment lines in active region instead. > > However, it seems that it also comments out the line just after the end > of the region. > > For example, given the following text > > abc > def > ghi > > Placing the cursor before `a', then pressing C-SPC C-n C-n, causes two > lines to be marked: (> is highlighting, | is point) > >>abc >>def > |ghi > > Yet pressing C-x C-; (comment-region) comments out all three lines. Because the end of region is at point. Try to run this: (list (point) (region-beginning) (region-end)) Also, from the docstring, Unlike ‘comment-dwim’, this always comments whole lines. You'd get what you'd expect if you run comment-dwim (M-;) > Similarly, again starting from > > abc > def > ghi > > placing the point before `g' and pressing C-SPC C-p C-p causes two lines > to be marked: Again, in fact the region start at 'g'. Check e.g. with C-x C-x. But it's not obvious from the face. >>|abc >>def > ghi > > Yet pressing C-x C-; comments out all three lines. I find this second example especially confusing. > > Is this behaviour only surprising to me? Perhaps the confusion is caused by region not being displayed at column zero. The behavior is correct IMO. For your particular examples, comment-dwim does what you want, it seems. Hope it helps, Rasmus -- Spil noget med Slayer! From unknown Fri Aug 15 20:51:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21921: New function comment-line also comments first line after region Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Nov 2015 09:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Rasmus Cc: 21921@debbugs.gnu.org Reply-To: bruce.connor.am@gmail.com Received: via spool by 21921-submit@debbugs.gnu.org id=B21921.144766453621399 (code B ref 21921); Mon, 16 Nov 2015 09:03:01 +0000 Received: (at 21921) by debbugs.gnu.org; 16 Nov 2015 09:02:16 +0000 Received: from localhost ([127.0.0.1]:39495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyFfz-0005Z4-Hn for submit@debbugs.gnu.org; Mon, 16 Nov 2015 04:02:15 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:33410) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyFfx-0005Yw-JI for 21921@debbugs.gnu.org; Mon, 16 Nov 2015 04:02:14 -0500 Received: by lfaz4 with SMTP id z4so19082735lfa.0 for <21921@debbugs.gnu.org>; Mon, 16 Nov 2015 01:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=tGdwz0fZLzzDERi5/Bn0TxMAi+7mRRnLlqEGXiFOkcc=; b=aIczOE/bGRfIdEMxlhYnr6HPb6ArIuLrgVD0VpMPS/boQE/RAiUY74/pT76z+9JqKD yCMT9SPo5CN14qUrIDnMmxoPmz8gRA/RCpNjMZDAQKjiD47bWFO2uf1JKw2Ybg/NvfTs aFbY3SfNy5Css0eZLbQT6dVvioy7Z11jHgdsiZ5j5mW29m470H5N+vp4PlwU9HLQrXaH GHny9V8Azg9QHP49uvCVBqegPrhbGC0et/IaAyatARpS7Oe+iCB1j7VoMET9tlmcY6DS wZusR4KnzkxaunwPtRWIbsTX7IJYYPpTkZ1S346UHdriQbMAysEbqlBj5Sn0q/pf0ish 1W8g== MIME-Version: 1.0 X-Received: by 10.25.23.42 with SMTP id n42mr16811965lfi.42.1447664532509; Mon, 16 Nov 2015 01:02:12 -0800 (PST) Received: by 10.112.63.70 with HTTP; Mon, 16 Nov 2015 01:02:12 -0800 (PST) Received: by 10.112.63.70 with HTTP; Mon, 16 Nov 2015 01:02:12 -0800 (PST) In-Reply-To: <87a8qffpvl.fsf@gmx.us> References: <56477C57.6090109@live.com> <87a8qffpvl.fsf@gmx.us> Date: Mon, 16 Nov 2015 09:02:12 +0000 X-Google-Sender-Auth: GbvNFEmfiTu7i3M6GsTuPqtyYZ8 Message-ID: From: Artur Malabarba Content-Type: multipart/alternative; boundary=001a114057cc36dc940524a4aa5e X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a114057cc36dc940524a4aa5e Content-Type: text/plain; charset=UTF-8 On 15 Nov 2015 11:45 am, "Rasmus" wrote: > > > > Yet pressing C-x C-; comments out all three lines. I find this second example especially confusing. > > > > Is this behaviour only surprising to me? > > Perhaps the confusion is caused by region not being displayed at column > zero. > > The behavior is correct IMO. > > For your particular examples, comment-dwim does what you want, it seems. > > Hope it helps, > Rasmus Indeed. When I was deciding how comment-line should work on a region, I specifically chose to not make it identical to comment-dwim. Maybe it should still treat the "region ends at a newline" case specially. Some emacs commands do that already. Not sure though, since that would be slightly redundant with comment-dwim. --001a114057cc36dc940524a4aa5e Content-Type: text/html; charset=UTF-8


On 15 Nov 2015 11:45 am, "Rasmus" <rasmus@gmx.us> wrote:
> >
> > Yet pressing C-x C-; comments out all three lines. I find this second example especially confusing.
> >
> > Is this behaviour only surprising to me?
>
> Perhaps the confusion is caused by region not being displayed at column
> zero.
>
> The behavior is correct IMO.
>
> For your particular examples, comment-dwim does what you want, it seems.
>
> Hope it helps,
> Rasmus

Indeed. When I was deciding how comment-line should work on a region, I specifically chose to not make it identical to comment-dwim.

Maybe it should still treat the "region ends at a newline" case specially. Some emacs commands do that already.
Not sure though, since that would be slightly redundant with comment-dwim.

--001a114057cc36dc940524a4aa5e-- From unknown Fri Aug 15 20:51:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21921: New function comment-line also comments first line after region Resent-From: Rasmus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Nov 2015 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: bruce.connor.am@gmail.com Cc: 21921@debbugs.gnu.org Received: via spool by 21921-submit@debbugs.gnu.org id=B21921.144769679423674 (code B ref 21921); Mon, 16 Nov 2015 18:00:02 +0000 Received: (at 21921) by debbugs.gnu.org; 16 Nov 2015 17:59:54 +0000 Received: from localhost ([127.0.0.1]:40432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyO4I-00069m-GZ for submit@debbugs.gnu.org; Mon, 16 Nov 2015 12:59:54 -0500 Received: from mout.gmx.net ([212.227.17.22]:59575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyO4G-00069e-Mn for 21921@debbugs.gnu.org; Mon, 16 Nov 2015 12:59:53 -0500 Received: from W530 ([109.201.152.246]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MPppG-1a2Doa2oxG-004ww3; Mon, 16 Nov 2015 18:59:50 +0100 From: Rasmus References: <56477C57.6090109@live.com> <87a8qffpvl.fsf@gmx.us> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAG1BMVEX9/f1xcXFRUVEwMDAH BweQkJCvr6/Pz89fX2B5g//hAAAACXBIWXMAAABIAAAASABGyWs+AAACO0lEQVQ4EQXBPXfTVgAA 0CvpSM+jQ+vA6Hx3DGnAjKR5wYwvTmyvIh8240s4lhgdTqH87N4LAAAAQDEGAABUH3GbAAB4mFLE DADA2ZSDKwAAmskn1a8pAABVumouijEBAJrk3tVDqlrh3zEAqqkj51e+eTr/DADVRZg6bM3u3v6Z AKA6H5zCzTtvAUA1O2wRqLfhMQNQbiPh8c2J8tX+KANQjvtuM0uehR70gMGp0c4eMpvfQ2EzBAan xQwg9FnRJLAsxosVABT14w48kVuA73vZU7WtocygHMKXTfdz1CxXUI9RD4tT+K7sl76MCEMTNJPw ER5edStCwKwF7yTomukmKXo0I7BJG+Co1t/MUe+AMhVDcLIu5gm6s9yibJ9bcJyOgcVmnOF6d3P4 Xv30s06A1S5wF2NUHi+fACHfg/sYY8zlLCUgLPbfQxljjLGtJvMEFPkAnH9OtzHmb4sygf2X5h9o 4kd1jPYKOyC01Q2tMo7V8XP9V0jFFO7G4XbS7RvESbiNp/MqL+c9XLfC4fls28QYL0fFXrGtEsjr 56Nw+eGyvY8X2Y/5YrMLDLbz5uVqeff3Yk0xPNotM3CdFurJutvs/v5w/bh8ufsP4PWJ5mTd9e12 Nlq1f/zIAE02WK37Po2WQn84BoCy6UO7XesW/W0GgKevb+bp9aJb85ABQNi8Ovt1lHWL5wwA0Bx8 CqtWMQYAEG5WwuNqAgBAmbs1IwAAmuMcutU9AADNabPqlQkAgDdrwtcJ8D/okH0hQX5omgAAAABJ RU5ErkJggg== Date: Mon, 16 Nov 2015 18:59:49 +0100 In-Reply-To: (Artur Malabarba's message of "Mon, 16 Nov 2015 09:02:12 +0000") Message-ID: <8737w5bzai.fsf@gmx.us> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:lxfgHzG1SXsmeczez+ppJ52P50IVT60pGkAkq19mMdqmzw7f6NR xtG8iBWGQuX4II+jsD2dNgeSK+0Nd8wBKY9e5Iq1IzC14qZTqs77ZApUXLqQ30ZBQ7V0hEa dAGugGKxISK4Xzpf6jv1yA0PsG3wjDwTSGP+n4LiW+Q9cEJMMGayTupcutHviKdWHP0zIxK CANGP0qhJiBa4ePwNjOEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wPVO077fxUI=:dPaux9DdOVLvpqAI2dOVoI KgKoa1oyocVhj2vOpSL2Hu+3YVhKLYK/A+bz7EsBxdfUfY+kFmGvinh8TD2oYTJ8uf7rOrxPr BrWbv8oZ8qktmMF9zNF5vwws0+FVpyUyAxu6Y7+dHi0+xQcYEVHkwg0kQaq6YVZc11137xnFx jlW+JxhRm9LsSLbNS72JHs1ewuJI7FfrUryhFBkx8GDZHNQG+sgxMtS2z8cjkP9BL+rEj7rID +SykBXSuntB/lcYohFCtERwXlTSvCkhySupMUSPrbfOyC3Gao8HttRjPOHzFtcqD8SZKAe3kO ky4Au6wdUDFMkvx2D6SknfQf44gwn5btWIZUdvQor6ETaKV5EFesDMqfk8d2FHt1/YAJRjX1J ur2Ns8jJoOilkuGDg6xccOBfnqaIHwznb6vLxtCkQfKT/bIAFo7LVxOE282tXgEAbzjhor57r +VRGH8entOzl7Db/8alwqzHKr32GeJcSPQ5mWxtQ9IcBoBC+qs6mxe/dYjy+6LUdlppBBkUvZ kWke4EdEfzfWQeoy1VdbCQJEgxsxv7PirCxbZedRc9HuqgtEXxBj4jCHIOtea7SJBTNKPHqDv 1SYEAIEm51wKiYj4YIBQsOMLhwcZINZYo3eE7X+zurFTmQk6AAZ1SJje8kNMl79vDlTwDaCtj BKjLPUvCxRZpaP6kt5MQBbNy6K39FFIeiGN0NS3lI18c9Td5Ly8nQBcMcAhjEfBxYGZpzPpm3 yf5/7aGTdY6pM63l5ElsJVqESmgLc+Jii6cujFvTfMjb7svQrP6coMwtF4TgdQg4ixo8HkSfN XkBtvU5BgA3Khkgx/CPXZr5nF3Z4A== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Artur Malabarba writes: > Indeed. When I was deciding how comment-line should work on a region, I > specifically chose to not make it identical to comment-dwim. > > Maybe it should still treat the "region ends at a newline" case specially. > Some emacs commands do that already. > Not sure though, since that would be slightly redundant with comment-dwim. It's already in comment-dwim. On my layout, comment-dwim is easier to reach anyway. I=E2=80=99m indifferent on the behavior of comment-line in t= his edge case. Both would make sense. Rasmus --=20 This is the kind of tedious nonsense up with which I will not put From unknown Fri Aug 15 20:51:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21921: New function comment-line also comments first line after region Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2015 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21921@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144779324423195 (code B ref -1); Tue, 17 Nov 2015 20:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2015 20:47:24 +0000 Received: from localhost ([127.0.0.1]:42041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zyn9v-000622-RE for submit@debbugs.gnu.org; Tue, 17 Nov 2015 15:47:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54626) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zyn9a-00061A-Qi for submit@debbugs.gnu.org; Tue, 17 Nov 2015 15:47:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zyn9Z-0001fu-G3 for submit@debbugs.gnu.org; Tue, 17 Nov 2015 15:47:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyn9Z-0001fo-Ct for submit@debbugs.gnu.org; Tue, 17 Nov 2015 15:47:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyn9Y-00058U-Gr for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 15:47:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zyn9T-0001dm-Fb for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 15:47:00 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:57324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyn9T-0001cl-6m for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 15:46:55 -0500 Received: from [192.168.178.31] ([77.12.22.183]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0M57sc-1aJ49S3DNm-00zE9n for ; Tue, 17 Nov 2015 21:46:52 +0100 Message-ID: <564B9277.2050306@easy-emacs.de> Date: Tue, 17 Nov 2015 21:47:51 +0100 From: Andreas =?UTF-8?Q?R=C3=B6hler?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 References: <56477C57.6090109@live.com> <87a8qffpvl.fsf@gmx.us> <8737w5bzai.fsf@gmx.us> In-Reply-To: <8737w5bzai.fsf@gmx.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:uErCFy4Hnc7tcGbxDFVszwkDIT+RbQFI5+i7eA59EcN02x67zEw +OATsnBSHBqeXITXfBzWT+MOm6fKrU3M/0i4KbWvn62JYvgWXsaJl2RrBssPXts56hBLavU mceOJeYej2UiCMPnYppMRELxOkP09rj7UPaZIt4QGYicYqPEwVKGowKgJ8FeI4EYRfGAK/t KhG5wDzUQVASNaAiukkvA== X-UI-Out-Filterresults: notjunk:1;V01:K0:nunjMLIwUO4=:3Cvp5nzYGWt8HJc03WO50X LC97pXyKeDj3vd59vaX7hH+qPpa1bNCNzAYOf11rbLTT0EuoWDbR+U7pQzH1tqANy06wZpgwS tFxEhP6dggFj3gf7mg5WcCF6K30uqlDwerwnGJpjs0qvm0hpAFDwQx9eDVGA9lYniOCm01f5E DcZJV0WD/K+m2Voit7UinTGQKTZb1lvVIH7Za8DsaX+4XPk5LcEzfhMZTeCk8iLdVMcsY6EAo 8FUbXyhMqAm7Kl0o5QbSFjASiBW2KD4kasCQDMuMTEQoX70E2V6FnjJeI5UrqpdVqLq4W+dhY SCMNzcs3YpZ2K26++f8KX/Y3mSj/h7CTIhcXN0IdDiLkilA8K5nLEPUn9xV8c9GPyNKdlPEl8 WEeCq6LWma7AbidzScD+wiiEc2DSp5dXdBLp+VMlSYnHZt6PX/GXMx5YIxZognmrkHycdfSCb 4CJhd6r0X3NLxUo8vNI80kEGu0oyv4cLRRH7WX6j7mGm/APjA6gOi52cWqLJl64MQEZ+vqY1+ +nUjrXVdusq8ejXd7mHke8nIN5dXfKW3E4AZx+Jv2VnZMkj0MEDSwt48p1bi/nCBpSkWQ3f/j Xcy/dWKLTuzRI7fWujSUr4OwZDrmUdYCUcpV30n0NNaGxh3YKSjYXolqzbr+Xwn5GI5OFpQ7I MIhqMd4Vu9fZlVulIzbOQ6Gx0lOR9K7fE3e2RkUtrBvHcvB/vs9ETUkZHVvPPzG4/yp2SwrCm ZIm3njkI8BEL+1y5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 16.11.2015 18:59, Rasmus wrote: > Artur Malabarba writes: > >> Indeed. When I was deciding how comment-line should work on a region, I >> specifically chose to not make it identical to comment-dwim. >> >> Maybe it should still treat the "region ends at a newline" case specially. >> Some emacs commands do that already. >> Not sure though, since that would be slightly redundant with comment-dwim. > It's already in comment-dwim. On my layout, comment-dwim is easier to > reach anyway. I’m indifferent on the behavior of comment-line in this > edge case. Both would make sense. > > Rasmus > Being in favor to keep it as implemented. Congrats BTW. Use this feature for years personally, glad to see it built-in now. IMO it's most useful as line-oriented command. Moving one line down, being ready for repeat. Cheers, Andreas From unknown Fri Aug 15 20:51:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21921: New function comment-line also comments first line after region Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2017 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21921@debbugs.gnu.org Received: via spool by 21921-submit@debbugs.gnu.org id=B21921.149658259323454 (code B ref 21921); Sun, 04 Jun 2017 13:24:02 +0000 Received: (at 21921) by debbugs.gnu.org; 4 Jun 2017 13:23:13 +0000 Received: from localhost ([127.0.0.1]:54757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHVUv-000668-7w for submit@debbugs.gnu.org; Sun, 04 Jun 2017 09:23:13 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:34803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHVUs-00065q-Jf; Sun, 04 Jun 2017 09:23:11 -0400 Received: by mail-it0-f48.google.com with SMTP id m47so11127901iti.1; Sun, 04 Jun 2017 06:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fFkTpQsk8zIAr3yOMN0LpHzx/boBEQ9CqL1d767+Ksc=; b=kpw5upVW8MBMo4hniBBuwzq4i2AlluDf/x7TOmT3Y/S9ybc52h0ft9jG7g3dWJcVs7 XfAk7NRasMl/vfTA6lvZlGvqAxVUFK7w8mGvfpyswe/5tFuWg5XZo/ECmOZQ4YBfTVNj yWtMWYrVUyBWdoP5jwZ03NxV5bSot5ToM/1YsUdbk35EivXrDVKTpHavG4fG1MI89ydu 187XwXhjPQbGycWMgf1/JQwY+BU8/U1ymK3/Ol2LQol5E677xENjWZNX1QpsqEsB4q/t iNTgNX7lzLnWx949+qWzfu2GaJv3M+mfCUvWndvzOcCJO0OjE22gFbuUPqg4DeAC8RIl L/2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=fFkTpQsk8zIAr3yOMN0LpHzx/boBEQ9CqL1d767+Ksc=; b=gctNmgKcU2okNoC+o9ljjBV8ZjYXtnM7M8DFggsU4pl0o3C/VXlw4C2Lo3iaE07bt4 OaimDLidzAFfniYzQyVBw44kWlkTj0mQSN+wLMFrXTojz7WzxdCHTehzvh9BDAK90ssy 7RFTOtw8TD0puzJGhC9lthig6fyRfoQxxHBLB4doHS/gBtNoKDV6vb5PuR51IHVorOkE BZcOUZ5WWik+Q26j4KVvAY/LFmMiCIY0hYjKhusu/gdH5bft87UfpJ6yRFP5ndXhrg55 p4c5gkS8h7ewj8pbtwEwVii47UduLcxM/AaPiblx4Ke+3ZGzEbunOg848XsADeZOjXpY bUow== X-Gm-Message-State: AODbwcA0nULKAIuXm+Y5la6v1a6/NmPkhGzjxuJxEKGtByBp4uOblxpx Nm73g4Re8kNOgg4R X-Received: by 10.107.41.82 with SMTP id p79mr5546583iop.196.1496582584797; Sun, 04 Jun 2017 06:23:04 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id u135sm4359028itu.10.2017.06.04.06.23.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Jun 2017 06:23:04 -0700 (PDT) From: npostavs@users.sourceforge.net References: <56477C57.6090109@live.com> <87a8qffpvl.fsf@gmx.us> Date: Sun, 04 Jun 2017 09:24:42 -0400 In-Reply-To: <87a8qffpvl.fsf@gmx.us> (rasmus@gmx.us's message of "Sun, 15 Nov 2015 12:45:02 +0100") Message-ID: <87h8zvzy05.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 21921 notabug wontfix close 21921 quit Rasmus writes: > Perhaps the confusion is caused by region not being displayed at column > zero. > > The behavior is correct IMO. > Artur Malabarba writes: > Indeed. When I was deciding how comment-line should work on a region, I s= pecifically chose to not make it identical to comment-dwim.=20 > > Maybe it should still treat the "region ends at a newline" case specially= . Some emacs commands do that already. > Not sure though, since that would be slightly redundant with comment-dwim= .=20 Andreas R=C3=B6hler writes: > Being in favor to keep it as implemented. Congrats BTW. Use this > feature for years personally, glad to see it built-in now. > IMO it's most useful as line-oriented command. Moving one line down, > being ready for repeat. I think we've decided it's okay as is, closing.