GNU bug report logs - #21898
scss-mode font-lock face for variables

Previous Next

Package: emacs;

Reported by: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>

Date: Fri, 13 Nov 2015 06:39:01 UTC

Severity: wishlist

Tags: patch

Done: Simen Heggestøyl <simenheg <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
To: bug-gnu-emacs <at> gnu.org
Subject: scss-mode font-lock face for variables
Date: Thu, 12 Nov 2015 22:37:57 -0800
[Message part 1 (text/plain, inline)]
I'd like to propose the following change to the scss-mode on master: Use
font-lock-constant-face for SCSS variables.

This may not seem intuitive from a naming perspective, but
font-lock-variable-name-face is already used for CSS properties. That makes
it harder to distinguish between properties and variables.

AFAIK, Sass doesn't even have constants, so I don't see much harm in using
this face. It'd be a less dramatic change for those who have grown used to
variable coloring for CSS properties.

I guess the alternative would be to inherit the property face from
something else, to free up the face for real variables. But then what do we
use for properties? (Inheriting from nothing doesn't look good IMO.)

Attached is the proposed patch.
[Message part 2 (text/html, inline)]
[0001-Use-font-lock-constant-face-for-scss-variables.patch (text/x-patch, attachment)]

This bug report was last modified 7 years and 296 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.