GNU bug report logs - #21898
scss-mode font-lock face for variables

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#21898: closed (scss-mode font-lock face for variables)
Date: Sun, 30 Jul 2017 09:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 30 Jul 2017 11:33:56 +0200
with message-id <1501407236.5617.0 <at> smtp.gmail.com>
and subject line Re: bug#21898: scss-mode font-lock face for variables
has caused the debbugs.gnu.org bug report #21898,
regarding scss-mode font-lock face for variables
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
21898: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21898
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
To: bug-gnu-emacs <at> gnu.org
Subject: scss-mode font-lock face for variables
Date: Thu, 12 Nov 2015 22:37:57 -0800

[Message part 3 (text/plain, inline)]

I'd like to propose the following change to the scss-mode on master: Use
font-lock-constant-face for SCSS variables.

This may not seem intuitive from a naming perspective, but
font-lock-variable-name-face is already used for CSS properties. That makes
it harder to distinguish between properties and variables.

AFAIK, Sass doesn't even have constants, so I don't see much harm in using
this face. It'd be a less dramatic change for those who have grown used to
variable coloring for CSS properties.

I guess the alternative would be to inherit the property face from
something else, to free up the face for real variables. But then what do we
use for properties? (Inheriting from nothing doesn't look good IMO.)

Attached is the proposed patch.

[Message part 4 (text/html, inline)]

[0001-Use-font-lock-constant-face-for-scss-variables.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Jackson Ray Hamilton <jackson <at> jacksonrayhamilton.com>
Cc: 21898-done <at> debbugs.gnu.org
Subject: Re: bug#21898: scss-mode font-lock face for variables
Date: Sun, 30 Jul 2017 11:33:56 +0200

On Sat, Jul 29, 2017 at 7:24 PM, Jackson Ray Hamilton 
<jackson <at> jacksonrayhamilton.com> wrote:
> Looks fine to me in all the default themes and the top 10 themes 
> here: https://emacsthemes.com/charts/all-time.html

Thanks for checking. It looks good to me in all the built-in themes as
well. I've installed the change in master as
4219240e1df6abbd842f4474fe7862f341cc355a.

-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.