From unknown Tue Jun 17 20:19:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#21898 <21898@debbugs.gnu.org> To: bug#21898 <21898@debbugs.gnu.org> Subject: Status: scss-mode font-lock face for variables Reply-To: bug#21898 <21898@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:19:22 +0000 retitle 21898 scss-mode font-lock face for variables reassign 21898 emacs submitter 21898 Jackson Hamilton severity 21898 wishlist tag 21898 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 01:38:22 2015 Received: (at submit) by debbugs.gnu.org; 13 Nov 2015 06:38:22 +0000 Received: from localhost ([127.0.0.1]:36501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zx806-0006TW-9H for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58890) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zx7zm-0006T2-C2 for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx7zk-0004BT-Sl for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx7zk-0004BK-PG for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx7zj-0000mn-Ql for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:38:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx7zi-0004A8-IP for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:37:59 -0500 Received: from mail-ob0-x233.google.com ([2607:f8b0:4003:c01::233]:35557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx7zi-00049h-CG for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:37:58 -0500 Received: by obbnk6 with SMTP id nk6so66643039obb.2 for ; Thu, 12 Nov 2015 22:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=plqQ7gyWh/AJOMHOedPzw0t9eI49up0SX7sNyH1K3Uw=; b=WvAiSzOQzjsT33XIB2o73a7B47O6OpBNbmFFPmoKGavp2+dpRaP8UvRE0UN+H7sVDA ZxNGe4p2PJJFN/teLCR8U1e20hMEo5e7p2V+tNXy8zQCcZInJ9RcNYSA/2f8YMLnxG/f AcErSXiVi17rHblZI+kqoCQ/vQKA0nlgv8ERjq3hXhGbQ9m9l7ghMybNEjK9g6bMcRTE BIC9Ii5kglQyf0wtG9SwzPHzo5Xaq4eHPHFHqMN+sqFfs5ezsMoOibS6cjnWNZdN2N+Y jpde2rfPnBv7IBnmJ2RsDddQ0VhGWgMvCTTEBA+saipZ3sP4UZ0ZeZ2mEa4dA1kHxTXK eRTQ== MIME-Version: 1.0 X-Received: by 10.60.165.72 with SMTP id yw8mr11679402oeb.45.1447396677639; Thu, 12 Nov 2015 22:37:57 -0800 (PST) Received: by 10.76.55.4 with HTTP; Thu, 12 Nov 2015 22:37:57 -0800 (PST) Date: Thu, 12 Nov 2015 22:37:57 -0800 X-Google-Sender-Auth: 1bxq_oGqvNF8E2Z3zmDlKQRf_o4 Message-ID: Subject: scss-mode font-lock face for variables From: Jackson Hamilton To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=047d7b41904bd224720524664cc4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --047d7b41904bd224720524664cc4 Content-Type: multipart/alternative; boundary=047d7b41904bd2246d0524664cc2 --047d7b41904bd2246d0524664cc2 Content-Type: text/plain; charset=UTF-8 I'd like to propose the following change to the scss-mode on master: Use font-lock-constant-face for SCSS variables. This may not seem intuitive from a naming perspective, but font-lock-variable-name-face is already used for CSS properties. That makes it harder to distinguish between properties and variables. AFAIK, Sass doesn't even have constants, so I don't see much harm in using this face. It'd be a less dramatic change for those who have grown used to variable coloring for CSS properties. I guess the alternative would be to inherit the property face from something else, to free up the face for real variables. But then what do we use for properties? (Inheriting from nothing doesn't look good IMO.) Attached is the proposed patch. --047d7b41904bd2246d0524664cc2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I'd like to propose the following change to the scss-m= ode on master: Use font-lock-constant-face for SCSS variables.

This may not seem intuitive from a naming perspective, but font-lock= -variable-name-face is already used for CSS properties. That makes it harde= r to distinguish between properties and variables.

AFAIK, Sass doesn't even have constants, so I don't see much harm = in using this face. It'd be a less dramatic change for those who have g= rown used to variable coloring for CSS properties.

I guess the alternative would be to inherit the property face from somethi= ng else, to free up the face for real variables. But then what do we use fo= r properties? (Inheriting from nothing doesn't look good IMO.)

Attached is the proposed patch.
--047d7b41904bd2246d0524664cc2-- --047d7b41904bd224720524664cc4 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Use-font-lock-constant-face-for-scss-variables.patch" Content-Disposition: attachment; filename="0001-Use-font-lock-constant-face-for-scss-variables.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igxakozw0 RnJvbSA3MmZiNDY3MDIyODMyNGI1OTUzMWExOTQwOTYxODI3N2I2MmFkMjMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNrc29uIFJheSBIYW1pbHRvbiA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgpEYXRlOiBUaHUsIDEyIE5vdiAyMDE1IDIyOjIxOjM4IC0wODAwClN1 YmplY3Q6IFtQQVRDSF0gVXNlIGBmb250LWxvY2stY29uc3RhbnQtZmFjZScgZm9yIHNjc3MgdmFy aWFibGVzCgoqIGNzcy1tb2RlLmVsIChzY3NzLWZvbnQtbG9jay1rZXl3b3Jkcyk6IENoYW5nZSBm YWNlLgotLS0KIGxpc3AvdGV4dG1vZGVzL2Nzcy1tb2RlLmVsIHwgMiArLQogMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXh0 bW9kZXMvY3NzLW1vZGUuZWwgYi9saXNwL3RleHRtb2Rlcy9jc3MtbW9kZS5lbAppbmRleCAzZTg0 YjQzLi5lMzVlNmNiIDEwMDY0NAotLS0gYS9saXNwL3RleHRtb2Rlcy9jc3MtbW9kZS5lbAorKysg Yi9saXNwL3RleHRtb2Rlcy9jc3MtbW9kZS5lbApAQCAtNTI1LDcgKzUyNSw3IEBAIHBzZXVkby1j bGFzc2VzLCBhbmQgYXQtcnVsZXMuIgogICAgIHN0KSkKIAogKGRlZnZhciBzY3NzLWZvbnQtbG9j ay1rZXl3b3JkcwotICAoYXBwZW5kIGAoKCwoY29uY2F0ICIkIiBjc3MtaWRlbnQtcmUpICgwIGZv bnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKSkKKyAgKGFwcGVuZCBgKCgsKGNvbmNhdCAiJCIg Y3NzLWlkZW50LXJlKSAoMCBmb250LWxvY2stY29uc3RhbnQtZmFjZSkpKQogICAgICAgICAgIChj c3MtLWZvbnQtbG9jay1rZXl3b3JkcyAnc2Fzc3kpCiAgICAgICAgICAgYCgoLChjb25jYXQgIkBt aXhpblsgXHRdK1xcKCIgY3NzLWlkZW50LXJlICJcXClbIFx0XSooIikKICAgICAgICAgICAgICAo MSBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKSkpKSkKLS0gCjIuNi4zCgo= --047d7b41904bd224720524664cc4-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 15:29:51 2015 Received: (at 21898) by debbugs.gnu.org; 13 Nov 2015 20:29:51 +0000 Received: from localhost ([127.0.0.1]:37496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxKyl-00063d-1f for submit@debbugs.gnu.org; Fri, 13 Nov 2015 15:29:51 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:35733) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxKyi-00063S-1M for 21898@debbugs.gnu.org; Fri, 13 Nov 2015 15:29:48 -0500 Received: by lbbsy6 with SMTP id sy6so31757850lbb.2 for <21898@debbugs.gnu.org>; Fri, 13 Nov 2015 12:29:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version:content-type; bh=6vpE4HBxP95Qf0iMiPGPWtyRIp2vur4F8A8kDcoGI2Y=; b=kvJJWT86rg+AMGOP7KYAiqthGOGbkbO2Z118bTl4mmdTn82sahzOOglBo9g+zs97YD gocFVPRCGjWLOtTUoG+IJeDYuTnNZq82E6J8pkXWoimszo2GZQ6PzunBomTPFvdC78mm VKsklSNnElnKOlvlix4RKsmzJ6mxC6PG3jezsA0KNRcHgcSJoF2aNS4FcjBl6gqIr6ae to7neTB1swrquvXqPfhBsdAwJUpbImT1NW0mE2ZuI5HvmQcwrOpfJ8Xys7mjMsmPymB3 zuP6Sj96gpYWXt9X1nKDIv41hJytrIxAO7NXdGOClfKr2U8fwMZtQ+O54nWJZoA2tNdv 2t2g== X-Received: by 10.112.169.97 with SMTP id ad1mr11486438lbc.5.1447446587125; Fri, 13 Nov 2015 12:29:47 -0800 (PST) Received: from [192.168.100.7] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id v4sm3381339lbo.30.2015.11.13.12.29.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Nov 2015 12:29:46 -0800 (PST) Date: Fri, 13 Nov 2015 21:29:45 +0100 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#21898: scss-mode font-lock face for variables To: Jackson Hamilton Message-Id: <1447446585.9212.2@smtp.gmail.com> In-Reply-To: References: X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-soiIomttdZ0F7+T4qBMo" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21898 Cc: 21898@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-soiIomttdZ0F7+T4qBMo Content-Type: text/plain; charset=utf-8; format=flowed Hello, Jackson! Thanks for the report. I never noticed this issue myself, since the theme I'm using (Leuven) styles the css-property face. We should definitely fix it. Like you say, two possible solutions are: 1. Highlight variables with font-lock-constant-face instead of font-lock-variable-name-face. A downside is that this is backwards wrt. the intended meaning of the faces, so users will see variables highlighted in a face that's usually used for constants. An upside is that it will probably look nice with existing themes, since they are likely to already style font-lock-variable-name-face. 2. Change the css-property face. It doesn't mean it has to inherit from another one of the standard Font Lock faces, we could also just change the default foreground color, for instance. A downside of this approach is that users may be startled that the face that they were used to changed, but for themes that already style the css-property, everything will be like before. The upside is that font-lock-variable-name-face remains used for variables, like it's intended to. I'm not sure which solution is best. Either way, we should also add a defface for variables and use it for Sass variables (and also CSS variables later on). -- Simen On Fri, Nov 13, 2015 at 7:37 AM, Jackson Hamilton wrote: > I'd like to propose the following change to the scss-mode on master: > Use font-lock-constant-face for SCSS variables. > > This may not seem intuitive from a naming perspective, but > font-lock-variable-name-face is already used for CSS properties. That > makes it harder to distinguish between properties and variables. > > AFAIK, Sass doesn't even have constants, so I don't see much harm in > using this face. It'd be a less dramatic change for those who have > grown used to variable coloring for CSS properties. > > I guess the alternative would be to inherit the property face from > something else, to free up the face for real variables. But then what > do we use for properties? (Inheriting from nothing doesn't look good > IMO.) > > Attached is the proposed patch. --=-soiIomttdZ0F7+T4qBMo Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hello, Jackson!

Thanks for the report. I neve= r noticed this issue myself, since the
theme I'm using (Leuven) s= tyles the css-property face. We should
definitely fix it.

Like you say, two possible solutions are:

<= /div>
1. Highlight variables with font-lock-constant-face instead of
   font-lock-variable-name-face. A downside is that this = is backwards
   wrt. the intended meaning of the faces,= so users will see variables
   highlighted in a face t= hat's usually used for constants. An upside is
   that = it will probably look nice with existing themes, since they are
&= nbsp;  likely to already style font-lock-variable-name-face.

2. Change the css-property face. It doesn't mean it has to = inherit from
   another one of the standard Font Lock f= aces, we could also just
   change the default foregrou= nd color, for instance. A downside of this
   approach = is that users may be startled that the face that they were
 =  used to changed, but for themes that already style the css-property,=
   everything will be like before. The upside is that<= /div>
   font-lock-variable-name-face remains used for variab= les, like it's
   intended to.

I'm not sure which solution is best.

Either = way, we should also add a defface for variables and use it for
Sa= ss variables (and also CSS variables later on).

<= div>-- Simen

On Fri, Nov 13, 2015 at 7:37 AM, Jackson H= amilton <jackson@jacksonrayhamilton.com> wrote:
I'd like to propose the followin= g change to the scss-mode on master: Use font-lock-constant-face for SCSS v= ariables.

This may not seem intuitive from a naming pers= pective, but font-lock-variable-name-face is already used for CSS propertie= s. That makes it harder to distinguish between properties and variables.

AFAIK, Sass doesn't even have constants, so I don't = see much harm in using this face. It'd be a less dramatic change for those = who have grown used to variable coloring for CSS properties.

=
I guess the alternative would be to inherit the property face fr= om something else, to free up the face for real variables. But then what do= we use for properties? (Inheriting from nothing doesn't look good IMO.)

Attached is the proposed patch.
= --=-soiIomttdZ0F7+T4qBMo-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 12:46:17 2017 Received: (at 21898) by debbugs.gnu.org; 29 Jul 2017 16:46:17 +0000 Received: from localhost ([127.0.0.1]:33292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbUsb-0005C6-Jc for submit@debbugs.gnu.org; Sat, 29 Jul 2017 12:46:17 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:33960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbUsZ-0005Bu-Pf for 21898@debbugs.gnu.org; Sat, 29 Jul 2017 12:46:16 -0400 Received: by mail-lf0-f47.google.com with SMTP id g25so97101893lfh.1 for <21898@debbugs.gnu.org>; Sat, 29 Jul 2017 09:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=Q4OwRzrmaNbDvS/dCOHS8sdKPV9BSzpVIyFvnEXKAqM=; b=AKi55YuYFy64nATm8SufumCTe05UMQWDPvW61Ze7C14TRaBO+GBnVlMQORuA88Tl6i k61jLiVxySSNN9q38WfOk3pm1f1T9JkBhJSglqfcOqK+ITtdjoiU/KjL7A+wDzz6rqUn lz0UTbVZM9taVU3/Pbe5/fL/pdXPd4WYwnrqX9V/tre/P+tcMFPRHIWUDQh6bvJR0IzR JWY1XhnGHvXaXane1w4jx0lJoR6Nliv2UAGN2563jz9uthu6npHl6oplZ3BHJ2oVGWOZ Lbzubdh9nY3QM/kRn6XVKUm1jb93xH/jbQgVQvjDMixvCnHsWGrUzgUZJJnI+vleT/yx yJOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=Q4OwRzrmaNbDvS/dCOHS8sdKPV9BSzpVIyFvnEXKAqM=; b=SVxBIbzSAgiBVwmry6Tk58NWEx9fEouc/LLVxWn3rjXdgSoLPtIZf2Gd36p+a1hZzW 9I2xTg1VXmXhFRh3RdAXNz7QZf5OungW1t8fGcyVBlYMF3Gfu+pNQ9ke7yne5WGGrFO1 messKVRAOAzGkNTSqJXMlEgkSmRuGDWpdjU1zZP/B04A1uXYmU4g1e5G6E2MCBnHRFoK UCmHalQfhXwRfOhMPFuN2iqG0aq6fmklUk9dYNtC/7cVET2ztuVDPw3TDPueMi8PU9Il 8SPPSTNK5EYxBOAr26hpEqJKSfAu7vBXnro70Vo3U+wfJDvQY+qoCkkFozxJZJYvW3Qr /R7g== X-Gm-Message-State: AIVw111XVWGyutKjrVaFdOg67ZV3Xjl6BPGJ7zRQS3JGfPtY+tsV4Rkr 8TF1CtBGNz6tLg== X-Received: by 10.46.20.22 with SMTP id u22mr690014ljd.58.1501346769769; Sat, 29 Jul 2017 09:46:09 -0700 (PDT) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id 67sm2919219lja.19.2017.07.29.09.46.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Jul 2017 09:46:09 -0700 (PDT) Date: Sat, 29 Jul 2017 18:46:07 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#21898: scss-mode font-lock face for variables To: Jackson Hamilton Message-Id: <1501346767.29622.1@smtp.gmail.com> In-Reply-To: <1447446585.9212.2@smtp.gmail.com> References: <1447446585.9212.2@smtp.gmail.com> X-Mailer: geary/0.11.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 21898 Cc: 21898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Maybe a solution could be to let the `css-property' face inherit from `font-lock-keyword-face' instead of `font-lock-variable-name-face'? That would let `font-lock-variable-name-face' stay reserved for CSS/Sass variables, while being distinguishable from CSS properties by default. -- Simen From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 13:24:56 2017 Received: (at 21898) by debbugs.gnu.org; 29 Jul 2017 17:24:56 +0000 Received: from localhost ([127.0.0.1]:33307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbVU0-00065d-MV for submit@debbugs.gnu.org; Sat, 29 Jul 2017 13:24:56 -0400 Received: from mta-08-3.privateemail.com ([198.54.127.61]:3190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbVTy-00065Q-W6 for 21898@debbugs.gnu.org; Sat, 29 Jul 2017 13:24:55 -0400 Received: from APP-03 (unknown [10.20.147.153]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by MTA-08.privateemail.com (Postfix) with ESMTPSA id 9F92B60044; Sat, 29 Jul 2017 17:24:48 +0000 (UTC) Date: Sat, 29 Jul 2017 10:24:48 -0700 (PDT) From: Jackson Ray Hamilton To: =?UTF-8?Q?Simen_Heggest=C3=B8yl?= Message-ID: <619239865.75863.1501349088595@privateemail.com> In-Reply-To: <1501346767.29622.1@smtp.gmail.com> References: <1447446585.9212.2@smtp.gmail.com> <1501346767.29622.1@smtp.gmail.com> Subject: Re: bug#21898: scss-mode font-lock face for variables MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_75862_663829224.1501349088478" X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.1-Rev35 X-Originating-Client: open-xchange-appsuite X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21898 Cc: 21898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jackson Ray Hamilton Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) ------=_Part_75862_663829224.1501349088478 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Looks fine to me in all the default themes and the top 10 themes here: http= s://emacsthemes.com/charts/all-time.html > On July 29, 2017 at 9:46 AM Simen Heggest=C3=B8yl wr= ote: > > > Maybe a solution could be to let the `css-property' face inherit from > `font-lock-keyword-face' instead of `font-lock-variable-name-face'? That > would let `font-lock-variable-name-face' stay reserved for CSS/Sass > variables, while being distinguishable from CSS properties by default. > > -- Simen > ------=_Part_75862_663829224.1501349088478 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Looks fine to me in all the default themes and the top 10 themes here: https://emacsthemes.com/charts/all-time.html

> On July 29, 2017 at 9:46 AM Simen Heggestøyl <simenheg@gmail.com> wrote:
>
>
> Maybe a solution could be to let the `css-property' face inherit from
> `font-lock-keyword-face' instead of `font-lock-variable-name-face'? That
> would let `font-lock-variable-name-face' stay reserved for CSS/Sass
> variables, while being distinguishable from CSS properties by default.
>
> -- Simen
>
------=_Part_75862_663829224.1501349088478-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 30 05:34:07 2017 Received: (at 21898-done) by debbugs.gnu.org; 30 Jul 2017 09:34:07 +0000 Received: from localhost ([127.0.0.1]:33603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbkbv-0003ri-Cu for submit@debbugs.gnu.org; Sun, 30 Jul 2017 05:34:07 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:35283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbkbt-0003rA-B8 for 21898-done@debbugs.gnu.org; Sun, 30 Jul 2017 05:34:05 -0400 Received: by mail-lf0-f48.google.com with SMTP id t128so74275641lff.2 for <21898-done@debbugs.gnu.org>; Sun, 30 Jul 2017 02:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=CHDcUuDFgR8AFIfsw+Hv3KJ4EBS99muL1n6BBdfBqfQ=; b=YYukQg1nwv2kRmZn7CEYe4f3EQBcuqevmu/9Jh7J9ODEJLAVASTK0d6ToghIXb6NKT ACDuuGS6xMYJdNtMSrGebLel/vhictrhdrPeA3yTZJZQTHexngvau89BqzMbChu/w7xH fgTp5hdtsbT8Vo49YOUcL/Bi0ikx/43L2A1u10F/eW2A/nBxPA5B7NBR6OEVOsGdObyk HKgJ6yvZevi59O89LCNlLOQCw1g6dPKGPni2qjOraqkFvT08vX+pnRyQ9UtZ1hDRnvu2 4DHUu3O3vOpUv9IThNDA//kRxCyTRTsNt0XG0sTEaEGzHuZeh7GnSb1ReUCQif6QKVP5 XV6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=CHDcUuDFgR8AFIfsw+Hv3KJ4EBS99muL1n6BBdfBqfQ=; b=OvA/Pmf9HW9U3rfnNOv5QuoEzBIdNXsdUC5fexOLv1i/7j7magw6aRoe/BAhWokNqg XBbYzJkmys688FikwciKR90+7ZUv8igEymzfY0eEJJuDyOO+4+7SkbamflMuVvCjNvZY JohB9Y3Aa69vtmGVVpzuz32IrIptWBQiQJQH05bT2JrtKk/SOBeZfBNLUk6ZxKsfLA3E M05MEGQXCaMOYblnE+GP7ZYoSwehzoyYWihTlX5+JksD/7lheVYnPcQPmAkVY9N2AzL9 BhQoYvtEi4xanw4YCGE9XS6hVgnLzLdJgYQd/DWdbSzCOtZ5K8dpvv9Fa0uHv4kuguTB clew== X-Gm-Message-State: AIVw1139whdrlrxtZ3im1PFz9SuDJ3eaOjj5lMwUSg9foX90aOlQU/nY T2wwlmAIT7+9hSZ1 X-Received: by 10.46.72.17 with SMTP id v17mr5133820lja.13.1501407239109; Sun, 30 Jul 2017 02:33:59 -0700 (PDT) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id 1sm1499556lju.63.2017.07.30.02.33.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Jul 2017 02:33:58 -0700 (PDT) Date: Sun, 30 Jul 2017 11:33:56 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#21898: scss-mode font-lock face for variables To: Jackson Ray Hamilton Message-Id: <1501407236.5617.0@smtp.gmail.com> In-Reply-To: <619239865.75863.1501349088595@privateemail.com> References: <1447446585.9212.2@smtp.gmail.com> <1501346767.29622.1@smtp.gmail.com> <619239865.75863.1501349088595@privateemail.com> X-Mailer: geary/0.11.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 21898-done Cc: 21898-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, Jul 29, 2017 at 7:24 PM, Jackson Ray Hamilton wrote: > Looks fine to me in all the default themes and the top 10 themes > here: https://emacsthemes.com/charts/all-time.html Thanks for checking. It looks good to me in all the built-in themes as well. I've installed the change in master as 4219240e1df6abbd842f4474fe7862f341cc355a. -- Simen From unknown Tue Jun 17 20:19:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 27 Aug 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator