From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 11:28:52 2015 Received: (at submit) by debbugs.gnu.org; 10 Nov 2015 16:28:52 +0000 Received: from localhost ([127.0.0.1]:60463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwBmu-0000yb-EM for submit@debbugs.gnu.org; Tue, 10 Nov 2015 11:28:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41152) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwBms-0000yQ-GX for submit@debbugs.gnu.org; Tue, 10 Nov 2015 11:28:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwBmo-0003nW-Ay for submit@debbugs.gnu.org; Tue, 10 Nov 2015 11:28:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwBmo-0003nS-95 for submit@debbugs.gnu.org; Tue, 10 Nov 2015 11:28:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwBmn-0004BF-D9 for bug-gnu-emacs@gnu.org; Tue, 10 Nov 2015 11:28:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwBmi-0003mm-Aw for bug-gnu-emacs@gnu.org; Tue, 10 Nov 2015 11:28:45 -0500 Received: from mail.muc.de ([193.149.48.3]:60909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwBmi-0003mg-0z for bug-gnu-emacs@gnu.org; Tue, 10 Nov 2015 11:28:40 -0500 Received: (qmail 89999 invoked by uid 3782); 10 Nov 2015 16:28:38 -0000 Received: from acm.muc.de (p5B14697B.dip0.t-ipconnect.de [91.20.105.123]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 10 Nov 2015 17:28:37 +0100 Received: (qmail 4295 invoked by uid 1000); 10 Nov 2015 16:30:34 -0000 Date: Tue, 10 Nov 2015 16:30:34 +0000 To: bug-gnu-emacs@gnu.org Subject: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. Message-ID: <20151110163034.GH2626@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Hello, Emacs. In the Emacs manual page "Left Margin Paren", it says that: To help you catch violations of this convention, Font Lock mode highlights confusing opening delimiters (those that ought to be quoted) in bold red. , where "this convention" is the convention of not putting opening parens in column 0 when they aren't at the beginning of defuns. In Emacs Lisp Mode, this highlighting isn't done. It isn't in CC Mode, either. This is either a bug in the code, or a bug in the documentation. I rather tend to the view that this bold red highlighting should be done when open-paren-in-column-0-is-defun-start is non-nil. I think it did, at one stage, but searching the emacs-devel archives doesn't reveal what happened. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 12:44:54 2015 Received: (at control) by debbugs.gnu.org; 10 Nov 2015 17:44:55 +0000 Received: from localhost ([127.0.0.1]:60529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwCyU-0002pq-Lx for submit@debbugs.gnu.org; Tue, 10 Nov 2015 12:44:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41291) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwCyS-0002pg-Ta for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:44:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwCyS-0001kS-3G for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:44:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCyR-0001kO-W5 for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:44:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ZwCyR-0007i4-Nh for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:44:51 -0500 Subject: control message for bug 21871 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 10 Nov 2015 12:44:51 -0500 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) found 21871 24.4 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 12:45:02 2015 Received: (at control) by debbugs.gnu.org; 10 Nov 2015 17:45:03 +0000 Received: from localhost ([127.0.0.1]:60532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwCyb-0002q9-Tj for submit@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41336) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwCya-0002q2-Nq for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwCya-0001lz-0k for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCyZ-0001lu-V0 for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:44:59 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ZwCyZ-00083U-CQ for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:44:59 -0500 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 10 Nov 2015 12:44:59 -0500 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) block 19759 by 21871 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 12:45:30 2015 Received: (at control) by debbugs.gnu.org; 10 Nov 2015 17:45:30 +0000 Received: from localhost ([127.0.0.1]:60537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwCyl-0002rU-Hh for submit@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41362) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwCyf-0002ql-7t for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwCye-0001n7-Gf for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCye-0001n2-EP for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:04 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ZwCye-0008KK-1n for control@debbugs.gnu.org; Tue, 10 Nov 2015 12:45:04 -0500 Subject: control message for bug 21871 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 10 Nov 2015 12:45:04 -0500 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) found 21871 24.5 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 07:45:11 2015 Received: (at 21871) by debbugs.gnu.org; 12 Nov 2015 12:45:11 +0000 Received: from localhost ([127.0.0.1]:34163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwrFX-0000JB-3m for submit@debbugs.gnu.org; Thu, 12 Nov 2015 07:45:11 -0500 Received: from mail.muc.de ([193.149.48.3]:35685) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwrFC-0000IC-Qj for 21871@debbugs.gnu.org; Thu, 12 Nov 2015 07:45:09 -0500 Received: (qmail 55829 invoked by uid 3782); 12 Nov 2015 12:44:49 -0000 Date: 12 Nov 2015 12:44:49 -0000 Message-ID: <20151112124449.55828.qmail@mail.muc.de> From: Alan Mackenzie To: 21871@debbugs.gnu.org Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.3.1-20141224 ("Tallant") (UNIX) (FreeBSD/10.1-RELEASE-p16 (amd64)) X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 21871 Cc: Alan Mackenzie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) In article you wrote: > In the Emacs manual page "Left Margin Paren", it says that: > To help you catch violations of this convention, Font Lock mode > highlights confusing opening delimiters (those that ought to be quoted) > in bold red. > , where "this convention" is the convention of not putting opening parens > in column 0 when they aren't at the beginning of defuns. > In Emacs Lisp Mode, this highlighting isn't done. It isn't in CC Mode, > either. > This is either a bug in the code, or a bug in the documentation. I > rather tend to the view that this bold red highlighting should be done > when open-paren-in-column-0-is-defun-start is non-nil. I think it did, > at one stage, but searching the emacs-devel archives doesn't reveal what > happened. Thinking about it, this is surely a bug in the documentation. The only way Font Lock (or anything else) could pick out an offending paren would be to scan a buffer from BOB. This would rather defeat the point of the paren in column 0 convention. I'll patch the doc. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 11:37:23 2015 Received: (at 21871) by debbugs.gnu.org; 12 Nov 2015 16:37:24 +0000 Received: from localhost ([127.0.0.1]:34912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwusF-00062y-Lg for submit@debbugs.gnu.org; Thu, 12 Nov 2015 11:37:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49230) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zwurw-00062V-0o for 21871@debbugs.gnu.org; Thu, 12 Nov 2015 11:37:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwurs-0000Qr-07 for 21871@debbugs.gnu.org; Thu, 12 Nov 2015 11:37:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwurp-0000PT-FU; Thu, 12 Nov 2015 11:36:57 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Zwurn-0000Yl-OT; Thu, 12 Nov 2015 11:36:55 -0500 From: Glenn Morris To: Alan Mackenzie Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. References: <20151110163034.GH2626@acm.fritz.box> <20151112124449.55828.qmail@mail.muc.de> X-Spook: gamma spies Tsunami E. Coli Drug cartel Gang digicash AQAP X-Ran: ty"02vK`B&n|sh"v=&9F@^H(Wr.FU2w_KNK#(r$h1G{6RP4~~eg~>j^bBeiDg<7-pn;a9. X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 12 Nov 2015 11:36:55 -0500 In-Reply-To: <20151112124449.55828.qmail@mail.muc.de> (Alan Mackenzie's message of "12 Nov 2015 12:44:49 -0000") Message-ID: <756117yy1k.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) Alan Mackenzie wrote: > Thinking about it, this is surely a bug in the documentation. I disagree, since it works as documented in Emacs 24.3. It seems to have been broken since 24.4. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 13:11:05 2015 Received: (at 21871) by debbugs.gnu.org; 12 Nov 2015 18:11:05 +0000 Received: from localhost ([127.0.0.1]:34986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwwKu-0003AN-DR for submit@debbugs.gnu.org; Thu, 12 Nov 2015 13:11:04 -0500 Received: from mail.muc.de ([193.149.48.3]:30643) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwwKa-00039b-O3 for 21871@debbugs.gnu.org; Thu, 12 Nov 2015 13:11:03 -0500 Received: (qmail 28911 invoked by uid 3782); 12 Nov 2015 18:10:43 -0000 Received: from acm.muc.de (p5B14648C.dip0.t-ipconnect.de [91.20.100.140]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 12 Nov 2015 19:10:43 +0100 Received: (qmail 6239 invoked by uid 1000); 12 Nov 2015 18:12:41 -0000 Date: Thu, 12 Nov 2015 18:12:41 +0000 To: Glenn Morris Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. Message-ID: <20151112181241.GG3120@acm.fritz.box> References: <20151110163034.GH2626@acm.fritz.box> <20151112124449.55828.qmail@mail.muc.de> <756117yy1k.fsf@fencepost.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <756117yy1k.fsf@fencepost.gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Hello, Glenn. On Thu, Nov 12, 2015 at 11:36:55AM -0500, Glenn Morris wrote: > Alan Mackenzie wrote: > > Thinking about it, this is surely a bug in the documentation. > I disagree, since it works as documented in Emacs 24.3. > It seems to have been broken since 24.4. Thanks for that tip. The code for it (in font-lock-compile-keywords) is still there, but somehow one of a list of conditions which prevent it being activated has become set. I'm looking into it. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 13:54:46 2015 Received: (at 21871) by debbugs.gnu.org; 12 Nov 2015 18:54:46 +0000 Received: from localhost ([127.0.0.1]:35066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zwx0t-0004HQ-V4 for submit@debbugs.gnu.org; Thu, 12 Nov 2015 13:54:46 -0500 Received: from mail.muc.de ([193.149.48.3]:55733) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zwx0r-0004HH-RC for 21871@debbugs.gnu.org; Thu, 12 Nov 2015 13:54:26 -0500 Received: (qmail 38600 invoked by uid 3782); 12 Nov 2015 18:54:24 -0000 Date: 12 Nov 2015 18:54:24 -0000 Message-ID: <20151112185424.38599.qmail@mail.muc.de> From: Alan Mackenzie To: 21871@debbugs.gnu.org Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.3.1-20141224 ("Tallant") (UNIX) (FreeBSD/10.1-RELEASE-p16 (amd64)) X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 21871 Cc: Glenn Morris , Alan Mackenzie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) In article you wrote: > On Thu, Nov 12, 2015 at 11:36:55AM -0500, Glenn Morris wrote: >> Alan Mackenzie wrote: >> > Thinking about it, this is surely a bug in the documentation. >> I disagree, since it works as documented in Emacs 24.3. >> It seems to have been broken since 24.4. > Thanks for that tip. The code for it (in font-lock-compile-keywords) is > still there, but somehow one of a list of conditions which prevent it > being activated has become set. > I'm looking into it. The fix to bug #16247 meant no longer setting syntax-begin-function to a non-nil value. This is the condition which used to cause the appropriate font-lock-keywords form to get added to lisp-font-lock-keywords-1/2. It no longer is. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 14:17:41 2015 Received: (at 21871) by debbugs.gnu.org; 12 Nov 2015 19:17:42 +0000 Received: from localhost ([127.0.0.1]:35073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwxNN-0004p3-Hj for submit@debbugs.gnu.org; Thu, 12 Nov 2015 14:17:41 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:41474) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwxN2-0004oc-Ss for 21871@debbugs.gnu.org; Thu, 12 Nov 2015 14:17:40 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NXP00F00UNHDC00@a-mtaout20.012.net.il> for 21871@debbugs.gnu.org; Thu, 12 Nov 2015 21:17:19 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXP00ETYUWVWCA0@a-mtaout20.012.net.il>; Thu, 12 Nov 2015 21:17:19 +0200 (IST) Date: Thu, 12 Nov 2015 21:17:05 +0200 From: Eli Zaretskii Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. In-reply-to: <20151112185424.38599.qmail@mail.muc.de> X-012-Sender: halo1@inter.net.il To: Alan Mackenzie , Stefan Monnier Message-id: <831tbvhvta.fsf@gnu.org> References: <20151110163034.GH2626@acm.fritz.box> <20151112185424.38599.qmail@mail.muc.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21871 Cc: acm@muc.de, 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: 12 Nov 2015 18:54:24 -0000 > From: Alan Mackenzie > Cc: Alan Mackenzie > > The fix to bug #16247 meant no longer setting syntax-begin-function to a > non-nil value. This is the condition which used to cause the appropriate > font-lock-keywords form to get added to lisp-font-lock-keywords-1/2. It > no longer is. Stefan? From debbugs-submit-bounces@debbugs.gnu.org Sun May 15 17:51:05 2016 Received: (at 21871) by debbugs.gnu.org; 15 May 2016 21:51:05 +0000 Received: from localhost ([127.0.0.1]:53045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b23wG-00025T-Tt for submit@debbugs.gnu.org; Sun, 15 May 2016 17:51:05 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b23wE-00024z-Pn for 21871@debbugs.gnu.org; Sun, 15 May 2016 17:51:03 -0400 Received: by mail-wm0-f45.google.com with SMTP id g17so108992066wme.1 for <21871@debbugs.gnu.org>; Sun, 15 May 2016 14:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=5eRg20JKTaSu+NmNg6mHYAT+Oumok0vuuCulKoTwcOg=; b=eExCZpsjDiHQlXuXOxQwrEthJNLNZksDooIsdh1vjctQB+V78gcjKwF2jfcVyuhw7v YyZRelfhzG7Wyu2ijlpW5uR85SqAS7vFftMqem8aX6VsicGyJQVN+MzhAQD8PEwrCm3b D4GV1I2ceiPIBP7EroefMxBS2fNvmzQ2DxCJhkRaqGVp3Fol2eVPEeoaw8AJWc+HziuB k+Ae69M4pzqn/KbK7mhFatcy92s0RJCGftvwudA+G8NGjQQBTCQl9d5KXwifGugdd/4B CAnay1ZxwEgkeBYTN7//L3eAlA17lfXSwak5qpwDRParFN7VTe1UecPSXcRMcJEXVIOq IAMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=5eRg20JKTaSu+NmNg6mHYAT+Oumok0vuuCulKoTwcOg=; b=kvFY636RmCbrTQkA9IIlAxgtuvDLTavQtbxeyYsiKwjNr2WDiRWyb7LKT3W7YzTMig D90erVqUul7Q1ksPbYVLX+ngKMC70zSYFnnBnUidLa+p1C883KUujb7mNiZR2JPuqCnr mz2b9iGvq+Hf34UPgcQ8gOFJqfUshJy+e9LAb/M/zhrUkS8ZIexVEmoLi9ooKZI3M/2/ FD7EaUEzN76LhHw11mFd/5N+4WbBe7b7pBaoahPPyRzzz8R2jIo3s/yU7SzERkONbRXo 5aEdIT1XdD9eR00VUke+FL9X2ajEC/LzNPvevtSMLeh/LyZApnHL4nO8lmOnxRpu1gcp Kufw== X-Gm-Message-State: AOPr4FVSe/N2ikAOC3zxO79VvWdkD9nITn5COOTTE4FNkGt/l+o2IOr/XF8avUhB6OVzPA== X-Received: by 10.194.42.69 with SMTP id m5mr26716505wjl.89.1463349057102; Sun, 15 May 2016 14:50:57 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id m140sm14989349wma.24.2016.05.15.14.50.55 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 15 May 2016 14:50:56 -0700 (PDT) Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. To: Alan Mackenzie , 21871@debbugs.gnu.org References: <20151110163034.GH2626@acm.fritz.box> <20151112185424.38599.qmail@mail.muc.de> From: Dmitry Gutov Message-ID: <414b75b8-bb45-4640-4742-9f88b9ff5e75@yandex.ru> Date: Mon, 16 May 2016 00:50:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 MIME-Version: 1.0 In-Reply-To: <20151112185424.38599.qmail@mail.muc.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 21871 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 11/12/2015 08:54 PM, Alan Mackenzie wrote: > The fix to bug #16247 meant no longer setting syntax-begin-function to a > non-nil value. This is the condition which used to cause the appropriate > font-lock-keywords form to get added to lisp-font-lock-keywords-1/2. It > no longer is. Looking into this, I'm not sure we still want to highlight them. The aforementioned bug, now fixed, mirrored the justifications that we give in the manual and the comments for the highlighting of parens in the 0th column: "The convention speeds up many Emacs operations, which would otherwise have to scan back to the beginning of the buffer to analyze the syntax of the code." and ;; Try to detect when a string or comment contains something that ;; looks like a defun and would thus confuse font-lock. We don't have to scan back to the beginning of the buffer, we can use syntax-ppss (and it's more reliable with bug#16247 fixed). font-lock doesn't get confused by something looking like a defun inside a docstring (try it; I wasn't able to get it highlight something wrong). M-x beginning-of-defun does get confused, though. If *that* is problem what we want to detect, I think the patch should look like this: diff --git a/lisp/font-lock.el b/lisp/font-lock.el index 8ee9f69..eed2766 100644 --- a/lisp/font-lock.el +++ b/lisp/font-lock.el @@ -1786,13 +1786,10 @@ font-lock-compile-keywords (cons t (cons keywords (mapcar #'font-lock-compile-keyword keywords)))) (if (and (not syntactic-keywords) - (let ((beg-function syntax-begin-function)) - (or (eq beg-function 'beginning-of-defun) - (if (symbolp beg-function) - (get beg-function 'font-lock-syntax-paren-check)))) - (not beginning-of-defun-function)) + (not beginning-of-defun-function) + open-paren-in-column-0-is-defun-start) ;; Try to detect when a string or comment contains something that - ;; looks like a defun and would thus confuse font-lock. + ;; looks like a defun and would thus confuse beginning-of-defun. (nconc keywords `((,(if defun-prompt-regexp (concat "^\\(?:" defun-prompt-regexp "\\)?\\s(") From debbugs-submit-bounces@debbugs.gnu.org Mon May 16 09:19:04 2016 Received: (at 21871) by debbugs.gnu.org; 16 May 2016 13:19:04 +0000 Received: from localhost ([127.0.0.1]:53384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2IQK-0004BG-DQ for submit@debbugs.gnu.org; Mon, 16 May 2016 09:19:04 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2IQI-0004Ak-I7 for 21871@debbugs.gnu.org; Mon, 16 May 2016 09:19:02 -0400 Received: by mail-wm0-f43.google.com with SMTP id g17so135703306wme.1 for <21871@debbugs.gnu.org>; Mon, 16 May 2016 06:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=FFWN9N/blOPaybWjsKhJymDsSaHU5iqYVTDg7YPfTwc=; b=dBAgxXksVDBN9xeMXLV5kIwZ2ZWDSATWvmnWjQsUIFJ/32/6RYYcrROaydptGBBgOA GYq7nn0IhDrGVRvyNpmfvaELOIUMWeC8YbNr+L1pF0RZ8AxY8jf1f+T0EHgu+vVsX+tB Pru0ZAc4S6s9niOhVV/PX7tj2u1BbBWGBDqBtcfS27zJ45iiYxHJpZy0AH+a8Wu2MmJg zlLj7emjsn2jt14A8w+FC6zLPT++sdlqL3b1McIBQ1Wqs9YIp3/0naJNVi4PnLMIORS5 E/WDwqDIoO+wIfyNaBL8uMQfXeIAjuXucVm1yCB/f36JbjXKOJpdyzYq80sFZJsw4Hhj 2swg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=FFWN9N/blOPaybWjsKhJymDsSaHU5iqYVTDg7YPfTwc=; b=QP2TjjQfoi/cmAlSvhfWBYBlsfpRov8t1Ej9NtFvF2hXjxTD0tdryYVga8VwNRGVhL xDt2NPPhZmWWxqNbGcxw6bDNqvyvQeMFZR3jayWT+pdPVld1LU6Z00QpRpWytp6IS/PD xIg1DCvZE61T+vq/gAMHRR8ANWsZubdAK3A6smELsPCo86G8vHsZm7JRyfajB8WYlPi4 R07gSbO3jUvW6g6bdy7VWo+dWOcGCagdnGLmlcoHCchiMabGgyznrP2UDcj2++0Tzlts RLjFBYV70MlXMk+cisJctp4qGLkvHx6FsWIulnQf7HENonzuXlkcc/nwrfqnHlWxk9q9 QRRQ== X-Gm-Message-State: AOPr4FUZ8h9fhFCKXTc7ofaMrgxnUs3XqVwhGaIXMUZrhLjdGJcY2/R6hfpsrM9Qe8gJYA== X-Received: by 10.28.27.17 with SMTP id b17mr17693209wmb.19.1463404736887; Mon, 16 May 2016 06:18:56 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id xz3sm16423482wjb.10.2016.05.16.06.18.55 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 May 2016 06:18:56 -0700 (PDT) Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. To: Alan Mackenzie References: <20151110163034.GH2626@acm.fritz.box> <20151112185424.38599.qmail@mail.muc.de> <414b75b8-bb45-4640-4742-9f88b9ff5e75@yandex.ru> <20160516102002.GB2317@acm.fritz.box> From: Dmitry Gutov Message-ID: <37a9ca07-1ffc-b872-4cf0-719f97177e35@yandex.ru> Date: Mon, 16 May 2016 16:18:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 MIME-Version: 1.0 In-Reply-To: <20160516102002.GB2317@acm.fritz.box> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 05/16/2016 01:20 PM, Alan Mackenzie wrote: > Note this convention is still active. The "convention" may be in place, but the underlying reasons for it are much weaker these days. Any relevant operation can use syntax-ppss. >> We don't have to scan back to the beginning of the buffer, we can use >> syntax-ppss (and it's more reliable with bug#16247 fixed). > > Sorry, this isn't true. The scanning back to BOB is done at the C > level, in function back_comment. What I wrote is true: font-lock rules can use syntax-ppss, and often do. > syntax-ppss isn't suitable for use > here (Stefan's view, not merely mine), because syntax-ppss doesn't react > to changes in the syntax table, and suchlike. Here where? >> font-lock doesn't get confused by something looking like a defun inside >> a docstring (try it; I wasn't able to get it highlight something wrong). > > You might be getting confused, here. No, I'm not. I'm addressing a comment inside font-lock-compile-keywords, which is trying to justify highlighting parens in the first column. > The scanning back to BOB which is > slow doesn't just happen in font lock; it can (and does) happen > anywhere. Only in certain places, where the programmer didn't think to use the cache provided by syntax-ppss. > It's just font lock's job to warn the user about this, so > that she can correct it by adding in a backslash, for example. And it's the job of the programmer to avoid this problem altogether, which is not too hard. > Things do get confused, for example see bug #22884, where there was an > open paren in column zero in our own C sources. Even if bug#22884 is somewhat related, it's actually irrelevant is the current discussion because c-mode uses a non-default beginning-of-defun-function. Which means font-lock-compile-keywords won't add highlighting to 0-column parens in c-mode anyway. It seems the current code was designed with only Lisp modes in mind. >> M-x beginning-of-defun does get confused, though. If *that* is problem >> what we want to detect, ..... > > Not particularly. We want the user to be warned about things > potentially going wrong in back_comment, and anything which calls it. I don't see any reason to believe that the original author of this code was concerned with back_comment specifically. > No. open-paren-in-column-0-is-defun-start is a variable that the user > can change at any time. I don't think it is, or should be, true. The major mode knows better whether it can know where a defun starts, or not. E.g. js-mode and elisp-byte-code-mode set it to nil. If the user changes that value in one of these modes, nothing good will happen. > We can't make our font-locking dependent upon > what its value was at some time in the past. If open-paren-... belongs > anywhere, it's in the form just beyond the end of your patch's text. I don't think so. I don't mind taking its comparison out altogether, but then the predicate will become very simple. > Do you understand the consequences of taking out the check on > syntax-begin-function? (I certainly don't.) It would be good if Stefan > could express a view, here. Point is, there is no way to simply alter the check that it would accept the current situation with syntax-begin-function, but still keep it meaningful. If we accept the value nil (which it is emacs-lisp-mode now), we should accept any syntax-begin-function, I think. From debbugs-submit-bounces@debbugs.gnu.org Mon May 16 13:32:07 2016 Received: (at 21871) by debbugs.gnu.org; 16 May 2016 17:32:07 +0000 Received: from localhost ([127.0.0.1]:54137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2MND-0007Kf-AP for submit@debbugs.gnu.org; Mon, 16 May 2016 13:32:07 -0400 Received: from mail.muc.de ([193.149.48.3]:55646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2MNC-0007Hk-1J for 21871@debbugs.gnu.org; Mon, 16 May 2016 13:32:06 -0400 Received: (qmail 10532 invoked by uid 3782); 16 May 2016 10:20:03 -0000 Received: from acm.muc.de (p548C61A4.dip0.t-ipconnect.de [84.140.97.164]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 16 May 2016 12:20:03 +0200 Received: (qmail 17390 invoked by uid 1000); 16 May 2016 10:20:02 -0000 Date: Mon, 16 May 2016 10:20:02 +0000 To: Dmitry Gutov Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. Message-ID: <20160516102002.GB2317@acm.fritz.box> References: <20151110163034.GH2626@acm.fritz.box> <20151112185424.38599.qmail@mail.muc.de> <414b75b8-bb45-4640-4742-9f88b9ff5e75@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <414b75b8-bb45-4640-4742-9f88b9ff5e75@yandex.ru> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Hello, Dmitry. On Mon, May 16, 2016 at 12:50:54AM +0300, Dmitry Gutov wrote: > On 11/12/2015 08:54 PM, Alan Mackenzie wrote: > > The fix to bug #16247 meant no longer setting syntax-begin-function to a > > non-nil value. This is the condition which used to cause the appropriate > > font-lock-keywords form to get added to lisp-font-lock-keywords-1/2. It > > no longer is. > Looking into this, I'm not sure we still want to highlight them. The > aforementioned bug, now fixed, mirrored the justifications that we give > in the manual and the comments for the highlighting of parens in the 0th > column: > "The convention speeds up many Emacs operations, which would otherwise > have to scan back to the beginning of the buffer to analyze the syntax > of the code." Note this convention is still active. > and > ;; Try to detect when a string or comment contains something that > ;; looks like a defun and would thus confuse font-lock. > We don't have to scan back to the beginning of the buffer, we can use > syntax-ppss (and it's more reliable with bug#16247 fixed). Sorry, this isn't true. The scanning back to BOB is done at the C level, in function back_comment. syntax-ppss isn't suitable for use here (Stefan's view, not merely mine), because syntax-ppss doesn't react to changes in the syntax table, and suchlike. > font-lock doesn't get confused by something looking like a defun inside > a docstring (try it; I wasn't able to get it highlight something wrong). You might be getting confused, here. The scanning back to BOB which is slow doesn't just happen in font lock; it can (and does) happen anywhere. It's just font lock's job to warn the user about this, so that she can correct it by adding in a backslash, for example. Things do get confused, for example see bug #22884, where there was an open paren in column zero in our own C sources. > M-x beginning-of-defun does get confused, though. If *that* is problem > what we want to detect, ..... Not particularly. We want the user to be warned about things potentially going wrong in back_comment, and anything which calls it. The problem we want to fix is the lack of font-lock-warning-face on these parens in column 0. Anything beyond that is not for Emacs 25.1. > .... I think the patch should look like this: > diff --git a/lisp/font-lock.el b/lisp/font-lock.el > index 8ee9f69..eed2766 100644 > --- a/lisp/font-lock.el > +++ b/lisp/font-lock.el > @@ -1786,13 +1786,10 @@ font-lock-compile-keywords > (cons t (cons keywords > (mapcar #'font-lock-compile-keyword keywords)))) > (if (and (not syntactic-keywords) > - (let ((beg-function syntax-begin-function)) > - (or (eq beg-function 'beginning-of-defun) > - (if (symbolp beg-function) > - (get beg-function 'font-lock-syntax-paren-check)))) > - (not beginning-of-defun-function)) > + (not beginning-of-defun-function) > + open-paren-in-column-0-is-defun-start) No. open-paren-in-column-0-is-defun-start is a variable that the user can change at any time. We can't make our font-locking dependent upon what its value was at some time in the past. If open-paren-... belongs anywhere, it's in the form just beyond the end of your patch's text. Do you understand the consequences of taking out the check on syntax-begin-function? (I certainly don't.) It would be good if Stefan could express a view, here. > ;; Try to detect when a string or comment contains something that > - ;; looks like a defun and would thus confuse font-lock. > + ;; looks like a defun and would thus confuse beginning-of-defun. Also no. It's more general than that. I think "would thus confuse Emacs" would be more accurate. > (nconc keywords > `((,(if defun-prompt-regexp > (concat "^\\(?:" defun-prompt-regexp "\\)?\\s(") -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon May 16 13:43:05 2016 Received: (at submit) by debbugs.gnu.org; 16 May 2016 17:43:05 +0000 Received: from localhost ([127.0.0.1]:54172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2MXp-0007by-JX for submit@debbugs.gnu.org; Mon, 16 May 2016 13:43:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2MXo-0007bT-Bb for submit@debbugs.gnu.org; Mon, 16 May 2016 13:43:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2MXi-00048f-Hn for submit@debbugs.gnu.org; Mon, 16 May 2016 13:42:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2MXi-000483-FK for submit@debbugs.gnu.org; Mon, 16 May 2016 13:42:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2MXg-0004Yc-7r for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 13:42:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2MXc-000475-DB for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 13:42:55 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:51148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2MXc-00046x-2L for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 13:42:52 -0400 Received: from [192.168.178.35] ([77.12.90.221]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0Lmufk-1bVqoV3YLM-00h2k4 for ; Mon, 16 May 2016 16:57:35 +0200 Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. To: bug-gnu-emacs@gnu.org References: <20151110163034.GH2626@acm.fritz.box> <20151112185424.38599.qmail@mail.muc.de> <414b75b8-bb45-4640-4742-9f88b9ff5e75@yandex.ru> <20160516102002.GB2317@acm.fritz.box> <37a9ca07-1ffc-b872-4cf0-719f97177e35@yandex.ru> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <5739E09F.7020009@easy-emacs.de> Date: Mon, 16 May 2016 17:00:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <37a9ca07-1ffc-b872-4cf0-719f97177e35@yandex.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:612XdDr0yX4lnHXVvm4QYl5iL0Z+BXq/rYWpjayyA1JKQDw3KGg FZJj3PYEO1vzMp9YYwPBZ5029jiuhiajhjiA8bUspZBuIQkzFu4/geXqd9mKE2V3HSw4b1d EDMauxl6nIO8OCSc6H4ZI7CD6tP9leabshW4t8QtMWki/wgTKIwcNufbzeHh1kmdNDm21zP N5aF0c+0rFKB43roomzvA== X-UI-Out-Filterresults: notjunk:1;V01:K0:BHzrN1+6sKw=:eq+Zva9bJqfZs7w7A0b40O rXalBDJ454FhIMKBbUJrGjGGeAGnihg/sGFPoEmqw7SL4sMTJHvoRbcYU2xr3uPyKtIF/kLqv pdrrPixwRLIQKp730/7w3x7F9KswLPHGD5g5kj/PXwFCzsfgST5kOusI1vlkSC5l0w9OhPrVX Y9aL92G1p+x61lWRbC7CA9Hn7i6N7+QIu10X36Vnh0rvd5hS89ea0RLsVg+WsTmB4kF0HFMaQ N/7d4J4Ipk6pwaKZJE4ECF6uyVTwQ9LcStRGaprgoXTgkjjR/XPD2ZM0trwjtomB66rtOCGz1 g7+K4XQ0HPJMYRRevFztNCHk/mUEO1Bg/yAZ28mknyIurnWrFvgyMIWJ8cVCvO7nxcjuYdUoB jtZZL5Xn3n8249/zodTm3VDaQTR+Dx9hUCWBtlumu532WRkIYuuyvq3GmxlMWCXSoKqQHwx/+ /75I7FUPdatQn+h98KIXowTI4/jbIsIx8Hqi2o/GoddbAndKZmhbDIb/FzQRRNmAZt7VF+mpM PEtJccSR+LdAHgjERZduztzWMhEl4uPXyYsvqXeQy3e5uKCbVhzC+dyImmZm6EttB5CMzyKTi 20r6pJX8PXPelRI/WyRg+FCriEqgh3BMNXhHj7rNcFNKpcfHLISIhJmGi3nGXgLH/RJ5CJsr1 RXpXN3P/S0BZKAW7nWGZ5zlhU3jRUWFvwwbV95FR89Ya3HV2MJXch61Uw8BB0pSRx8TxTUR0b rVwtMn3+8WNvQyvy X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 16.05.2016 15:18, Dmitry Gutov wrote: > On 05/16/2016 01:20 PM, Alan Mackenzie wrote: > >> No. open-paren-in-column-0-is-defun-start is a variable that the user >> can change at any time. > > I don't think it is, or should be, true. The major mode knows better > whether it can know where a defun starts, or not. > This open-paren-in-column-0-is-defun-start introduces exercises how to jump with crossed legs. There are some astonishing jumpers around, I see. From the state of art of programming it's just a shame. Emacs will always buggy cherishing such crap. From debbugs-submit-bounces@debbugs.gnu.org Tue May 17 05:02:48 2016 Received: (at 21871) by debbugs.gnu.org; 17 May 2016 09:02:48 +0000 Received: from localhost ([127.0.0.1]:54690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2ats-0004iy-2b for submit@debbugs.gnu.org; Tue, 17 May 2016 05:02:48 -0400 Received: from mail.muc.de ([193.149.48.3]:41953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2atq-0004iq-1p for 21871@debbugs.gnu.org; Tue, 17 May 2016 05:02:46 -0400 Received: (qmail 56925 invoked by uid 3782); 17 May 2016 09:02:44 -0000 Received: from acm.muc.de (p548C7AFA.dip0.t-ipconnect.de [84.140.122.250]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 17 May 2016 11:02:43 +0200 Received: (qmail 5271 invoked by uid 1000); 17 May 2016 09:02:42 -0000 Date: Tue, 17 May 2016 09:02:42 +0000 To: Dmitry Gutov Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. Message-ID: <20160517090242.GA2250@acm.fritz.box> References: <20151110163034.GH2626@acm.fritz.box> <20151112185424.38599.qmail@mail.muc.de> <414b75b8-bb45-4640-4742-9f88b9ff5e75@yandex.ru> <20160516102002.GB2317@acm.fritz.box> <37a9ca07-1ffc-b872-4cf0-719f97177e35@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37a9ca07-1ffc-b872-4cf0-719f97177e35@yandex.ru> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Hello, Dmitry. On Mon, May 16, 2016 at 04:18:54PM +0300, Dmitry Gutov wrote: > On 05/16/2016 01:20 PM, Alan Mackenzie wrote: > > Note this convention is still active. > The "convention" may be in place, but the underlying reasons for it are > much weaker these days. The convention is still needed, in particular in CC Mode. We tried to do without it for some time, and got complaints (from Martin Rudalics) about its speed. > Any relevant operation can use syntax-ppss. No, it can't. Anything which uses back_comment can't. That includes scan-lists, backward-list, and so on, which are very widely used, including in beginning-of-defun. Or are you proposing to rewrite vast swathes of Emacs, expunging all (backward) uses of scan-lists, etc.? > >> We don't have to scan back to the beginning of the buffer, we can use > >> syntax-ppss (and it's more reliable with bug#16247 fixed). > > Sorry, this isn't true. The scanning back to BOB is done at the C > > level, in function back_comment. > What I wrote is true: font-lock rules can use syntax-ppss, and often do. Up to a point, you may be right. Any time anybody uses beginning-of-defun, etc., this scanning from BOB may happen. Also, syntax-ppss will deliver the wrong value if font-lock-syntax-table is non-nil and syntax-ppss is also used outside of font-lock. This is (one of) the problems with syntax-ppss - it ploughs on blindly, regardless of changes to the syntax table, text-properties, etc. But it sort of works most of the time. > > syntax-ppss isn't suitable for use > > here (Stefan's view, not merely mine), because syntax-ppss doesn't react > > to changes in the syntax table, and suchlike. > Here where? In back_comment. [ .... ] > > The scanning back to BOB which is slow doesn't just happen in font > > lock; it can (and does) happen anywhere. > Only in certain places, where the programmer didn't think to use the > cache provided by syntax-ppss. This is simply false. See above. > > It's just font lock's job to warn the user about this, so > > that she can correct it by adding in a backslash, for example. > And it's the job of the programmer to avoid this problem altogether, > which is not too hard. This is also false. People have been struggling with the problem for years, if not decades. > > Things do get confused, for example see bug #22884, where there was an > > open paren in column zero in our own C sources. > Even if bug#22884 is somewhat related, it's actually irrelevant is the > current discussion because c-mode uses a non-default > beginning-of-defun-function. Which means font-lock-compile-keywords > won't add highlighting to 0-column parens in c-mode anyway. Sadly true. It ought to, though. I can't see the connection between a major mode determining its own BOD, and whether or not it wants parens in column zero in strings and comments to get warning face. > It seems the current code was designed with only Lisp modes in mind. Not at all. Read the manual. > >> M-x beginning-of-defun does get confused, though. If *that* is problem > >> what we want to detect, ..... > > Not particularly. We want the user to be warned about things > > potentially going wrong in back_comment, and anything which calls it. > I don't see any reason to believe that the original author of this code > was concerned with back_comment specifically. No, with things which call it, including scan-lists, beginning-of-defun, etc. > > No. open-paren-in-column-0-is-defun-start is a variable that the user > > can change at any time. > I don't think it is, or should be, true. The major mode knows better > whether it can know where a defun starts, or not. open-paren-in-... is a customisable option. It is up to the user whether she wants the speed of o-p-i-c-0-i-d-s set at t, or the accuracy of it set at nil. > E.g. js-mode and elisp-byte-code-mode set it to nil. If the user changes > that value in one of these modes, nothing good will happen. Set it to nil or bind it to nil? This may be a misuse of the variable by these modes. > > We can't make our font-locking dependent upon > > what its value was at some time in the past. If open-paren-... belongs > > anywhere, it's in the form just beyond the end of your patch's text. > I don't think so. I don't mind taking its comparison out altogether, but > then the predicate will become very simple. Again, do you understand that comparison, and why all the components of that `and' form are there? > > Do you understand the consequences of taking out the check on > > syntax-begin-function? (I certainly don't.) It would be good if Stefan > > could express a view, here. > Point is, there is no way to simply alter the check that it would accept > the current situation with syntax-begin-function, but still keep it > meaningful. If we accept the value nil (which it is emacs-lisp-mode > now), we should accept any syntax-begin-function, I think. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 12:35:35 2016 Received: (at control) by debbugs.gnu.org; 22 May 2016 16:35:35 +0000 Received: from localhost ([127.0.0.1]:32980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4WLn-00007y-Mu for submit@debbugs.gnu.org; Sun, 22 May 2016 12:35:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4WLm-00007l-46 for control@debbugs.gnu.org; Sun, 22 May 2016 12:35:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4WLc-00083X-6U for control@debbugs.gnu.org; Sun, 22 May 2016 12:35:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4WLc-000824-25 for control@debbugs.gnu.org; Sun, 22 May 2016 12:35:24 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2342 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b4WLa-0003Ob-61 for control@debbugs.gnu.org; Sun, 22 May 2016 12:35:22 -0400 Date: Sun, 22 May 2016 19:35:19 +0300 Message-Id: <8337pa6ofs.fsf@gnu.org> From: Eli Zaretskii To: control@debbugs.gnu.org Subject: Unblock X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) unblock 19759 by 17976 unblock 19759 by 19548 unblock 19759 by 21182 unblock 19759 by 21650 unblock 19759 by 21871 unblock 19759 by 21874 unblock 19759 by 22107 unblock 19759 by 22147 unblock 19759 by 22338 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 14:14:31 2016 Received: (at control) by debbugs.gnu.org; 22 May 2016 18:14:31 +0000 Received: from localhost ([127.0.0.1]:33021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4XtX-00047x-Cu for submit@debbugs.gnu.org; Sun, 22 May 2016 14:14:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4XtW-00047j-GG for control@debbugs.gnu.org; Sun, 22 May 2016 14:14:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4XtQ-0004AM-Fr for control@debbugs.gnu.org; Sun, 22 May 2016 14:14:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4XtQ-00049X-Cu for control@debbugs.gnu.org; Sun, 22 May 2016 14:14:24 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1b4XtP-0006hI-0P for control@debbugs.gnu.org; Sun, 22 May 2016 14:14:23 -0400 Subject: control message for bug 21966 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sun, 22 May 2016 14:14:23 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) block 21966 by 21871 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 10 06:35:44 2016 Received: (at control) by debbugs.gnu.org; 10 Oct 2016 10:35:44 +0000 Received: from localhost ([127.0.0.1]:50517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btXvs-0000dL-4i for submit@debbugs.gnu.org; Mon, 10 Oct 2016 06:35:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btXvq-0000d3-1V for control@debbugs.gnu.org; Mon, 10 Oct 2016 06:35:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btXvf-0002IB-IG for control@debbugs.gnu.org; Mon, 10 Oct 2016 06:35:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btXve-0002Ht-Vm for control@debbugs.gnu.org; Mon, 10 Oct 2016 06:35:31 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3021 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1btXvd-00086O-Bo for control@debbugs.gnu.org; Mon, 10 Oct 2016 06:35:29 -0400 Date: Mon, 10 Oct 2016 13:35:42 +0300 Message-Id: <83oa2sebk1.fsf@gnu.org> From: Eli Zaretskii To: control@debbugs.gnu.org Subject: Re: bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.7 (-------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.7 (-------) unblock 21966 by 23692 block 24655 by 23692 unblock 21966 by 23508 unblock 21966 by 21871 block 24655 by 21871 unblock 21966 by 23534 block 24655 by 23534 unblock 21966 by 24482 block 24655 by 24482 unblock 21966 by 19479 block 24655 by 19479 unblock 21966 by 23827 block 24655 by 23827 unblock 21966 by 22307 block 24655 by 22307 thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 09:19:41 2017 Received: (at 21871) by debbugs.gnu.org; 2 Sep 2017 13:19:42 +0000 Received: from localhost ([127.0.0.1]:41866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do8Kr-0004Vd-Ha for submit@debbugs.gnu.org; Sat, 02 Sep 2017 09:19:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do8Kq-0004VO-Pf for 21871@debbugs.gnu.org; Sat, 02 Sep 2017 09:19:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do8Kg-0007td-Kc for 21871@debbugs.gnu.org; Sat, 02 Sep 2017 09:19:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do8KV-0007hN-Vd; Sat, 02 Sep 2017 09:19:20 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2148 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1do8KU-0007sh-8A; Sat, 02 Sep 2017 09:19:19 -0400 Date: Sat, 02 Sep 2017 16:19:02 +0300 Message-Id: <83fuc5z1a1.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-reply-to: <20160517090242.GA2250@acm.fritz.box> (message from Alan Mackenzie on Tue, 17 May 2016 09:02:42 +0000) Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. References: <20151110163034.GH2626@acm.fritz.box> <20151112185424.38599.qmail@mail.muc.de> <414b75b8-bb45-4640-4742-9f88b9ff5e75@yandex.ru> <20160516102002.GB2317@acm.fritz.box> <37a9ca07-1ffc-b872-4cf0-719f97177e35@yandex.ru> <20160517090242.GA2250@acm.fritz.box> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) unblock 24655 by 21871 thanks > Date: Tue, 17 May 2016 09:02:42 +0000 > From: Alan Mackenzie > Cc: 21871@debbugs.gnu.org > > On Mon, May 16, 2016 at 04:18:54PM +0300, Dmitry Gutov wrote: > > On 05/16/2016 01:20 PM, Alan Mackenzie wrote: > > > > Note this convention is still active. > > > The "convention" may be in place, but the underlying reasons for it are > > much weaker these days. > > The convention is still needed, in particular in CC Mode. We tried to > do without it for some time, and got complaints (from Martin Rudalics) > about its speed. > > > Any relevant operation can use syntax-ppss. > > No, it can't. Anything which uses back_comment can't. That includes > scan-lists, backward-list, and so on, which are very widely used, > including in beginning-of-defun. > > Or are you proposing to rewrite vast swathes of Emacs, expunging all > (backward) uses of scan-lists, etc.? > > > >> We don't have to scan back to the beginning of the buffer, we can use > > >> syntax-ppss (and it's more reliable with bug#16247 fixed). > > > > Sorry, this isn't true. The scanning back to BOB is done at the C > > > level, in function back_comment. > > > What I wrote is true: font-lock rules can use syntax-ppss, and often do. > > Up to a point, you may be right. Any time anybody uses > beginning-of-defun, etc., this scanning from BOB may happen. > > Also, syntax-ppss will deliver the wrong value if font-lock-syntax-table > is non-nil and syntax-ppss is also used outside of font-lock. This is > (one of) the problems with syntax-ppss - it ploughs on blindly, > regardless of changes to the syntax table, text-properties, etc. But it > sort of works most of the time. > > > > syntax-ppss isn't suitable for use > > > here (Stefan's view, not merely mine), because syntax-ppss doesn't react > > > to changes in the syntax table, and suchlike. > > > Here where? > > In back_comment. > > [ .... ] > > > > The scanning back to BOB which is slow doesn't just happen in font > > > lock; it can (and does) happen anywhere. > > > Only in certain places, where the programmer didn't think to use the > > cache provided by syntax-ppss. > > This is simply false. See above. > > > > It's just font lock's job to warn the user about this, so > > > that she can correct it by adding in a backslash, for example. > > > And it's the job of the programmer to avoid this problem altogether, > > which is not too hard. > > This is also false. People have been struggling with the problem for > years, if not decades. > > > > Things do get confused, for example see bug #22884, where there was an > > > open paren in column zero in our own C sources. > > > Even if bug#22884 is somewhat related, it's actually irrelevant is the > > current discussion because c-mode uses a non-default > > beginning-of-defun-function. Which means font-lock-compile-keywords > > won't add highlighting to 0-column parens in c-mode anyway. > > Sadly true. It ought to, though. I can't see the connection between a > major mode determining its own BOD, and whether or not it wants parens > in column zero in strings and comments to get warning face. > > > It seems the current code was designed with only Lisp modes in mind. > > Not at all. Read the manual. > > > >> M-x beginning-of-defun does get confused, though. If *that* is problem > > >> what we want to detect, ..... > > > > Not particularly. We want the user to be warned about things > > > potentially going wrong in back_comment, and anything which calls it. > > > I don't see any reason to believe that the original author of this code > > was concerned with back_comment specifically. > > No, with things which call it, including scan-lists, beginning-of-defun, > etc. > > > > No. open-paren-in-column-0-is-defun-start is a variable that the user > > > can change at any time. > > > I don't think it is, or should be, true. The major mode knows better > > whether it can know where a defun starts, or not. > > open-paren-in-... is a customisable option. It is up to the user > whether she wants the speed of o-p-i-c-0-i-d-s set at t, or the accuracy > of it set at nil. > > > E.g. js-mode and elisp-byte-code-mode set it to nil. If the user changes > > that value in one of these modes, nothing good will happen. > > Set it to nil or bind it to nil? This may be a misuse of the variable > by these modes. More than a year later, it doesn't sound like this is bothering anyone else, and Stefan still didn't chime in to tell what he thinks. So I'm removing the Emacs 26.1 blocking status from this bug. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 11:00:46 2020 Received: (at 21871) by debbugs.gnu.org; 11 Apr 2020 15:00:46 +0000 Received: from localhost ([127.0.0.1]:56961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNHck-0003Qa-6K for submit@debbugs.gnu.org; Sat, 11 Apr 2020 11:00:46 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:39685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNHch-0003QM-BG for 21871@debbugs.gnu.org; Sat, 11 Apr 2020 11:00:44 -0400 Received: by mail-qk1-f182.google.com with SMTP id b62so5064640qkf.6 for <21871@debbugs.gnu.org>; Sat, 11 Apr 2020 08:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6IekO+x+2fA5YSas8Wy2fgO/hSioa5sYmsfDYgWqiDI=; b=bAcjmcMdgYD0SSX4znBUM/F4kvNkgjyGtFQlGRcNJ3jnlZJGfMiXMpNaDg9UBx3gEJ zFi6+8Yw01+Y9b5c3uvfyZAHarfcqfTq9QbxZ0LX2Q/xcHKehT3jFDH6N83CHZfpyWd/ 3g02WpQo/XzRDmtkazpdh52ldH9s6kVCp4US9Tx1e7JbKaTx/TBb7PFtRg7jWB8RcGe7 OJJIG7V31cmtAqSV3heBoB6eHyWV2HdVDii5s8Z0Cdk5lkJ1Pv45hlBLpTArODNKe+Hg vCBAjYH9k4aLECbybJIuOxrMHbTnEkj906P2oBegojGmVe8VPjL8uVU02AogFtADLvnX 8iBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6IekO+x+2fA5YSas8Wy2fgO/hSioa5sYmsfDYgWqiDI=; b=Hzt79IKepjnoN/Tixak/a0W5kaB/qJzpVnqn2OwESTGCVnYQK5Xw8QTY0JRMKRKjxC cIx31PpbSN+iVdGwc7RC+SlmIE1DtCjP8J/jPiXGxI5DrR/w+EpAh0SkM/dkioQYyX+T B7t2YPIp1Q0By2EQY5q1vOkXFsAtGwZpZz+56Fty/DqUmYzSSf5yMhmOpzpIigBCuEoj OZwtKqRiQhwTt3Rv5TMzEM5WDh0s1Q5mJrJLOZ2sEihzuq+153Y1KAsKpo/z6wx+C71Z FYYUKhfzcRb6S0+DOevAvd5IO5TwKrZ8wvdc4800n4XHzdLU5GQbmmBsMSiB+TC3LtWi fJ9w== X-Gm-Message-State: AGi0PubK3QsTEM07bNgheC1elY7ReLwRyuINejxJofB3K9w+i1Q5HEtM 9w2mZpX0BfpMZks5QKeifEjLULhU X-Google-Smtp-Source: APiQypKWTtGdZkyAwj5pN+uBhKmxAEhjjz7WeQQBrvtda3awKvP8NtoPMknc98CmI4Q8USdZQsImJQ== X-Received: by 2002:ae9:e708:: with SMTP id m8mr1894487qka.90.1586617237185; Sat, 11 Apr 2020 08:00:37 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id z6sm3825980qke.56.2020.04.11.08.00.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Apr 2020 08:00:36 -0700 (PDT) From: Noam Postavsky To: Alan Mackenzie Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. References: <20151110163034.GH2626@acm.fritz.box> Date: Sat, 11 Apr 2020 11:00:35 -0400 In-Reply-To: <20151110163034.GH2626@acm.fritz.box> (Alan Mackenzie's message of "Tue, 10 Nov 2015 16:30:34 +0000") Message-ID: <878sj23w4s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Alan Mackenzie writes: > In the Emacs manual page "Left Margin Paren", it says that: > > To help you catch violations of this convention, Font Lock mode > highlights confusing opening delimiters (those that ought to be quoted) > in bold red. > > , where "this convention" is the convention of not putting opening parens > in column 0 when they aren't at the beginning of defuns. > > In Emacs Lisp Mode, this highlighting isn't done. It isn't in CC Mode, > either. The recent thread in emacs-devel[1] reminded me I wrote a (still half-baked) patch for this. [1]: https://lists.gnu.org/r/emacs-devel/2020-04/msg00402.html --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-WIP-Restore-highlighting-of-open-parens-in-column-0-.patch Content-Description: patch >From b3794a2a87c6aafc2174162f72f716a5801668a4 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 5 Aug 2017 12:31:02 -0400 Subject: [PATCH] [WIP] Restore highlighting of open parens in column-0 (Bug#21871) --- lisp/emacs-lisp/lisp-mode.el | 1 + lisp/font-lock.el | 38 ++++++++++++++++++++++++-------------- 2 files changed, 25 insertions(+), 14 deletions(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index 3b0f5493ee..50707fd10a 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -642,6 +642,7 @@ lisp-mode-variables (setq-local imenu-generic-expression lisp-imenu-generic-expression) (setq-local multibyte-syntax-as-symbol t) ;; (setq-local syntax-begin-function 'beginning-of-defun) ;;Bug#16247. + (setq-local font-lock-syntax-paren-check t) ;; Bug#21871. (setq font-lock-defaults `(,(if elisp '(lisp-el-font-lock-keywords lisp-el-font-lock-keywords-1 diff --git a/lisp/font-lock.el b/lisp/font-lock.el index e0955b74ab..565f4b22b4 100644 --- a/lisp/font-lock.el +++ b/lisp/font-lock.el @@ -1779,6 +1779,11 @@ font-lock-fontify-keywords-region ;; Various functions. +(defvar-local font-lock-syntax-paren-check nil + "Major modes should set this to non-nil if they rely on the +`open-paren-in-column-0-is-defun-start' convention for movement +or fontification.") + (defun font-lock-compile-keywords (keywords &optional syntactic-keywords) "Compile KEYWORDS into the form (t KEYWORDS COMPILED...) Here each COMPILED is of the form (MATCHER HIGHLIGHT ...) as shown in the @@ -1798,24 +1803,29 @@ font-lock-compile-keywords (cons t (cons keywords (mapcar #'font-lock-compile-keyword keywords)))) (if (and (not syntactic-keywords) - (let ((beg-function (with-no-warnings syntax-begin-function))) - (or (eq beg-function #'beginning-of-defun) - (if (symbolp beg-function) - (get beg-function 'font-lock-syntax-paren-check)))) - (not beginning-of-defun-function)) + (or (and (let ((beg-function (with-no-warnings syntax-begin-function))) + (or (eq beg-function #'beginning-of-defun) + (if (symbolp beg-function) + (get beg-function 'font-lock-syntax-paren-check)))) + (not beginning-of-defun-function)) + font-lock-syntax-paren-check)) ;; Try to detect when a string or comment contains something that ;; looks like a defun and would thus confuse font-lock. (nconc keywords - `((,(if defun-prompt-regexp - (concat "^\\(?:" defun-prompt-regexp "\\)?\\s(") - "^\\s(") - (0 - (if (memq (get-text-property (match-beginning 0) 'face) - '(font-lock-string-face font-lock-doc-face - font-lock-comment-face)) - (list 'face font-lock-warning-face + `((,(let ((regexp + (if defun-prompt-regexp + (concat "^\\(?:" defun-prompt-regexp "\\)?\\s(") + "^\\s("))) + (lambda (bound) + (if open-paren-in-column-0-is-defun-start + (re-search-forward regexp bound t)))) + (0 + (if (memq (get-text-property (match-beginning 0) 'face) + '(font-lock-string-face font-lock-doc-face + font-lock-comment-face)) + (list 'face font-lock-warning-face 'help-echo "Looks like a toplevel defun: escape the parenthesis")) - prepend))))) + prepend))))) keywords)) (defun font-lock-compile-keyword (keyword) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 18:14:29 2021 Received: (at 21871) by debbugs.gnu.org; 19 Sep 2021 22:14:29 +0000 Received: from localhost ([127.0.0.1]:40190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS54v-0003Cn-Ic for submit@debbugs.gnu.org; Sun, 19 Sep 2021 18:14:29 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:40701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS54q-0003CQ-C8 for 21871@debbugs.gnu.org; Sun, 19 Sep 2021 18:14:28 -0400 Received: by mail-pl1-f173.google.com with SMTP id n18so9773505plp.7 for <21871@debbugs.gnu.org>; Sun, 19 Sep 2021 15:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=in/zX+ykJuhwykREzNhFvpeJZ0vGeSVb8MVMVgyx+Ts=; b=2EkZRQffPVxOdA4vWUNpUlQaSixGs1FNsnbNe7MTW7Tg/FNkpChehqm5Z3cx3gCzUX rauO5avwsi5tin9rf+vXhiTPlXiSkLiLI0kH+EOZ18PjbA27JeTn560gVP6ghLJxl2Wl hkE1eRw4QL7Y1isfRBh4Sx/myuCSkiokirEQeED6B/vZljKiQvhWoY35SMinQ6N2BDTB p/7OrZzM9n7BSL3QD1U5xZs2iAuFX7U0/hkUEqFgRiBIpsAhw7p9XVscgDrBw0ULFS+N 6IjNizZ/VlAqV6nfS0nM7Vt1wWIMx6HcYCfikPvYda8QI5oVkAKXLplQftliqpWGe5cU 2LRA== X-Gm-Message-State: AOAM532h5twIakFiOuj5sWw6REHtAdtZhxuQ3PZ+0YhiSbF5O4qcJGxt HSolgtroy5Aibj20ofJ7lx/GHezsw4NFVPeyUVqJBj/a X-Google-Smtp-Source: ABdhPJwJR4P/Lt+3vQ3THx0G63KUd2WUPysarVDpNGsouIGZTrZ4J9zra+QVBK2Z3cDQPoyArCj4upPOjtNp2ZlNcVE= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr19680804pls.71.1632089658528; Sun, 19 Sep 2021 15:14:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Sep 2021 15:14:18 -0700 From: Stefan Kangas In-Reply-To: <20151110163034.GH2626@acm.fritz.box> (Alan Mackenzie's message of "Tue, 10 Nov 2015 16:30:34 +0000") References: <20151110163034.GH2626@acm.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 19 Sep 2021 15:14:18 -0700 Message-ID: Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. To: Alan Mackenzie Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Alan Mackenzie writes: > Hello, Emacs. > > In the Emacs manual page "Left Margin Paren", it says that: > > To help you catch violations of this convention, Font Lock mode > highlights confusing opening delimiters (those that ought to be quoted) > in bold red. > > , where "this convention" is the convention of not putting opening parens > in column 0 when they aren't at the beginning of defuns. > > In Emacs Lisp Mode, this highlighting isn't done. It isn't in CC Mode, > either. The above text no longer exists, and in Emacs 27.1 or later, we no longer treat an unescaped ( in column zero in a docstring as the beginning of a defun. (See `(elisp) Documentation Tips', final paragraph.) So should this bug be closed, or is there anything more to do here? > This is either a bug in the code, or a bug in the documentation. I > rather tend to the view that this bold red highlighting should be done > when open-paren-in-column-0-is-defun-start is non-nil. I think it did, > at one stage, but searching the emacs-devel archives doesn't reveal what > happened. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 13:50:13 2021 Received: (at 21871) by debbugs.gnu.org; 20 Sep 2021 17:50:13 +0000 Received: from localhost ([127.0.0.1]:43976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSNQi-0006gp-Po for submit@debbugs.gnu.org; Mon, 20 Sep 2021 13:50:12 -0400 Received: from colin.muc.de ([193.149.48.1]:56736 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1mSNQh-0006gQ-4i for 21871@debbugs.gnu.org; Mon, 20 Sep 2021 13:50:12 -0400 Received: (qmail 57184 invoked by uid 3782); 20 Sep 2021 17:50:03 -0000 Received: from acm.muc.de (p4fe15b15.dip0.t-ipconnect.de [79.225.91.21]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 20 Sep 2021 19:50:03 +0200 Received: (qmail 15687 invoked by uid 1000); 20 Sep 2021 17:50:03 -0000 Date: Mon, 20 Sep 2021 17:50:03 +0000 To: Stefan Kangas Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. Message-ID: References: <20151110163034.GH2626@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21871 Cc: 21871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Stefan. On Sun, Sep 19, 2021 at 15:14:18 -0700, Stefan Kangas wrote: > Alan Mackenzie writes: > > Hello, Emacs. > > In the Emacs manual page "Left Margin Paren", it says that: > > To help you catch violations of this convention, Font Lock mode > > highlights confusing opening delimiters (those that ought to be quoted) > > in bold red. > > , where "this convention" is the convention of not putting opening parens > > in column 0 when they aren't at the beginning of defuns. > > In Emacs Lisp Mode, this highlighting isn't done. It isn't in CC Mode, > > either. > The above text no longer exists, and in Emacs 27.1 or later, we no > longer treat an unescaped ( in column zero in a docstring as the > beginning of a defun. (See `(elisp) Documentation Tips', final > paragraph.) > So should this bug be closed, or is there anything more to do here? I would say it should definitely be closed, the fix that has been implemented being far and away better than that anticipated by the bug report. :-) > > This is either a bug in the code, or a bug in the documentation. I > > rather tend to the view that this bold red highlighting should be done > > when open-paren-in-column-0-is-defun-start is non-nil. I think it did, > > at one stage, but searching the emacs-devel archives doesn't reveal what > > happened. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 19:07:12 2021 Received: (at 21871-done) by debbugs.gnu.org; 21 Sep 2021 23:07:13 +0000 Received: from localhost ([127.0.0.1]:48227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSor2-0002N6-Oh for submit@debbugs.gnu.org; Tue, 21 Sep 2021 19:07:12 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:47073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSor0-0002Mo-Rw for 21871-done@debbugs.gnu.org; Tue, 21 Sep 2021 19:07:11 -0400 Received: by mail-pf1-f179.google.com with SMTP id 203so948012pfy.13 for <21871-done@debbugs.gnu.org>; Tue, 21 Sep 2021 16:07:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=umFB2X8Bwo/Ckx5tkv5FAQhtPy5Yzvf3WLewsJIHpfc=; b=oJJ2oDpWX7zi4hl0V6l5T2rU/tJMgIJivCekLK0tTmirnbElUFMuIRYq2pdA1Lz2ub gzg96PFT82ITUAvj8lRyrxtKyZ73eDzrIgJ9HXXFLazPTwH9L16GkodVbt4fvmSB89fQ GW0S2XRuXfFlqAeIEj9K9puRXpCrU2tpCngv7cczIjdtXCPWjWicLj5WdmUscY0hychG j+XbmYtXNJMOeZ+cafUTnDapR1rHjxlUTMAqAY0NALr7QDVXMhLSe27srytirYeGUkxU kJclOSUv7q/INc1XGwGQ0KEiFwaFoSw1tZxfgvDeFuJLsOlz+un+/8Ferf3BQcDDaUGh mUTQ== X-Gm-Message-State: AOAM530i9ly6c+DxCehMhsVRF/GIK4NxBWF0mN74hAHaRcIxsTygazYy mdYGHED33CZxQ0QD4v3uiDe2fl0bkNUUAW2CBzA= X-Google-Smtp-Source: ABdhPJyMsnW/80ohQk71ir1ZNvMlVwwsFo+3oWnJZZnZ12lFSIauLbwLayEwKZHI1T9fTL5jSJiLphBc+q4SkC9Lcsk= X-Received: by 2002:a05:6a00:1586:b0:447:b30c:4a65 with SMTP id u6-20020a056a00158600b00447b30c4a65mr13562068pfk.0.1632265625093; Tue, 21 Sep 2021 16:07:05 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Sep 2021 16:07:04 -0700 From: Stefan Kangas In-Reply-To: References: <20151110163034.GH2626@acm.fritz.box> MIME-Version: 1.0 Date: Tue, 21 Sep 2021 16:07:04 -0700 Message-ID: Subject: Re: bug#21871: Emacs Lisp Mode (at least): spurious parens in column 0 don't get bold red highlighting. To: Alan Mackenzie Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 21871-done Cc: 21871-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Alan Mackenzie writes: > I would say it should definitely be closed, the fix that has been > implemented being far and away better than that anticipated by the bug > report. :-) Excellent! :-) I'm therefore closing this bug report. From unknown Mon Aug 18 11:22:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Oct 2021 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator