GNU bug report logs - #21862
24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6

Previous Next

Full log

Message #72 received at 21862 <at> debbugs.gnu.org (full text, mbox):

From: Anders Lindgren <andlind <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 21862-done <at> debbugs.gnu.org, 21862 <at> debbugs.gnu.org,
 David Caldwell <david <at> porkrind.org>
Subject: Re: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks
 nsterm.m on Mac OS X 10.6)
Date: Sun, 15 Nov 2015 18:57:02 +0100

[Message part 1 (text/plain, inline)]

Hi,

I just pushed the patch on the emacs-25 branch (OK:ed by John). Hopefully,
everything should work properly this time.

    -- Anders

On Sat, Nov 14, 2015 at 9:23 PM, David Reitter <david.reitter <at> gmail.com>
wrote:

> On Nov 14, 2015, at 3:14 PM, Anders Lindgren <andlind <at> gmail.com> wrote:
>
> > David (R), if you think this is a good way to solve this, would you like
> to commit this patch, or would you prefer me to do it?
>
> Yes, defining an extra windowDidBecomeKey function is prettier.
> I think that’s okay to check in to master.
>
> For emacs-25, I think it’s good, too, as it is part of the original
> compile bug fix and reduces the chance of future problems rather than
> increasing it.  I defer to John Wiegley (cc’ed) regarding this.
>
> Anders, I do think that the cleaner way would be to use notifications to
> run these functions, which might reduce extra calls.  However, that
> requires more testing that I was willing to do (on GNUStep too), because
> there’s potential for these methods getting called at a later point in time.
>
> - David

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.