GNU bug report logs - #21862
24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6

Previous Next

Full log

View this message in rfc822 format

From: Anders Lindgren <andlind <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 21862-done <at> debbugs.gnu.org, 21862 <at> debbugs.gnu.org, David Caldwell <david <at> porkrind.org>
Subject: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6)
Date: Sat, 14 Nov 2015 21:14:45 +0100

[Message part 1 (text/plain, inline)]

Hi,

here is another, cleaner, patch to the OS X 10.6.8 build problem. It adds a
non-notification version of windowDidBecomeKey, which
windowDidEnterFullScreen now calls. This mean that 1) all functions now use
the same pattern (the notification version calls the non-notification
version) and 2) there is no need for the locally defined symbol
NSWindowDidEnterFullScreenNotification any more.

David (R), if you think this is a good way to solve this, would you like to
commit this patch, or would you prefer me to do it?

    -- Anders

On Wed, Nov 11, 2015 at 7:56 AM, Anders Lindgren <andlind <at> gmail.com> wrote:

> I don’t think you should unconditionally declare this one:
>>
>> +- (void)windowDidEnterFullScreen:(NSNotification *)notification;
>>
>
>> Only declare it for the 10.6 build, please.
>>
>
> Ah, yes, that seems correct. It is provided from 10.7 onwards.
>
> Alternatively, we can implement a non-notification variant of
> windowDidBecomeKey (it doesn't use the notification anyway), that way we
> can move the code from windowDidEnterFullScreen from the notification
> variant to the non-notification variant, and avoid a lot of the
> notification complexity.
>
>     -- Anders
>
>
>

[Message part 2 (text/html, inline)]

[osx106-2.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.