GNU bug report logs - #21862
24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6

Previous Next

Package: emacs;

Reported by: David Caldwell <david <at> porkrind.org>

Date: Sun, 8 Nov 2015 13:17:02 UTC

Severity: normal

Found in version 24.5

Done: David Reitter <david.reitter <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #42 received at 21862 <at> debbugs.gnu.org (full text, mbox):

From: Anders Lindgren <andlind <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 21862-done <at> debbugs.gnu.org, 21862 <at> debbugs.gnu.org,
 David Caldwell <david <at> porkrind.org>
Subject: Re: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks
 nsterm.m on Mac OS X 10.6)
Date: Wed, 11 Nov 2015 07:56:16 +0100

[Message part 1 (text/plain, inline)]
>
> I don’t think you should unconditionally declare this one:
>
> +- (void)windowDidEnterFullScreen:(NSNotification *)notification;
>

> Only declare it for the 10.6 build, please.
>

Ah, yes, that seems correct. It is provided from 10.7 onwards.

Alternatively, we can implement a non-notification variant of
windowDidBecomeKey (it doesn't use the notification anyway), that way we
can move the code from windowDidEnterFullScreen from the notification
variant to the non-notification variant, and avoid a lot of the
notification complexity.

    -- Anders

[Message part 2 (text/html, inline)]
This bug report was last modified 9 years and 189 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.