GNU bug report logs - #21862
24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6

Previous Next

Full log

View this message in rfc822 format

From: Anders Lindgren <andlind <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 21862-done <at> debbugs.gnu.org, 21862 <at> debbugs.gnu.org, David Caldwell <david <at> porkrind.org>
Subject: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6)
Date: Tue, 10 Nov 2015 22:39:25 +0100

[Message part 1 (text/plain, inline)]

Hi,

Unfortunately, when I compile on my 10.6.8 machine I get the following
warnings:

nsterm.m: In function ‘-[EmacsView windowWillEnterFullScreen:]’:
nsterm.m:6875: warning: ‘EmacsView’ may not respond to
‘-windowWillEnterFullScreen’
nsterm.m:6875: warning: (Messages without a matching method signature
nsterm.m:6875: warning: will be assumed to return ‘id’ and accept
nsterm.m:6875: warning: ‘...’ as arguments.)
nsterm.m: In function ‘-[EmacsView windowDidEnterFullScreen]’:
nsterm.m:6887: warning: passing argument 1 of
‘notificationWithName:object:’ from incompatible pointer type
nsterm.m:6887: warning: ‘EmacsView’ may not respond to
‘-windowDidEnterFullScreen:’
nsterm.m: In function ‘-[EmacsView windowWillExitFullScreen:]’:
nsterm.m:6925: warning: ‘EmacsView’ may not respond to
‘-windowWillExitFullScreen’
nsterm.m: In function ‘-[EmacsView windowDidExitFullScreen:]’:
nsterm.m:6942: warning: ‘EmacsView’ may not respond to ‘-windowDid

The attached patch eliminate them. Basically, it's declarations of the new
(and shadowed) functions and the notification name should be a NSString
(i.e. a @ was missing).

    -- Anders



On Tue, Nov 10, 2015 at 10:02 PM, David Reitter <david.reitter <at> gmail.com>
wrote:

> Hi David (and Anders),
>
> I have checked in some changes that should allow compilation on 10.6.8.
> I do not have a machine to test, so please reopen this bug in case you
> encounter a problem.
>
> - David
>
>
> > On Nov 10, 2015, at 2:37 PM, David Caldwell <david <at> porkrind.org> wrote:
> >
> > Hi David, I'm pulling you in to this bug report since it is about your
> > commit.
> >
> > I tried reverting the commit in question
> > (35cd51814507987b916c4b4e0a7b45e09e454341) and I don't see any warning
> > generated with the latest XCode (Version 7.1.1 (7B1005)). Where were you
> > seeing these warnings?
> >
> > -David
> >
> >
>
>

[Message part 2 (text/html, inline)]

[osx106.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.