GNU bug report logs - #21862
24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: David Reitter <david.reitter <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#21862: closed (24.5; Commit 35cd5181450 breaks nsterm.m on
 Mac OS X 10.6)
Date: Tue, 10 Nov 2015 21:03:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 10 Nov 2015 16:02:02 -0500
with message-id <50B60CF8-CBE3-4DF1-8E44-9C6DD5883C6E <at> gmail.com>
and subject line Re: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6)
has caused the debbugs.gnu.org bug report #21862,
regarding 24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
21862: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21862
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Caldwell <david <at> porkrind.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6
Date: Sun, 8 Nov 2015 05:16:07 -0800

[Message part 3 (text/plain, inline)]

I'm getting this when trying to build on Mac OS X 10.6:

    CC       nsterm.o
  nsterm.m: In function '-[EmacsView toggleFullScreen:]':
  nsterm.m:7058: error: 'NSWindowWillEnterFullScreenNotification'
undeclared (first use in this function)
  nsterm.m:7058: error: (Each undeclared identifier is reported only once
  nsterm.m:7058: error: for each function it appears in.)
  nsterm.m:7066: error: 'NSWindowDidEnterFullScreenNotification'
undeclared (first use in this function)
  nsterm.m:7098: error: 'NSWindowWillExitFullScreenNotification'
undeclared (first use in this function)
  nsterm.m:7104: error: 'NSWindowDidExitFullScreenNotification'
undeclared (first use in this function)
  make[1]: *** [nsterm.o] Error 1
  make: *** [src] Error 2
  make failed


Looks like this commit is the culprit:

  commit 35cd51814507987b916c4b4e0a7b45e09e454341
  Author: David Reitter <david.reitter <at> gmail.com>
  Date:   Sat Nov 7 20:43:29 2015 -0500

      Provide NS notification objects where required to eliminate warnings

      * nsterm.m (windowDidResize:, toggleFullScreen:):
      Call notification functions with notification objects
      as per delegate APIs.


NSWindow.h says:

  APPKIT_EXTERN NSString * const NSWindowWillEnterFullScreenNotification
NS_AVAILABLE_MAC(10_7);
  APPKIT_EXTERN NSString * const NSWindowDidEnterFullScreenNotification
NS_AVAILABLE_MAC(10_7);
  APPKIT_EXTERN NSString * const NSWindowWillExitFullScreenNotification
NS_AVAILABLE_MAC(10_7);
  APPKIT_EXTERN NSString * const NSWindowDidExitFullScreenNotification
NS_AVAILABLE_MAC(10_7);

We could fix this by wrapping NSWindow*FullScreenNotification with
preprocessor guards. On the other hand, that's getting awfully bulky for
creating a bunch of NSNotifications that aren't ever used (follow the
function calls).

Perhaps we can fix the warning a different way?

-David

[smime.p7s (application/pkcs7-signature, attachment)]

[Message part 5 (message/rfc822, inline)]

From: David Reitter <david.reitter <at> gmail.com>
To: 21862 <at> debbugs.gnu.org,
 21862-done <at> debbugs.gnu.org
Cc: Anders Lindgren <andlind <at> gmail.com>, David Caldwell <david <at> porkrind.org>
Subject: Re: bug#21862: Acknowledgement (24.5;
 Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6)
Date: Tue, 10 Nov 2015 16:02:02 -0500

Hi David (and Anders),

I have checked in some changes that should allow compilation on 10.6.8.
I do not have a machine to test, so please reopen this bug in case you encounter a problem.

- David


> On Nov 10, 2015, at 2:37 PM, David Caldwell <david <at> porkrind.org> wrote:
> 
> Hi David, I'm pulling you in to this bug report since it is about your
> commit.
> 
> I tried reverting the commit in question
> (35cd51814507987b916c4b4e0a7b45e09e454341) and I don't see any warning
> generated with the latest XCode (Version 7.1.1 (7B1005)). Where were you
> seeing these warnings?
> 
> -David
> 
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.