GNU bug report logs - #21857
package install should give better feedback

Previous Next

Package: emacs;

Reported by: David Reitter <david.reitter <at> gmail.com>

Date: Sat, 7 Nov 2015 23:43:02 UTC

Severity: wishlist

Tags: easy

Merged with 39163

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #16 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Olson <ryan.olson.x <at> gmail.com>
To: 21857 <at> debbugs.gnu.org
Subject: Re: PATCH to show message after `package-install` installs
 successfully
Date: Fri, 17 Jan 2020 11:04:22 -0700

Switched patch to `diff -u` variant.

--- package.el.orig 2020-01-17 10:11:48.000000000 -0700
+++ package.el 2020-01-17 10:12:36.000000000 -0700
@@ -2076,7 +2076,8 @@
                  (package-compute-transaction () (list (list pkg))))))
         (progn
           (package-download-transaction transaction)
-          (package--quickstart-maybe-refresh))
+          (package--quickstart-maybe-refresh)
+          (message "Package `%s' installed." name))
       (message "`%s' is already installed" name))))

 (defun package-strip-rcs-id (str)

On Fri, Jan 17, 2020 at 10:53 AM Ryan Olson <ryan.olson.x <at> gmail.com> wrote:
>
> When `package-install` function finishes successfully, this patch
> (below) shows the message "Package `package-name` installed."  This
> matches the message that is shown with the function `package-delete`.
> I feel like this solves the primary issue: messaging.  After this
> patch, the user should know that everything was a success.
>
> *** package.el.orig 2020-01-17 10:11:48.000000000 -0700
> --- package.el 2020-01-17 10:12:36.000000000 -0700
> *************** to install it but still mark it as selec
> *** 2076,2082 ****
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)
> --- 2076,2083 ----
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh)
> !           (message "Package `%s' installed." name))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)
This bug report was last modified 4 years and 286 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.