From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 18:30:52 2015 Received: (at submit) by debbugs.gnu.org; 7 Nov 2015 23:30:52 +0000 Received: from localhost ([127.0.0.1]:57144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvCwL-0000ud-QD for submit@debbugs.gnu.org; Sat, 07 Nov 2015 18:30:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58518) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvAZy-0005hu-3w for submit@debbugs.gnu.org; Sat, 07 Nov 2015 15:59:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvAZw-0002JT-D9 for submit@debbugs.gnu.org; Sat, 07 Nov 2015 15:59:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvAZw-0002JP-9i for submit@debbugs.gnu.org; Sat, 07 Nov 2015 15:59:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvAZv-0003Po-6V for bug-parted@gnu.org; Sat, 07 Nov 2015 15:59:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvAZq-0002J5-2u for bug-parted@gnu.org; Sat, 07 Nov 2015 15:59:15 -0500 Received: from timbury.com ([23.239.9.149]:45249 helo=rick.timbury.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvAZp-0002J1-VZ for bug-parted@gnu.org; Sat, 07 Nov 2015 15:59:10 -0500 Received: from localhost (localhost [127.0.0.1]) by rick.timbury.com (Postfix) with ESMTP id 26D7F9F95 for ; Sat, 7 Nov 2015 15:59:09 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at rick.timbury.com Received: from rick.timbury.com ([127.0.0.1]) by localhost (mail.timbury.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NyH5LBnFJj5B for ; Sat, 7 Nov 2015 15:58:52 -0500 (EST) Received: from [192.168.1.22] (pool-173-70-16-58.nwrknj.fios.verizon.net [173.70.16.58]) by rick.timbury.com (Postfix) with ESMTPSA id CBED29F93 for ; Sat, 7 Nov 2015 15:58:52 -0500 (EST) Message-ID: <563E660C.1010302@timbury.com> Date: Sat, 07 Nov 2015 15:58:52 -0500 From: Tim Kissane User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: bug-parted@gnu.org Subject: print bug in probe_filesystem_for_geom Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 07 Nov 2015 18:30:31 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Greetings Parted devs, While attempting to use parted to examine a USB (/dev/sdb), I tripped a bug message. I hope this information proves helpful. My uneducated guess is that the function probe_filesystem_for_geom needs to validate input. Or perhaps I need to learn the right usage. ;) --- (parted) print devices /dev/sda (480GB) /dev/sdb (2012MB) (parted) print sdb Backtrace has 11 calls on stack: 11: /lib/x86_64-linux-gnu/libparted.so.2(ped_assert+0x44) [0x7fc9e17cf644] 10: /lib/x86_64-linux-gnu/libparted.so.2(+0x1f0de) [0x7fc9e17e10de] 9: /lib/x86_64-linux-gnu/libparted.so.2(+0x1f1e7) [0x7fc9e17e11e7] 8: /lib/x86_64-linux-gnu/libparted.so.2(+0x209b8) [0x7fc9e17e29b8] 7: /lib/x86_64-linux-gnu/libparted.so.2(+0x120aa) [0x7fc9e17d40aa] 6: /lib/x86_64-linux-gnu/libparted.so.2(ped_disk_set_flag+0x68) [0x7fc9e17d46c8] 5: parted() [0x406b21] 4: parted(interactive_mode+0xff) [0x40ca2f] 3: parted(main+0x119f) [0x405f6f] 2: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7fc9e0fc6b45] 1: parted() [0x405fc7] You found a bug in GNU Parted! Here's what you have to do: --- Assertion (part->disk->dev->sector_size % PED_SECTOR_SIZE_DEFAULT == 0) at ../../../libparted/labels/dos.c:589 in function probe_filesystem_for_geom() failed. --- root@host:~# parted --version parted (GNU parted) 3.2 Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by . root@host:~# --- root@host:~# parted /dev/sdb unit co print unit s print Model: Kingston DataTraveler 2.0 (scsi) Disk /dev/sdb: 2012MB Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 1049kB 2012MB 2011MB primary ext4 boot Model: Kingston DataTraveler 2.0 (scsi) Disk /dev/sdb: 3930112s Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 2048s 3930111s 3928064s primary ext4 boot root@host:~# --- Regards, Tim Kissane tim@timbury.com From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 18:09:16 2015 Received: (at 21856) by debbugs.gnu.org; 9 Nov 2015 23:09:16 +0000 Received: from localhost ([127.0.0.1]:59563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvvYp-0007Ud-Ab for submit@debbugs.gnu.org; Mon, 09 Nov 2015 18:09:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51603) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvvYm-0007UR-Ns for 21856@debbugs.gnu.org; Mon, 09 Nov 2015 18:09:13 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B8EF88E6EF; Mon, 9 Nov 2015 23:09:11 +0000 (UTC) Received: from lister.brianlane.com (ovpn-113-195.phx2.redhat.com [10.3.113.195]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA9N99WC028144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 9 Nov 2015 18:09:11 -0500 Date: Mon, 9 Nov 2015 15:09:09 -0800 From: "Brian C. Lane" To: Tim Kissane Subject: Re: bug#21856: print bug in probe_filesystem_for_geom Message-ID: <20151109230909.GB28150@lister.brianlane.com> References: <563E660C.1010302@timbury.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <563E660C.1010302@timbury.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 21856 Cc: 21856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) On Sat, Nov 07, 2015 at 03:58:52PM -0500, Tim Kissane wrote: > Greetings Parted devs, > > While attempting to use parted to examine a USB (/dev/sdb), I tripped a bug > message. I hope this information proves helpful. > My uneducated guess is that the function probe_filesystem_for_geom needs to > validate input. Or perhaps I need to learn the right usage. ;) > > --- > (parted) print devices > /dev/sda (480GB) > /dev/sdb (2012MB) > (parted) print sdb > Backtrace has 11 calls on stack: > 11: /lib/x86_64-linux-gnu/libparted.so.2(ped_assert+0x44) [0x7fc9e17cf644] > 10: /lib/x86_64-linux-gnu/libparted.so.2(+0x1f0de) [0x7fc9e17e10de] > 9: /lib/x86_64-linux-gnu/libparted.so.2(+0x1f1e7) [0x7fc9e17e11e7] > 8: /lib/x86_64-linux-gnu/libparted.so.2(+0x209b8) [0x7fc9e17e29b8] > 7: /lib/x86_64-linux-gnu/libparted.so.2(+0x120aa) [0x7fc9e17d40aa] > 6: /lib/x86_64-linux-gnu/libparted.so.2(ped_disk_set_flag+0x68) > [0x7fc9e17d46c8] > 5: parted() [0x406b21] > 4: parted(interactive_mode+0xff) [0x40ca2f] > 3: parted(main+0x119f) [0x405f6f] > 2: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) > [0x7fc9e0fc6b45] > 1: parted() [0x405fc7] > > > You found a bug in GNU Parted! Here's what you have to do: > --- > Assertion (part->disk->dev->sector_size % PED_SECTOR_SIZE_DEFAULT == 0) > at ../../../libparted/labels/dos.c:589 in function > probe_filesystem_for_geom() failed. Well, you aren't supposed to do 'print sdb' but it also shouldn't crash. I couldn't reproduce this with parted-3.2-10.fc22.x86_64 on Fedora. Commit eef3035 might have fixed it, but I'm not sure. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)