From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 05 18:24:12 2015 Received: (at submit) by debbugs.gnu.org; 5 Nov 2015 23:24:12 +0000 Received: from localhost ([127.0.0.1]:55092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZuTt4-0001me-Nr for submit@debbugs.gnu.org; Thu, 05 Nov 2015 18:24:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44608) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZuTjx-0001TS-C8 for submit@debbugs.gnu.org; Thu, 05 Nov 2015 18:15:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuTjv-00070J-Mn for submit@debbugs.gnu.org; Thu, 05 Nov 2015 18:14:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_50, BUG6152_INVALID_DATE_TZ_ABSURD,FREEMAIL_FROM,INVALID_DATE_TZ_ABSURD, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuTjv-00070F-KV for submit@debbugs.gnu.org; Thu, 05 Nov 2015 18:14:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuTju-00079L-7c for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2015 18:14:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuTjq-0006yK-4F for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2015 18:14:42 -0500 Received: from mail-yk0-x236.google.com ([2607:f8b0:4002:c07::236]:34108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuTjp-0006xH-Ns for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2015 18:14:37 -0500 Received: by ykdr3 with SMTP id r3so160087743ykd.1 for ; Thu, 05 Nov 2015 15:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:message-id:mime-version:content-type :content-transfer-encoding; bh=3g1CyR3dwol7/WrX1A6ZkQXkbck11nOtXNWGFx9qmYg=; b=kuA6KQDMCTZAS0NpURjetlTVbaUzhYyRqAKAfbbeogvODmT8wfG+P+r59bVQFGwrVB id23bJusuG1NOikzaW2MRyVQ+tR+BroHmjHiumZ5uHmuP0m5Nb6mWscZMtWfk4TTgdG6 z2MhNpLi05PyWDzEMWpL17jVT5mHrjxFQYwEz+d5Lj0s5LqrdotuF2zjr0Y4uw+mSQWo f2wTo7RYVjrwX2zyZSPus6AY21i2Q9+AJqo6IMTFNEBWkenTjewiMDeqQ6Pya7KkaCPD VJsJlXL9kcPDLQFq32DS8fZCZ3UdXDQXsJBVpD2gbNSlrEVY3+StZaHqQ5drDYABSHkg 5orw== X-Received: by 10.129.70.132 with SMTP id t126mr8514716ywa.164.1446765276910; Thu, 05 Nov 2015 15:14:36 -0800 (PST) Received: from [192.168.1.105] (68-186-214-241.dhcp.thbd.la.charter.com. [68.186.214.241]) by smtp.gmail.com with ESMTPSA id q141sm3351119ywg.22.2015.11.05.15.14.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 05 Nov 2015 15:14:36 -0800 (PST) Date: Thu, 05 Nov 2015 23:08:34 -0006 From: "Paul M. Rodriguez" Subject: 25.0.50; can't use newlines in defaults in cl functions To: bug-gnu-emacs@gnu.org Message-Id: <1446765274.26909.0@smtp.gmail.com> X-Mailer: geary/0.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 05 Nov 2015 18:24:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) Defining a function using the `cl' package with an optional argument whose default contains a newline causes an error with the message "Unrecognized usage format". Example: (require 'cl-lib) (cl-defun example (&optional (separator "\n")) ()) ;; Unrecognized usage format The problem appears to be due to a change to `help-add-fundoc-usage' introduced in this commit: https://lists.gnu.org/archive/html/emacs-diffs/2015-10/msg00365.html Paul Rodriguez. In GNU Emacs 25.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.10.8) of 2015-11-03 Windowing system distributor 'The X.Org Foundation', version=20 11.0.11600000 System Description: Ubuntu 14.04.3 LTS Configured using: 'configure --build=3Dx86_64-linux-gnu --prefix=3D/usr '--includedir=3D${prefix}/include' '--mandir=3D${prefix}/share/man' '--infodir=3D${prefix}/share/info' --sysconfdir=3D/etc --localstatedir=3D/= var '--libdir=3D${prefix}/lib/x86_64-linux-gnu' '--libexecdir=3D${prefix}/lib/x86_64-linux-gnu' --disable-maintainer-mode --disable-dependency-tracking --prefix=3D/usr --sharedstatedir=3D/var/lib --program-suffix=3D-snapshot --with-x=3Dyes --with-x-toolkit=3Dgtk3 'CFLAGS=3D-g -O2 -fstack-protector --param=3Dssp-buffer-size=3D4 -Wformat -Werror=3Dformat-security' CPPFLAGS=3D-D_FORTIFY_SOURCE=3D2 'LDFLAGS=3D-Wl,-Bsymbolic-functions -Wl,-z,relro'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Type C-x 1 to delete the help window. Scanning for dabbrevs...done user-error: No dynamic expansion for =E2=80=98user-mail-add=E2=80=99 found "pmr@ruricolist.com" Quit [4 times] Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-extra dabbrev help-fns help-mode easymenu cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 81136 4848) (symbols 48 19075 0) (miscs 40 48 85) (strings 32 12781 5416) (string-bytes 1 371247) (vectors 16 10746) (vector-slots 8 412657 7275) (floats 8 136 182) (intervals 56 257 16) (buffers 976 12) (heap 1024 32881 1060)) = From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 05 18:39:26 2015 Received: (at control) by debbugs.gnu.org; 5 Nov 2015 23:39:26 +0000 Received: from localhost ([127.0.0.1]:55098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZuU7p-0002BY-SH for submit@debbugs.gnu.org; Thu, 05 Nov 2015 18:39:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50072) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZuU7W-0002Ar-HM for control@debbugs.gnu.org; Thu, 05 Nov 2015 18:39:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuU7V-0005fa-BO for control@debbugs.gnu.org; Thu, 05 Nov 2015 18:39:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuU7V-0005fQ-7l for control@debbugs.gnu.org; Thu, 05 Nov 2015 18:39:05 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ZuU7U-0005b4-V3 for control@debbugs.gnu.org; Thu, 05 Nov 2015 18:39:05 -0500 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 05 Nov 2015 18:39:04 -0500 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 21839 From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 19:55:09 2016 Received: (at 21839-done) by debbugs.gnu.org; 9 May 2016 23:55:09 +0000 Received: from localhost ([127.0.0.1]:44888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azv13-0003TB-9g for submit@debbugs.gnu.org; Mon, 09 May 2016 19:55:09 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azv11-0003Sm-4I for 21839-done@debbugs.gnu.org; Mon, 09 May 2016 19:55:07 -0400 Received: by mail-wm0-f47.google.com with SMTP id a17so212976104wme.0 for <21839-done@debbugs.gnu.org>; Mon, 09 May 2016 16:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=EXQsHwEvd1gGz1S4f3Ah6aprQdzz0GHH8rlivRekNAQ=; b=fPCiciywQv1tsK+s+RrOMwKe8vzo7onEPBi6jWk8ZpXHUZfpWDNVP5/c8Ixnqd8PuG xWZPA4h9JWC77/q8qiP7vERLdoP4BB5F5GmsM64Jn7HmA/JHPWAbvNe29k/yIBztQKym 4F0llVPHYoRhE2GU4kFWQkI2H1mZazx3UhvB40Ga/qGBpmPFAaPexBKW/5SBw+fLkPKM 235Uiuj53Bu3rN16KHs9mJ+JxGT9/5pAszxxse9Io3W2ArpsmEMMex5cro8e2hlL8FSs wgMnkY0mNC9BTJZQa9f2Nd3aFL++su8OOiWGNAYYzBeeLkqVsbGJbMTBhB92RV85ggfK p3Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=EXQsHwEvd1gGz1S4f3Ah6aprQdzz0GHH8rlivRekNAQ=; b=AYt8vyYBJUj5ePye4gA6Cx3MQ0eLqZq8w8LfwzcL4Y8ymGmh4PKwfBHUAzemWqlGyo aTF3VqlTI2pN3gSKkB2CtSBJBQg/FxdaRb+bTNAZAOB2Up5gX+VdMOFn7CVuYdP4KLQ4 sgmse6BvhiSaJSuzK2G2PU7wndFDc1nu9+OETk3L1CL/DDgapmOUUSykmzdJbbbx/GQi uHkloVJcJ/IWjqEd/ICnsdzwVNgnU/+n/64u4ZN301HpTjcqtBLaumKra53VDLMB7iWH AJy+mS/Ccl86Z25c4WAHweIKPSjTf2M96Bq5WqYC5q9bpoS/uxjnKej9BJdPny4ZGv0z TQbw== X-Gm-Message-State: AOPr4FV7G9pyFgIsvM4BzUOv9HqI9XkfV+tCSAo6pU3Ir4FMI1f2LFvHaz5JVlmrrhM/aw== X-Received: by 10.28.229.68 with SMTP id c65mr14323495wmh.77.1462838101261; Mon, 09 May 2016 16:55:01 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id u4sm33701268wjz.4.2016.05.09.16.55.00 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 May 2016 16:55:00 -0700 (PDT) Subject: Re: bug#21839: 25.0.50; can't use newlines in defaults in cl functions To: "Paul M. Rodriguez" , 21839-done@debbugs.gnu.org References: <1446765274.26909.0@smtp.gmail.com> From: Dmitry Gutov Message-ID: <4a7c3366-20cc-107c-bcfb-4231200a4037@yandex.ru> Date: Tue, 10 May 2016 02:54:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 MIME-Version: 1.0 In-Reply-To: <1446765274.26909.0@smtp.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 21839-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Paul, Thanks for the report. I've pushed the attached patch to emacs-25. Not sure it's the best approach (I don't like seeing the unescaped newline in the resulting Help buffer), but it might have to do. Closing. diff --git a/lisp/help.el b/lisp/help.el index 061daac..7289375 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1395,7 +1395,7 @@ help-add-fundoc-usage (if (< (- (match-end 0) (match-beginning 0)) 2) "\n" "") "\n\n") (if (stringp arglist) - (if (string-match "\\`[^ ]+\\(.*\\))\\'" arglist) + (if (string-match "\\`[^ ]+\\(\\(?:.\\|\n\\)*\\))\\'" arglist) (concat "(fn" (match-string 1 arglist) ")") (error "Unrecognized usage format")) (help--make-usage-docstring 'fn arglist))))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 14:04:24 2016 Received: (at control) by debbugs.gnu.org; 2 Jun 2016 18:04:24 +0000 Received: from localhost ([127.0.0.1]:52004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Wym-0005R9-JQ for submit@debbugs.gnu.org; Thu, 02 Jun 2016 14:04:24 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Wyl-0005Qx-0b for control@debbugs.gnu.org; Thu, 02 Jun 2016 14:04:23 -0400 Received: by mail-oi0-f50.google.com with SMTP id e72so89953141oib.1 for ; Thu, 02 Jun 2016 11:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to; bh=bnZ4GLt0Bf83Yx38srxDVZ7vPzcinu3MJwBpwUN4WuQ=; b=ytfq0RTqQlo88rMfOAJ/5T8EQicpDWqyyeCOrkOPZOGp3yCYPwUzcbRqgq36GMX+wz o+Hfo9KDkKw/gZ1D08JGCVI7lNTU8AiNxkKWqqnBvMwFq+ljEIlaqw438LKJjZN5U/9q ldHn7cPum2+Jgc8wYrr2cLbM1rxrGWWGt6x+g3JKLRQ8GDnixI7atPgDRtRUOGYoVpFn S98DcgpKSrLXyrlJWVF/LT+wOjdxXT78LRKkAib8fqUOh8kB55H0ITyey3TWVkUYva73 BH5CMHIIWS0YRopCjE2a3QkVauI5S7zzAUxCUY2+W07pJ4BZdXzD8Bczt4yW8bpHZ54l ZlQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to; bh=bnZ4GLt0Bf83Yx38srxDVZ7vPzcinu3MJwBpwUN4WuQ=; b=SJEwpuG2HgEIKs+/or6ecVUKKjbThg66fd+pNHQWZwwBBJZqshA8rV1QCV7XAb3riw 9pidFKjjI60oib00xBDwr8oUklaStN4WZdNv9Kv5nDR9oaGWR3V3jFXoCAxN9sXHv5b0 a4awB2EOqZZjZi/TdUIFfSYin0xhr/KewCknr6F7rszkz8N3ESnxB90SDQ5QF7rToMkG B+lJGS6ys/6VFYGz6YFJ+2mbpfPzF1kXwuukkET7GaoTvqaE63norqMLqyCEcMe4coSW 3y7RGCuECk9yuHJjRU6vNrePz+SZDbnAsY2t+UVKPrngJ0T/mE0AldJUY5XqLMc71f+d w28w== X-Gm-Message-State: ALyK8tKvNfwCvvCXuuK23MNEehaSrhNPfcSbiS4UfDbjVQGZjQrjur5PR06/0ABVh62kHLQIG0g0SgndXv4BAQ== MIME-Version: 1.0 X-Received: by 10.202.168.131 with SMTP id r125mr1973962oie.40.1464890657282; Thu, 02 Jun 2016 11:04:17 -0700 (PDT) Received: by 10.157.34.169 with HTTP; Thu, 2 Jun 2016 11:04:17 -0700 (PDT) Date: Thu, 2 Jun 2016 14:04:17 -0400 X-Google-Sender-Auth: DIbznSTbLj823hPbnjxK9_Eyc-w Message-ID: Subject: Re: bug#18039: 24.3; Broken docstring in cl-style functions From: Noam Postavsky To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) found 18039 24.5 fixed 18034 25.0.94 close 18039 merge 18039 21839 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 26 01:40:37 2016 Received: (at control) by debbugs.gnu.org; 26 Jun 2016 05:40:37 +0000 Received: from localhost ([127.0.0.1]:55977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o8-00079t-Tg for submit@debbugs.gnu.org; Sun, 26 Jun 2016 01:40:37 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o7-00079c-V1; Sun, 26 Jun 2016 01:40:36 -0400 Received: by mail-oi0-f46.google.com with SMTP id u201so164112318oie.0; Sat, 25 Jun 2016 22:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=pGWklxGOerB4sjJ+cHyNnckUqHc3XoT1MSAP4gEtDpkagGKqwzRjfHkbtS+NaO21Sn HPl8Dmiedt1/EN2lnS4fEVdZDXaDJEB7WXnA9/zgW67YvgYQ9/z3m4j6b31+VasTcTLX rzPI0qVBQL8b/kqGZDkAwVVQibe57XvYRx7lFfMAd0cJ6KFoYkDKeNkBTymxFdlOGgVF 6GsaOEBVQneeiuGx9+zuUl7ruvbmkPPov/Hg5r4ovcueXDC03FpyqEalXjgjvMsSIom9 4q7BGQR5ZGCDWiuB2uAGy42QJPFMQdo883mnVhaVqHmNyuRyRTCzyINDu3I4fPVhiNyz tLaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=bx3bmbsBkmwsYg5U5RnIH3ja6FVQvicuE8ClhNmvP24CDuXfyg0LY/Jv1illmKfzH3 R0ivFlCSiBc53nyS+llgMvWKI+Iaq/O+2DAD9Qbk5ycKnzm49o1uxT5Pv/oQWfMKRJUF BUONANapIgEqvP5a1biLzuu+gt0zDUOEivnJMptwEYL7kPgqb/0F3pBL7JePz/7F2PH4 ONbdezuLoXFXGX/hQNihRPpNK5AoFkZWKSmjRK8hyRS6pig/h4NlrmEd5oARiHPY8DQw s2bmwThdmSExmBqm6/iXttBWV+mc77nyndTw6NhTszBbVrDgLRapZ9PoNYVRIA+3ZJF5 HXZA== X-Gm-Message-State: ALyK8tI3CundH5wGIhtXwNjUfx0oVn1SsgUQh66oAoRYkZegFhUMUOKZbyzDF96OS0JinUiyCJWBHswtQd1UMA== X-Received: by 10.202.207.16 with SMTP id f16mr6491125oig.178.1466919630353; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) From: Noam Postavsky Date: Sun, 26 Jun 2016 01:40:30 -0400 X-Google-Sender-Auth: RyP4tpJGeObNUm2OdclUvMp-jec Message-ID: Subject: Bug #18034: toggle-read-only used in the code To: GNU bug tracker automated control server , 18034-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) # I accidentally marked 18034 fixed due to typo but I meant 18039 fixed 18039 25.0.94 quit However, this bug is fixed as well. I ran the find+gawk expression against emacs-25 sources, only 3 occurences left, and they are acceptable uses kept for backwards compat reasons. I've added context to each hit: ~/src/emacs$ find emacs-25/lisp/ -type f -name \*.el -exec gawk 'FILENAME ~ /\/ { print FILENAME ":" FNR ":\t" $0; }' {} + ;; toggle-read-only is obsolete since 24.3, but since vc-t-r-o was made ;; obsolete earlier, it is ok for the latter to be an alias to the former, ;; since the latter will be removed first. We can't just make it ;; an alias for read-only-mode, since that is not 100% the same. emacs-25/lisp/vc/vc-hooks.el:573: (defalias 'vc-toggle-read-only 'toggle-read-only) (substitute-key-definition 'read-only-mode 'hide-ifdef-toggle-outside-read-only map) ;; `toggle-read-only' is obsoleted by `read-only-mode'. (substitute-key-definition emacs-25/lisp/progmodes/hideif.el:195: 'toggle-read-only 'hide-ifdef-toggle-outside-read-only map) (define-key map [remap read-only-mode] 'dired-toggle-read-only) ;; `toggle-read-only' is an obsolete alias for `read-only-mode' emacs-25/lisp/dired.el:1561: (define-key map [remap toggle-read-only] 'dired-toggle-read-only) From unknown Sun Jun 22 11:35:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 Jul 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator