GNU bug report logs - #21833
24.4; desktop-kill, which is interactive, is in kill-emacs-hook

Previous Next

Package: emacs;

Reported by: Michael Arntzenius <daekharel <at> gmail.com>

Date: Wed, 4 Nov 2015 23:09:02 UTC

Severity: minor

Merged with 28943

Found in versions 24.4, 25.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 21833 <at> debbugs.gnu.org (full text, mbox):

From: Stelian Iancu <si <at> siancu.net>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 21833 <at> debbugs.gnu.org
Subject: Re: bug#21833: 24.4; desktop-kill, which is interactive, is in
 kill-emacs-hook
Date: Thu, 12 Nov 2015 21:24:36 +0100

On 12/11/15 21:11, Glenn Morris wrote:
>
> The point is that kill-emacs-hook is not supposed to contain interactive
> things.
>

Thanks for the clarification.

I've had a look at the code and desktop-kill is added to the 
kill-emacs-hook in desktop.el:

(unless noninteractive
(add-hook 'kill-emacs-hook 'desktop-kill))

So I guess the fix would be to remove these two lines, right?

Thanks,
Stelian
This bug report was last modified 4 years and 9 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.