GNU bug report logs - #21830
Useless messages from comint-previous-matching-input

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21830 in the body.
You can then email your comments to 21830 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jay Adams <jka <at> google.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Useless messages from comint-previous-matching-input
Date: Wed, 4 Nov 2015 09:50:03 -0800

[Message part 1 (text/plain, inline)]

Can we please delete this line:

      (message "History item: %d" (1+ pos))

form comint-previous-matching-input in comint.el?  It provides no value and
makes searching the history very slow, at least on a Mac, when a large part
of the history has to be searched.

Basically, with these messages in place, one of two things happens:

1. They go by so fast as to be unnoticeable (this happens on my Ubuntu
desktop).
2. They go by slowly and make the search excruciatingly slow (this happens
on my Mac).

[Message part 2 (text/html, inline)]

Message #8 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: "John Wiegley" <jwiegley <at> gmail.com>
To: Jay Adams <jka <at> google.com>
Cc: 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Wed, 04 Nov 2015 13:04:06 -0500

>>>>> Jay Adams <jka <at> google.com> writes:

> Can we please delete this line:
> (message "History item: %d" (1+ pos))

Since there's no way to make use of that information, I wouldn't mind seeing
it removed.

Would you be willing to submit a patch?

John

Message #11 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: John Wiegley <jwiegley <at> gmail.com>
Cc: jka <at> google.com, 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Wed, 04 Nov 2015 20:13:11 +0200

> From: "John Wiegley" <jwiegley <at> gmail.com>
> Date: Wed, 04 Nov 2015 13:04:06 -0500
> Cc: 21830 <at> debbugs.gnu.org
> 
> >>>>> Jay Adams <jka <at> google.com> writes:
> 
> > Can we please delete this line:
> > (message "History item: %d" (1+ pos))
> 
> Since there's no way to make use of that information, I wouldn't mind seeing
> it removed.

It was there since 1993.

Message #14 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: "John Wiegley" <jwiegley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jka <at> google.com, 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Wed, 04 Nov 2015 13:24:57 -0500

>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:

>> Since there's no way to make use of that information, I wouldn't mind seeing
>> it removed.

> It was there since 1993.

Well, hard to argue against that too. I can't say I feel any real passion for
this issue, as there may be some who like the feedback they see upon pressing
the key.

I guess what I'd like to know more, then, is why it's so slow on the
reporter's Mac machine?

John

Message #17 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: John Wiegley <jwiegley <at> gmail.com>
Cc: jka <at> google.com, 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Wed, 04 Nov 2015 22:42:57 +0200

> From: "John Wiegley" <jwiegley <at> gmail.com>
> Cc: jka <at> google.com,  21830 <at> debbugs.gnu.org
> Date: Wed, 04 Nov 2015 13:24:57 -0500
> 
> >>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Since there's no way to make use of that information, I wouldn't mind seeing
> >> it removed.
> 
> > It was there since 1993.
> 
> Well, hard to argue against that too. I can't say I feel any real passion for
> this issue, as there may be some who like the feedback they see upon pressing
> the key.

How about a defcustom to turn that off?

Message #20 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: "John Wiegley" <jwiegley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jka <at> google.com, 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Wed, 04 Nov 2015 16:26:57 -0500

>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:

>> > It was there since 1993.
>> 
>> Well, hard to argue against that too. I can't say I feel any real passion for
>> this issue, as there may be some who like the feedback they see upon pressing
>> the key.

> How about a defcustom to turn that off?

Well, that was silly of me. Of course a defcustom is the right answer to this
query.

John

Message #23 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: Jay Adams <jka <at> google.com>
Cc: 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Thu, 05 Nov 2015 03:11:02 +0100

On Wed, Nov 04 2015, Jay Adams wrote:

> 1. They go by so fast as to be unnoticeable (this happens on my Ubuntu
> desktop).
> 2. They go by slowly and make the search excruciatingly slow (this happens
> on my Mac).

I guess the message is meant to remain visible until you use the
minibuffer (again) or some other message pops up from somewhere.

At least, this is what happens for me when I call
comint-previous-matching-input-from-input or
comint-previous-matching-input repeatedly (via some key binding).

Can you reproduce your problem with emacs -Q?

Message #26 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: Jay Adams <jka <at> google.com>
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Wed, 4 Nov 2015 19:49:49 -0800

[Message part 1 (text/plain, inline)]

Thanks to all who replied.

It looks like this is fixed in 24.5 (I was running 24.3).  That message
call now appears inside of (let ((message-log-max nil)) ...).

I verified that this fixes the problem on the Mac.


On Wed, Nov 4, 2015 at 6:11 PM, Wolfgang Jenkner <wjenkner <at> inode.at> wrote:

> On Wed, Nov 04 2015, Jay Adams wrote:
>
> > 1. They go by so fast as to be unnoticeable (this happens on my Ubuntu
> > desktop).
> > 2. They go by slowly and make the search excruciatingly slow (this
> happens
> > on my Mac).
>
> I guess the message is meant to remain visible until you use the
> minibuffer (again) or some other message pops up from somewhere.
>
> At least, this is what happens for me when I call
> comint-previous-matching-input-from-input or
> comint-previous-matching-input repeatedly (via some key binding).
>
> Can you reproduce your problem with emacs -Q?
>

[Message part 2 (text/html, inline)]

Message #29 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: "John Wiegley" <jwiegley <at> gmail.com>
To: Jay Adams <jka <at> google.com>
Cc: Wolfgang Jenkner <wjenkner <at> inode.at>, 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Thu, 05 Nov 2015 00:14:42 -0500

>>>>> Jay Adams <jka <at> google.com> writes:

> It looks like this is fixed in 24.5 (I was running 24.3). That message call
> now appears inside of (let ((message-log-max nil)) ...).

> I verified that this fixes the problem on the Mac.

Does this mean you don't need a customization variable to disable the message
anymore?

John

Message #32 received at 21830 <at> debbugs.gnu.org (full text, mbox):

From: Jay Adams <jka <at> google.com>
To: John Wiegley <jwiegley <at> gmail.com>
Cc: Wolfgang Jenkner <wjenkner <at> inode.at>, 21830 <at> debbugs.gnu.org
Subject: Re: bug#21830: Useless messages from comint-previous-matching-input
Date: Wed, 4 Nov 2015 21:35:11 -0800

[Message part 1 (text/plain, inline)]

Yes. No customization variable.
On Nov 4, 2015 9:15 PM, "John Wiegley" <jwiegley <at> gmail.com> wrote:

> >>>>> Jay Adams <jka <at> google.com> writes:
>
> > It looks like this is fixed in 24.5 (I was running 24.3). That message
> call
> > now appears inside of (let ((message-log-max nil)) ...).
>
> > I verified that this fixes the problem on the Mac.
>
> Does this mean you don't need a customization variable to disable the
> message
> anymore?
>
> John
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.