GNU bug report logs - #21804
25.0.50; file-notify-tests failure on Cygwin

Previous Next

Package: emacs;

Reported by: Ken Brown <kbrown <at> cornell.edu>

Date: Sun, 1 Nov 2015 15:52:02 UTC

Severity: normal

Found in version 25.0.50

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 21804 <at> debbugs.gnu.org, Ken Brown <kbrown <at> cornell.edu>
Subject: bug#21804: 25.0.50; file-notify-tests failure on Cygwin
Date: Fri, 30 Dec 2016 20:07:05 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> -         (string-equal (file-notify--test-monitor) "GPollFileMonitor"))
>> +          (or (string-equal (file-notify--test-monitor) "GPollFileMonitor")
>> +              (string-equal (file-notify--test-monitor) "GFamFileMonitor")))
>
> Wouldn't it be better if gfile-monitor-name returned a symbol instead
> of a string?  That's our general convention with functions, I think.

I've changed it accordingly.

Best regards, Michael.
This bug report was last modified 8 years and 201 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.