From gbrunick@math.utexas.edu Mon Feb 2 23:31:53 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Feb 2009 07:31:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n137Vo3v024166 for ; Mon, 2 Feb 2009 23:31:52 -0800 Received: from mx10.gnu.org ([199.232.76.166]:48858) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LUFjP-0005K7-Ho for emacs-pretest-bug@gnu.org; Tue, 03 Feb 2009 02:30:03 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LUFl4-0002yJ-Gf for emacs-pretest-bug@gnu.org; Tue, 03 Feb 2009 02:31:47 -0500 Received: from dell3.ma.utexas.edu ([146.6.139.124]:41626 helo=ibm3.ma.utexas.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUFl4-0002y3-0i for emacs-pretest-bug@gnu.org; Tue, 03 Feb 2009 02:31:46 -0500 Received: from [192.168.1.149] (rrcs-71-42-216-171.sw.biz.rr.com [71.42.216.171]) (authenticated bits=0) by ibm3.ma.utexas.edu (8.13.6/8.13.6/Debian-1) with ESMTP id n137VcWO017409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 3 Feb 2009 01:31:39 -0600 Message-ID: <4987F2D6.2010900@math.utexas.edu> Date: Tue, 03 Feb 2009 01:31:34 -0600 From: Gerard Brunick User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: emacs-pretest-bug@gnu.org Subject: 23.0.60; define-key vs define-key-after key syntax Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) This may or may not be a bug, but it caused me some pain, so I am pointing it out. (define-key my-map [(control l)] 'do-something) works as expected, but (define-key-after my-map [(control l)] 'do-something) does not. The reason is that define-key does a lot of work to allow for a wide range of key syntaxes, but define-key-after just does: (setq key (if (<= (length key) 1) (aref key 0) ... and (control l) must get mapped to ?\C-l = 12 to be useful in a keymap. As I say, I'm not sure this is a bug, but it was rather counter-intuitive to me, so maybe a warning to this effect in the documentation for define-key-after would be sufficient. The current documentation says "... This is like `define-key' except that the binding for KEY is placed just after the binding for the event AFTER ..." Cheers, Gerard From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 17:31:58 2011 Received: (at 2179) by debbugs.gnu.org; 11 Sep 2011 21:31:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rd7-0004bS-L3 for submit@debbugs.gnu.org; Sun, 11 Sep 2011 17:31:57 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rd0-0004an-Q7 for 2179@debbugs.gnu.org; Sun, 11 Sep 2011 17:31:53 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R2rYk-0001CP-Ie; Sun, 11 Sep 2011 23:27:26 +0200 From: Lars Magne Ingebrigtsen To: Gerard Brunick Subject: Re: 23.0.60; define-key vs define-key-after key syntax In-Reply-To: <4987F2D6.2010900@math.utexas.edu> (Gerard Brunick's message of "Tue, 03 Feb 2009 01:31:34 -0600") Date: Sun, 11 Sep 2011 23:18:20 +0200 Message-ID: References: <4987F2D6.2010900@math.utexas.edu> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Scout Niblett's _This Fool Can Die Now_: "Dinosaur Egg" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1R2rYk-0001CP-Ie X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1316381246.88778@KgIK6SYX9c6axPsL/rhfzw X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Gerard Brunick writes: > (define-key my-map [(control l)] 'do-something) > > works as expected, but > > (define-key-after my-map [(control l)] 'do-something) > > does not. The reason is that define-key does a lot of work to allow > for a wide range of key syntaxes, but define-key-after just does: > > (setq key > (if (<= (length key) 1) (aref key 0) ... > > and (control l) must get mapped to ?\C-l = 12 to be useful in a keymap. Yes, you'd expect both key's to allow the same syntax. However, as far as I can see, all the magic to translate from the `define-key' key syntax is inside that C function, so that would have to be refactored out first. I think. `define-key-after' should at least document the restricted key syntax it allows... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 17:53:15 2011 Received: (at 2179) by debbugs.gnu.org; 11 Sep 2011 21:53:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rxj-0005tQ-Ei for submit@debbugs.gnu.org; Sun, 11 Sep 2011 17:53:15 -0400 Received: from mail-out.m-online.net ([212.18.0.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rxh-0005tJ-Sy for 2179@debbugs.gnu.org; Sun, 11 Sep 2011 17:53:14 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id B5211188A18C; Sun, 11 Sep 2011 23:48:53 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id E36661C00181; Sun, 11 Sep 2011 23:48:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id VWbFSksRJM1v; Sun, 11 Sep 2011 23:48:50 +0200 (CEST) Received: from igel.home (ppp-88-217-122-177.dynamic.mnet-online.de [88.217.122.177]) by mail.mnet-online.de (Postfix) with ESMTP; Sun, 11 Sep 2011 23:48:50 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id B2CB8CA296; Sun, 11 Sep 2011 23:48:49 +0200 (CEST) From: Andreas Schwab To: Lars Magne Ingebrigtsen Subject: Re: bug#2179: 23.0.60; define-key vs define-key-after key syntax References: <4987F2D6.2010900@math.utexas.edu> X-Yow: FUN is never having to say you're SUSHI!! Date: Sun, 11 Sep 2011 23:48:49 +0200 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 11 Sep 2011 23:18:20 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org, Gerard Brunick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Lars Magne Ingebrigtsen writes: > Gerard Brunick writes: > >> (define-key my-map [(control l)] 'do-something) >> >> works as expected, but >> >> (define-key-after my-map [(control l)] 'do-something) >> >> does not. The reason is that define-key does a lot of work to allow >> for a wide range of key syntaxes, but define-key-after just does: >> >> (setq key >> (if (<= (length key) 1) (aref key 0) ... >> >> and (control l) must get mapped to ?\C-l = 12 to be useful in a keymap. > > Yes, you'd expect both key's to allow the same syntax. However, as far > as I can see, all the magic to translate from the `define-key' key > syntax is inside that C function, so that would have to be refactored > out first. I think. Since define-key-after is only useful for menu-bar bindings which don't use characters in keys this doesn't look like a serious restriction. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 18:30:15 2011 Received: (at 2179) by debbugs.gnu.org; 11 Sep 2011 22:30:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2sXW-00005I-VJ for submit@debbugs.gnu.org; Sun, 11 Sep 2011 18:30:15 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2sXU-0008UD-SB for 2179@debbugs.gnu.org; Sun, 11 Sep 2011 18:30:13 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R2sTE-0002lK-8z; Mon, 12 Sep 2011 00:25:48 +0200 From: Lars Magne Ingebrigtsen To: Andreas Schwab Subject: Re: bug#2179: 23.0.60; define-key vs define-key-after key syntax In-Reply-To: (Andreas Schwab's message of "Sun, 11 Sep 2011 23:48:49 +0200") Date: Mon, 12 Sep 2011 00:22:43 +0200 Message-ID: References: <4987F2D6.2010900@math.utexas.edu> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUSDxQMCQ4JBwsPDRIN CxA6NzsFAwaWwLMAAAACd0lEQVQ4jX1UTZfaMAx0682eUXDvG+/C2TyZnnEt7iagnHfTxv//J1QK BOileQ8CGY9m9BVj/nMFG/RGFHYYEDEsgMX5tkPKlAAoLwDGYISEFCmD90C4AFdyjESp3XrvbsEs Rj1ig40AwuhyWCToIA4QiSAlaFt3Q4hcbriEBqAcuKRuba+EmAA5s+GL4yPzBTLi1VPbHUpmy4X4 eEmU3NUWkvfHCzWWWYBzzgkozATn/eoEe8v7i4Y6AeQrAK1fnaEhPhQ+FvOtkwwFQbE+kkSJ8hGN TAAOxRcJYQRWZdrzD2YGWKutBH5b/Yp3wHA4i0YRcRWRGvixet960PJhjI6S2oJ29LXWN1/96KVW 4CSPJJTU6vOJh1rq+P1D7PoOtFpuBriWketXv2Hupe4qotq1DvVYuf8cNnWsW2kIKTDOwFQLT8NG T40fURkzRYFTw4OEeq1iQtoOnb8x+kmBIsdG1UheGX3lcag8TBpKYt1DMQ9fQ22Gyf5SQO1KkwX4 /VNPTttJNeoo1RJGO9OXSz2OnVMA/gH08p2LGsr7t2F4/exZkqtzIl0iYUi1NtxzM5QNN5KLMEBD 5Z1rV03hP73ZNPsT93OobJIOeHLuXXrS+fed9OcKOFrHiALKaLZ+LY2SlMGRkbGzGF5ebOpcCwed ehAGyTAbDHsuLOFNEa1iLHQpGdQFkJkux7MMQlMa5cicm2V7uDGNfM2ArNYCoK7PsjCydZHuDIu4 /JTNeCyoCTJQ9z+Yo3ks9dMpod8B+wxEpAXAkOMDMOLK3lY95qd3hdnNesGamCk/XEnutAgnWqO1 9vo+kMTT/Dyjjnmr/cEo7wBdjb+7Z8RTgkkfQAAAAABJRU5ErkJggg== X-Now-Playing: Matthew Herbert's _One One_: "Milan" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1R2sTE-0002lK-8z X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1316384748.41518@f9nuWuvyG1KGOSL3e41QqQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org, Gerard Brunick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Andreas Schwab writes: > Since define-key-after is only useful for menu-bar bindings which don't > use characters in keys this doesn't look like a serious restriction. The doc string of `define-key-after' doesn't say that it's only for menu-bar bindings. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 03:53:20 2011 Received: (at 2179) by debbugs.gnu.org; 12 Sep 2011 07:53:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R31KS-0008L2-6z for submit@debbugs.gnu.org; Mon, 12 Sep 2011 03:53:20 -0400 Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R31KO-0008Kt-T2 for 2179@debbugs.gnu.org; Mon, 12 Sep 2011 03:53:18 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 86C3A1C01F11; Mon, 12 Sep 2011 09:48:55 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 4F6121C001E3; Mon, 12 Sep 2011 09:48:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id h43aq+dSvj2m; Mon, 12 Sep 2011 09:48:51 +0200 (CEST) Received: from hase.home (ppp-88-217-102-104.dynamic.mnet-online.de [88.217.102.104]) by mail.mnet-online.de (Postfix) with ESMTP; Mon, 12 Sep 2011 09:48:51 +0200 (CEST) From: Andreas Schwab To: Lars Magne Ingebrigtsen Subject: Re: bug#2179: 23.0.60; define-key vs define-key-after key syntax References: <4987F2D6.2010900@math.utexas.edu> X-Yow: There's enough money here to buy 5000 cans of Noodle-Roni! Date: Mon, 12 Sep 2011 09:48:50 +0200 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 12 Sep 2011 00:22:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org, Gerard Brunick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Lars Magne Ingebrigtsen writes: > Andreas Schwab writes: > >> Since define-key-after is only useful for menu-bar bindings which don't >> use characters in keys this doesn't look like a serious restriction. > > The doc string of `define-key-after' doesn't say that it's only for > menu-bar bindings. define-key-after is a compiled Lisp function in `subr.el'. [...] The order of bindings in a keymap matters when it is used as a menu. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 04:07:14 2011 Received: (at 2179) by debbugs.gnu.org; 12 Sep 2011 08:07:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R31Xt-00010U-Lp for submit@debbugs.gnu.org; Mon, 12 Sep 2011 04:07:14 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R31Xq-00010D-5M for 2179@debbugs.gnu.org; Mon, 12 Sep 2011 04:07:11 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R31TD-00033v-Fj; Mon, 12 Sep 2011 10:02:23 +0200 From: Lars Magne Ingebrigtsen To: Andreas Schwab Subject: Re: bug#2179: 23.0.60; define-key vs define-key-after key syntax In-Reply-To: (Andreas Schwab's message of "Mon, 12 Sep 2011 09:48:50 +0200") Date: Mon, 12 Sep 2011 09:59:10 +0200 Message-ID: References: <4987F2D6.2010900@math.utexas.edu> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAIVBMVEXy6RPl2Q///wdgThr+ +wz79RL+/g7//wj//wvYxhb//wy2CYfNAAACb0lEQVQ4jVWUv4/aMBTHn+8uoHSKK7jWG1icIsYq E1vhqHphIvRS0U50AKlMV+skZ2ynppkSUVp56w1Flf/KPuc3T0hI/ujr79fPzwFfUUoZZZn5k1Ec a33a7XZb8GccywVrzvmXOE601rscjA0YMaZUKhHopALDNwimlCqlfge5oAJ8zgOl8KfUuYLzZaYo QUk2RY+4kGyB8tFSKZrlAEMl+xIM+T1/wKyEXN3jVkawL1Ixc4CM5udAQZIfAwFvSn7PQWk+q9dd KeMorgFtFG6EoPYYOc1W6N0o+KDXUrQOyPngeWkRFT3MU21MquEF58JYt0ARd7riQkqBivjfGeCE CyGNeUtR3JNjtsIDJm1zUxhayqgAra0kRuvJs1SVQsiHl7Lw2OcgKHsluPjWxUYlZaqt1XRXBl0U GHDCdbvuLoYid4kuxsoKaAVcE5YU4LQBZtVAuHH06JhZOFkb5pCWB6b62zdxD0foZCVwzV4y0n96 ePDDr801hTItAiGjRD91NCy37HpTAtMqEUU4ClPyPiTWcVsr0B63wmJgd4jjNObmpnA96JCMQD+A +cFraqGfnp2WGdAthdt6VSlv/RVTASiL2i2AFfaxVxsgR6Dgg6lDCoCuTmJauASWAUwH3oTfepOZ 7038tc4vCpzPNoLlO44BLi49L1vHxbvpfMoaoOzDZF3fLT6csW2vbKVmvn356k63Hucg/LDy0/Tt 6/CQratZyEFqi0EYinHqBR+TFhirn70b27r6kXpsYRT7EtwoX3GbqMhiapGPQvnJwIePb9N8ZNix HMNq4NxpF6/vcT4vAtVADF/kU9taRvAfeeWMT6qYSYAAAAAASUVORK5CYII= X-Now-Playing: Figurine's _The Heartfelt_: "International Space Station II" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1R31TD-00033v-Fj X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1316419344.00057@Rv9Mqm7Vf6DQi+eU/2mgcg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org, Gerard Brunick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Andreas Schwab writes: >>> Since define-key-after is only useful for menu-bar bindings which don't >>> use characters in keys this doesn't look like a serious restriction. >> >> The doc string of `define-key-after' doesn't say that it's only for >> menu-bar bindings. > > define-key-after is a compiled Lisp function in `subr.el'. > [...] > The order of bindings in a keymap matters when it is used as a menu. So? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 04:18:41 2011 Received: (at 2179) by debbugs.gnu.org; 12 Sep 2011 08:18:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R31iz-00022D-0I for submit@debbugs.gnu.org; Mon, 12 Sep 2011 04:18:41 -0400 Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R31ix-000227-8U for 2179@debbugs.gnu.org; Mon, 12 Sep 2011 04:18:40 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 437EE1C021FB; Mon, 12 Sep 2011 10:14:18 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 25E751C00181; Mon, 12 Sep 2011 10:14:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id VkeJeIJReTEL; Mon, 12 Sep 2011 10:14:14 +0200 (CEST) Received: from hase.home (ppp-88-217-102-104.dynamic.mnet-online.de [88.217.102.104]) by mail.mnet-online.de (Postfix) with ESMTP; Mon, 12 Sep 2011 10:14:13 +0200 (CEST) From: Andreas Schwab To: Lars Magne Ingebrigtsen Subject: Re: bug#2179: 23.0.60; define-key vs define-key-after key syntax References: <4987F2D6.2010900@math.utexas.edu> X-Yow: FROZEN ENTREES may be flung by members of opposing SWANSON SECTS.. Date: Mon, 12 Sep 2011 10:14:13 +0200 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 12 Sep 2011 09:59:10 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org, Gerard Brunick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Lars Magne Ingebrigtsen writes: > Andreas Schwab writes: > >>>> Since define-key-after is only useful for menu-bar bindings which don't >>>> use characters in keys this doesn't look like a serious restriction. >>> >>> The doc string of `define-key-after' doesn't say that it's only for >>> menu-bar bindings. >> >> define-key-after is a compiled Lisp function in `subr.el'. >> [...] >> The order of bindings in a keymap matters when it is used as a menu. > > So? Yes. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 05 01:08:18 2011 Received: (at 2179) by debbugs.gnu.org; 5 Oct 2011 05:08:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBJiM-0005rQ-I4 for submit@debbugs.gnu.org; Wed, 05 Oct 2011 01:08:18 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBJiK-0005rJ-Ho for 2179@debbugs.gnu.org; Wed, 05 Oct 2011 01:08:17 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RBJiH-0000zD-Cl; Wed, 05 Oct 2011 01:08:13 -0400 From: Glenn Morris To: Lars Magne Ingebrigtsen Subject: Re: bug#2179: 23.0.60; define-key vs define-key-after key syntax References: <4987F2D6.2010900@math.utexas.edu> X-Spook: enemy of the state Qaddafi SAPO clones Noriega X-Ran: +>,`fChVhLS|OV&@\zPL`MmRxim)6w]Kv#%_>/1a_W4k@dz7W;gA(11D??\{myp\J&q8v3 X-Hue: yellow X-Attribution: GM Date: Wed, 05 Oct 2011 01:08:13 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 12 Sep 2011 09:59:10 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org, Gerard Brunick , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Lars Magne Ingebrigtsen wrote: >>> The doc string of `define-key-after' doesn't say that it's only for >>> menu-bar bindings. >> >> define-key-after is a compiled Lisp function in `subr.el'. >> [...] >> The order of bindings in a keymap matters when it is used as a menu. > > So? Perhaps the point was supposed to be that the order of the elements in a keymap ONLY matters in a menu, therefore there is no point to use define-key-after with anything other then menu entries, therefore define-key-after does not need to be extended to handle the same range of key syntax that define-key can, therefore this is just a documentation bug for define-key-after. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 15:16:59 2011 Received: (at control) by debbugs.gnu.org; 6 Oct 2011 19:16:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBtRC-0001gf-Km for submit@debbugs.gnu.org; Thu, 06 Oct 2011 15:16:59 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBtRB-0001gX-4p for control@debbugs.gnu.org; Thu, 06 Oct 2011 15:16:57 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1RBtQu-00086X-U8 for control@debbugs.gnu.org; Thu, 06 Oct 2011 21:16:41 +0200 Date: Thu, 06 Oct 2011 21:16:40 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #2179 X-MailScanner-ID: 1RBtQu-00086X-U8 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1318533401.14088@H0KXcvVxGI3Y/hFrdn3lZw X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 2179 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 15:17:25 2011 Received: (at 2179) by debbugs.gnu.org; 6 Oct 2011 19:17:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBtRd-0001iM-3m for submit@debbugs.gnu.org; Thu, 06 Oct 2011 15:17:25 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBtRW-0001hq-Ro for 2179@debbugs.gnu.org; Thu, 06 Oct 2011 15:17:21 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1RBtRF-00087T-EG; Thu, 06 Oct 2011 21:17:01 +0200 From: Lars Magne Ingebrigtsen To: Glenn Morris Subject: Re: bug#2179: 23.0.60; define-key vs define-key-after key syntax In-Reply-To: (Glenn Morris's message of "Wed, 05 Oct 2011 01:08:13 -0400") Date: Thu, 06 Oct 2011 21:16:34 +0200 Message-ID: References: <4987F2D6.2010900@math.utexas.edu> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) X-Now-Playing: Zola Jesus's _Conatus_: "Shivers" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1RBtRF-00087T-EG X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1318533422.1253@ElR68jhBDQ47V2c8n1lKMA X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 2179 Cc: 2179@debbugs.gnu.org, Gerard Brunick , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Glenn Morris writes: > Perhaps the point was supposed to be that the order of the elements in a > keymap ONLY matters in a menu, therefore there is no point to use > define-key-after with anything other then menu entries, therefore > define-key-after does not need to be extended to handle the same range > of key syntax that define-key can, therefore this is just a > documentation bug for define-key-after. I totally misunderstood what the function was meant to do. :-) I've now just clarified the doc string and am closing the report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Wed Sep 10 12:14:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 04 Nov 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator