From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 19:09:13 2015 Received: (at submit) by debbugs.gnu.org; 26 Oct 2015 23:09:13 +0000 Received: from localhost ([127.0.0.1]:39494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqqt7-0003YN-8u for submit@debbugs.gnu.org; Mon, 26 Oct 2015 19:09:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40955) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqqt5-0003YF-BR for submit@debbugs.gnu.org; Mon, 26 Oct 2015 19:09:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zqqt4-0002kw-B1 for submit@debbugs.gnu.org; Mon, 26 Oct 2015 19:09:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqqt4-0002ko-8L for submit@debbugs.gnu.org; Mon, 26 Oct 2015 19:09:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqqt3-0001iO-7j for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2015 19:09:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zqqsz-0002gB-Ri for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2015 19:09:09 -0400 Received: from static.59.150.47.78.clients.your-server.de ([78.47.150.59]:35112 helo=metalevel.at) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqqsz-0002f7-LV for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2015 19:09:05 -0400 Received: from dawn.meta (dawn.metalevel.at [127.0.0.1]) by metalevel.at (Postfix) with ESMTP id 32CC4EC109 for ; Tue, 27 Oct 2015 00:09:02 +0100 (CET) Received: by dawn.meta (Postfix, from userid 501) id C732F16BE6D5; Tue, 27 Oct 2015 00:07:10 +0100 (CET) From: Markus Triska To: bug-gnu-emacs@gnu.org Subject: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace Date: Tue, 27 Oct 2015 00:07:10 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Steps to reproduce: 1) wget http://www.metalevel.at/ei/fault1.html 2) emacs -Q fault1.html 3) M-x delete-trailing-whitespace RET This removes several non-white-space characters, including the whole line containing "and use it like" (line 83 in the original file), yielding the following diff against the original file: http://www.metalevel.at/ei/fault1.patch Subtle changes in different sections of the file cause different behaviour of `delete-trailing-whitespace'. For example, if I remove the initial paragraph (patch: http://www.metalevel.at/ei/fault12.patch) to obtain the slightly altered file: http://www.metalevel.at/ei/fault2.html Then the analogous steps, using fault2.html ($ emacs -Q fault2.html, M-x delete-trailing-whitespace RET) work as expected, removing only trailing whitespace characters and leading to the diff: http://www.metalevel.at/ei/fault2.patch All steps work as expected in Emacs 24.5, removing only trailing whitespace characters in all cases. Thank you for looking into this! Markus In GNU Emacs 25.0.50.5 (x86_64-apple-darwin14.1.0, X toolkit, Xaw3d scroll bars) of 2015-10-04 Repository revision: acfb5cd0353406784f085ddb6edfb0d0587048c8 Windowing system distributor 'The X.Org Foundation', version 11.0.11502000 Configured using: 'configure --without-ns CFLAGS=-I/opt/local/include LDFLAGS=-L/opt/local/lib' Configured features: XAW3D XPM JPEG TIFF GIF PNG IMAGEMAGICK GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 20:16:02 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 00:16:02 +0000 Received: from localhost ([127.0.0.1]:39517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqrvl-00055c-Ix for submit@debbugs.gnu.org; Mon, 26 Oct 2015 20:16:02 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:35652) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqrvj-00055K-8f for 21766@debbugs.gnu.org; Mon, 26 Oct 2015 20:16:00 -0400 Received: by lbbes7 with SMTP id es7so52145316lbb.2 for <21766@debbugs.gnu.org>; Mon, 26 Oct 2015 17:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=/s8wE5+WLQpIywfMBsm1dtGAkFAhmrWudo97noJhsUg=; b=yWUaA4W3LCX7/bPmoDAvjIdmIG+pglYlyC/OSaBrzvlzh5PYpi1hKJA4XE7jzUs8l8 QJchQUN1wxctbWHQwtTtmZpPH8ge4rQr9uz07zzvuFe7ITXtip2bDq68+ndHV0V9hTcy S1FnEl1+EonEpaGcW2iy7p1pb29/bW2mzCHjGHrzVxhhE2XqEqoq4tNa0tPH2AO3TiDg z+XkkahiMPHa93sZ49MlAW+kAU+OLwpq4FoocfyUPYrZyz68QPheP/d3HKtPwdttVO2L VJ0ijrwGZOJFWJJXBOIK121gNTc/S07Q1+kwer/rKY7pw/TyGF90mPGSoRQ3cFaA5pAM DMAw== X-Received: by 10.112.77.10 with SMTP id o10mr18571208lbw.28.1445904958394; Mon, 26 Oct 2015 17:15:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Mon, 26 Oct 2015 17:15:18 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 27 Oct 2015 01:15:18 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: Markus Triska Content-Type: multipart/alternative; boundary=001a11c3ba826c9e4f05230afb1e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c3ba826c9e4f05230afb1e Content-Type: text/plain; charset=UTF-8 On Tue, Oct 27, 2015 at 12:07 AM, Markus Triska wrote: > > > Steps to reproduce: > > 1) wget http://www.metalevel.at/ei/fault1.html > > 2) emacs -Q fault1.html > > 3) M-x delete-trailing-whitespace RET > > This removes several non-white-space characters, including the whole > line containing "and use it like" (line 83 in the original file), Apparently, the call to skip-syntax-backward is altering the match data. If you try this --- a/lisp/simple.el +++ b/lisp/simple.el @@ -609,7 +609,7 @@ delete-trailing-whitespace (start (or start (point-min)))) (goto-char start) (while (re-search-forward "\\s-$" end-marker t) - (skip-syntax-backward "-" (line-beginning-position)) + (save-match-data (skip-syntax-backward "-" (line-beginning-position))) ;; Don't delete formfeeds, even if they are considered whitespace. (if (looking-at-p ".*\f") (goto-char (match-end 0))) or, alternatively, @@ -609,11 +609,12 @@ delete-trailing-whitespace (start (or start (point-min)))) (goto-char start) (while (re-search-forward "\\s-$" end-marker t) - (skip-syntax-backward "-" (line-beginning-position)) - ;; Don't delete formfeeds, even if they are considered whitespace. - (if (looking-at-p ".*\f") - (goto-char (match-end 0))) - (delete-region (point) (match-end 0))) + (let ((end (match-end 0))) + (skip-syntax-backward "-" (line-beginning-position)) + ;; Don't delete formfeeds, even if they are considered whitespace. + (if (looking-at-p ".*\f") + (goto-char end)) + (delete-region (point) end))) ;; Delete trailing empty lines. (goto-char end-marker) (when (and (not end) it works. Now, the question is, should skip-syntax-backward preserve the match data, or must delete-trailing-whitespace be coded defensively? The usual policy has been that code that needs the match data preserved should make sure itself that it is so. --001a11c3ba826c9e4f05230afb1e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Oct 27, 2015 at 12:07 AM, Markus Triska <triska@metalevel.at> wrote:
>=
>
> Steps to reproduce:
>
> 1) wget http://www.metalevel.at/ei/fault1.html=
>
> 2) emacs -Q fault1.html
>
> 3) M-x delete-= trailing-whitespace RET
>
> This removes several non-white-spac= e characters, including the whole
> line containing "and use it = like" (line 83 in the original file),

Apparently, the call= to skip-syntax-backward is altering the match data. If you try this
<= div>
--- a/lisp/simple.el
+++ b/lisp/simpl= e.el
@@ -609,7 +609,7 @@ delete-trailing-whitespace
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(start (or start (point-min)))= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(goto-char start)
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(while (re-search-forward "\\s-$&quo= t; end-marker t)
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(skip-syntax= -backward "-" (line-beginning-position))
+ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(save-match-data (skip-syntax-backward "-"= ; (line-beginning-position)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0;; Don't delete formfeeds, even if they are considered whitespace= .
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (looking-at-p &quo= t;.*\f")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(goto-char (match-end 0)))


<= div>or, alternatively,

@@ -609,11 +609,12 @@ = delete-trailing-whitespace
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(start (or start (point-min))))
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0(goto-char start)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (while (re-search-forward "\\s-$" end-marker t)
- =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(skip-syntax-backward "-" (line-be= ginning-position))
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Don'= ;t delete formfeeds, even if they are considered whitespace.
- = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (looking-at-p ".*\f")
=
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(goto-char (match-en= d 0)))
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete-region (point)= (match-end 0)))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((end (= match-end 0)))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(skip-s= yntax-backward "-" (line-beginning-position))
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Don't delete formfeeds, even if th= ey are considered whitespace.
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(if (looking-at-p ".*\f")
+ =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(goto-char end))
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete-region (point) end)))
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Delete trailing empty lines.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(goto-char end-marker)
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (and (not end)

<= div>it works. Now, the question is, should skip-syntax-backward preserve th= e match data, or must delete-trailing-whitespace be coded defensively? The = usual policy has been that code that needs the match data preserved should = make sure itself that it is so.
--001a11c3ba826c9e4f05230afb1e-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 03:07:29 2015 Received: (at submit) by debbugs.gnu.org; 27 Oct 2015 07:07:29 +0000 Received: from localhost ([127.0.0.1]:39911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqyLw-00081Z-Hg for submit@debbugs.gnu.org; Tue, 27 Oct 2015 03:07:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59585) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqyLu-00081Q-Ls for submit@debbugs.gnu.org; Tue, 27 Oct 2015 03:07:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqyLt-00057J-2u for submit@debbugs.gnu.org; Tue, 27 Oct 2015 03:07:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqyLs-00057F-Vf for submit@debbugs.gnu.org; Tue, 27 Oct 2015 03:07:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqyLr-0006zR-Ox for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 03:07:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqyLo-00056t-FH for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 03:07:23 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:61633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqyLo-00056o-5E for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 03:07:20 -0400 Received: from [192.168.178.31] ([77.6.197.144]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0LnGP8-1aQsw40SwY-00hblK for ; Tue, 27 Oct 2015 08:07:18 +0100 Message-ID: <562F22BA.3050103@easy-emacs.de> Date: Tue, 27 Oct 2015 08:07:38 +0100 From: =?UTF-8?B?QW5kcmVhcyBSw7ZobGVy?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: In-Reply-To: Content-Type: multipart/alternative; boundary="------------030608040407060300090508" X-Provags-ID: V03:K0:OdjrnciVoZy7Au53RKZjb/qS6OqsqHY2IH30/bD8yC4ql+WKbj+ 3Nkkl4aDAgX0Cuc/0QV/LD2lzJnaXZteGdQDafybUZYJGh1uHe/AXM7JAaw7cCQ5OVaOgv6 KYuOevvD77i29VuUw31S/sWF8gkIyKeGvIjmsBBj5G2Z40XLZrHNv5OaiA1l+mjIrGDddJM iRW1mM5FMLP6Yh8rN7XIQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:J6TVg7OaZhs=:q5PooRh1FMklgDXS1ouM1z KCJNu0wQAsRFF3ehRr0UwtQJmLWQWi7JED25BH9B3UQVOJJ7usfG+3TeI1eHYRHySI/g8K2YF OvX6jWuCQqxNmw8KaOYV9zoXMWzKm37L0CW2FT/c41cd3Qtc1hx2ZKpG/0bk/0FtnBqSrxeUf McarGAVsJJzvpPepatG/LZlu/CbKq3RCvs0X3fZwn5r1yWV3hBM3mVPSiLWN3Mh8ldini0g6N WABIPCYWJAzcTgssJZX+OfhkobYZFUB6YrFCPSyY5ZMCN5Bl7E525upytZulsyefs2KeMdoZv pz43uPE7vIkODUMZV8UPiz2TVMadSRPJ17hRGigdyJaXIVxvc2ktyH1SWVJvhtscckMDKPP7l q9LCP7aLp/qA79PMSnUo9vVX9shqn/lNgl2ApFRkGqt5JJi7fc922vChEsFHBGy3vRIlVd6ye jn6UyQnVaRovL+xKtGjb3zZM8ANPE7UA5thFmAjC9xA0NmJtCo4B5wmYXPqc9omLftZxVag21 jzdglhQpvveyXMWSohTTaAF3etXRL7joeD+5JPgiYify4ADfDvJraFUPSwbGm1lQhGVRiCBWE LcirIDjysTth3ToKK+NaCU9i732bgY9y3EbhgQxjDjjFpz041KUqNuU9Qum+DIQbFGRg4/R/+ aBLnBXf8Uf2o3kuZtQbX4fR695W3jbvr86TrbOJmfA/tBse/deXA3zqlCyLleV4mNdB8TIm7e 3fvki1G5LL6effwX X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------030608040407060300090508 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27.10.2015 01:15, Juanma Barranquero wrote: > On Tue, Oct 27, 2015 at 12:07 AM, Markus Triska > wrote: > > > > > > Steps to reproduce: > > > > 1) wget http://www.metalevel.at/ei/fault1.html > > > > 2) emacs -Q fault1.html > > > > 3) M-x delete-trailing-whitespace RET > > > > This removes several non-white-space characters, including the whole > > line containing "and use it like" (line 83 in the original file), > > Apparently, the call to skip-syntax-backward is altering the match > data. If you try this > > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -609,7 +609,7 @@ delete-trailing-whitespace > (start (or start (point-min)))) > (goto-char start) > (while (re-search-forward "\\s-$" end-marker t) > - (skip-syntax-backward "-" (line-beginning-position)) > + (save-match-data (skip-syntax-backward "-" > (line-beginning-position))) > ;; Don't delete formfeeds, even if they are considered > whitespace. > (if (looking-at-p ".*\f") > (goto-char (match-end 0))) > > > or, alternatively, > > @@ -609,11 +609,12 @@ delete-trailing-whitespace > (start (or start (point-min)))) > (goto-char start) > (while (re-search-forward "\\s-$" end-marker t) > - (skip-syntax-backward "-" (line-beginning-position)) > - ;; Don't delete formfeeds, even if they are considered > whitespace. > - (if (looking-at-p ".*\f") > - (goto-char (match-end 0))) > - (delete-region (point) (match-end 0))) > + (let ((end (match-end 0))) > + (skip-syntax-backward "-" (line-beginning-position)) > + ;; Don't delete formfeeds, even if they are considered > whitespace. > + (if (looking-at-p ".*\f") > + (goto-char end)) > + (delete-region (point) end))) > ;; Delete trailing empty lines. > (goto-char end-marker) > (when (and (not end) > > it works. First fix looks cleaner. > Now, the question is, should skip-syntax-backward preserve the match > data, or must delete-trailing-whitespace be coded defensively? The > usual policy has been that code that needs the match data preserved > should make sure itself that it is so. Such a basic routine should preserve matches by its own virtue. A couple of regression tests should pay here. Thanks --------------030608040407060300090508 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27.10.2015 01:15, Juanma Barranquero wrote:
On Tue, Oct 27, 2015 at 12:07 AM, Markus Triska <triska@metalevel.at> wrote:
>
>
> Steps to reproduce:
>
> 1) wget http://www.metalevel.at/ei/fault1.html
>
> 2) emacs -Q fault1.html
>
> 3) M-x delete-trailing-whitespace RET
>
> This removes several non-white-space characters, including the whole
> line containing "and use it like" (line 83 in the original file),

Apparently, the call to skip-syntax-backward is altering the match data. If you try this

--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -609,7 +609,7 @@ delete-trailing-whitespace
             (start (or start (point-min))))
         (goto-char start)
         (while (re-search-forward "\\s-$" end-marker t)
-          (skip-syntax-backward "-" (line-beginning-position))
+          (save-match-data (skip-syntax-backward "-" (line-beginning-position)))
           ;; Don't delete formfeeds, even if they are considered whitespace.
           (if (looking-at-p ".*\f")
               (goto-char (match-end 0)))


or, alternatively,

@@ -609,11 +609,12 @@ delete-trailing-whitespace
             (start (or start (point-min))))
         (goto-char start)
         (while (re-search-forward "\\s-$" end-marker t)
-          (skip-syntax-backward "-" (line-beginning-position))
-          ;; Don't delete formfeeds, even if they are considered whitespace.
-          (if (looking-at-p ".*\f")
-              (goto-char (match-end 0)))
-          (delete-region (point) (match-end 0)))
+          (let ((end (match-end 0)))
+            (skip-syntax-backward "-" (line-beginning-position))
+            ;; Don't delete formfeeds, even if they are considered whitespace.
+            (if (looking-at-p ".*\f")
+                (goto-char end))
+            (delete-region (point) end)))
         ;; Delete trailing empty lines.
         (goto-char end-marker)
         (when (and (not end)

it works.

First fix looks cleaner.

Now, the question is, should skip-syntax-backward preserve the match data, or must delete-trailing-whitespace be coded defensively? The usual policy has been that code that needs the match data preserved should make sure itself that it is so.

Such a basic routine should preserve matches by its own virtue.

A couple of regression tests should pay here.

Thanks
--------------030608040407060300090508-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 03:54:31 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 07:54:31 +0000 Received: from localhost ([127.0.0.1]:39920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqz5T-0000iL-71 for submit@debbugs.gnu.org; Tue, 27 Oct 2015 03:54:31 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:36533) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqz57-0000hl-Hc for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 03:54:28 -0400 Received: by lbcao8 with SMTP id ao8so57024970lbc.3 for <21766@debbugs.gnu.org>; Tue, 27 Oct 2015 00:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=v+MnfkcIxb+jq0Ji/mn4APnaqBOCVAXAbv9Ahgx0FaM=; b=bbBAVVac/EKgNzDw+MJoFaxX4zoxb3utM3RDHudnyb47hTarEt6Ia8RQP7v+ssUwMt rXam4S4NP977Kl5v4Mxx5AoZFfzv3ukYEcLqU1uQHpEr1CBuxBY+akib8RDrXnYmTDV0 vDifY07xkTKM2AOV4eWtwzq7SFGAoZweUzOC70XCZ0/pcI1eQuMkYoEK1nl3m+JyErTt itXoi+2E3CEfxxhaPdboCAq5CxNFC0q5Ohcs1mS5koLtU4mVcsV5/6gjRHvKld1sj3sY mxHJD6fmazTc/hV3PQhD91TlzEElmzVXDKtyJUBQPLQfnknEQ78biEc2RbtooWlBliec FS7g== X-Received: by 10.112.62.194 with SMTP id a2mr19430083lbs.80.1445932448122; Tue, 27 Oct 2015 00:54:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Tue, 27 Oct 2015 00:53:28 -0700 (PDT) In-Reply-To: <562F22BA.3050103@easy-emacs.de> References: <562F22BA.3050103@easy-emacs.de> From: Juanma Barranquero Date: Tue, 27 Oct 2015 08:53:28 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: =?UTF-8?Q?Andreas_R=C3=B6hler?= Content-Type: multipart/alternative; boundary=001a11c3c46ef08ed7052311612e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c3c46ef08ed7052311612e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Oct 27, 2015 at 8:07 AM, Andreas R=C3=B6hler < andreas.roehler@easy-emacs.de> wrote: > First fix looks cleaner. Shorter, indeed, though it does more work, and inside a loop. I really have no preference. > Such a basic routine should preserve matches by its own virtue. Are you talking about delete-trailing-whitespace or skip-syntax-backward? Anyway, I've always thought that functions should preserve the match data, but I was told that doing so is a (relatively) expensive operation, and functions that use match data should be the ones to make sure that it is valid when they need it. J --001a11c3c46ef08ed7052311612e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Oct 27, 2015 at 8:07 AM, Andreas R=C3=B6hler <<= a href=3D"mailto:andreas.roehler@easy-emacs.de">andreas.roehler@easy-emacs.= de> wrote:

> First fix looks cleaner.

Shorter, indeed, though it does more work, and inside a loop. I really h= ave no preference.

> Such a basic routine shoul= d preserve matches by its own virtue.

Are you talking abo= ut delete-trailing-whitespace or skip-syntax-backward?

=
Anyway, I've always thought that functions should preserve the mat= ch data, but I was told that doing so is a (relatively) expensive operation= , and functions that use match data should be the ones to make sure that it= is valid when they need it.

=C2=A0 =C2=A0 J
= --001a11c3c46ef08ed7052311612e-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 04:06:17 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 08:06:18 +0000 Received: from localhost ([127.0.0.1]:39925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzGr-0000zw-Hp for submit@debbugs.gnu.org; Tue, 27 Oct 2015 04:06:17 -0400 Received: from mout.gmx.net ([212.227.17.21]:59451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzGW-0000zG-Oi for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 04:06:15 -0400 Received: from [178.190.19.40] ([178.190.19.40]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0M3zG2-1ahRUf0Wws-00rc32; Tue, 27 Oct 2015 09:05:55 +0100 Message-ID: <562F3060.9050301@gmx.at> Date: Tue, 27 Oct 2015 09:05:52 +0100 From: martin rudalics MIME-Version: 1.0 To: Juanma Barranquero , Markus Triska Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:y75C2G9LOgzEvU5NikpbMuWX351cinBOLWcIPn3BXnGDnbIb7cG FiMjDlBCfTvDSAau8x2HI3xCIEhX6VtKZoctUucyC0qnW0psX0K+kK9A5a2NrpNTcSlPY/g Q2XcK8dU6uUt8TokXgy2OwPZqi7jlGUj949ouC+1eeCRA5QlPoyrAXiBTe96r6iIa1raLQB 5+NlxY39URbd2GJV+M6PA== X-UI-Out-Filterresults: notjunk:1;V01:K0:JyMLBxQagoA=:3e/RycrhRvsf5ha42vChbG pNdlf26u1RISHW9B6SccVbumQBq+ntqGIFVlxd+7Ai0kIKHvymLOcDLMoc3dj+FdErxWudeia ZfDkty8+TQYBfOg8cyQqCoXUnswu9ApyGXSgDLbqwO3xpnVHkoJkyKi0TWTfdfLsn3Q3e7Vzz jvqjrd8siSeNpWWRLNETpCLMdfOlLeydOpCx/cW4dX4GlmwE+Ad10pEn3E6zUMEnVufHuCNM/ PX98CPlm9JZRoF5J33/LJ6h6Bcwb+gKAfje5VLMGNzdheyn2DsYK07G+cBmM8Q0ZdyBa3wVTX LSNfGiMkWg90AMIU/azAxTHIYn03Wuqvf5kuxi02f++BTl+RNL/9rHxzuNtMZk4cjXxhfUTCf 74YsVbRD6m+zNlVz840Bq42jQYMrre3D1rRhHRrnOy1mKErW2KQfHbM2JrEmWISIvUUm+q5Mi hHRytTu79Ns+qq4rH8d25R48g9JkQBzDmCMU0e3vV4bxWbOPt1GT2/nOn1gOK6YbiXsahVpQE Dcn4obbtKNtJWT4kRYhSBXnEE7hNzLW1tDLL6rANa5WemCeb3Qx3KQxIO8AeVgPjqrp7PPJpO hSFDsztKrI7/PQsMRakqoEqPPWeMzP7XJ0yotWy6CKXYXckEh1w9zrmixtI7Ec68iHNbcNvDz BfPF0C5e6SM/tTOrq1F/JylY42Xw75uN6FfWW0rTcLWaT1f2khEVA+7OMgc1tthXnLfz6wHEg 3iFT666Q5SR8Wsmj/i4GNEo1jgWZC2WW9fJXdTvG4ysBBCFc8cXX6/6zY5GGZ6YJIO57dHNwz uHYVsvV X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Now, the question is, should skip-syntax-backward preserve the > match data, or must delete-trailing-whitespace be coded defensively? The latter. > The > usual policy has been that code that needs the match data preserved should > make sure itself that it is so. Shouldn't we remove that "\\s-$" rigmarole? Something like the largely untested (let ((end-marker (copy-marker (or end (point-max)))) old-bol new-eol new-bol) (goto-char (or start (point-min))) (while (re-search-forward "\\\n" end-marker t) (setq new-bol (point)) (goto-char (setq new-eol (match-beginning 0))) (if (or (zerop (skip-syntax-backward "-" (or old-bol (line-beginning-position)))) (looking-at-p ".*\f")) (goto-char new-bol) (delete-region (point) new-eol) (forward-char)) (setq old-bol (point))) It's still not very clean (should line-beginning-position be allowed to go before START?) so if someone wants to polish it up .... martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 04:13:05 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 08:13:05 +0000 Received: from localhost ([127.0.0.1]:39929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzNR-00019Y-D8 for submit@debbugs.gnu.org; Tue, 27 Oct 2015 04:13:05 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:34033) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzNP-00019Q-KT for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 04:13:04 -0400 Received: by lfaz124 with SMTP id z124so168615763lfa.1 for <21766@debbugs.gnu.org>; Tue, 27 Oct 2015 01:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=vET8TVP+rwk/PMfNXVoASP0P5wikVaJnaVXYtIOvt88=; b=p7Fuo2WK6Y7BiKbEOgrtgAw0fMwRel8UK+uq77SVg7wbyLMshU67x3wqXx21MD9Jxo L+Keuf03ty/Vb6t3pp/zYa7YyuUN1nmy2bMretjH4Q3S1ie1gibG4tRTMcduB+JkKi7C p6ER+EjPLw+57jdxaYornSq/N7iIIoOzdTNHnQ8scEELHOOgVbLigOjFZkHX8s08a306 If23J2H2anqHgMr4lvrTRd26n4Hehahl26VbdYs2oCWJDPKRvby5LqqrZfS2FZ+IYBfW qru8RCIeLolIJLWPCGlQafBkyPMGTlc4yvuSA4qL6NPIYCjPNniNJFtLkY0x4W3jvAlS +JKw== X-Received: by 10.25.167.2 with SMTP id q2mr4081734lfe.15.1445933582665; Tue, 27 Oct 2015 01:13:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Tue, 27 Oct 2015 01:12:23 -0700 (PDT) In-Reply-To: <562F3060.9050301@gmx.at> References: <562F3060.9050301@gmx.at> From: Juanma Barranquero Date: Tue, 27 Oct 2015 09:12:23 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: martin rudalics Content-Type: multipart/alternative; boundary=001a113fbdc6904ebb052311a5c9 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113fbdc6904ebb052311a5c9 Content-Type: text/plain; charset=UTF-8 On Tue, Oct 27, 2015 at 9:05 AM, martin rudalics wrote: > The latter. Yep, that's the policy. > Shouldn't we remove that "\\s-quot; rigmarole? Something like the largely > untested Hmm, what's the gain for the added complexity? J --001a113fbdc6904ebb052311a5c9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Oct 27, 2015 at 9:05 AM, martin rudalics <rudalics@gmx.at> wrote:

&g= t; The latter.

Yep, that's the policy.

=
> Shouldn't we remove that "\\s-quot; rigmarole?=C2=A0 Something like the largely
> u= ntested

Hmm, what's the gain for the added complexity= ?

=C2=A0 =C2=A0 J
--001a113fbdc6904ebb052311a5c9-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 04:25:23 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 08:25:23 +0000 Received: from localhost ([127.0.0.1]:39942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzZL-0001S8-0Y for submit@debbugs.gnu.org; Tue, 27 Oct 2015 04:25:23 -0400 Received: from mout.gmx.net ([212.227.17.20]:50233) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzZI-0001Rz-AK for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 04:25:21 -0400 Received: from [178.190.19.40] ([178.190.19.40]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MI9n0-1Zn9HM3dR0-003skj; Tue, 27 Oct 2015 09:25:19 +0100 Message-ID: <562F34EB.8030209@gmx.at> Date: Tue, 27 Oct 2015 09:25:15 +0100 From: martin rudalics MIME-Version: 1.0 To: Juanma Barranquero Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: <562F3060.9050301@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:KeiTTTL/ozW2EIRmkx4eh4cgR5Lv6kUaPlIziOJY4/Ts9+Y2Wu0 H87hwZOS+WOT7zASn9wM6zp5Tz765xgTctVS9bmhf2KYC0EDEaPygisY8Qupn3+WmmpZIfJ Cdf67oXAOteneFyIKXvvzwij+f2i3rBUHPgzGxNQQROk2QJZsKadS2ACpKu3LAjfjtd4FGK 3U/ctpj3UA4vsdiaSJBrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:qb3yV+dvb6U=:zSB7GunSkiwiBM84Axb5Vr 5vMARrZocjOPN5Hl+Qwa3k73vIOsjH6gVW7CBdHdfcra+JCrFbpkJbTjMz7GpA3rnKXOiy47X OJFr6jdGIr29sbjO6cZStlzJJQl44GlLJyoAfVd903suEq+ek741L3HwLMncK65Xd3lnQYCje RP8I0sSChbT/0urjYthOZdaIOfBTJ7ilWktAHT6n/nwH4iUhDBca3hMvIwoZlMqfHNAyh0fa9 TNj2C+tIBzMwxtwMSfZSTCE9yuRI1N0wo6H7jlYVHcLTLMBBtLEQPAqdVSp/TDYSJPUvgwMdc n42cPsy0FwZXB+pbHgmxYk07AL9SU5hgrglhTHaft5PC+jg8MAanyvngeusVyMy54B0fSIc5X qyWcsWjNyaNccvvl385Qg8KgX1R4GcPSoqablzItWeswQ2YCaY/xFK3RXwniMsqTTm4KVPbEf gMPiUbNY46e4dywZ9h03kvJyanM2kaUW9shCxMUhyRx8ij7KWjpzaWp3NENeCGKWNYU9ADsux zeJQdygP6OIb8UJn2tMnS3wBPCkFY0vG8/DU9PobvbKB8/vd8Z48ui0tpy/4Kk7FudJJlD6Rw UyzkxxoVMKxbuPf5FA5nCdUIu0vD03FZN7wx36gHLANNyaruTq9n2CJ6J7M1dsRmOv0QIG50Q PRM4V4d1e2j34M2ItpdoQQKkQ+doEU2ycLtL4HnTF6jXiCVlNz30ICI9wVCAzx8u05GS3Ehwj M8+Tg0VKeF/U5iyaZswjDpNaHFQG3jzHON2tabzlDG1e8h4QBnJLJm11nSsH6RfEUSyzer0tl JEVJF6H X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Hmm, what's the gain for the added complexity? Maybe none. I have no idea how the regexp machine works when looking for "\\s-$". If it looks for whitespace followed by a line end and not for whitespace preceding a line end, the old version will be slow with indented code. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 04:33:32 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 08:33:32 +0000 Received: from localhost ([127.0.0.1]:39951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzhD-0001ej-S9 for submit@debbugs.gnu.org; Tue, 27 Oct 2015 04:33:32 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:36476) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzhB-0001eb-Uv for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 04:33:30 -0400 Received: by lffz202 with SMTP id z202so168839778lff.3 for <21766@debbugs.gnu.org>; Tue, 27 Oct 2015 01:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=SSIDBMk8LVgF5m8ph9bb8PykQjxhEjQG2OLexhYcyhg=; b=Aqtau36taj+JF9z9ljSXDOqPFFgPb12GwE4XP6zHagy5IvBx2F1xfZAQWKCd6JEnwW OiBuICUJ0ZF48WbB0f6ytIKN5A8yLX3DyS7Qz2lRFgvlvtK83E90B+IY6S+Ubd15dxlx 2AyCnlNOFZN9KKMIC2fU8m7gq96P/tuzyb5rxgRhkrKP7OcnSuIdQ4e1y+L0C0hBzy0E nFISueB74+/+h2PxnF604/ex0O3jCBDxHq3aTDwbI0xBFct/217NJy0SVK97aHqArzpD yFQNjsrhBdWw/EQeoe5LLGWv5jEG5MliZlhJHtqC4rby9DzJdVRejQSr3rHiFADovF+z VOsA== X-Received: by 10.25.135.136 with SMTP id j130mr817036lfd.95.1445934809148; Tue, 27 Oct 2015 01:33:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Tue, 27 Oct 2015 01:32:49 -0700 (PDT) In-Reply-To: <562F34EB.8030209@gmx.at> References: <562F3060.9050301@gmx.at> <562F34EB.8030209@gmx.at> From: Juanma Barranquero Date: Tue, 27 Oct 2015 09:32:49 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: martin rudalics Content-Type: multipart/alternative; boundary=001a113fc40aaaf5e9052311ee95 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113fc40aaaf5e9052311ee95 Content-Type: text/plain; charset=UTF-8 On Tue, Oct 27, 2015 at 9:25 AM, martin rudalics wrote: > If it looks for whitespace followed by a line end and not > for whitespace preceding a line end, the old version will be slow with > indented code. I don't think we've ever had a bug report / complaint about delete-trailing-whitespace's performance. It's usually used either interactively or as a hook before saving the file, and in both cases I'd bet the time it takes is dwarfed by human reaction times or by the time spent saving the file to disk. J --001a113fc40aaaf5e9052311ee95 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Oct 27, 2015 at 9:25 AM, martin rudalics <rudalics@gmx.at> wrote:

&g= t; If it looks for whitespace followed by a line end and not
> for wh= itespace preceding a line end, the old version will be slow with
> in= dented code.

I don't think we've ever had = a bug report / complaint about delete-trailing-whitespace's performance= . It's usually used either interactively or as a hook before saving the= file, and in both cases I'd bet the time it takes is dwarfed by human = reaction times or by the time spent saving the file to disk.

= =C2=A0 =C2=A0 J
--001a113fc40aaaf5e9052311ee95-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 05:01:51 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 09:01:51 +0000 Received: from localhost ([127.0.0.1]:39957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr08c-0002KB-PM for submit@debbugs.gnu.org; Tue, 27 Oct 2015 05:01:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:48190) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr08b-0002K4-7K for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 05:01:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C967CAABB; Tue, 27 Oct 2015 09:01:48 +0000 (UTC) From: Andreas Schwab To: Juanma Barranquero Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: X-Yow: Look!! Karl Malden! Date: Tue, 27 Oct 2015 10:01:48 +0100 In-Reply-To: (Juanma Barranquero's message of "Tue, 27 Oct 2015 01:15:18 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Juanma Barranquero writes: > Apparently, the call to skip-syntax-backward is altering the match > data. No, skip-syntax-backward is safe. There must be something in line-beginning-position that does this, but only indirectly. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 05:17:11 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 09:17:12 +0000 Received: from localhost ([127.0.0.1]:40006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr0NT-0002iL-JH for submit@debbugs.gnu.org; Tue, 27 Oct 2015 05:17:11 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:33298) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr0NR-0002iC-UB for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 05:17:10 -0400 Received: by lbbec13 with SMTP id ec13so56629603lbb.0 for <21766@debbugs.gnu.org>; Tue, 27 Oct 2015 02:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=z9dbkZltjM2nOX+gVh5tQtU3nvs7qbE24DEoHZWRkWY=; b=ZrAZF3oMJWlhj5muLVvX31wzXfPknJXXY2Yr4BLka+qkaEjJXfYH1bBNq61ODkiKYZ PDNEYvLCljFODjBE5DdOXJF3wP0Syh70WE68e0iryiePVaLw47A0ZSugAQjFaSbVMM4i ChgMVFZQWWb3PierNyLshY01n7gD5LKXZzZnS7awzzQqDmj9wSliAxGeO+4ihprlJtRp Bsvgok0yjNioFIg63r0SojSSJ4lPLNYs4r9YjzoMKf7IuEmOH2BdTwwK6kHmAV7FcJKv Q3gg3eu8NLEBk5bjbbZckuJ0OhSUxOcAiwSS3iM8ijW6h/AG5blgDIm0EFPQXYyB1ZVT lKRw== X-Received: by 10.112.62.194 with SMTP id a2mr19627518lbs.80.1445937429064; Tue, 27 Oct 2015 02:17:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Tue, 27 Oct 2015 02:16:28 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 27 Oct 2015 10:16:28 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: Andreas Schwab Content-Type: multipart/alternative; boundary=001a11c3c46ed3b1c40523128ae4 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c3c46ed3b1c40523128ae4 Content-Type: text/plain; charset=UTF-8 On Tue, Oct 27, 2015 at 10:01 AM, Andreas Schwab wrote: > No, skip-syntax-backward is safe. There must be something in > line-beginning-position that does this, but only indirectly. (skip-syntax-backward "-" (save-match-data (line-beginning-position))) still shows the bug, while (save-match-data (skip-syntax-backward "-" (line-beginning-position))) fixes it. --001a11c3c46ed3b1c40523128ae4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Oct 27, 2015 at 10:01 AM, Andreas Schwab <schwab@suse.de> wrote:

>= No, skip-syntax-backward is safe.=C2=A0 There must be something in
>= line-beginning-position that does this, but only indirectly.

=
=C2=A0 (skip-syntax-backward "-"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (save-= match-data
(line-beginning-position)))

still shows the= bug, while=C2=A0

=C2=A0 (save-match-data
=C2=A0 =C2=A0 (skip-syntax-backward "-" (line-beginning-po= sition)))

fixes it.

--001a11c3c46ed3b1c40523128ae4-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 05:24:35 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 09:24:35 +0000 Received: from localhost ([127.0.0.1]:40010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr0Ud-0002sf-Eh for submit@debbugs.gnu.org; Tue, 27 Oct 2015 05:24:35 -0400 Received: from mout.gmx.net ([212.227.17.20]:50961) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr0Ub-0002sX-L2 for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 05:24:34 -0400 Received: from [178.190.19.40] ([178.190.19.40]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MCwbX-1ZhPqu2KG3-009ffq; Tue, 27 Oct 2015 10:24:31 +0100 Message-ID: <562F42CC.4010809@gmx.at> Date: Tue, 27 Oct 2015 10:24:28 +0100 From: martin rudalics MIME-Version: 1.0 To: Juanma Barranquero , Andreas Schwab Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:gp+jwUqKetNxWIGrusmBileZeByNUbvjJ9+36SE7XJC69Zy62Ml 2ecwS17NnLX+7FD8a2uxXjHP5837+xXa5hXxJjYNkSouiYJuxBUH3tQdSdSl9sofbB2uagm gkOFTfj5w82v9YlrsAFzepUIjtfTz2iTHKbEwfruT6/fybGk+S8cfvbcIojUjROD0zwNipv P8UiPPLy1d7Ypbkx7EJsg== X-UI-Out-Filterresults: notjunk:1;V01:K0:1qk4IQtw15Q=:bZfil0GYRxNN++/fj5roYo yZzo0quSXIAnDbpXt4w62zswV6WU9DWWi2SQrjjMIoYTSDQI4d5JwVrS1JKjDKOenoegNsnkA 7CndgTECINWrRFE57A4LGQUNLTuNMmqQmxHkiF2Wd3CJC1Y3BmHwHUIGutb0uIRmKwG975oyS vRwfkCQtS0Uf59FMCCdEesMFLNyt+AMQOS3z0JqHQaEZIMj6uwXS3w3MmQKr1SzYBCPGeA6x/ z6MLEs5yZiKQz9hIgBqDXbTFHUQDQjodDQsJ5vl3pc40BA7m/I/l1WbtchOkHIMNxbKapsens IBmk3QSkMQW4R7yguQlZ2VRlO3+sRZIZyxR+p01DaTJU/ewBa137d9ajsW7fKVoxz26vqRgjC MhYwDB/K9GCaEXh3KHHx8JbgTKLnY/GHAboIYpdzw1XHHJoq10mSSAGN6CwZKINoQSrm7AGDX 7wSGzJXyHAwd/r0sc3AHy9AiTQ3eVwzQtuUcQLudM79tY/+kMVjRFfKGNBR/VYB1lw1Pm9FJQ L8x7zfSLHammzoHcEoRnM65l9uZWCtYlgN0AJDRfhhlhsSsd3cG5d0FB2UPAfjIDTj7W0yXtq uCXzkqSyGrxGFJSdrH461qE06TqBBfehTaiTMXFIDKOPTrX5LwCthMDgZ182kQH//e4g7dez8 OW5WCDpAiMHP45S+02VagIHOyE5YJJFNyvCNsGESfk22wjISPxZni6HyZztFXsOhg2bgUSHyi LqaOjnuqe8csG1kRcq1YMgdj5z2mzticthr+HTh/wKxQA3pRMqlj12/u83TnZfyBrYCjkZwLy aM/JrRK X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> No, skip-syntax-backward is safe. There must be something in >> line-beginning-position that does this, but only indirectly. > > (skip-syntax-backward "-" > (save-match-data > (line-beginning-position))) > > still shows the bug, while > > (save-match-data > (skip-syntax-backward "-" (line-beginning-position))) > > fixes it. I doubt that =E2=80=98syntax-propertize=E2=80=99 is always safe. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 05:46:18 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 09:46:18 +0000 Received: from localhost ([127.0.0.1]:40015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr0pe-0003NN-DJ for submit@debbugs.gnu.org; Tue, 27 Oct 2015 05:46:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:52145) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr0pc-0003NF-Jo for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 05:46:17 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 75CF3AABB; Tue, 27 Oct 2015 09:46:16 +0000 (UTC) From: Andreas Schwab To: Juanma Barranquero Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: X-Yow: We have DIFFERENT amounts of HAIR -- Date: Tue, 27 Oct 2015 10:46:15 +0100 In-Reply-To: (Juanma Barranquero's message of "Tue, 27 Oct 2015 10:16:28 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Juanma Barranquero writes: > On Tue, Oct 27, 2015 at 10:01 AM, Andreas Schwab wrote: > >> No, skip-syntax-backward is safe. There must be something in >> line-beginning-position that does this, but only indirectly. > > (skip-syntax-backward "-" > (save-match-data > (line-beginning-position))) > > still shows the bug, while > > (save-match-data > (skip-syntax-backward "-" (line-beginning-position))) > > fixes it. Ok, I see it now, it is the new parse_sexp_propertize stuff which is called by SETUP_SYNTAX_TABLE. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 06:22:15 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 10:22:15 +0000 Received: from localhost ([127.0.0.1]:40022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr1OR-0004CG-Ea for submit@debbugs.gnu.org; Tue, 27 Oct 2015 06:22:15 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:33559) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr1O7-0004BX-7H for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 06:22:13 -0400 Received: by lbbec13 with SMTP id ec13so57835341lbb.0 for <21766@debbugs.gnu.org>; Tue, 27 Oct 2015 03:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=AFcErDl0+OcTDxJBAY+AOgJKNLXmL7fu8ecNvlqo8UY=; b=flfiAloXx5QldO+gtW9QKbyTc2OMTVpaK0QLyakd0rK50xJGFa7HJ74bP4/j7fdS+I Rb/IUOxS/hgE57JKCGef38C/Scn9uS8yyUlClUjVN61Y7H0Gyl2lu3glLnOow7jG2jaq YROhV66Eb1TyKxJmQKavYWSH1BwymjFCTP9OAV+Q8hZaPLcd1pJLzDToXErQdFF1EXGa SL41l2GQBZZoc4e1UsV+GQh4RYYtM8ravp0WwaQCjUD4UKgYaRw2+PNmrBeJG5KTaUy+ 4u64RQfr4mC/o38cTpgzMmPGVekfNVzT5+0Q3V+s7XxaBCLXWklvU1wIqFrQelG8Xmeg NjXQ== X-Received: by 10.112.17.34 with SMTP id l2mr20045782lbd.117.1445941314442; Tue, 27 Oct 2015 03:21:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Tue, 27 Oct 2015 03:21:14 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 27 Oct 2015 11:21:14 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: Andreas Schwab Content-Type: multipart/alternative; boundary=001a11c3c47c69dc31052313720a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c3c47c69dc31052313720a Content-Type: text/plain; charset=UTF-8 On Tue, Oct 27, 2015 at 10:46 AM, Andreas Schwab wrote: > Ok, I see it now, it is the new parse_sexp_propertize stuff which is > called by SETUP_SYNTAX_TABLE. Then, can I assume this is not a bug in skip-syntax-backward or parse_sexp_propetize, and fix delete-trailing-whitespace? --001a11c3c47c69dc31052313720a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Oct 27, 2015 at 10:46 AM, Andreas Schwab <schwab@suse.de> wrote:

>= Ok, I see it now, it is the new parse_sexp_propertize stuff which is
&g= t; called by SETUP_SYNTAX_TABLE.

Then, can I assume this = is not a bug in skip-syntax-backward or parse_sexp_propetize, and fix delet= e-trailing-whitespace?

--001a11c3c47c69dc31052313720a-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 10:01:19 2015 Received: (at control) by debbugs.gnu.org; 27 Oct 2015 14:01:19 +0000 Received: from localhost ([127.0.0.1]:40672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr4oR-00045h-0Z for submit@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60862) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr4oL-00045W-Pn for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr4oG-00051P-2F for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr4oG-00051J-0C for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:08 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Zr4oF-0000Kq-EI for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:07 -0400 Subject: control message for bug 21769 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 27 Oct 2015 10:01:07 -0400 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 21766 21769 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 10:01:53 2015 Received: (at control) by debbugs.gnu.org; 27 Oct 2015 14:01:54 +0000 Received: from localhost ([127.0.0.1]:40677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr4oc-00046T-D6 for submit@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60920) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr4oV-000461-OL for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr4oN-00053r-SF for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr4oN-00053l-Q3 for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:15 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Zr4oN-0000Uj-EI for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:15 -0400 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 27 Oct 2015 10:01:15 -0400 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 21766 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 10:01:59 2015 Received: (at control) by debbugs.gnu.org; 27 Oct 2015 14:01:59 +0000 Received: from localhost ([127.0.0.1]:40681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr4oz-00047Y-Uf for submit@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:59 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:35112) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr4oY-000463-0e for control@debbugs.gnu.org; Tue, 27 Oct 2015 10:01:33 -0400 Received: by lbbes7 with SMTP id es7so64315722lbb.2 for ; Tue, 27 Oct 2015 07:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=h3afDb3uVnxhJcmVtK5unwIuvx431WO2qJczC9cvbXU=; b=RsM6mpdV8lape7XbgOCzSZrv2SGcE9hyAdortlbwg0faXMxAcq7PXSemuDOvwc2Ccq H8WjLh3AOodgmM1IIVg3ySURrVDb6MNDwQt14MCT9jAIi70TARjVwb65/O0nW5NzFTAU xo2f0xa2wfOpaeRsGIix0nf1dAHQ+n1LIiqYfAu/4qWz+Go8BxNO+mFc7VlC544xJZiu UF1W/Wfewz8dLQxJOyvhklz+v4ywunQD4ojNF3G4wiFRG5XHXLruHfgWd7kXOtBt3kAl 2Z63iAItk/DQcYvdvOtxMseAczXPgdsF8FqlIa1Smwye1QUvJzX2/M3wmuRAmCHovQJ3 kncA== X-Received: by 10.112.234.163 with SMTP id uf3mr20162682lbc.15.1445954484682; Tue, 27 Oct 2015 07:01:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Tue, 27 Oct 2015 07:00:45 -0700 (PDT) In-Reply-To: <87r3kgft31.fsf@muse-amuse.in> References: <87r3kgft31.fsf@muse-amuse.in> From: Juanma Barranquero Date: Tue, 27 Oct 2015 15:00:45 +0100 Message-ID: Subject: Re: bug#21769: 25.0.50; delete-trailing-whitespace gobbles up text. To: Puneeth Chaganti Content-Type: multipart/alternative; boundary=001a11c317e86bc50c0523168352 Bcc: control@debbugs.gnu.org X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: 21769@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c317e86bc50c0523168352 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable merge 21766 21769 quit =E2=80=8B Yes, the bug was just filed as #21766 and we're working on it. Thanks for your test case, which is *much* shorter than the one in bug#21766. --001a11c317e86bc50c0523168352 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
merge 21766 21769
quit
=E2=80=8B

Yes, the bug was just filed as #21766 and we're working on it.
=

Thanks for your test case, which is *much* shorter than= the one in bug#21766.

--001a11c317e86bc50c0523168352-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 12:04:03 2015 Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 16:04:03 +0000 Received: from localhost ([127.0.0.1]:40728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr6jD-00006P-9Q for submit@debbugs.gnu.org; Tue, 27 Oct 2015 12:04:03 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:33246) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zr6jB-000066-OX for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 12:04:02 -0400 Received: by lffv3 with SMTP id v3so174711794lff.0 for <21766@debbugs.gnu.org>; Tue, 27 Oct 2015 09:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wibNc1nx5q6ZJj0i1hdxhls3r5snn4VLGTTLWYisdlY=; b=XuClHIv8otHUA9NQRgISo4UQYBZPQcAJCjdk0oVggEuAqRRC4PPCIuxLfg+ZGQmVvi MQx4HUelCtQLfRRRoAHURBxaZkwnqMGgIdsmafN0Waf6h0q6p7BwU1X/sgs/9hEMsAgA 5yuw9Awjgf6I4q7HzOMcUPEbNwvK+Lg6BZnJATDQC95NVbOLidaC3b9G/w/wswVyVZgS zRKksX6rgVwIQUa0yuVMbM/sU7zw4/wXDkzwTHmri0Dhr/HoKyVr4AIjh1zt+D6kRjsT 83p30kbMpfldWA37P1yawDRawdihKEBGFSKoPUbeH/QjG4liev6YO4Ug28iYNVMyV4Rh SqRw== X-Received: by 10.25.135.136 with SMTP id j130mr1634239lfd.95.1445961840662; Tue, 27 Oct 2015 09:04:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Tue, 27 Oct 2015 09:03:20 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 27 Oct 2015 17:03:20 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: Andreas Schwab Content-Type: multipart/mixed; boundary=001a113fc40adf749205231839e6 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org, Markus Triska , Emacs developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113fc40adf749205231839e6 Content-Type: multipart/alternative; boundary=001a113fc40adf748c05231839e4 --001a113fc40adf748c05231839e4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable This will be my first ERT test, so, does the following (attached, because Gmail) patch look acceptable? And, it is possible to commit a file with trailing whitespace? =E2=80=8B --001a113fc40adf748c05231839e4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
This will be my first ERT test, so, does the following (at= tached, because Gmail) patch look acceptable?=C2=A0

And,= it is possible to commit a file with trailing whitespace?
=E2=80=8B
--001a113fc40adf748c05231839e4-- --001a113fc40adf749205231839e6 Content-Type: application/octet-stream; name="bug-21766.patch" Content-Disposition: attachment; filename="bug-21766.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ig9kb7x90 ZGlmZiAtLWdpdCBjL2xpc3Avc2ltcGxlLmVsIGkvbGlzcC9zaW1wbGUuZWwKaW5kZXggMzM4YTA2 MC4uZjZjNTgwZiAxMDA2NDQKLS0tIGMvbGlzcC9zaW1wbGUuZWwKKysrIGkvbGlzcC9zaW1wbGUu ZWwKQEAgLTYwOSw3ICs2MDksOCBAQCBkZWxldGUtdHJhaWxpbmctd2hpdGVzcGFjZQogICAgICAg ICAgICAgKHN0YXJ0IChvciBzdGFydCAocG9pbnQtbWluKSkpKQogICAgICAgICAoZ290by1jaGFy IHN0YXJ0KQogICAgICAgICAod2hpbGUgKHJlLXNlYXJjaC1mb3J3YXJkICJcXHMtJCIgZW5kLW1h cmtlciB0KQotICAgICAgICAgIChza2lwLXN5bnRheC1iYWNrd2FyZCAiLSIgKGxpbmUtYmVnaW5u aW5nLXBvc2l0aW9uKSkKKyAgICAgICAgICAoc2F2ZS1tYXRjaC1kYXRhCisgICAgICAgICAgICAo c2tpcC1zeW50YXgtYmFja3dhcmQgIi0iIChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikpKQogICAg ICAgICAgIDs7IERvbid0IGRlbGV0ZSBmb3JtZmVlZHMsIGV2ZW4gaWYgdGhleSBhcmUgY29uc2lk ZXJlZCB3aGl0ZXNwYWNlLgogICAgICAgICAgIChpZiAobG9va2luZy1hdC1wICIuKlxmIikKICAg ICAgICAgICAgICAgKGdvdG8tY2hhciAobWF0Y2gtZW5kIDApKSkKZGlmZiAtLWdpdCBjL3Rlc3Qv YXV0b21hdGVkL2RhdGEvc2ltcGxlL2J1Zy0yMTc2Ni5weSBpL3Rlc3QvYXV0b21hdGVkL2RhdGEv c2ltcGxlL2J1Zy0yMTc2Ni5weQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4x MTg3MTlhCi0tLSAvZGV2L251bGwKKysrIGkvdGVzdC9hdXRvbWF0ZWQvZGF0YS9zaW1wbGUvYnVn LTIxNzY2LnB5CkBAIC0wLDAgKzEsNCBAQAorcXVlcnkgPSAiIiJXSVRIIGZpbHRlcmVkIEFTIA0K K1dIRVJFICAgICAgDQorIiIiLmZvcm1hdChmdl8pDQorDQpkaWZmIC0tZ2l0IGMvdGVzdC9hdXRv bWF0ZWQvc2ltcGxlLXRlc3QuZWwgaS90ZXN0L2F1dG9tYXRlZC9zaW1wbGUtdGVzdC5lbAppbmRl eCA4ZGE1NzVkLi42MmZlMTdjIDEwMDY0NAotLS0gYy90ZXN0L2F1dG9tYXRlZC9zaW1wbGUtdGVz dC5lbAorKysgaS90ZXN0L2F1dG9tYXRlZC9zaW1wbGUtdGVzdC5lbApAQCAtMjEsNiArMjEsMTAg QEAKIAogKHJlcXVpcmUgJ2VydCkKIAorKGRlZnZhciBzaW1wbGUtdGVzdHMtZGF0YS1kaXJlY3Rv cnkKKyAgKGV4cGFuZC1maWxlLW5hbWUgImRhdGEvc2ltcGxlIiAoZ2V0ZW52ICJFTUFDU19URVNU X0RJUkVDVE9SWSIpKQorICAiRGlyZWN0b3J5IGNvbnRhaW5pbmcgc2ltcGxlLmVsIHRlc3QgZGF0 YS4iKQorCiAoZGVmbWFjcm8gc2ltcGxlLXRlc3QtLWR1bW15LWJ1ZmZlciAoJnJlc3QgYm9keSkK ICAgKGRlY2xhcmUgKGluZGVudCAwKQogICAgICAgICAgICAoZGVidWcgdCkpCkBAIC0xODAsNSAr MTg0LDIzIEBAIHNpbXBsZS10ZXN0LS1kdW1teS1idWZmZXIKICAgICAgICAgICAoc2hvdWxkICg9 IHggMikpKQogICAgICAgKHJlbW92ZS1ob29rICdwb3N0LXNlbGYtaW5zZXJ0LWhvb2sgaW5jKSkp KQogCisMCis7OzsgYGRlbGV0ZS10cmFpbGluZy13aGl0ZXNwYWNlJworKGVydC1kZWZ0ZXN0IHNp bXBsZS1kZWxldGUtdHJhaWxpbmctd2hpdGVzcGFjZSAoKQorICAoZGVmdmFyIHB5dGhvbi1pbmRl bnQtZ3Vlc3MtaW5kZW50LW9mZnNldCkgIDsgdG8gYXZvaWQgYSB3YXJuaW5nCisgIChsZXQgKChw eXRob24gKGZlYXR1cmVwICdweXRob24pKQorICAgICAgICAocHl0aG9uLWluZGVudC1ndWVzcy1p bmRlbnQtb2Zmc2V0IG5pbCkKKyAgICAgICAgKGRlbGV0ZS10cmFpbGluZy1saW5lcyB0KSkKKyAg ICAodW53aW5kLXByb3RlY3QKKyAgICAgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgICAo cHl0aG9uLW1vZGUpCisgICAgICAgICAgKGluc2VydC1maWxlLWNvbnRlbnRzIChleHBhbmQtZmls ZS1uYW1lICJidWctMjE3NjYucHkiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHNpbXBsZS10ZXN0cy1kYXRhLWRpcmVjdG9yeSkpCisgICAgICAgICAg KGRlbGV0ZS10cmFpbGluZy13aGl0ZXNwYWNlKQorICAgICAgICAgIChzaG91bGQgKGVxdWFsIChj b3VudC1saW5lcyAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkgMykpKQorICAgICAgOzsgTGV0J3Mg Y2xlYW4gdXAgaWYgcnVubmluZyBpbnRlcmFjdGl2ZQorICAgICAgKHVubGVzcyAob3Igbm9uaW50 ZXJhY3RpdmUgcHl0aG9uKQorICAgICAgICAodW5sb2FkLWZlYXR1cmUgJ3B5dGhvbikpKSkpCisK IChwcm92aWRlICdzaW1wbGUtdGVzdCkKIDs7OyBzaW1wbGUtdGVzdC5lbCBlbmRzIGhlcmUK --001a113fc40adf749205231839e6-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 21:52:08 2015 Received: (at 21766) by debbugs.gnu.org; 28 Oct 2015 01:52:08 +0000 Received: from localhost ([127.0.0.1]:41003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrFuK-0001wq-I6 for submit@debbugs.gnu.org; Tue, 27 Oct 2015 21:52:08 -0400 Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:36195) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1ZrFuH-0001wh-Gg for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 21:52:06 -0400 Received: (qmail 2066 invoked by uid 0); 28 Oct 2015 01:51:59 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy1.mail.unifiedlayer.com with SMTP; 28 Oct 2015 01:51:59 -0000 Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw3 with id aXrl1r00s2UdiVW01XroVm; Wed, 28 Oct 2015 01:51:58 -0600 X-Authority-Analysis: v=2.1 cv=Zs1+dbLG c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=5lJygRwiOn0A:10 a=pGLkceISAAAA:8 a=Ix5xV5TN6PjERupaXpEA:9 Received: from [76.218.37.33] (port=58835 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1ZrFtz-0006KM-DV; Tue, 27 Oct 2015 19:51:47 -0600 From: Stephen Leake To: Juanma Barranquero Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: Date: Tue, 27 Oct 2015 20:51:42 -0500 In-Reply-To: (Juanma Barranquero's message of "Tue, 27 Oct 2015 17:03:20 +0100") Message-ID: <86wpu77ob5.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 21766 Cc: Andreas Schwab , Emacs developers , Markus Triska , 21766@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Juanma Barranquero writes: > This will be my first ERT test, so, does the following (attached, because > Gmail) patch look acceptable? Looks good to me, except see below. > And, it is possible to commit a file with trailing whitespace? Yes, but it's also very easy to lose it, thus breaking the test. I suggest instead to save the file without extra whitespace, and add code to the test to insert the extra whitespace. That way you can also add comments about why this test exists, etc. -- -- Stephe From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 05:09:17 2015 Received: (at 21766) by debbugs.gnu.org; 28 Oct 2015 09:09:17 +0000 Received: from localhost ([127.0.0.1]:41175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrMjM-0005bt-CW for submit@debbugs.gnu.org; Wed, 28 Oct 2015 05:09:17 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:36546) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrMj1-0005ao-17 for 21766@debbugs.gnu.org; Wed, 28 Oct 2015 05:09:13 -0400 Received: by lbjm5 with SMTP id m5so784908lbj.3 for <21766@debbugs.gnu.org>; Wed, 28 Oct 2015 02:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wKz60Wo81gsCOboHau1FviIQm0yHVUnADmQjf5eCD0E=; b=tdQqgDCq396dCUEQ+da/f6YlVJ1SdQCVpWCUgsnGe9tbhRVIkg/BZ5E8v3VzzRc6OZ v5qZfeMnksuBYj0XQxBD/2Y2oKQr96dBbjwekfE5+2tG8MCdMKLV/I/b+tqEce5DjYIQ BXMy9oJGMatm8c1SHnWOAFoF8vMGU6qGnal3aP08lgt879/lpWrStEH6ocNZBFL/7lub aEj1+1ML1QvqE9TnzmX9K3MjYImBkgcA321u9yDSMuVkDJa8wZvGXLIi0ndGBta9Yzfh o4QbmfSRGl35WzlipcAiYROxVsPgfetT6Nw0AXmpzUlTiifMummZ5Q+t9+mcTuAZ+ldY yMsA== X-Received: by 10.112.62.194 with SMTP id a2mr22864137lbs.80.1446023334208; Wed, 28 Oct 2015 02:08:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Wed, 28 Oct 2015 02:08:14 -0700 (PDT) In-Reply-To: <86wpu77ob5.fsf@stephe-leake.org> References: <86wpu77ob5.fsf@stephe-leake.org> From: Juanma Barranquero Date: Wed, 28 Oct 2015 10:08:14 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: Stephen Leake Content-Type: multipart/alternative; boundary=001a11c3c46e2c2c9e0523268bb8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: Andreas Schwab , Emacs developers , Markus Triska , 21766@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c3c46e2c2c9e0523268bb8 Content-Type: text/plain; charset=UTF-8 On Wed, Oct 28, 2015 at 2:51 AM, Stephen Leake < stephen_leake@stephe-leake.org> wrote: > I suggest instead to save the file without extra whitespace, and add code > to the test to insert the extra whitespace. The file is quite short, so in this case is better to get rid of it and just insert its contents into the buffer. Thanks, Juanma Fix bug#21766 and add test. * lisp/simple.el (delete-trailing-whitespace): Save match data when calling `skip-syntax-backward'. * test/automated/simple-test.el (simple-delete-trailing-whitespace): New test. diff --git a/lisp/simple.el b/lisp/simple.el index 338a060..f6c580f 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -609,7 +609,8 @@ delete-trailing-whitespace (start (or start (point-min)))) (goto-char start) (while (re-search-forward "\\s-$" end-marker t) - (skip-syntax-backward "-" (line-beginning-position)) + (save-match-data + (skip-syntax-backward "-" (line-beginning-position))) ;; Don't delete formfeeds, even if they are considered whitespace. (if (looking-at-p ".*\f") (goto-char (match-end 0))) diff --git a/test/automated/simple-test.el b/test/automated/simple-test.el index 8da575d..5bfb746 100644 --- a/test/automated/simple-test.el +++ b/test/automated/simple-test.el @@ -180,5 +180,27 @@ simple-test--dummy-buffer (should (= x 2))) (remove-hook 'post-self-insert-hook inc)))) + +;;; `delete-trailing-whitespace' +(ert-deftest simple-delete-trailing-whitespace () + "Test bug#21766: delete-whitespace sometimes deletes non-whitespace." + (defvar python-indent-guess-indent-offset) ; to avoid a warning + (let ((python (featurep 'python)) + (python-indent-guess-indent-offset nil) + (delete-trailing-lines t)) + (unwind-protect + (with-temp-buffer + (python-mode) + (insert (concat "query = \"\"\"WITH filtered AS \n" + "WHERE \n" + "\"\"\".format(fv_)\n" + "\n" + "\n")) + (delete-trailing-whitespace) + (should (equal (count-lines (point-min) (point-max)) 3))) + ;; Let's clean up if running interactive + (unless (or noninteractive python) + (unload-feature 'python))))) + (provide 'simple-test) ;;; simple-test.el ends here -- 2.6.2.windows.1 --001a11c3c46e2c2c9e0523268bb8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Oct 28, 2015 at 2:51 AM, Stephen Leake <stephen_leake@= stephe-leake.org> wrote:

> I=C2=A0suggest instead to = save the file without extra whitespace, and add code
> to the test to= insert the extra whitespace.

The file is quite sh= ort, so in this case is better to get rid of it and just insert its content= s into the buffer.

Thanks,

=C2=A0 =C2=A0 =C2=A0Juanma



=C2=A0 =C2=A0 =C2=A0 =C2=A0 Fix bug#21766 and add test.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 * lisp/simple.el (delet= e-trailing-whitespace): Save match data when
=C2=A0 =C2=A0 =C2=A0= =C2=A0 calling `skip-syntax-backward'.
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 * test/automated/simple-test.el (simple-delete-trailing-whitespace):=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 New test.

<= br>
diff --git a/lisp/simple.el b/lisp/simple.el
index = 338a060..f6c580f 100644
--- a/lisp/simple.el
+++ b/lisp= /simple.el
@@ -609,7 +609,8 @@ delete-trailing-whitespace
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(start (or start (point-= min))))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(goto-char start)
=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(while (re-search-forward "\\s-= $" end-marker t)
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(skip-s= yntax-backward "-" (line-beginning-position))
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(save-match-data
+ =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(skip-syntax-backward "-" (line-beginning= -position)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Don'= t delete formfeeds, even if they are considered whitespace.
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (looking-at-p ".*\f")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(goto-char = (match-end 0)))
diff --git a/test/automated/simple-test.el b/test= /automated/simple-test.el
index 8da575d..5bfb746 100644
--- a/test/automated/simple-test.el
+++ b/test/automated/simple-= test.el
@@ -180,5 +180,27 @@ simple-test--dummy-buffer
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(should (=3D x 2)))
=C2= =A0 =C2=A0 =C2=A0 =C2=A0(remove-hook 'post-self-insert-hook inc))))
=C2=A0
+=0C
+;;; `delete-trailing-whitespace'= ;
+(ert-deftest simple-delete-trailing-whitespace ()
+ = =C2=A0"Test bug#21766: delete-whitespace sometimes deletes non-whitesp= ace."
+ =C2=A0(defvar python-indent-guess-indent-offset) =C2= =A0; to avoid a warning
+ =C2=A0(let ((python (featurep 'pyth= on))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(python-indent-guess-indent-off= set nil)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete-trailing-lines t))<= /div>
+ =C2=A0 =C2=A0(unwind-protect
+ =C2=A0 =C2=A0 =C2=A0 = =C2=A0(with-temp-buffer
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pyth= on-mode)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(insert (concat &quo= t;query =3D \"\"\"WITH filtered AS \n"
+ =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0"WHERE =C2=A0 =C2=A0 =C2=A0\n"
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0"\"\"\".format(fv_)\n"
+ =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0"\n"
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"\n"))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete-trailing-whitespace)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(should (equal (count-lines (poi= nt-min) (point-max)) 3)))
+ =C2=A0 =C2=A0 =C2=A0;; Let's clea= n up if running interactive
+ =C2=A0 =C2=A0 =C2=A0(unless (or non= interactive python)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(unload-feature = 'python)))))
+
=C2=A0(provide 'simple-test)
=C2=A0;;; simple-test.el ends here
--=C2=A0
2.6.= 2.windows.1

--001a11c3c46e2c2c9e0523268bb8-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 13:38:49 2015 Received: (at 21766-done) by debbugs.gnu.org; 28 Oct 2015 17:38:49 +0000 Received: from localhost ([127.0.0.1]:42785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrUgT-000880-0v for submit@debbugs.gnu.org; Wed, 28 Oct 2015 13:38:49 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:35911) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrUgR-00087s-CA for 21766-done@debbugs.gnu.org; Wed, 28 Oct 2015 13:38:47 -0400 Received: by lffz202 with SMTP id z202so7340705lff.3 for <21766-done@debbugs.gnu.org>; Wed, 28 Oct 2015 10:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=7wl5wkQbh3fY2lIzzRtSgZnl9x2XqYsX2vs/fLqlnms=; b=0MdfJdU1txJynLyR1ojqAtBl975xzTXI4hg/dVqokey12PKEUoF/bQ/o1H8rc+GOlB Qm4CqN8jtcVaa7N1X8eIOynxEV/6YfxMFaYnUB+bdPGnNBeson+geBlHPFs6iI0yENM6 TQ77J5OUNFj6J6nunDagR3WKedEmH/bTmjoWWZFjRejmpe8N5fDvQdjZ/ocXhos28lLk TjCKKDMQ6RthV/Kc+1lIg94H8nWPzTuxyZRvMUNjoUwYzQfNFi5hI65wBZP6iBiK+3dc sKOswGCjEEC4F3cblExqfOkiMEqC1fgEAoO/nVIaAXlgaJHj9RDYrYk4lheI2IPwQtaP CpCQ== X-Received: by 10.25.167.2 with SMTP id q2mr7160459lfe.15.1446053926608; Wed, 28 Oct 2015 10:38:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Wed, 28 Oct 2015 10:38:07 -0700 (PDT) In-Reply-To: References: <86wpu77ob5.fsf@stephe-leake.org> From: Juanma Barranquero Date: Wed, 28 Oct 2015 18:38:07 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: Stephen Leake Content-Type: multipart/alternative; boundary=001a113fbdc69f26b505232daa0e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766-done Cc: Andreas Schwab , 21766-done@debbugs.gnu.org, Markus Triska X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113fbdc69f26b505232daa0e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Fixed in commit 1f02cbea8b489ed7676110431aa36ad5abc47d9b =E2=80=8B --001a113fbdc69f26b505232daa0e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Fixed in commit=C2=A01f02cbea8b489ed7676110431= aa36ad5abc47d9b
=E2=80=8B
--001a113fbdc69f26b505232daa0e-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 15:20:01 2015 Received: (at 21766) by debbugs.gnu.org; 28 Oct 2015 19:20:02 +0000 Received: from localhost ([127.0.0.1]:42861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrWGO-0003cH-UT for submit@debbugs.gnu.org; Wed, 28 Oct 2015 15:20:01 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:11216) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrWGM-0003c7-TT for 21766@debbugs.gnu.org; Wed, 28 Oct 2015 15:19:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CXDQA731xV/zCdWxdcgxCEAsEVhH6CTQQCAoE8OhMBAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQEEAQEBAR6LOoUFB4QtBbUEI4I7gVkigngBAQE X-IPAS-Result: A0CXDQA731xV/zCdWxdcgxCEAsEVhH6CTQQCAoE8OhMBAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQEEAQEBAR6LOoUFB4QtBbUEI4I7gVkigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="171887978" Received: from 23-91-157-48.cpe.pppoe.ca (HELO pastel.home) ([23.91.157.48]) by ironport2-out.teksavvy.com with ESMTP; 28 Oct 2015 15:19:57 -0400 Received: by pastel.home (Postfix, from userid 20848) id 0BA6060005; Wed, 28 Oct 2015 15:19:58 -0400 (EDT) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace Message-ID: References: Date: Wed, 28 Oct 2015 15:19:58 -0400 In-Reply-To: (Andreas Schwab's message of "Tue, 27 Oct 2015 10:46:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21766 Cc: Juanma Barranquero , Markus Triska , 21766@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> (save-match-data >> (skip-syntax-backward "-" (line-beginning-position))) [...] > Ok, I see it now, it is the new parse_sexp_propertize stuff which is > called by SETUP_SYNTAX_TABLE. Indeed, internal--syntax-propertize needs to be fixed so it preserves the match-data! Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 02:30:20 2015 Received: (at submit) by debbugs.gnu.org; 29 Oct 2015 06:30:20 +0000 Received: from localhost ([127.0.0.1]:43128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zrgj5-0004Ch-83 for submit@debbugs.gnu.org; Thu, 29 Oct 2015 02:30:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42488) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zrgil-0004An-1h for submit@debbugs.gnu.org; Thu, 29 Oct 2015 02:30:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zrgik-0006I5-3m for submit@debbugs.gnu.org; Thu, 29 Oct 2015 02:29:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zrgik-0006I1-0L for submit@debbugs.gnu.org; Thu, 29 Oct 2015 02:29:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zrgij-000343-5c for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2015 02:29:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zrgig-0006HP-0E for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2015 02:29:57 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:64244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zrgif-0006H6-Ml for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2015 02:29:53 -0400 Received: from [192.168.178.31] ([77.12.74.197]) by mrelayeu.kundenserver.de (mreue001) with ESMTPSA (Nemesis) id 0LyNF8-1aWoPp3hck-015qXI for ; Thu, 29 Oct 2015 07:29:51 +0100 Message-ID: <5631BCF7.2050003@easy-emacs.de> Date: Thu, 29 Oct 2015 07:30:15 +0100 From: =?ISO-8859-1?Q?Andreas_R=F6hler?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:wGIU9TKoh3PuLH9M9ln8hn5KpGD+uw1t0D6rQwiR3NJp1x3qBMr Srt13oekja5yMbI25VTvqNEBDU9FE3H2PAmPl23p2mxAOVS6sSFdd0RVUDAR4vu4LiCM6jM C3n0hFdnl8ohJEKkJczhZVJbCuI0JQPOHK8KOy75+RgLD2gWQTBMPcV3b/54E1zCHxRVAaY cH6JRrEcO9YpNfunR56kw== X-UI-Out-Filterresults: notjunk:1;V01:K0:eJ8yr3grtCQ=:5NTTrx7X+TLqsjzE4QaarT RHXzB8WZ+/4hIaIhpbesFOjzjhRDZxMAduxGL1yLu44qqfXF+FV+PQ3H1A3rS+Pj+lVau47e4 2TO/mg1BEOV6EsMSFpuV9VMqqqR6Ofg/3trLwJDIlwMxzTejn+HWUK2F6zxH5LpFxOnltMonO BGhr8FvNv0BkUE/1urmXbz5hnSYZCbcfOhxRGzudozVTKbZsh3JwN5Mc2tj0RcnurEpMUn9P+ R/lhq/o0+3kcWB0TUOwfVy2O357y5fG2Q8nvE4iWXP8jibWUciNJRguh3a2hAMgmsceUWrfW7 +x8yIsqUpfpaYsISSVSkreoikNxkAhyCRVA/tQyFrt6m5wtafEV/Uo5yfrhIFE2lgvrGXBzNN 7W0uqA4BMLq8TKMsDyiSMHqGdS9iXzApLi+a0LhAMk9zPDvCTX5pyz6A1RqlTNO3dAi0RjzJ+ lxutGMNiN7xBbPj71G46m3zNgZEXZtAnaodBKak6KyKmNk8Q7DeDvfTLAtdmwHtIjzShkkCmo IwzptZdxFrYDKN1ULG4kKL7y/p2ERgsn7XPOWurpVciYSfWrKW8BGwkQRnA3mNnR5PnZ6P1bN m/AZRauUedZU+fqjHp3tk6hjLZk3FzWRToT9RJznxg/vs+JDuginSPGSka5+Oij4K5Xg/Y7F/ X3UyWRzBOATf1iUCyYM4F+azjxl/8B7o4QFek+PNy/2a6l7dUsQOZ0mc2i7mnCzeANptnbVCI T7ISZ6vNqqHAgb+o X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 28.10.2015 20:19, Stefan Monnier wrote: >>> (save-match-data >>> (skip-syntax-backward "-" (line-beginning-position))) > [...] >> Ok, I see it now, it is the new parse_sexp_propertize stuff which is >> called by SETUP_SYNTAX_TABLE. > Indeed, internal--syntax-propertize needs to be fixed so it preserves > the match-data! > > > Stefan > > > > > When internal--syntax-propertize is fixed, the current fix will be useless, i.e. redundant. Is there a task-keeper for this scenario? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 05:42:13 2015 Received: (at 21766) by debbugs.gnu.org; 29 Oct 2015 09:42:13 +0000 Received: from localhost ([127.0.0.1]:43235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zrjim-0000D8-Vb for submit@debbugs.gnu.org; Thu, 29 Oct 2015 05:42:13 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:35032) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrjiT-0000CP-1T for 21766@debbugs.gnu.org; Thu, 29 Oct 2015 05:42:11 -0400 Received: by lbbes7 with SMTP id es7so24199898lbb.2 for <21766@debbugs.gnu.org>; Thu, 29 Oct 2015 02:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wsNE1yMdnWikPVFK9tTkguIneCIaeOoLExS1FHbGugA=; b=qqglotA3L78KR/dT7xr5UU3DUjrjJI5Cy39WWMXCVAPUeTiDip0HmbRXOu/TKkT10Q aBFgre9GFtDALOLC/gikjOmm846yzsCRoXLECUFuJsKfRLPWp1T8nOXz8d0xAu6HQkZK hecvQSieDYpASS4QgWEQWndtbTRkeduLdEpQR95foQxfx8DaNi8O1JfmcLtrYBXsMW7O Hc0rwfVJfqlSNixUD4ysSpe2a8lOArRashXEi5WZGBNVhO4UT9bGsg0BxHc2ve9m8yGs wFZ+L7TBtZHlqtKMJOnITYCvd6CLbgAoo7FixbozlizaVE+rmOx2ELacp4NPnbQ6Wtcv t4gQ== X-Received: by 10.112.61.226 with SMTP id t2mr417054lbr.11.1446111711902; Thu, 29 Oct 2015 02:41:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.217.135 with HTTP; Thu, 29 Oct 2015 02:41:12 -0700 (PDT) In-Reply-To: <5631BCF7.2050003@easy-emacs.de> References: <5631BCF7.2050003@easy-emacs.de> From: Juanma Barranquero Date: Thu, 29 Oct 2015 10:41:12 +0100 Message-ID: Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace To: =?UTF-8?Q?Andreas_R=C3=B6hler?= Content-Type: multipart/alternative; boundary=001a11c3eebce4c25705233b1e10 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21766 Cc: 21766@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c3eebce4c25705233b1e10 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Oct 29, 2015 at 7:30 AM, Andreas R=C3=B6hler < andreas.roehler@easy-emacs.de> wrote: > When internal--syntax-propertize is fixed, the current fix will be useless, i.e. redundant. Stefan already reverted the fix to delete-trailing-whitespace and fixed internal--syntax-propertize in d7a67c5a2fe63b6f087d6cae24c8f3b3c09eb57a --001a11c3eebce4c25705233b1e10 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Thu, Oct 29, 2015 at 7:30 AM, Andreas R=C3=B6hler <<= a href=3D"mailto:andreas.roehler@easy-emacs.de">andreas.roehler@easy-emacs.= de> wrote:

> When internal--syntax-propertize is fixe= d, the current fix will be useless, i.e. redundant.

Stefa= n already reverted the fix to delete-trailing-whitespace and fixed internal= --syntax-propertize in d7a67c5a2fe63b6f087d6cae24c8f3b3c09eb57a
<= br>

--001a11c3eebce4c25705233b1e10-- From unknown Sun Jun 22 00:52:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 26 Nov 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator