From unknown Sat Jun 21 12:30:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21751: 24.5; Undesirable sh-mode indent Resent-From: Bob Proulx Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Oct 2015 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21751 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21751@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144571355022757 (code B ref -1); Sat, 24 Oct 2015 19:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Oct 2015 19:05:50 +0000 Received: from localhost ([127.0.0.1]:37070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zq48T-0005uy-0i for submit@debbugs.gnu.org; Sat, 24 Oct 2015 15:05:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35398) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zq48P-0005uo-Rj for submit@debbugs.gnu.org; Sat, 24 Oct 2015 15:05:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zq48O-0000Oz-4r for submit@debbugs.gnu.org; Sat, 24 Oct 2015 15:05:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq48O-0000Op-2p for submit@debbugs.gnu.org; Sat, 24 Oct 2015 15:05:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq48M-0002ma-29 for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2015 15:05:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zq48G-0000Lr-Ts for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2015 15:05:41 -0400 Received: from joseki.proulx.com ([216.17.153.58]:56298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq48G-0000Lf-DJ for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2015 15:05:36 -0400 Received: from hysteria.proulx.com (hysteria.proulx.com [192.168.230.119]) by joseki.proulx.com (Postfix) with ESMTP id 7713E21232 for ; Sat, 24 Oct 2015 13:05:35 -0600 (MDT) Received: by hysteria.proulx.com (Postfix, from userid 1000) id 2A1B72DC52; Sat, 24 Oct 2015 13:05:33 -0600 (MDT) From: Bob Proulx Date: Sat, 24 Oct 2015 13:04:55 -0600 Message-ID: <87y4esm6js.fsf@hysteria.proulx.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) In 24.5.1 from Debian Sid I am now getting an undesirable indent that is no longer controlled by sh-basic-offset. In 23 this worked. emacs -Q /tmp/trial.sh M-: (setq sh-basic-offset 2) if true; then true ^ indent should be 2 not 4 here C-c ? Rules used: :elem basic -> 4, :before "then" -> 0, :after "then" -> nil Anyone know what is happening here? I have reviewed the NEWS and the latest manual but I didn't find any intentionally noted changes. Thanks, Bob In GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2015-09-19 on trouble, modified by Debian System Description: Debian GNU/Linux unstable (sid) Configured using: `configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.5/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.5/site-lisp:/usr/share/emacs/site-lisp --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.5/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.5/site-lisp:/usr/share/emacs/site-lisp --with-x=yes --with-x-toolkit=lucid --with-toolkit-scroll-bars --without-gconf --without-gsettings 'CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-z,relro' Important settings: value of $LC_COLLATE: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Recent messages: Loading /etc/emacs/site-start.d/51debian-el.el (source)...done Loading /etc/emacs/site-start.d/51planner-el.el (source)... Loading /usr/share/emacs24/site-lisp/planner-el/planner-autoloads.el (source)...done Loading /etc/emacs/site-start.d/51planner-el.el (source)...done Loading /etc/emacs/site-start.d/52remember-el.el (source)... Loading /usr/share/emacs/site-lisp/remember-el/remember-autoloads.el (source)...done Loading /etc/emacs/site-start.d/52remember-el.el (source)...done For information about GNU Emacs and the GNU system, type C-h C-a. e is undefined p is undefined Load-path shadows: /usr/share/emacs24/site-lisp/css-mode/css-mode hides /usr/share/emacs/site-lisp/css-mode/css-mode /usr/share/emacs24/site-lisp/cmake-data/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode /usr/share/emacs/24.5/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /usr/share/emacs24/site-lisp/flim/hex-util hides /usr/share/emacs/24.5/lisp/hex-util /usr/share/emacs24/site-lisp/flim/md4 hides /usr/share/emacs/24.5/lisp/md4 /usr/share/emacs24/site-lisp/css-mode/css-mode hides /usr/share/emacs/24.5/lisp/textmodes/css-mode /usr/share/emacs/site-lisp/remember-el/remember hides /usr/share/emacs/24.5/lisp/textmodes/remember /usr/share/emacs24/site-lisp/flim/sasl-cram hides /usr/share/emacs/24.5/lisp/net/sasl-cram /usr/share/emacs24/site-lisp/flim/ntlm hides /usr/share/emacs/24.5/lisp/net/ntlm /usr/share/emacs24/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/24.5/lisp/net/sasl-ntlm /usr/share/emacs24/site-lisp/flim/sasl hides /usr/share/emacs/24.5/lisp/net/sasl /usr/share/emacs24/site-lisp/flim/hmac-md5 hides /usr/share/emacs/24.5/lisp/net/hmac-md5 /usr/share/emacs24/site-lisp/flim/sasl-digest hides /usr/share/emacs/24.5/lisp/net/sasl-digest /usr/share/emacs24/site-lisp/flim/hmac-def hides /usr/share/emacs/24.5/lisp/net/hmac-def /usr/share/emacs24/site-lisp/erc/erc-ring hides /usr/share/emacs/24.5/lisp/erc/erc-ring /usr/share/emacs24/site-lisp/erc/erc-truncate hides /usr/share/emacs/24.5/lisp/erc/erc-truncate /usr/share/emacs24/site-lisp/erc/erc-match hides /usr/share/emacs/24.5/lisp/erc/erc-match /usr/share/emacs24/site-lisp/erc/erc-autoaway hides /usr/share/emacs/24.5/lisp/erc/erc-autoaway /usr/share/emacs24/site-lisp/erc/erc-button hides /usr/share/emacs/24.5/lisp/erc/erc-button /usr/share/emacs24/site-lisp/erc/erc-goodies hides /usr/share/emacs/24.5/lisp/erc/erc-goodies /usr/share/emacs24/site-lisp/erc/erc-notify hides /usr/share/emacs/24.5/lisp/erc/erc-notify /usr/share/emacs24/site-lisp/erc/erc-backend hides /usr/share/emacs/24.5/lisp/erc/erc-backend /usr/share/emacs24/site-lisp/erc/erc-xdcc hides /usr/share/emacs/24.5/lisp/erc/erc-xdcc /usr/share/emacs24/site-lisp/erc/erc-join hides /usr/share/emacs/24.5/lisp/erc/erc-join /usr/share/emacs24/site-lisp/erc/erc-pcomplete hides /usr/share/emacs/24.5/lisp/erc/erc-pcomplete /usr/share/emacs24/site-lisp/erc/erc-identd hides /usr/share/emacs/24.5/lisp/erc/erc-identd /usr/share/emacs24/site-lisp/erc/erc-stamp hides /usr/share/emacs/24.5/lisp/erc/erc-stamp /usr/share/emacs24/site-lisp/erc/erc-page hides /usr/share/emacs/24.5/lisp/erc/erc-page /usr/share/emacs24/site-lisp/erc/erc hides /usr/share/emacs/24.5/lisp/erc/erc /usr/share/emacs24/site-lisp/erc/erc-sound hides /usr/share/emacs/24.5/lisp/erc/erc-sound /usr/share/emacs24/site-lisp/erc/erc-replace hides /usr/share/emacs/24.5/lisp/erc/erc-replace /usr/share/emacs24/site-lisp/erc/erc-log hides /usr/share/emacs/24.5/lisp/erc/erc-log /usr/share/emacs24/site-lisp/erc/erc-track hides /usr/share/emacs/24.5/lisp/erc/erc-track /usr/share/emacs24/site-lisp/erc/erc-imenu hides /usr/share/emacs/24.5/lisp/erc/erc-imenu /usr/share/emacs24/site-lisp/erc/erc-capab hides /usr/share/emacs/24.5/lisp/erc/erc-capab /usr/share/emacs24/site-lisp/erc/erc-lang hides /usr/share/emacs/24.5/lisp/erc/erc-lang /usr/share/emacs24/site-lisp/erc/erc-services hides /usr/share/emacs/24.5/lisp/erc/erc-services /usr/share/emacs24/site-lisp/erc/erc-ezbounce hides /usr/share/emacs/24.5/lisp/erc/erc-ezbounce /usr/share/emacs24/site-lisp/erc/erc-speedbar hides /usr/share/emacs/24.5/lisp/erc/erc-speedbar /usr/share/emacs24/site-lisp/erc/erc-spelling hides /usr/share/emacs/24.5/lisp/erc/erc-spelling /usr/share/emacs24/site-lisp/erc/erc-list hides /usr/share/emacs/24.5/lisp/erc/erc-list /usr/share/emacs24/site-lisp/erc/erc-dcc hides /usr/share/emacs/24.5/lisp/erc/erc-dcc /usr/share/emacs24/site-lisp/erc/erc-menu hides /usr/share/emacs/24.5/lisp/erc/erc-menu /usr/share/emacs24/site-lisp/erc/erc-netsplit hides /usr/share/emacs/24.5/lisp/erc/erc-netsplit /usr/share/emacs24/site-lisp/erc/erc-networks hides /usr/share/emacs/24.5/lisp/erc/erc-networks /usr/share/emacs24/site-lisp/erc/erc-compat hides /usr/share/emacs/24.5/lisp/erc/erc-compat /usr/share/emacs24/site-lisp/erc/erc-fill hides /usr/share/emacs/24.5/lisp/erc/erc-fill /usr/share/emacs24/site-lisp/erc/erc-ibuffer hides /usr/share/emacs/24.5/lisp/erc/erc-ibuffer /usr/share/emacs24/site-lisp/erc/erc-hecomplete hides /usr/share/emacs/24.5/lisp/obsolete/erc-hecomplete Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils xterm time-date info easymenu package epg-config remember-autoloads planner-autoloads debian-el debian-el-loaddefs w3m-load muse-autoloads erc-auto jabber-autoloads emacs-goodies-el emacs-goodies-custom emacs-goodies-loaddefs easy-mmode dpkg-dev-el dpkg-dev-el-loaddefs dash-functional dash bbdb-autoloads tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting font-render-setting x-toolkit x multi-tty emacs) Memory information: ((conses 16 94821 5787) (symbols 48 19910 0) (miscs 40 70 107) (strings 32 16043 5285) (string-bytes 1 503690) (vectors 16 8494) (vector-slots 8 355157 20689) (floats 8 68 293) (intervals 56 221 0) (buffers 960 12) (heap 1024 23801 864)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 21:08:05 2016 Received: (at control) by debbugs.gnu.org; 3 Jul 2016 01:08:05 +0000 Received: from localhost ([127.0.0.1]:34993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJVtF-00075Z-NB for submit@debbugs.gnu.org; Sat, 02 Jul 2016 21:08:05 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:36400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJVtE-000755-H8 for control@debbugs.gnu.org; Sat, 02 Jul 2016 21:08:04 -0400 Received: by mail-io0-f176.google.com with SMTP id s63so128232537ioi.3 for ; Sat, 02 Jul 2016 18:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version; bh=p9RlayBZWamwKw8mGLGviAlAWGtS4MbWGA6ZN0vwWUU=; b=KdM5Ahmk3E+CLrDZXrK2AOpvcVr/WvUiiL4ZDAtIQRLLq0SNlacEy3wwS31rZoy7iG rNn83DGLhj5kuJlyBGGLflpfdjBcIDiH+WU2TiNcRn9LT8UmzSUpQ2TQsS4d2+2gu2Dj +ZATNiCfDH0L030XPw2ru7qujgECikks1H7NENhlhDjWACtk+clDXeppUsyrAFWAkKYl J7bcEvTAKZnDSARF0Ig4mYHnurqZKODePpEaRWarO0QXVZxZnkK8avaY+CzzMdDzuMav ITs2vtHcDIS15rnup5yqmpHHOCtflmPiIzkLrlvWtfmCUTBxdIvVGvz5GCN/04H87P9b YoHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=p9RlayBZWamwKw8mGLGviAlAWGtS4MbWGA6ZN0vwWUU=; b=miU++DPmRZZoOZ2dY78YcJnnGXFmFQk5zCMzbdabfU21UZ27urFnTacznqHs0Vt0Oj rCB8R2ybDgQmyb3D2l5CFOU6Qsar9xeqVxjpvtxfwWW7MwuRl04Ga9p/zfmEopV16fta MZro5aYrYa3HJMTOTExboG2qY/UmlaTl0hYJc+vdE527h9bkWKO4DHiPujORVD+/+8Ur 5SPWL1oOvIthYtljmRUnpBrxRc/8r3vcnPBbDlik/kojy2UGCbZERPeqPVxAm0Ea0KLp JYErvqvCHCL44xfZYVUBnOnDH7lf7R3ASt4f/ly6rHQVsVIluYWnENrlmsFzOYhdT7Zo M9kg== X-Gm-Message-State: ALyK8tLq7LtEgw2iSLcTTv1j6YLeykF9XGCAnexOPZ2GFrosicS5SIcMcTMPOCjPTpm/6g== X-Received: by 10.107.53.233 with SMTP id k102mr4074795ioo.134.1467508078933; Sat, 02 Jul 2016 18:07:58 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id i13sm704065iod.33.2016.07.02.18.07.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Jul 2016 18:07:58 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control-message (sh-script "then" indent bugs) Date: Sat, 02 Jul 2016 21:08:08 -0400 Message-ID: <87r3bbfs07.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) forcemerge 21751 23004 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 09 13:18:08 2016 Received: (at control) by debbugs.gnu.org; 9 Sep 2016 17:18:08 +0000 Received: from localhost ([127.0.0.1]:54857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biPRH-0002TI-Tr for submit@debbugs.gnu.org; Fri, 09 Sep 2016 13:18:08 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:37822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biPRG-0002Sq-9D for control@debbugs.gnu.org; Fri, 09 Sep 2016 13:18:06 -0400 Received: by mail-it0-f46.google.com with SMTP id i184so23602845itf.0 for ; Fri, 09 Sep 2016 10:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:to:from:subject; bh=PpC9ZRknR8a8hvYDJSo44kMEUPLYpf3fqu+vvt/rLoI=; b=cHZSEjrEA3lOocAfhScSMJKpZCXMgCCrIXAI3rcE9+iQzWPGWZNNauae28pTWsHJ9x Kyr1eGqfGm7tukQ4StJ7K1pg+yuXLKnYexJc6Jx+03Lqlp6qxiSrIYwPFRb3CqeDiwCo eINMPH00KluJEwm9+HVMorF95aCRgBiTKDlxnVWKXfyanWrtaWc5MecbD7E6MkoWFdPQ JAGwTovKWkCsa5XZhpQV173Xchtt9vARUeTKQ/UI15TrapSfLBeW15e4dpr59CjBFM+M 2iIVlVPfdMmZiB2RxPZUdTaSUr/RfAJ88yqcPRqQ1iODx0myP2r9X4oOWIUSfiBXuUcn aJ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:to:from:subject; bh=PpC9ZRknR8a8hvYDJSo44kMEUPLYpf3fqu+vvt/rLoI=; b=YE7XpYtZaESlRyz96kjKpZUgJgWE5lI38IETqnqQhxmOePMN4rSkhiuDt7NoUhBIDH WJJcutwJ7lfulYW9tcEV8gpaq/Ryz4FVChYEz0eFmeimtVRNJdKbFz9522WhsxplfaiW 8R0bgUEO81QSQJIeT4FDHcXTk3NWu8R2EQAJBJ6+KP+9X3TJIBARrElJhan6VdidvaRy cN/BozTK/FDDeg9PnyNS5cJQLskQ6dvqa318CvofUTyIoC3OcrwtbBnACufGdQv4dVcU VNqwCcjzdrB9CQnzOdAkrFf6eF7/8BsXwfamYqg6oI+C4MbsF2drwipI6gUSkwkotrFs hbRA== X-Gm-Message-State: AE9vXwOmIyuJVXSywUJfqHeG3dRZM3vBvxjEcxkSDSnp6eWDEvloQ3uHfkbwqWeEZnTw7w== X-Received: by 10.157.47.183 with SMTP id r52mr6277771otb.178.1473441480476; Fri, 09 Sep 2016 10:18:00 -0700 (PDT) Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id m205sm1785807itg.8.2016.09.09.10.17.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Sep 2016 10:18:00 -0700 (PDT) Date: Fri, 09 Sep 2016 11:17:17 -0600 Message-Id: <87oa3xouw2.fsf@gmail.com> To: control@debbugs.gnu.org From: Alex Subject: control message for bug #21751 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) forcemerge 21751 24337 From unknown Sat Jun 21 12:30:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21751: 24.5; Undesirable sh-mode indent Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Aug 2017 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21751 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Bob Proulx , Oleksandr Gavenko , Phil Cc: 21751@debbugs.gnu.org Received: via spool by 21751-submit@debbugs.gnu.org id=B21751.15037497973472 (code B ref 21751); Sat, 26 Aug 2017 12:17:01 +0000 Received: (at 21751) by debbugs.gnu.org; 26 Aug 2017 12:16:37 +0000 Received: from localhost ([127.0.0.1]:56108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dla0z-0000tw-8l for submit@debbugs.gnu.org; Sat, 26 Aug 2017 08:16:37 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:33379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dla0y-0000ti-6r for 21751@debbugs.gnu.org; Sat, 26 Aug 2017 08:16:36 -0400 Received: by mail-it0-f65.google.com with SMTP id 77so1544489itj.0 for <21751@debbugs.gnu.org>; Sat, 26 Aug 2017 05:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ljNjaLLq/IGhe7nJ/jX5paBeIkmPC/p5sl1qlfbr7EI=; b=fcG8qIsW2lhWHU224HRr4ojFPSEsrT0ngjqd+7vwEb4Y7Fh8jDOH4E14K4iH2cyKOk 2TCswM5ADjB077t4dBXGpCZyWiQA6Ss3e8QPJHNcAxIwqfiI/RSi56Qw4A3kGvyjzrt6 ShRfJcoHgGXbkEc8sDOv4NYEb6Qa0DsewyiAMHXnizz85zNmCJTtW78OZEzrvI9JCdB6 0SNIIz8syay/JAa8YgUBbSwCk30cjjsNWXuvgyyf1gpZZ+s03J5O4byLfLQNP65llwXG kSSRw4H8K+OUUQbcBAU5+z0X6eM7prnuRzQHAJFqSTbJq+53/HNDQJ5rpL4eD0LgTTX8 IeWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ljNjaLLq/IGhe7nJ/jX5paBeIkmPC/p5sl1qlfbr7EI=; b=Ivld5Irk9W7umJbAA6TsUmtxvl1UBq7xHJ/v8hiNCZo+YzRMaX6SE7pNLN62X7oLEL Zwi5rXqW3/z4BL82OLzJvzIY1j0SvlL/cYjkqvQDvEW8rqvkjgxzao+VoCPhtUqev+A7 vP3JWwr2pAav9J5h227raOrc9qpU81haGBHatiWZuJSfWWt4AdrvgeLY4MV2Cq38AMng RXkBZ/Rx3y+QxNlVg7SwtUIzEzYa14Dko3/LMNQ1zUWTiPi82dPLjmycoPefqZcX57Q8 d3GM5QcSF6Tfv1IzQ/iLfpxvqyzBSI4lhX0UXmV8z1TolOpgL4lKAwkImBOKOUvsvc0A zMlQ== X-Gm-Message-State: AHYfb5i3uZIFED41FYEuR8TPqA55lfIePmChiJhWzwE/IXQtWmJsAqEt Giy2GDhBTjfk8et3 X-Received: by 10.107.199.195 with SMTP id x186mr1547037iof.293.1503749790511; Sat, 26 Aug 2017 05:16:30 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id s141sm24082ita.1.2017.08.26.05.16.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Aug 2017 05:16:29 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87y4esm6js.fsf@hysteria.proulx.com> Date: Sat, 26 Aug 2017 08:18:09 -0400 In-Reply-To: <87y4esm6js.fsf@hysteria.proulx.com> (Bob Proulx's message of "Sat, 24 Oct 2015 13:04:55 -0600") Message-ID: <874lsua5fi.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Bob Proulx writes: > In 24.5.1 from Debian Sid I am now getting an undesirable indent that > is no longer controlled by sh-basic-offset. In 23 this worked. > > emacs -Q /tmp/trial.sh > > M-: (setq sh-basic-offset 2) > > if true; then > true > ^ indent should be 2 not 4 here > > C-c ? > Rules used: :elem basic -> 4, :before "then" -> 0, :after "then" -> nil > > Anyone know what is happening here? I have reviewed the NEWS and the > latest manual but I didn't find any intentionally noted changes. Doing M-: (setq sh-indentation 2 sh-basic-offset 2) gives the expected result. The smie indentation code is using sh-indentation for default/basic offset, and sh-basic-offset indirectly for other offsets. I'm not sure why both sh-indentation and sh-basic-offset exist (sh-basic-offset was added in [1: f964dfcb0d], sh-indentation in [2: 133693bc90]). The only other place that uses sh-indentation is sh-basic-indent-line (which is only used for shells lacking any indentation rules). I guess sh-indentation should be made into an obsolete alias for sh-basic-offset? (defcustom sh-basic-offset 4 "The default indentation increment. This value is used for the `+' and `-' symbols in an indentation variable." (defcustom sh-indentation 4 "The width for further indentation in Shell-Script mode." (defun sh-basic-indent-line () "Indent a line for Sh mode (shell script mode). Indent as far as preceding non-empty line, then by steps of `sh-indentation'. (defun sh-set-shell (shell &optional no-query-flag insert-flag) "Set this buffer's shell to SHELL (a string)." ... (if (setq-local sh-indent-supported-here (sh-feature sh-indent-supported)) (progn (message "Setting up indent for shell type %s" sh-shell) ...) (message "No indentation for this shell type.") (setq-local indent-line-function 'sh-basic-indent-line))) [1: f964dfcb0d]: 1999-10-12 12:30:38 +0000 Added support for indenting existing scripts. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f964dfcb0d9dca156cbb29009bf4e399828f9b13 [2: 133693bc90]: 1995-07-07 19:48:24 +0000 restructured, largely rewritten without the bugs and extended to cover over 15 shells. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=133693bc904830ab88908d7f9806326543264f24 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 26 08:17:38 2017 Received: (at control) by debbugs.gnu.org; 26 Aug 2017 12:17:38 +0000 Received: from localhost ([127.0.0.1]:56113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dla1y-0000vm-LM for submit@debbugs.gnu.org; Sat, 26 Aug 2017 08:17:38 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:35713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dla1x-0000vb-KO for control@debbugs.gnu.org; Sat, 26 Aug 2017 08:17:37 -0400 Received: by mail-it0-f46.google.com with SMTP id f1so4869207ith.0 for ; Sat, 26 Aug 2017 05:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=IF8EMJPwhiBwuITazJm9ljQ6CMfORSLTnB8LXTqpFu8=; b=FVOXPTIToyglrDczTndvB/aDPlt/Cmxg3zHY/l1EI+baHtw+O6TRqzkniV1SQwLOVS hyML1AQ16r3wO5NLy04LjSephSYdR99tOWAy2RhGeVhFurUJOiMSujWE7IpqndzWF6AA FliPvePHmIrRK3zzb09gUVTrF+NXLb59WGx+Ok3z5vJlkkAhFunrY0ZasNZqfKT6SCar EO19UM7NiTk+EG/BSyoQ3IL2ug+GDvVCdJiSGBIsGKzZIxXDI5KXOz3j0+LRNEAz4tFv GS07YkS3a7hPAiyYJEq5LxlSFOH1JFOVCmUbVP+80oTtIUZRX6cqId5KIXyqQBpk7uV8 HbWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=IF8EMJPwhiBwuITazJm9ljQ6CMfORSLTnB8LXTqpFu8=; b=X1oPFkaa+0XYB8Aj1hFOuShJaWrS4EIBoVGwuTKzvVWUN2UaAJLteDWskuHKnU+MNF mjIxFrz+F3p7DQQDVIQEK9dQct84K+KPzR0LQ6tVioLpTslVMflm3wJXY2TIKEC46qZk ZUcbjpsYCTOyxWQxObeGaKQhnO67WBXu101Na53Jacv2Dsn+ExNE31U5b6YKGZtxJp68 IlF73yozxZ1YaJ+xLX1BhoPLpg3QQwZxQRE7qk/tdmk/TRE8VGTXMIHPRwxK0QiyiZ0e Z1k5IG5szMEswypFVISfWldL3bsSgoShBvOSbSNMTWnG3lLuEcNmB/NwTZu9VuTASA0o j/Jw== X-Gm-Message-State: AHYfb5gKV11M8/MTRS3OIg66EG8Wx2rI5w1yAVZMW8I+KFv+CZTDCb2m 7V88Y4A/CqJpiZee X-Received: by 10.107.11.71 with SMTP id v68mr1135564ioi.301.1503749852186; Sat, 26 Aug 2017 05:17:32 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id m100sm3893197iod.5.2017.08.26.05.17.31 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Aug 2017 05:17:31 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #21751 Date: Sat, 26 Aug 2017 08:19:12 -0400 Message-ID: <871snya5dr.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 21751 + confirmed quit From unknown Sat Jun 21 12:30:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21751: 24.5; Undesirable sh-mode indent Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2017 23:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21751 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Bob Proulx Cc: Phil , 21751@debbugs.gnu.org, Oleksandr Gavenko Received: via spool by 21751-submit@debbugs.gnu.org id=B21751.150413693722352 (code B ref 21751); Wed, 30 Aug 2017 23:49:02 +0000 Received: (at 21751) by debbugs.gnu.org; 30 Aug 2017 23:48:57 +0000 Received: from localhost ([127.0.0.1]:35425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnCjB-0005oM-Au for submit@debbugs.gnu.org; Wed, 30 Aug 2017 19:48:57 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:37073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnCj9-0005o4-AM; Wed, 30 Aug 2017 19:48:55 -0400 Received: by mail-io0-f169.google.com with SMTP id d78so11577342ioe.4; Wed, 30 Aug 2017 16:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=674t4lC2woNUvIdfEleUX+tZAlc+r3wvH+TIJ60yFwM=; b=Gjxz638Qv8SCAA3E74xV+A3iZDvhW5OiCdCFiDWw6r7xrABFcqAf8aJt0oXp8btbN8 naiiKiCnfrHEeWD7c8aiXVP1NLLAohXYvQV7HDFBNcubFnHdYrg/LjDEk4xzOo/ReoDM CQJvXcVtP5Dxv8izwXKoX8W9/s4Ol5+oz9aKGj6BxfGTJtdUcKg4FxcfIziB2faHsQNd Z0r2OSvfrLAhCqOEEFDbgpPju1TeDsIgy4cpkAc5//tbEb1JQlGSmhiYcKO2ynLwxByM jdNWLXLI4Ygvyt/0ALzIeuvXS042YpwMOPtXk8JZermeMgTrs9wrw52ENLD5Trq2JH5q Wbcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=674t4lC2woNUvIdfEleUX+tZAlc+r3wvH+TIJ60yFwM=; b=hfrH2XShEgJNhU6Z+YthOX+rkpszob/UgGe6zoFdEgRVj0a0BKsKfp6FTdYk3XyruW 9bKk8ZGomVclAA2qWm61uKzNMRLvu+ORU9+Z+8dYsuv/qJiNcovKqdCilSSbzT4DBz6k Q78Wx+qNeJ1hY8z4MCyZyRMkMJmuz2FtSJ/JPfyJRLqASJ2lyaXbZnNoTXmmMHcInqwO 1KZfjwWBK9ivLDK0SyOFdZiPDeMm9ZqyUtVXU5l1dyXN64nJjWW3aDSaLw6sZtARY7tN tFFFbCbTJLDco9yEy8MukC+aGceXo6DhnIu5xqu5WlzqzmmiWFKgyUuQBNdvjzTkewMo lumg== X-Gm-Message-State: AHYfb5gQk415WUsY7+U/DPD2f8+AtA4UfK3vJR8wUgm/KTGvhW/297bX L3FcDCqpO/s2RSeJ X-Received: by 10.36.25.199 with SMTP id b190mr3752380itb.58.1504136929602; Wed, 30 Aug 2017 16:48:49 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id y202sm1446724itc.2.2017.08.30.16.48.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Aug 2017 16:48:48 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87y4esm6js.fsf@hysteria.proulx.com> <874lsua5fi.fsf@users.sourceforge.net> Date: Wed, 30 Aug 2017 19:50:30 -0400 In-Reply-To: <874lsua5fi.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 26 Aug 2017 08:18:09 -0400") Message-ID: <87y3q07gzd.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain tags 21751 + patch quit npostavs@users.sourceforge.net writes: > I guess sh-indentation should be made into an obsolete alias for > sh-basic-offset? Here's a patch --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Make-sh-indentation-into-an-alias-for-sh-basic-of.patch Content-Description: patch >From 2205b597476083579bd3e50b20bc2ce42ca54520 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 30 Aug 2017 19:42:47 -0400 Subject: [PATCH v1] Make sh-indentation into an alias for sh-basic-offset (Bug#21751) * lisp/progmodes/sh-script.el (sh-indentation): Redefine as obsolete variable alias for `sh-basic-offset'. (sh-mode, sh-smie--indent-continuation) (sh-smie-rc-rules, sh-basic-indent-line): Replace `sh-indentation' with `sh-basic-offset'. --- lisp/progmodes/sh-script.el | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el index ca31635dbc..2cf7e15540 100644 --- a/lisp/progmodes/sh-script.el +++ b/lisp/progmodes/sh-script.el @@ -593,11 +593,7 @@ sh-assignment-regexp (sexp :format "Evaluate: %v")))) :group 'sh-script) - -(defcustom sh-indentation 4 - "The width for further indentation in Shell-Script mode." - :type 'integer - :group 'sh-script) +(define-obsolete-variable-alias 'sh-indentation 'sh-basic-offset "26.1") (put 'sh-indentation 'safe-local-variable 'integerp) (defcustom sh-remember-variable-min 3 @@ -1623,7 +1619,7 @@ sh-mode (setq-local skeleton-pair-alist '((?` _ ?`))) (setq-local skeleton-pair-filter-function 'sh-quoted-p) (setq-local skeleton-further-elements - '((< '(- (min sh-indentation (current-column)))))) + '((< '(- (min sh-basic-offset (current-column)))))) (setq-local skeleton-filter-function 'sh-feature) (setq-local skeleton-newline-indent-rigidly t) (setq-local defun-prompt-regexp @@ -2018,7 +2014,7 @@ sh-smie--indent-continuation (forward-line -1) (if (sh-smie--looking-back-at-continuation-p) (current-indentation) - (+ (current-indentation) sh-indentation)))) + (+ (current-indentation) sh-basic-offset)))) (t ;; Just make sure a line-continuation is indented deeper. (save-excursion @@ -2039,13 +2035,13 @@ sh-smie--indent-continuation ;; check the line before that one. (> ci indent)) (t ;Previous line is the beginning of the continued line. - (setq indent (min (+ ci sh-indentation) max)) + (setq indent (min (+ ci sh-basic-offset) max)) nil))))) indent)))))) (defun sh-smie-sh-rules (kind token) (pcase (cons kind token) - (`(:elem . basic) sh-indentation) + (`(:elem . basic) sh-basic-offset) (`(:after . "case-)") (- (sh-var-value 'sh-indent-for-case-alt) (sh-var-value 'sh-indent-for-case-label))) (`(:before . ,(or `"(" `"{" `"[" "while" "if" "for" "case")) @@ -2254,8 +2250,8 @@ sh-smie-rc-backward-token (defun sh-smie-rc-rules (kind token) (pcase (cons kind token) - (`(:elem . basic) sh-indentation) - ;; (`(:after . "case") (or sh-indentation smie-indent-basic)) + (`(:elem . basic) sh-basic-offset) + ;; (`(:after . "case") (or sh-basic-offset smie-indent-basic)) (`(:after . ";") (if (smie-rule-parent-p "case") (smie-rule-parent (sh-var-value 'sh-indent-after-case)))) @@ -2496,7 +2492,7 @@ sh-modify (defun sh-basic-indent-line () "Indent a line for Sh mode (shell script mode). -Indent as far as preceding non-empty line, then by steps of `sh-indentation'. +Indent as far as preceding non-empty line, then by steps of `sh-basic-offset'. Lines containing only comments are considered empty." (interactive) (let ((previous (save-excursion @@ -2520,9 +2516,9 @@ sh-basic-indent-line (delete-region (point) (progn (beginning-of-line) (point))) (if (eolp) - (max previous (* (1+ (/ current sh-indentation)) - sh-indentation)) - (* (1+ (/ current sh-indentation)) sh-indentation)))))) + (max previous (* (1+ (/ current sh-basic-offset)) + sh-basic-offset)) + (* (1+ (/ current sh-basic-offset)) sh-basic-offset)))))) (if (< (current-column) (current-indentation)) (skip-chars-forward " \t")))) -- 2.14.1 --=-=-=-- From unknown Sat Jun 21 12:30:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21751: 24.5; Undesirable sh-mode indent Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2017 12:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21751 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch To: npostavs@users.sourceforge.net Cc: p.stephani2@gmail.com, 21751@debbugs.gnu.org, bob@proulx.com, gavenkoa@gmail.com Reply-To: Eli Zaretskii Received: via spool by 21751-submit@debbugs.gnu.org id=B21751.1504357080764 (code B ref 21751); Sat, 02 Sep 2017 12:58:02 +0000 Received: (at 21751) by debbugs.gnu.org; 2 Sep 2017 12:58:00 +0000 Received: from localhost ([127.0.0.1]:41771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do7zs-0000CG-BM for submit@debbugs.gnu.org; Sat, 02 Sep 2017 08:58:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do7zq-0000C0-1D for 21751@debbugs.gnu.org; Sat, 02 Sep 2017 08:57:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do7zf-0005LR-Ux for 21751@debbugs.gnu.org; Sat, 02 Sep 2017 08:57:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do7zf-0005LM-Qs; Sat, 02 Sep 2017 08:57:47 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2091 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1do7zf-0005vE-8p; Sat, 02 Sep 2017 08:57:47 -0400 Date: Sat, 02 Sep 2017 15:57:38 +0300 Message-Id: <83mv6dz29p.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87y3q07gzd.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) References: <87y4esm6js.fsf@hysteria.proulx.com> <874lsua5fi.fsf@users.sourceforge.net> <87y3q07gzd.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Date: Wed, 30 Aug 2017 19:50:30 -0400 > Cc: Phil , Oleksandr Gavenko , > 21751@debbugs.gnu.org > > > I guess sh-indentation should be made into an obsolete alias for > > sh-basic-offset? > > Here's a patch Thanks. If there are no objections in a few days, please push. From unknown Sat Jun 21 12:30:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21751: 24.5; Undesirable sh-mode indent Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Sep 2017 23:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21751 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch To: Eli Zaretskii Cc: p.stephani2@gmail.com, gavenkoa@gmail.com, bob@proulx.com, 21751@debbugs.gnu.org Received: via spool by 21751-submit@debbugs.gnu.org id=B21751.15063830086454 (code B ref 21751); Mon, 25 Sep 2017 23:44:03 +0000 Received: (at 21751) by debbugs.gnu.org; 25 Sep 2017 23:43:28 +0000 Received: from localhost ([127.0.0.1]:59208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwd28-0001fx-1t for submit@debbugs.gnu.org; Mon, 25 Sep 2017 19:43:28 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwd26-0001fd-Ie; Mon, 25 Sep 2017 19:43:26 -0400 Received: by mail-io0-f196.google.com with SMTP id g32so3708922ioj.1; Mon, 25 Sep 2017 16:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jp2re7hqelRnbbZ5e+ewRZY9aUbValb1loS4ATAt4tI=; b=E5XgDSD2FzY3WTJEmdI6KHeL69cheOZQ+EB7RPio/L2fMYZGrMo/uWL8LiDxsAiUs1 HbYb+OrbfcIWppEKU37mcl+8ydmH86n6XXF1zLrK/9ucUYXuN9dRM/imjxhdZeMPQROy lHuHDs3RuWrnAOiOYW12dT600mu0sWHMYed8Sgk0plYmmsH/Dn0gqi9TvWH0zVRqu5/8 3ahqJHHLxcdyWU0UKsWZ2F4HssRfJHRy0Q4YcpIS5K0ftzIOeY3soDHXXvB+6CtpPXHV 0RzE3ySZnkFu92v7/gdDJJnq9QuL7LkCmuLTvu0fP6ipdwHhDOiv71TaMM3YTUVw+tXz NRnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=jp2re7hqelRnbbZ5e+ewRZY9aUbValb1loS4ATAt4tI=; b=b0yJRVyDnrBYwpz9XW9qixXsoNlIg2ZAN5PUgpb7Iaxgr7Z2SV93NINg2g367TOG8R XLhsLxOigEwjtOOmW5EUbOuoKqtrM3aT52tjqNNEs6G+dhYO16o7FX7iUWaCFZ1sioA9 Gpxur48yHHPklVSFWCwpiUQGQ4iI4WeiyV6375IssoJCj7/Xg2Qpd9oSErO2i/CO5E8C 5SoI1zWIrVlEolxB5Cr5nvml07httQp8rSW++Y5j0AkTeW3Ql9TSNNdlheOwLTAVBSXG O7hFVW0mqapwHcD/A6Y0NDEEh5QSPL9wBSkYz4Uv2zmafB9V6HrXU+tEsrxcVCZq6kcs xqxw== X-Gm-Message-State: AHPjjUgFF6yumspSQLCFBP+lMZMO37dnwq/nWHzmlikCqXi5+pkz0M1U 69XP5vA8spFfk2gpgurI8ieV2g== X-Google-Smtp-Source: AOwi7QDpvTNIxGkUdsp0L83QNhNG2Q6jK1s7xiFs2All0p+3c1Xu0MAvugERke+u9gvS1B+/w/CIow== X-Received: by 10.107.29.149 with SMTP id d143mr12396791iod.201.1506383001034; Mon, 25 Sep 2017 16:43:21 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k133sm3826944itd.0.2017.09.25.16.43.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Sep 2017 16:43:20 -0700 (PDT) From: Noam Postavsky References: <87y4esm6js.fsf@hysteria.proulx.com> <874lsua5fi.fsf@users.sourceforge.net> <87y3q07gzd.fsf@users.sourceforge.net> <83mv6dz29p.fsf@gnu.org> Date: Mon, 25 Sep 2017 19:43:19 -0400 In-Reply-To: <83mv6dz29p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Sep 2017 15:57:38 +0300") Message-ID: <87efqugx9k.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 21751 fixed close 21751 26.1 quit Eli Zaretskii writes: >> > I guess sh-indentation should be made into an obsolete alias for >> > sh-basic-offset? >> >> Here's a patch > > Thanks. If there are no objections in a few days, please push. It's more than a few days (I was travelling, and then waiting to see if anything unexpected would turn up from Bug#24848), but pushed to emacs-26 now. [1: f5e72b04d9]: 2017-09-25 19:39:19 -0400 Make sh-indentation into an alias for sh-basic-offset (Bug#21751) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f5e72b04d930215f6e770e2fe9e02ad6debf03ad