From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 22 16:29:31 2015 Received: (at submit) by debbugs.gnu.org; 22 Oct 2015 20:29:31 +0000 Received: from localhost ([127.0.0.1]:33254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpMUN-0001TF-7X for submit@debbugs.gnu.org; Thu, 22 Oct 2015 16:29:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50555) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpMUL-0001T4-Cw for submit@debbugs.gnu.org; Thu, 22 Oct 2015 16:29:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpMUK-0006PN-5U for submit@debbugs.gnu.org; Thu, 22 Oct 2015 16:29:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpMUK-0006PG-1n for submit@debbugs.gnu.org; Thu, 22 Oct 2015 16:29:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpMUI-00056E-LD for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 16:29:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpMUF-0006Lf-4I for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 16:29:26 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:35893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpMUF-0006LG-1V for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 16:29:23 -0400 Received: by qgad10 with SMTP id d10so67572026qga.3 for ; Thu, 22 Oct 2015 13:29:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject; bh=XT0vEK81+dro7YwN/bijExUwMRdV4J0+ViZuioHNjRc=; b=McL1atl2C1C67R5u/wj1u84js3TiX+DA0JTgVfTHgajNZkUW0cmHve/4wpsBxHVAMm s2s2rPg6erMKFNpeg+QPw663EZCcuqMqZfA0/2YNFg4cVpanX0bwd+Vq6WxGwidne4q+ XHh65KUcxJCZB8g9+f0SnZ21ag82rs3bI/0dJkrlI04MPkAfXylR7Iz/jrVNP/nOj85k 94lQAxD9UxQ98NDQTwYuycNB3NSmOFpibwIFmjAeUqDX0maKluYk42ze3Ebucmtr3lAN q7C2ne9C0njL5D9dsHRjfXi3oiL/O+MIBXz3fe1S1jJQnUH972Gqpp2BgZtguxvTdSF5 polg== X-Gm-Message-State: ALoCoQllur5G1YR7b6W+L78juhSMsmANWfwuaXFr19nAy8JpQACXWhMdFNS/U0wbz1d5rZpnI+bN X-Received: by 10.140.109.6 with SMTP id k6mr20982025qgf.28.1445545762498; Thu, 22 Oct 2015 13:29:22 -0700 (PDT) Received: from SHLEPTOP ([50.153.130.146]) by smtp.gmail.com with ESMTPSA id k136sm6028243qhk.2.2015.10.22.13.29.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2015 13:29:21 -0700 (PDT) From: Eli Barzilay MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <22057.18203.537000.988338@gargle.gargle.HOWL> Date: Thu, 22 Oct 2015 16:29:15 -0400 To: bug-gnu-emacs@gnu.org Subject: 24.5; Minor feature request: `comint-previous-matching-input-from-input' and point X-Mailer: VM 8.2.0a under 24.5.1 (i686-pc-mingw32) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Chong Yidong , Le Wang X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) `comint-previous-matching-input-from-input' used to insert a match and leave the point at the end of the line. I found that behavior much better than zsh and bash since when recalling old commands I edit the last part of the command much more often. (In fact, I think that comint used to leave the point where it was years ago, since I remember having to tweak emacs to put it at the end.) A few years ago, there was a bug & a patch reported by Le Wang about keeping the point at the same place -- something that I find really annoying... The problem with this patch is that it has no option to leave the point at the end, forcing me to duplicate the whole function if I want that behavior. So, this is a feature request to add such an option with a new custom variable. -- ((x=>x(x))(x=>x(x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 22 16:42:33 2015 Received: (at 21737) by debbugs.gnu.org; 22 Oct 2015 20:42:33 +0000 Received: from localhost ([127.0.0.1]:33271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpMgz-00020W-D8 for submit@debbugs.gnu.org; Thu, 22 Oct 2015 16:42:33 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:38152) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpMgy-00020N-3s for 21737@debbugs.gnu.org; Thu, 22 Oct 2015 16:42:32 -0400 Received: by igbdj2 with SMTP id dj2so2984488igb.1 for <21737@debbugs.gnu.org>; Thu, 22 Oct 2015 13:42:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=LtBR+5lxtEWeTV+CZiPECZZajhiHuATyVlUfW6vQfXo=; b=dI0Tyip4FHkmV8kHvOqKhBBUGGvDSvBT6lIeXL7qoP8Umg3a6bnGLvMFiSf7ljweEm 5sQhhOLiWDzCuishEyIoWZ8PhC959ziZQEd/QYiYNRBDpioU6LjTqNObOifCcsLIzemM fyrtysJ6/PiXHbrom0y/RApqAj/TaeUKpbwSMEHOOkLDw7eqxeSfhY+cVrZ+5+48I6cc BCZkOuo4MoJuEfaLVZuVdm9tCZYNWFQG8hfm6gUBKZGCsCLI4Py29uKl+nG7pCf6p/7p 978Bu2RCd82IoiBLm7QNJ5OuBgv3YyFcwqIvRNc6qUl8ZwVfRh7XVhyclPtPCGUcmOyW BrHQ== X-Gm-Message-State: ALoCoQl6tRJJD9D2HLifMNqsi7lAhy5VvdUmWeMk+vIWTg73nfEun1cUzDPqleRnypqCRxu8SeFE MIME-Version: 1.0 X-Received: by 10.50.22.5 with SMTP id z5mr556897ige.49.1445546551470; Thu, 22 Oct 2015 13:42:31 -0700 (PDT) Received: by 10.79.28.211 with HTTP; Thu, 22 Oct 2015 13:42:30 -0700 (PDT) In-Reply-To: References: <22057.18203.537000.988338@gargle.gargle.HOWL> Date: Thu, 22 Oct 2015 16:42:30 -0400 Message-ID: Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) From: Eli Barzilay To: 21737@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21737 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Thu, Oct 22, 2015 at 4:30 PM, GNU bug Tracking System wrote: > If you wish to submit further information on this problem, please > send it to 21737@debbugs.gnu.org. I forgot to also note that this bit from the mentioned bug report: | The point should not be moved so that I can press M-p again to find | the next match. is wrong: `comint-previous-matching-input-from-input' already had that functionality using `comint-matching-input-from-input-string' to keep the same search string on consequent searches regardless of the point position. (I tend to think that because of this the default behavior should be kept as it was, but in practice I'm guessing that most people expect the zsh/bash thing.) -- ((x=>x(x))(x=>x(x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 23 02:26:06 2015 Received: (at 21737) by debbugs.gnu.org; 23 Oct 2015 06:26:07 +0000 Received: from localhost ([127.0.0.1]:33696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpVnh-0006RZ-To for submit@debbugs.gnu.org; Fri, 23 Oct 2015 02:26:06 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:63089) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpVne-0006R8-Tm for 21737@debbugs.gnu.org; Fri, 23 Oct 2015 02:26:03 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NWN00800TO70P00@a-mtaout22.012.net.il> for 21737@debbugs.gnu.org; Fri, 23 Oct 2015 09:26:01 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWN0073NTVCYQ40@a-mtaout22.012.net.il>; Fri, 23 Oct 2015 09:26:01 +0300 (IDT) Date: Fri, 23 Oct 2015 09:26:04 +0300 From: Eli Zaretskii Subject: Re: bug#21737: 24.5; Minor feature request: `comint-previous-matching-input-from-input' and point In-reply-to: <22057.18203.537000.988338@gargle.gargle.HOWL> X-012-Sender: halo1@inter.net.il To: Eli Barzilay Message-id: <83si52rthf.fsf@gnu.org> References: <22057.18203.537000.988338@gargle.gargle.HOWL> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21737 Cc: cyd@gnu.org, l26wang@gmail.com, 21737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Eli Barzilay > Date: Thu, 22 Oct 2015 16:29:15 -0400 > Cc: Chong Yidong , Le Wang > > `comint-previous-matching-input-from-input' used to insert a match and > leave the point at the end of the line. I found that behavior much > better than zsh and bash since when recalling old commands I edit the > last part of the command much more often. (In fact, I think that > comint used to leave the point where it was years ago, since I > remember having to tweak emacs to put it at the end.) > > A few years ago, there was a bug & a patch reported by Le Wang about > keeping the point at the same place -- something that I find really > annoying... The problem with this patch is that it has no option to > leave the point at the end, forcing me to duplicate the whole function > if I want that behavior. > > So, this is a feature request to add such an option with a new custom > variable. Thanks. Would you like to prepare a patch along these lines? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 17:42:14 2015 Received: (at 21737) by debbugs.gnu.org; 13 Nov 2015 22:42:14 +0000 Received: from localhost ([127.0.0.1]:37531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxN2a-0000mm-8J for submit@debbugs.gnu.org; Fri, 13 Nov 2015 17:42:14 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36279) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxMrp-0000X3-7F for 21737@debbugs.gnu.org; Fri, 13 Nov 2015 17:30:50 -0500 Received: by wmww144 with SMTP id w144so46513463wmw.1 for <21737@debbugs.gnu.org>; Fri, 13 Nov 2015 14:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; bh=72zNX6Cj7Zdmm0yyYrkPdgB6jXeEv/LACKHwHGH/NtI=; b=twuMfbDtNxQVcsSwxLwHiSHK/CcQOy1PI+AFPNcON67PKoTMp+K35OVzMdMeyxFlBH vfL8AovJspxpuS+RkqYqTSHTWKI+BFaJKhv2s7+cxMi6yKNSPMsTad93dUSIIFn4gbkG W0FWcHywY8dymTLO6yNC27c8dZNywdoHU6sBjX3vXGs8vWQm/EIxw2oWthL0cn7YWJ2s kHr1Omw89lMR/T9mJyPkJBqnBVTtHmEBRdTPizpMhBSxRmx2olhpnyN3x8v2OWjZa9+m Xp1RIE0PRgVVtJs7abQ5M8YgLInY2HveseZGJqMqXxI/JuvuAEt5sHcttQXhVkYGRe1Q sYEw== X-Received: by 10.194.119.162 with SMTP id kv2mr24414368wjb.62.1447453848552; Fri, 13 Nov 2015 14:30:48 -0800 (PST) Received: from stephens-mbp.cable.virginmedia.net (cpc4-papw5-2-0-cust294.5-3.cable.virginm.net. [81.102.145.39]) by smtp.gmail.com with ESMTPSA id pc2sm21852850wjb.11.2015.11.13.14.30.46 for <21737@debbugs.gnu.org> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Nov 2015 14:30:46 -0800 (PST) From: Stephen Perry Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) Message-Id: <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> Date: Fri, 13 Nov 2015 22:30:45 +0000 To: 21737@debbugs.gnu.org Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) X-Mailer: Apple Mail (2.3096.5) X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 21737 X-Mailman-Approved-At: Fri, 13 Nov 2015 17:41:54 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) How about this for a patch? It=E2=80=99s my first so be kind :-) diff --git a/lisp/comint.el b/lisp/comint.el index e70fe88..8d61226 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -283,6 +283,14 @@ comint-move-point-for-output (const others)) :group 'comint) =20 +(defcustom comint-move-point-to-end-on-match nil + "Controls whether point moves to the end of the matched input. +If nil, then point remains in the current position. +If t, point moves to the end of matched input." + :type '(choice (const :tag "off" nil) + (const t)) + :group 'comint) + (defvaralias 'comint-scroll-to-bottom-on-output = 'comint-move-point-for-output) =20 (defcustom comint-scroll-show-maximum-output t @@ -1220,7 +1228,8 @@ comint-previous-matching-input-from-input (comint-previous-matching-input (concat "^" (regexp-quote = comint-matching-input-from-input-string)) n) - (goto-char opoint))) + (unless comint-move-point-to-end-on-match + (goto-char opoint)))) =20 (defun comint-next-matching-input-from-input (n) "Search forwards through input history for match for current input. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 11:50:18 2015 Received: (at 21737) by debbugs.gnu.org; 16 Nov 2015 16:50:18 +0000 Received: from localhost ([127.0.0.1]:40401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyMyw-0002hc-5j for submit@debbugs.gnu.org; Mon, 16 Nov 2015 11:50:18 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34100) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyMyu-0002hU-Gl for 21737@debbugs.gnu.org; Mon, 16 Nov 2015 11:50:16 -0500 Received: by padhx2 with SMTP id hx2so180274448pad.1 for <21737@debbugs.gnu.org>; Mon, 16 Nov 2015 08:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=nHuAaMvCabFQc92HIPXcUJxcJzsvzOEwxhf9uoJ+6WY=; b=mNURoW2AmtPDuWJKhcnEsObpHl2j3fxqVTkQhbuq3FXohpBto8VmNolmGJkWV8NTdo zspkEoI77W34xWFScJkR+3W4/8onx3V9REeAP+vKRK3eOEYf3ieMxsn6hxnn2mTvRak8 MvuywSEvurnDwcfsUD2Y7Q65lG6RIpEnVDrJ8c2KIjM/5a7vUY9gpJ6C92JKs/RHSst4 ran3ducZQhMBSbtELWE3xOxBJFPqenBRZsg+/6G18euEkAi0R6lj0tCAs9rtdpMMw+G+ b8OVDqhaQ7/8/rolSudnHDiS7oqJbXc8ooy75676vnfdT/w6+0XS4ataSLS+KuOy1nCB PGPw== X-Received: by 10.68.217.102 with SMTP id ox6mr29753734pbc.27.1447692615551; Mon, 16 Nov 2015 08:50:15 -0800 (PST) Received: from Vulcan.attlocal.net (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id jp1sm35423430pbc.54.2015.11.16.08.50.14 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 16 Nov 2015 08:50:14 -0800 (PST) Received: by Vulcan.attlocal.net (Postfix, from userid 501) id 332C5105DEA00; Mon, 16 Nov 2015 08:50:14 -0800 (PST) From: "John Wiegley" To: Stephen Perry Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) In-Reply-To: <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> (Stephen Perry's message of "Fri, 13 Nov 2015 22:30:45 +0000") Date: Mon, 16 Nov 2015 08:50:11 -0800 Message-ID: References: <22057.18203.537000.988338@gargle.gargle.HOWL> <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21737 Cc: 21737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Stephen Perry writes: > How about this for a patch? It=E2=80=99s my first so be kind :-) Hi Stephen, I think that using ":type 'boolean" is better than specifiying a custom version. Otherwise, it looks good to me. John From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 13:55:36 2015 Received: (at 21737) by debbugs.gnu.org; 16 Nov 2015 18:55:36 +0000 Received: from localhost ([127.0.0.1]:40448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyOwB-0007ew-5j for submit@debbugs.gnu.org; Mon, 16 Nov 2015 13:55:36 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:32806) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyOvr-0007eR-H9 for 21737@debbugs.gnu.org; Mon, 16 Nov 2015 13:55:34 -0500 Received: by wmec201 with SMTP id c201so192307850wme.0 for <21737@debbugs.gnu.org>; Mon, 16 Nov 2015 10:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gGeEmOsiZ260tC1Z9tF0gN5R6p8WGIdt/o4G0biCIgY=; b=rrT2tapOXIBMaPTGKaYTPnAmY0ILXXDDkoK9SwMd8PZWUF/Mn318ukHUYvvw9HCKVO LWvMxj8vxHvBBRdbqHYMit435/2TpKh3DgsH6M4/E1i49Y1TYZjJHG/Tyu5eFMm+zhmH JxA0rJwrRmNetH5tayr5k0YGHrGtqrY34SdgfE88oipRCki03LpGMdtl/eLgXNA1H3g9 TTtl1rKQJGaltbF/mez1wyir17J43q+VGrKreu8lMVrnH3JazG0tAvdfbdIGIIkcsiEo Fq3uHsPmYgZCVJN1NOhD5rIe2pQVqSQJ0q8w1oLQkSKKCcuPndZSgxUikMnTMiIECW99 OaWg== X-Received: by 10.194.108.103 with SMTP id hj7mr37866782wjb.143.1447700114718; Mon, 16 Nov 2015 10:55:14 -0800 (PST) Received: from stephens-mbp.cable.virginmedia.net (cpc4-papw5-2-0-cust294.5-3.cable.virginm.net. [81.102.145.39]) by smtp.gmail.com with ESMTPSA id l81sm19983716wmb.2.2015.11.16.10.55.12 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Nov 2015 10:55:12 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) From: Stephen Perry In-Reply-To: Date: Mon, 16 Nov 2015 18:55:13 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <22057.18203.537000.988338@gargle.gargle.HOWL> <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> To: John Wiegley X-Mailer: Apple Mail (2.3096.5) X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 21737 Cc: 21737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Updated patch: diff --git a/lisp/comint.el b/lisp/comint.el index e70fe88..b7a906e 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -283,6 +283,13 @@ comint-move-point-for-output (const others)) :group 'comint) =20 +(defcustom comint-move-point-to-end-on-match nil + "Controls whether point moves to the end of the matched input. +If nil, then point remains in the current position. +If t, point moves to the end of matched input." + :type 'boolean + :group 'comint) + (defvaralias 'comint-scroll-to-bottom-on-output = 'comint-move-point-for-output) =20 (defcustom comint-scroll-show-maximum-output t @@ -1220,7 +1227,8 @@ comint-previous-matching-input-from-input (comint-previous-matching-input (concat "^" (regexp-quote = comint-matching-input-from-input-string)) n) - (goto-char opoint))) + (unless comint-move-point-to-end-on-match + (goto-char opoint)))) =20 (defun comint-next-matching-input-from-input (n) "Search forwards through input history for match for current input. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 20:16:06 2015 Received: (at 21737) by debbugs.gnu.org; 17 Nov 2015 01:16:07 +0000 Received: from localhost ([127.0.0.1]:40659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyUsQ-0002Zp-EL for submit@debbugs.gnu.org; Mon, 16 Nov 2015 20:16:06 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:59791 helo=homiemail-a12.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyUs5-0002Ym-Pr for 21737@debbugs.gnu.org; Mon, 16 Nov 2015 20:16:04 -0500 Received: from homiemail-a12.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a12.g.dreamhost.com (Postfix) with ESMTP id 011101030063; Mon, 16 Nov 2015 17:15:44 -0800 (PST) Received: from localhost.linkov.net (m91-131-172-22.cust.tele2.ee [91.131.172.22]) (Authenticated sender: jurta@jurta.org) by homiemail-a12.g.dreamhost.com (Postfix) with ESMTPA id E2D0B103005E; Mon, 16 Nov 2015 17:15:43 -0800 (PST) From: Juri Linkov To: Stephen Perry Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) Organization: LINKOV.NET References: <22057.18203.537000.988338@gargle.gargle.HOWL> <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> Date: Tue, 17 Nov 2015 02:58:48 +0200 In-Reply-To: (Stephen Perry's message of "Mon, 16 Nov 2015 18:55:13 +0000") Message-ID: <87k2pho2tj.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21737 Cc: John Wiegley , 21737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > +(defcustom comint-move-point-to-end-on-match nil > + "Controls whether point moves to the end of the matched input. > +If nil, then point remains in the current position. > +If t, point moves to the end of matched input." > + :type 'boolean > + :group 'comint) > + > (defvaralias 'comint-scroll-to-bottom-on-output 'comint-move-point-for-output) > > (defcustom comint-scroll-show-maximum-output t > @@ -1220,7 +1227,8 @@ comint-previous-matching-input-from-input > (comint-previous-matching-input > (concat "^" (regexp-quote comint-matching-input-from-input-string)) > n) > - (goto-char opoint))) > + (unless comint-move-point-to-end-on-match > + (goto-char opoint)))) I wonder could we use the logic of 'track-eol' here? This means that going to the previous command lines starting at the end of the command line will keep to the ends of command lines. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 08:08:34 2015 Received: (at 21737) by debbugs.gnu.org; 17 Nov 2015 13:08:35 +0000 Received: from localhost ([127.0.0.1]:41099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zyfzu-0004u1-85 for submit@debbugs.gnu.org; Tue, 17 Nov 2015 08:08:34 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35758) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zyfzr-0004tp-KX for 21737@debbugs.gnu.org; Tue, 17 Nov 2015 08:08:32 -0500 Received: by wmdw130 with SMTP id w130so154084306wmd.0 for <21737@debbugs.gnu.org>; Tue, 17 Nov 2015 05:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ZAC/dDPSU/8jxsK9Hsoe9qjnLzz5ZojW7qHVYKR6tao=; b=iCfLtP2ulUbFouUh0wbk6XCZTYljx/ZpnCjse9LEX7aiJhSPsVqcFqgr7TjtjNjWXG x/LNS8UZWQyPQKAisdvoFw7aBg2N39bf1v2o1k1CMj1TqRfSKjICLWqfcK+LlNeeCu9o P3WynSXxIEn5GUM/VNQTmF1hIE3kwowcDmkwtbj77f53u80bQkI3aOAxfogMiEDQaqtH Gcw+2+c5mZtUYlD+ksE4GrEqskY5VecZvSRAz2OfIEj2BSenMnEUcP9xTeXGHK+uZEJX NvsudGzXEWcyALfokGBj2W48s5nfHD4j1SzkJLj1A69w8rJejBjvyc2jKtDMRVsfoYA9 Kr5Q== X-Received: by 10.194.92.138 with SMTP id cm10mr43691699wjb.6.1447765711090; Tue, 17 Nov 2015 05:08:31 -0800 (PST) Received: from [192.168.0.53] (host81-138-103-242.in-addr.btopenworld.com. [81.138.103.242]) by smtp.gmail.com with ESMTPSA id lv4sm39861159wjb.43.2015.11.17.05.08.29 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Nov 2015 05:08:29 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) From: Stephen Perry In-Reply-To: <87k2pho2tj.fsf@mail.linkov.net> Date: Tue, 17 Nov 2015 13:08:29 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <8D94ED5A-0304-479A-A1EC-AD5768EA206D@gmail.com> References: <22057.18203.537000.988338@gargle.gargle.HOWL> <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> <87k2pho2tj.fsf@mail.linkov.net> To: Juri Linkov X-Mailer: Apple Mail (2.3096.5) X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 21737 Cc: John Wiegley , 21737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > On 17 Nov 2015, at 00:58, Juri Linkov wrote: >=20 >> +(defcustom comint-move-point-to-end-on-match nil >> + "Controls whether point moves to the end of the matched input. >> +If nil, then point remains in the current position. >> +If t, point moves to the end of matched input." >> + :type 'boolean >> + :group 'comint) >> + >> (defvaralias 'comint-scroll-to-bottom-on-output = 'comint-move-point-for-output) >>=20 >> (defcustom comint-scroll-show-maximum-output t >> @@ -1220,7 +1227,8 @@ comint-previous-matching-input-from-input >> (comint-previous-matching-input >> (concat "^" (regexp-quote = comint-matching-input-from-input-string)) >> n) >> - (goto-char opoint))) >> + (unless comint-move-point-to-end-on-match >> + (goto-char opoint)))) >=20 > I wonder could we use the logic of 'track-eol' here? This means that = going > to the previous command lines starting at the end of the command line = will > keep to the ends of command lines. It=E2=80=99s a trivial change to make, but I=E2=80=99m not sure if = having it do the same thing will be annoying for people who don=E2=80=99t want track-eol turned on everywhere? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 18 20:07:46 2015 Received: (at 21737) by debbugs.gnu.org; 19 Nov 2015 01:07:46 +0000 Received: from localhost ([127.0.0.1]:43894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzDhS-000640-3K for submit@debbugs.gnu.org; Wed, 18 Nov 2015 20:07:46 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:34622 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzDh7-00063A-Um for 21737@debbugs.gnu.org; Wed, 18 Nov 2015 20:07:44 -0500 Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id DFC3925006B; Wed, 18 Nov 2015 17:07:24 -0800 (PST) Received: from localhost.linkov.net (m91-131-172-22.cust.tele2.ee [91.131.172.22]) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPA id BF2C3250069; Wed, 18 Nov 2015 17:07:23 -0800 (PST) From: Juri Linkov To: Stephen Perry Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) Organization: LINKOV.NET References: <22057.18203.537000.988338@gargle.gargle.HOWL> <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> <87k2pho2tj.fsf@mail.linkov.net> <8D94ED5A-0304-479A-A1EC-AD5768EA206D@gmail.com> Date: Thu, 19 Nov 2015 02:33:32 +0200 In-Reply-To: <8D94ED5A-0304-479A-A1EC-AD5768EA206D@gmail.com> (Stephen Perry's message of "Tue, 17 Nov 2015 13:08:29 +0000") Message-ID: <87fv02keab.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21737 Cc: John Wiegley , 21737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> I wonder could we use the logic of 'track-eol' here? This means that = going >> to the previous command lines starting at the end of the command line = will >> keep to the ends of command lines. > > It=E2=80=99s a trivial change to make, but I=E2=80=99m not sure if havi= ng it do > the same thing will be annoying for people who don=E2=80=99t want > track-eol turned on everywhere? We have it working this way in navigating the minibuffer's history, so users are already accustomed to this behavior. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 13:42:34 2020 Received: (at 21737) by debbugs.gnu.org; 17 Sep 2020 17:42:34 +0000 Received: from localhost ([127.0.0.1]:38912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxvV-0007m4-QR for submit@debbugs.gnu.org; Thu, 17 Sep 2020 13:42:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxvU-0007lr-7a for 21737@debbugs.gnu.org; Thu, 17 Sep 2020 13:42:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Xk1dqPXDJ9bELpTPo6HihGxS7cPJLeXnsA03gjnmKkM=; b=EBqGXlb+QpO3ETGYd0NeqY1iPE cVYS7saOixpSwK93hqFYHey2w9AGYqkiFidYmTO5fUQq9UssBs0MGKSdeaYejzbTAploUj5qHYctw b8Ykvr4RdpIdP7EJ5PidvGtwuyOcmQvh0zOnP9nH6V5Obc35l9eJySdcUnI0cJhduvq0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIxvL-0003AS-Ox; Thu, 17 Sep 2020 19:42:26 +0200 From: Lars Ingebrigtsen To: Stephen Perry Subject: Re: bug#21737: Acknowledgement (24.5; Minor feature request: `comint-previous-matching-input-from-input' and point) References: <22057.18203.537000.988338@gargle.gargle.HOWL> <3B07598E-834E-4071-8EF2-F32AF4B15164@gmail.com> X-Now-Playing: African Head Charge's _Drastic Season_: "Many Generations" Date: Thu, 17 Sep 2020 19:42:22 +0200 In-Reply-To: (Stephen Perry's message of "Mon, 16 Nov 2015 18:55:13 +0000") Message-ID: <875z8cnvup.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Perry writes: > +(defcustom comint-move-point-to-end-on-match nil > + "Controls whether point moves to the end of the matched input. > +If nil, then point remains in the current position. > +If t, point moves to th [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21737 Cc: John Wiegley , 21737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Perry writes: > +(defcustom comint-move-point-to-end-on-match nil > + "Controls whether point moves to the end of the matched input. > +If nil, then point remains in the current position. > +If t, point moves to the end of matched input." > + :type 'boolean > + :group 'comint) It seems like this was fixed by a somewhat similar patch the year after, so I'm closing this bug report: commit afe2997119a5e6b108851f2e236037da1d4acef2 Author: Philipp Stephani AuthorDate: Thu Oct 27 00:28:34 2016 +0200 Comint: new user option for C-c M-r and C-c M-s This option allows the user to specify where to place point after these commands. * comint.el (comint-move-point-for-matching-input): New user option. (comint-previous-matching-input-from-input): Use user option. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 13:42:43 2020 Received: (at control) by debbugs.gnu.org; 17 Sep 2020 17:42:43 +0000 Received: from localhost ([127.0.0.1]:38915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxvf-0007mR-1F for submit@debbugs.gnu.org; Thu, 17 Sep 2020 13:42:43 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxvd-0007mD-Ec for control@debbugs.gnu.org; Thu, 17 Sep 2020 13:42:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hqXF0IAcDjL1ZDqIYbIecZIjvU1xOUokSbIJNKnIBEA=; b=Qwp+Ug9etT0akt+qv7xrCTASBs lk6F8YJhq/25L9Fx1OCHDeEc2avMlkzgN9JJiboU8yXYKzCiAVmTACAW2GQigRZqSMRhrR80075FM ZHW4Vvf7EVnBAMrbf/XQLUjWtWl5qM2QRVazTas+en0A0d6fQ5Yy7p3Y2jUz9ZHQbwUI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIxvV-0003Ad-JM for control@debbugs.gnu.org; Thu, 17 Sep 2020 19:42:35 +0200 Date: Thu, 17 Sep 2020 19:42:32 +0200 Message-Id: <874knwnvuf.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21737 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 21737 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 21737 quit From unknown Tue Aug 19 10:04:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 16 Oct 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator