GNU bug report logs - #21714
25.0.50; image-metadata using Emacs --with-ns prevents *.gif animation.

Previous Next

Full log

Message #25 received at 21714 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: npostavs <at> users.sourceforge.net
Cc: Keith David Bershatsky <esq <at> lawlist.com>, 21714 <at> debbugs.gnu.org
Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port
 (bug#21714)
Date: Sun, 13 Aug 2017 15:56:12 +0100

On Sun, Aug 13, 2017 at 09:54:39AM -0400, npostavs <at> users.sourceforge.net wrote:
> Alan Third <alan <at> idiocy.org> writes:
> 
> > On Sun, Aug 13, 2017 at 09:21:44AM -0400, npostavs <at> users.sourceforge.net wrote:
> >> Alan Third <alan <at> idiocy.org> writes:
> >>  
> >> > +static Lisp_Object
> >> > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found)
> >> > +{
> >> > +  Lisp_Object tail;
> >> > +
> >> > +  eassert (valid_image_p (spec));
> >> > +
> >> > +  for (tail = XCDR (spec);
> >> > +       CONSP (tail) && CONSP (XCDR (tail));
> >> > +       tail = XCDR (XCDR (tail)))
> >> > +    {
> >> > +      if (EQ (XCAR (tail), key))
> >> > +	{
> >> > +	  if (found)
> >> > +	    *found = 1;
> >> > +	  return XCAR (XCDR (tail));
> >> > +	}
> >> > +    }
> >> 
> >> Wouldn't it be clearer to call Fplist_get here?
> 
> Actually we would need Fplist_member to set the 'found' parameter
> correctly in case the value is Qnil.  Hmm, that one can signal an error,
> so potentially it's not the right thing.

In this particular case I’m not using the found parameter anyway so
Fplist_get will work fine.

-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.