GNU bug report logs - #21714
25.0.50; image-metadata using Emacs --with-ns prevents *.gif animation.

Previous Next

Full log

Message #19 received at 21714 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: npostavs <at> users.sourceforge.net
Cc: Keith David Bershatsky <esq <at> lawlist.com>, 21714 <at> debbugs.gnu.org
Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port
 (bug#21714)
Date: Sun, 13 Aug 2017 14:37:45 +0100

On Sun, Aug 13, 2017 at 09:21:44AM -0400, npostavs <at> users.sourceforge.net wrote:
> Alan Third <alan <at> idiocy.org> writes:
>  
> > +static Lisp_Object
> > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found)
> > +{
> > +  Lisp_Object tail;
> > +
> > +  eassert (valid_image_p (spec));
> > +
> > +  for (tail = XCDR (spec);
> > +       CONSP (tail) && CONSP (XCDR (tail));
> > +       tail = XCDR (XCDR (tail)))
> > +    {
> > +      if (EQ (XCAR (tail), key))
> > +	{
> > +	  if (found)
> > +	    *found = 1;
> > +	  return XCAR (XCDR (tail));
> > +	}
> > +    }
> 
> Wouldn't it be clearer to call Fplist_get here?

Yes I think it would. I actually just copied the code from image.c, so
would it maybe be worth tidying up that code too?

Thanks!
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.