From unknown Fri Jun 20 07:17:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#21714 <21714@debbugs.gnu.org> To: bug#21714 <21714@debbugs.gnu.org> Subject: Status: 25.0.50; image-metadata using Emacs --with-ns prevents *.gif animation. Reply-To: bug#21714 <21714@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:17:43 +0000 retitle 21714 25.0.50; image-metadata using Emacs --with-ns prevents *.gif = animation. reassign 21714 emacs submitter 21714 Keith David Bershatsky severity 21714 normal tag 21714 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 12:29:31 2015 Received: (at submit) by debbugs.gnu.org; 19 Oct 2015 16:29:31 +0000 Received: from localhost ([127.0.0.1]:56948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZoDJS-0004y0-Ug for submit@debbugs.gnu.org; Mon, 19 Oct 2015 12:29:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60229) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZoDJQ-0004xm-Jx for submit@debbugs.gnu.org; Mon, 19 Oct 2015 12:29:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoDJP-0000yR-1X for submit@debbugs.gnu.org; Mon, 19 Oct 2015 12:29:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoDJO-0000yN-VR for submit@debbugs.gnu.org; Mon, 19 Oct 2015 12:29:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoDJN-0001WC-Lu for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 12:29:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoDJJ-0000xK-Jk for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 12:29:25 -0400 Received: from cobb.liquidweb.com ([50.28.13.150]:33435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoDJJ-0000wr-CS for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 12:29:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com; s=default; h=Content-Type:MIME-Version:Subject:To:From:Message-ID:Date; bh=kSRERqc/KrpfoX9XYdAdiav/JPg7N28VHCD/fxCAzrE=; b=WSc12Ni5esr5Y50osKlLqe5Tgqm+CqkK8TI+mo3FHDpEkdDa6YTlOh3/5MKo6K890QUby3DHXSUOk0C+YshBLX278VYI/eXP8bBTtgsQ5N0Qaj3Ezf8ASrhmyTb6Lnbv; Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:49391 helo=server.local.localhost) by cobb.liquidweb.com with esmtp (Exim 4.82) (envelope-from ) id 1ZoDJF-0002ym-Ci for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 12:29:17 -0400 Date: Mon, 19 Oct 2015 09:29:17 -0700 Message-ID: From: Keith David Bershatsky To: bug-gnu-emacs@gnu.org Subject: 25.0.50; image-metadata using Emacs --with-ns prevents *.gif animation. MIME-Version: 1.0 (generated by - "") Content-Type: text/plain; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cobb.liquidweb.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-Get-Message-Sender-Via: cobb.liquidweb.com: acl_c_relayhosts_text_entry: lawlist|lawlist.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When using Emacs built --with-ns on OSX 10.6.8, the function `image-metadata` returns `nil` when trying to animate a *.gif file with the built-in image-mode by pressing the return key. I suspect it is because `valid_image_p` returns `nil`, but I do not know how to test that internal function. When opening a *.gif image, Emacs successfully displays the first image in the series of multiple images. Pressing the return key yields: "No image animation." OSX has its own built-in image support when building --with-ns, which is why I am able to see the first of the *.gif images. (image-type-available-p 'gif) returns t, so I am fairly certain I have image support. Animation works on Emacs for Windows, but not OSX. Thanks, Keith ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.0.50.1 (x86_64-apple-darwin10.8.0, NS appkit-1038.36 Version 10.6.8 (Build 10K549)) of 2015-10-13 Repository revision: 6d6bf466477b004035a4314886e35214c6f8603b Windowing system distributor 'Apple', version 10.3.1038 Configured using: 'configure --with-ns --without-imagemagick --enable-checking=glyphs' Configured features: RSVG DBUS ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: locale-coding-system: utf-8-unix Major mode: C Minor modes in effect: tb-mode: t sb-mode: t ml-mode: t sd-mode: t fl-mode: t bc-mode: t +-mode: t buffer-read-only: t abbrev-mode: t Recent messages: Type C-c C-c to view the image as text. Wrote /Users/HOME/.0.data/.0.emacs/.lock Emacs: image-metadata *beep* if: End of buffer Load-path shadows: None found. Features: (shadow emacsbug sendmail lawlist-ztree lawlist-ys lawlist-ws lawlist-wl elmo-imap4 elmo-localdir modb-standard modb-legacy elmo-internal elmo-flag mmelmo-imap mmelmo-buffer elsp-generic mel-u ps-print ps-def lpr epg-config enriched lawlist-w3m doc-view jka-compr image-mode ccl lawlist-vl lawlist-view lawlist-undo lawlist-txt lawlist-tm lawlist-tex compare-w lawlist-tabbar lawlist-speedbar lawlist-shell info esh-groups ehelp ange-ftp lawlist-sgml lawlist-sb lawlist-saveplace lawlist-ruler lawlist-replace lawlist-rectangle lawlist-re-builder lawlist-python skeleton lawlist-profiler lawlist-print lawlist-php cl-seq cc-langs lawlist-perl lawlist-parens lawlist-org lawlist-calendar org-agenda org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func holidays hol-loaddefs cal-menu calendar cal-loaddefs lawlist-neotree lawlist-movement lawlist-mouse lawlist-ml lawlist-misc lawlist-messages lawlist-mc rect lawlist-markdown noutline outline lawlist-lorem lawlist-ln lawlist-keymap lawlist-js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs lawlist-ispell lawlist-isearch lawlist-imenu lawlist-ibuffer lawlist-hl lawlist-grep lawlist-git ido seq vc-git vc vc-dispatcher thingatpt time-stamp subr-x server nntp gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls utf7 netrc parse-time gnus-spec gnus-int gnus-range gnus-win nnoo mm-view mml-smime smime dig mailcap log-edit message mml mml-sec mm-decode mm-bodies mm-encode gmm-utils mailheader pcvs-util add-log ldap json find-lisp ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff diff-mode conf-mode autorevert filenotify lawlist-framebufs lawlist-frame lawlist-fm lawlist-files zeroconf dbus xml lawlist-env lawlist-elscreen lawlist-elisp lawlist-dv lawlist-image lawlist-ds lawlist-dired dired format-spec lawlist-diff lawlist-desktop frameset lawlist-debug lawlist-window debug lawlist-css smie lawlist-compile rx lawlist-color lawlist-cm lawlist-cc lawlist-font-lock cl-macs lawlist-calc lawlist-calc+ lawlist-bk lawlist-bc lawlist-bbdb gnus gnus-ems nnheader mail-utils wid-edit mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-extr rfc822 timezone lawlist-minibuffer gv lawlist-auth gnus-util mm-util help-fns mail-prsvr password-cache lawlist-as lawlist-archive lawlist-+ lawlist-lcl byte-opt bytecomp byte-compile cl-extra cconv lawlist-help disp-table easy-mmode edmacro kmacro quail help-mode easymenu cl-loaddefs cl-lib pcase derived advice shell pcomplete comint ansi-color ring savehist time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 2395843 198980) (symbols 48 89769 0) (miscs 40 1373 1067) (strings 32 212905 17549) (string-bytes 1 7685690) (vectors 16 44361) (vector-slots 8 1091868 14715) (floats 8 4334 755) (intervals 56 1101 110) (buffers 976 15)) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 19:41:20 2015 Received: (at 21714) by debbugs.gnu.org; 19 Oct 2015 23:41:20 +0000 Received: from localhost ([127.0.0.1]:57136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZoK3L-0001ID-Ly for submit@debbugs.gnu.org; Mon, 19 Oct 2015 19:41:19 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:35531) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZoK31-0001H6-Gk for 21714@debbugs.gnu.org; Mon, 19 Oct 2015 19:41:18 -0400 Received: by igbkq10 with SMTP id kq10so63580532igb.0 for <21714@debbugs.gnu.org>; Mon, 19 Oct 2015 16:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=iwQJ5xPY8Ou/f+19inXLyNVEQIwlVtb+1JveHuMOAVY=; b=kp5X+x01m6SCEKBV93p7EB3enpc2ak8m2E528C8CnXfhueoHCCKgJbpigYNev6gLaf o0qZDCOnokkZRLEOOkwS5JiEQ74Um0LGdxmv8cyi3yaBtMfT6QV+cUWxpZ01Q0ul2Z8K qxBEYKnPErgSjps6d+4RiouuYCPixP7hH1aIkS1mOdH0srcNsX5PnxKoMhAGbk6GQDwB Aw8gL5OaLOGrVyVg8i0wMMaTSBNiqBo8Rqste9ODwyMqhAQ25ffuUeQfMmK/MRjGGC8v iYCRrtmB+Ig4w0+Zb2u3pXu5PhP+PYTgT5UfgzanM2Y8IaCuBcGyUEg09cS3INiO3QA0 ZW2w== MIME-Version: 1.0 X-Received: by 10.50.142.99 with SMTP id rv3mr1038945igb.16.1445298058703; Mon, 19 Oct 2015 16:40:58 -0700 (PDT) Received: by 10.79.94.2 with HTTP; Mon, 19 Oct 2015 16:40:58 -0700 (PDT) In-Reply-To: References: Date: Tue, 20 Oct 2015 07:40:58 +0800 Message-ID: Subject: Re: bug#21714: 25.0.50; image-metadata using Emacs --with-ns prevents *.gif animation. From: Xue Fuqiao To: Keith David Bershatsky Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21714 Cc: 21714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Oct 20, 2015 at 12:29 AM, Keith David Bershatsky wrote: > When opening a *.gif image, Emacs successfully displays the first image in the series of multiple images. Pressing the return key yields: "No image animation." Yes, I can reproduce this problem on OS X 10.11 with Emacs master. Configured features: ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 20:58:30 2017 Received: (at 21714) by debbugs.gnu.org; 13 Aug 2017 00:58:30 +0000 Received: from localhost ([127.0.0.1]:58999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dghEc-00006i-3A for submit@debbugs.gnu.org; Sat, 12 Aug 2017 20:58:30 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:32958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dghEa-00006a-4u for 21714@debbugs.gnu.org; Sat, 12 Aug 2017 20:58:28 -0400 Received: by mail-wr0-f196.google.com with SMTP id y43so4853812wrd.0 for <21714@debbugs.gnu.org>; Sat, 12 Aug 2017 17:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=rk9l7pnyLzBXpZMbGzmhfeuWxEYozQJI/GjA6bul5qY=; b=g5fHav5ERuVSAQkWW1CsEJYoFBcYNK8Qi8TPrm0FheGfbnkEpiuSUa8FFcRu/Qn0QP DAX0yAvt3jiifZpru3tRbFSOfNbIHX40uQDMTDMI/oZRhfQMXFhnpGSuDlpuba+xfOct sLDh/wAAZWxJxXEPWwXkoYXtARmAiR7FHIIWg2TTenV3PBJIibhAnQRbwo7nSpaWKisa hTi6uU9jHqdz/OoWN9s/agZp56Gplfsg6Cs1c5y64Pnw4/ZI4y1psO3d2G8ix/jl2WsT 4EF3ts1QOx+eIyv4rHqZlro83nfv1uIkqx0KCxvtzoAtAU7XXPiQUGU9EDLA1iKcaFuF VcgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mime-version:content-disposition:user-agent; bh=rk9l7pnyLzBXpZMbGzmhfeuWxEYozQJI/GjA6bul5qY=; b=MtJOeiZH87BZxs2hcvpMWyulH5Fm2FQrPzfTBSKEUppfgXLdLA1yCeo/n2HVKMRwan cF1wxj0wbHhw2arRaO8eMCcbuDwKR+rw3jL0NJNYkvrh3PL2HoLLesTryFOyn2j53XLQ yc3S9fOYm8wCLxo/hcRG7BlVrYfTm5AY2no0YwUBE+aro3u6RihFJ515UQkCZ7+JS2RG I6i15wZxVAkKQ9FH33NA0fWYiLmSDkFzvBNsslVOCc58tA9STAST5W9wreWrFIkjVQXl aDNzJj6T+AdR60k70+dhTVULbMT/sYFb1iFZnIJH0aZPlVrQ21i06BBXRGbJyuICGn3A 5xvA== X-Gm-Message-State: AHYfb5iLkupbTeQVg05ZqbpDHbjmC3DkaCnDN6YG7GC6NK7RiiZcIH5F jP5g+8qSjca6/8hFcMXtIg== X-Received: by 10.223.129.66 with SMTP id 60mr13418994wrm.130.1502585902284; Sat, 12 Aug 2017 17:58:22 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-8ddc-b80d-a658-c5ed.holly.idiocy.org. [2001:8b0:3f8:8129:8ddc:b80d:a658:c5ed]) by smtp.gmail.com with ESMTPSA id p4sm3111970wrd.50.2017.08.12.17.58.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Aug 2017 17:58:21 -0700 (PDT) Date: Sun, 13 Aug 2017 01:58:18 +0100 From: Alan Third To: Keith David Bershatsky Subject: [PATCH] Add multiframe image support to NS port (bug#21714) Message-ID: <20170813005818.GA27146@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 21714 Cc: 21714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) * src/nsimage.m (image_spec_value): New function. (ns_load_image): Handle multiple frames. (EmacsImage::getMetadata, EmacsImage::setFrame): New function. * src/nsterm.h (EmacsImage::getMetadata, EmacsImage::setFrame): New function prototypes. --- src/nsimage.m | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/nsterm.h | 2 ++ 2 files changed, 81 insertions(+) diff --git a/src/nsimage.m b/src/nsimage.m index fb2322afc3..6717202199 100644 --- a/src/nsimage.m +++ b/src/nsimage.m @@ -70,12 +70,38 @@ Updated by Christian Limpach (chris@nice.ch) return [EmacsImage allocInitFromFile: file]; } +static Lisp_Object +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found) +{ + Lisp_Object tail; + + eassert (valid_image_p (spec)); + + for (tail = XCDR (spec); + CONSP (tail) && CONSP (XCDR (tail)); + tail = XCDR (XCDR (tail))) + { + if (EQ (XCAR (tail), key)) + { + if (found) + *found = 1; + return XCAR (XCDR (tail)); + } + } + + if (found) + *found = 0; + return Qnil; +} + bool ns_load_image (struct frame *f, struct image *img, Lisp_Object spec_file, Lisp_Object spec_data) { EmacsImage *eImg = nil; NSSize size; + Lisp_Object lisp_index = image_spec_value (img->spec, QCindex, NULL); + unsigned int index = INTEGERP (lisp_index) ? XFASTINT (lisp_index) : 0; NSTRACE ("ns_load_image"); @@ -99,12 +125,20 @@ Updated by Christian Limpach (chris@nice.ch) return 0; } + if (index < 0 || ![eImg setFrame: index]) + { + add_to_log ("Unable to set index %d for image %s", index, img->spec); + return 0; + } + size = [eImg size]; img->width = size.width; img->height = size.height; /* 4) set img->pixmap = emacsimage */ img->pixmap = eImg; + + img->lisp_data = [eImg getMetadata]; return 1; } @@ -435,4 +469,49 @@ - (NSColor *)stippleMask return stippleMask; } +/* If the image has multiple frames, get a count of them and the + animation delay, if available. */ +- (Lisp_Object)getMetadata +{ + Lisp_Object metadata = Qnil; + + for (NSImageRep * r in [self representations]) + { + if ([r isKindOfClass:[NSBitmapImageRep class]]) + { + NSBitmapImageRep * bm = (NSBitmapImageRep *)r; + int frames = [[bm valueForProperty: NSImageFrameCount] intValue]; + float delay = [[bm valueForProperty: NSImageCurrentFrameDuration] + floatValue]; + + if (frames > 1) + metadata = Fcons (Qcount, Fcons (make_number (frames), metadata)); + if (delay > 0) + metadata = Fcons (Qdelay, Fcons (make_float (delay), metadata)); + break; + } + } + return metadata; +} + +/* Attempt to set the animation frame to be displayed. */ +- (BOOL)setFrame: (unsigned int) index +{ + for (NSImageRep * r in [self representations]) + { + if ([r isKindOfClass:[NSBitmapImageRep class]]) + { + NSBitmapImageRep * bm = (NSBitmapImageRep *)r; + if ([[bm valueForProperty: NSImageFrameCount] intValue] <= index) + continue; + + [bm setProperty: NSImageCurrentFrame + withValue: [NSNumber numberWithUnsignedInt: index]]; + return YES; + } + } + + return NO; +} + @end diff --git a/src/nsterm.h b/src/nsterm.h index 0f1b36db7b..67c0d42ac1 100644 --- a/src/nsterm.h +++ b/src/nsterm.h @@ -668,6 +668,8 @@ typedef id instancetype; alpha:(unsigned char)a; - (void)setAlphaAtX: (int)x Y: (int)y to: (unsigned char)a; - (NSColor *)stippleMask; +- (Lisp_Object)getMetadata; +- (BOOL)setFrame: (unsigned int) index; @end -- Animated gif support, and I expect it to handle tiff with multiple layers, or whatever. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 20:59:54 2017 Received: (at control) by debbugs.gnu.org; 13 Aug 2017 00:59:54 +0000 Received: from localhost ([127.0.0.1]:59003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dghFy-00007V-FM for submit@debbugs.gnu.org; Sat, 12 Aug 2017 20:59:54 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:38112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dghFx-00007P-Aj for control@debbugs.gnu.org; Sat, 12 Aug 2017 20:59:53 -0400 Received: by mail-wm0-f67.google.com with SMTP id y206so10518209wmd.5 for ; Sat, 12 Aug 2017 17:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:message-id:to:from:subject; bh=g+FRT9iqkRcaBTpzYXqw/I3Ox4mH+cyKp/kwfBLODHU=; b=cbZrbuS3/IcX7vQjdTwWQIdmJSfARINmpPMUu1IPMTx1IIVKIwsDRltoTH0N+MEz2p axbHnrjyreaGP70GkfysJBxOD2egLS+hT1l3SuhOY9Vow2+LL5t5QJp9cTduWlcuwK5q YCuJMP4az7DQ87escVKasxzV3wxbY8mtHlRl2NqoLoDO9WP4yV5kMQa6BiKGIPd7w/LO QH2j9hp2bjTY+JFKK6lgujytpcIR58thk92/ZbCT0gn5S4YQX+nM8Y4W5VmBOf6qokhW fjAt+/2iVTfvi4QJi/FUBQUukGOPxJyY+zVDmuBt4uPbB/7c8MtMmanfxs1fOTcXzXYd YlnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:to:from:subject; bh=g+FRT9iqkRcaBTpzYXqw/I3Ox4mH+cyKp/kwfBLODHU=; b=S2hq8+fqFdijAlHQk1Pfnsjh1IkcrajH8TKgEUYoQIppjuJtiZ9b8cvxMoyPU6iqLi 7hhH5cezKH2rUP1QvMwsZCzdOJlo7ufv+RhVOH/HytBXjvgCQHxB/7c4YdsSTDRUsAzp mucl2CpHsObyIpx/R+ycq/kqOTD1LOiNPPfk5EzJIA9FbYfhNG/wFJvVZTuyYWn51mBy QWV98KlE3bOFlbuf0vk5iC+Dc9eknZd6hgJG8Le5twV1YLpAgEPTArsOUd9n9dpdUF4u L0c1VlLJ/thMJN6Uu7zj53OdaRDXmSa55nqD88oNSx0XSjyXfaz6uOFfaIfWnGp3Z/hd wQpQ== X-Gm-Message-State: AHYfb5jzhA8WuAci8hXpXCWblforZBIpXcTvxwms0C4feF2S8t1RAKvu HR1YxHPcJQCY4itzAUjgNA== X-Received: by 10.28.203.206 with SMTP id b197mr1580559wmg.120.1502585987229; Sat, 12 Aug 2017 17:59:47 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-8ddc-b80d-a658-c5ed.holly.idiocy.org. [2001:8b0:3f8:8129:8ddc:b80d:a658:c5ed]) by smtp.gmail.com with ESMTPSA id h33sm2940645wrh.23.2017.08.12.17.59.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 12 Aug 2017 17:59:46 -0700 (PDT) Date: Sun, 13 Aug 2017 01:59:45 +0100 Message-Id: To: control@debbugs.gnu.org From: Alan Third Subject: control message for bug #21714 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 21714 patch From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 13 09:20:14 2017 Received: (at 21714) by debbugs.gnu.org; 13 Aug 2017 13:20:14 +0000 Received: from localhost ([127.0.0.1]:59296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgsoQ-0003Pl-8M for submit@debbugs.gnu.org; Sun, 13 Aug 2017 09:20:14 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:38871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgsoO-0003Pf-Cn for 21714@debbugs.gnu.org; Sun, 13 Aug 2017 09:20:12 -0400 Received: by mail-it0-f66.google.com with SMTP id f16so6460390itb.5 for <21714@debbugs.gnu.org>; Sun, 13 Aug 2017 06:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nsw9Fo4CVcb7YV+kc2ZaiqDc4Lpa9AvlHQAXdo6Rg/A=; b=XyLNKRY5L0VoThFA4nRCyNnk8D6G4oQZfyeCha4W02FuoogwLdVy5Tus3+k6MkqMXB uIpzpb+fMK/Lk5RURTQJ6yXpfIf6YJ8f3vVcIcrZr/8UYnJIyxtULpmeXRm0YWUgxuc7 XU4UIol9j9b9/MpfrEAUMcHahjtmN5IP8cgqttdfV5Jcwsk9JI5yKsCQvT4mui4qHmbz VNrJ/TiN2s2Pv7RbtsvTsRudzkvk+L5y12J4URZexEh8UJXabr0xFhQg5Gt04vAyVZeE 2sKRh0qjAKdfFkSx6hs0sKyugNEvvFCmPBU/OqvctFt/JIWF2tu08VYOjxeTIXDKwzHm pxUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=nsw9Fo4CVcb7YV+kc2ZaiqDc4Lpa9AvlHQAXdo6Rg/A=; b=rdPuTFUEjuTqJmLAySv7SdkczfUCOlbH77RkR3K91gKsvyQsiHHVsm7N5jYGePdoAk DMtK3DvGZVB1WiM6cN1ITeKdKIvkkyqdtXrJpVx/wjmCTTLy8SZuUu8rfFA4H/iIZCz/ qCAg7dmsYz+SNaOtV6IHmfy+E53cHKd6Hba8jBga1B2yHoVgROrc8X3RRozwpiVBJmhf cSdCjP+1x91AXj64MRwjstvLR2/UqiiBnLqXzQ+rDs8SOyPYCeXvM8boQPvYgZb8fkv1 jlvnvCMJnQuo0Cl4C7sOfdlFaS2VyfIlsTU7rc/5brOHdh1Yd+Mvft6or83Tag2SXjm2 c6KA== X-Gm-Message-State: AHYfb5jyhQTDW759x0VTF7A55KhJXJEZhHDM81vQSKp8n1N6YnW/M2Tb nT1cJ6RxZs3X0Q0O X-Received: by 10.36.26.131 with SMTP id 125mr3662037iti.78.1502630406780; Sun, 13 Aug 2017 06:20:06 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id w74sm2503417iow.55.2017.08.13.06.20.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Aug 2017 06:20:06 -0700 (PDT) From: npostavs@users.sourceforge.net To: Alan Third Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) References: <20170813005818.GA27146@breton.holly.idiocy.org> Date: Sun, 13 Aug 2017 09:21:44 -0400 In-Reply-To: <20170813005818.GA27146@breton.holly.idiocy.org> (Alan Third's message of "Sun, 13 Aug 2017 01:58:18 +0100") Message-ID: <87bmnj1u3b.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 21714 Cc: Keith David Bershatsky , 21714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Alan Third writes: > +static Lisp_Object > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found) > +{ > + Lisp_Object tail; > + > + eassert (valid_image_p (spec)); > + > + for (tail = XCDR (spec); > + CONSP (tail) && CONSP (XCDR (tail)); > + tail = XCDR (XCDR (tail))) > + { > + if (EQ (XCAR (tail), key)) > + { > + if (found) > + *found = 1; > + return XCAR (XCDR (tail)); > + } > + } Wouldn't it be clearer to call Fplist_get here? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 13 09:37:55 2017 Received: (at 21714) by debbugs.gnu.org; 13 Aug 2017 13:37:55 +0000 Received: from localhost ([127.0.0.1]:59311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgt5X-0003YX-KV for submit@debbugs.gnu.org; Sun, 13 Aug 2017 09:37:55 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgt5V-0003YR-VP for 21714@debbugs.gnu.org; Sun, 13 Aug 2017 09:37:54 -0400 Received: by mail-wr0-f193.google.com with SMTP id g32so5469065wrd.5 for <21714@debbugs.gnu.org>; Sun, 13 Aug 2017 06:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=c5/KSZ3IjxQvUoPOpbELkF835LJ/wX1nEpw+e/1FPvw=; b=LtDm49opUDqPCJELsJJII/Tj9iaIQcMVtNBs8qe1ko+xPfo66C/N2y+a/3aLQMCJQ8 SvPpeM5lkchNY7UbpWPM265A39bLEtdSglKRsgB8SJ5kxWpVhGpSJYXvv87LEz+2hRJK U94Ga0L24SLMWeQ0w7GM6avMVfFBCqya4LiIa+rM5L01Jz7ZxAvkoLX/GE7hoUHnuRJe 6Rjce4AlX2Fbdhvz8C+aYP9WuMnIGCN/ngobQSNont6e8e/4xuuDbXpFPocY+Xy5L6MO Wh2dCIMQPyiCEvpcuxZXhP5Vb28D8GKN8/zfniu+EEREc6S0jmA8bYuk9+Mj0Q10cOeh v1jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=c5/KSZ3IjxQvUoPOpbELkF835LJ/wX1nEpw+e/1FPvw=; b=oKvx01848jbznIchGRKIhbIG6XA4j1RrzFRigMt2QoZ3jNAQ6qD7T20As3m57/pIlW dYSsxO5dCaMARk1otY0fR3m8/Me3QV2dcCvK6i+T4b+FfKTgdD3YC1+Q8AGLtwMBnt7X 8YITYDz/wCvYuC4sR7Je8Sgca7NtldbwI1TtasLpn9EL4ckHbOLj2oCkSYFEuvGYGyou hqzY7wE5J3N+H8LGxHFnxFewJtYhx1NjPGXMV6CKghLK1QtlO9hPCVJ6aUss/P7pXg5W OIx23vCEkLuePmxO3BiT6Ptk1VXWSPDfb3kkF8VpgB4MBSyXltQOHivLdZyDPJrTPskX 3u3A== X-Gm-Message-State: AHYfb5hi323tWnM8Gqih6IUmvvVr4Jj1n2eNeDuUo8alH21ye+MAoDUx kBPtFppwxIAtGg== X-Received: by 10.223.161.145 with SMTP id u17mr13770219wru.44.1502631468310; Sun, 13 Aug 2017 06:37:48 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-8ddc-b80d-a658-c5ed.holly.idiocy.org. [2001:8b0:3f8:8129:8ddc:b80d:a658:c5ed]) by smtp.gmail.com with ESMTPSA id o24sm2908020wmi.8.2017.08.13.06.37.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Aug 2017 06:37:47 -0700 (PDT) Date: Sun, 13 Aug 2017 14:37:45 +0100 From: Alan Third To: npostavs@users.sourceforge.net Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) Message-ID: <20170813133745.GA45884@breton.holly.idiocy.org> References: <20170813005818.GA27146@breton.holly.idiocy.org> <87bmnj1u3b.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bmnj1u3b.fsf@users.sourceforge.net> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 21714 Cc: Keith David Bershatsky , 21714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Sun, Aug 13, 2017 at 09:21:44AM -0400, npostavs@users.sourceforge.net wrote: > Alan Third writes: > > > +static Lisp_Object > > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found) > > +{ > > + Lisp_Object tail; > > + > > + eassert (valid_image_p (spec)); > > + > > + for (tail = XCDR (spec); > > + CONSP (tail) && CONSP (XCDR (tail)); > > + tail = XCDR (XCDR (tail))) > > + { > > + if (EQ (XCAR (tail), key)) > > + { > > + if (found) > > + *found = 1; > > + return XCAR (XCDR (tail)); > > + } > > + } > > Wouldn't it be clearer to call Fplist_get here? Yes I think it would. I actually just copied the code from image.c, so would it maybe be worth tidying up that code too? Thanks! -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 13 09:53:08 2017 Received: (at 21714) by debbugs.gnu.org; 13 Aug 2017 13:53:08 +0000 Received: from localhost ([127.0.0.1]:59322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgtKG-0003g9-4l for submit@debbugs.gnu.org; Sun, 13 Aug 2017 09:53:08 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:37598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgtKF-0003g3-3T for 21714@debbugs.gnu.org; Sun, 13 Aug 2017 09:53:07 -0400 Received: by mail-io0-f196.google.com with SMTP id c74so6136513iod.4 for <21714@debbugs.gnu.org>; Sun, 13 Aug 2017 06:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=x9zU1w+7gYs6KLeyF6XU0qEh5KeeSOtlucoBX/c4k1U=; b=KCFxT1/LdrPaDgcIFNCiDd78bOBwjkNIoJQ22uJC/524+AmcnVuP9t5OPtEI5meQse oTl5GsIBj6ZSZJxOri+X3fb44hbMgXbWmxN8yCj97fWLKYInT4/CddCdMR0koh0O8rMm aenWWZ7HZfXy/QoCdGxUJfc4sLEIQ5qVXwaIGIvZJYwj9S6+2Hog/zT1719x5/QnLxmH XkQTXoXJx7rDqFdEVa2ohk01Qop5WlB6IWMbi3pqqzdJOM/RB8WZiYLoiC/l3qDLRGzQ 2QHCiGq6aYIhgYH+Dj+I6T/yj5TrbGGYnSCxllpUsrmykthk5wWNSJ2Xeemm5/cgfLAA k0UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=x9zU1w+7gYs6KLeyF6XU0qEh5KeeSOtlucoBX/c4k1U=; b=rC73Qt8XVlxcgw9KFk+1+xXt9rhdub0ZxRkaZ8qhxRuRBfFF7f3V4rqJv9hKNeaFkW emHH8Y2QXG7f6MeBe6ecpTUyYPUm7/8++ilZFxGiu0zGduBg3U8tsMzC5s64Thg9i8k9 SEpcAJ+kXOGBn/UwPI1T8/ZGRy3DPZZYPQkU9sQI3DX4TSF6kBrtdE7URAFeaFCI8Yub qrQFWHMsLc+1ehc/N7SVy9D+6gRTly2URP0FehRGOLDy5jZ0KNc80D0FpX7uojAdSo4l 4UAcBncDq2NPfsxSAgiUWd6ANvcUCE8aZrJRjlHUYZDbh7ZVfw2yPMaLUZutTILXz54j oDcw== X-Gm-Message-State: AHYfb5jp4fBT/UsaIO8rafDg+3Qy+wfI64ymKYl8hFoq3nYybARd8Ux9 pRqIVorQT7KvUw== X-Received: by 10.107.14.17 with SMTP id 17mr17338479ioo.143.1502632381359; Sun, 13 Aug 2017 06:53:01 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id x131sm1711941itf.17.2017.08.13.06.53.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Aug 2017 06:53:00 -0700 (PDT) From: npostavs@users.sourceforge.net To: Alan Third Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) References: <20170813005818.GA27146@breton.holly.idiocy.org> <87bmnj1u3b.fsf@users.sourceforge.net> <20170813133745.GA45884@breton.holly.idiocy.org> Date: Sun, 13 Aug 2017 09:54:39 -0400 In-Reply-To: <20170813133745.GA45884@breton.holly.idiocy.org> (Alan Third's message of "Sun, 13 Aug 2017 14:37:45 +0100") Message-ID: <878tin1skg.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 21714 Cc: Keith David Bershatsky , 21714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Alan Third writes: > On Sun, Aug 13, 2017 at 09:21:44AM -0400, npostavs@users.sourceforge.net wrote: >> Alan Third writes: >> >> > +static Lisp_Object >> > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found) >> > +{ >> > + Lisp_Object tail; >> > + >> > + eassert (valid_image_p (spec)); >> > + >> > + for (tail = XCDR (spec); >> > + CONSP (tail) && CONSP (XCDR (tail)); >> > + tail = XCDR (XCDR (tail))) >> > + { >> > + if (EQ (XCAR (tail), key)) >> > + { >> > + if (found) >> > + *found = 1; >> > + return XCAR (XCDR (tail)); >> > + } >> > + } >> >> Wouldn't it be clearer to call Fplist_get here? Actually we would need Fplist_member to set the 'found' parameter correctly in case the value is Qnil. Hmm, that one can signal an error, so potentially it's not the right thing. > Yes I think it would. I actually just copied the code from image.c, so > would it maybe be worth tidying up that code too? Oh, maybe we should make it non-static and call it rather than copying then? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 13 10:56:23 2017 Received: (at 21714) by debbugs.gnu.org; 13 Aug 2017 14:56:23 +0000 Received: from localhost ([127.0.0.1]:59579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dguJT-0004A1-5h for submit@debbugs.gnu.org; Sun, 13 Aug 2017 10:56:23 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dguJS-00049v-24 for 21714@debbugs.gnu.org; Sun, 13 Aug 2017 10:56:22 -0400 Received: by mail-wm0-f43.google.com with SMTP id i66so26007610wmg.0 for <21714@debbugs.gnu.org>; Sun, 13 Aug 2017 07:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=txwgTi4jhYFtUuTq2MVbriaY0fGBeUWMFsaKc0zHjRU=; b=PzGsvrzy7Ki0+LW7mtcg1oLNYmc8FLXm+4fVecUglvY8Zbu9ZQw80mkaHq6RC5V32Q Y+91ikG56m1SW3ILIrC0sDz+ht3YLLrij2KTYFyCnSAgYqvU0dg4omkv6tzfzVSrfZh5 HAfMgTF8FnkFjEv5Bu+OOumjY/IBmc9NICu3qd2v5vjATMo99VpCuLKRxxI946v3DSuQ Med6lrcEoRNn+uQgCYd4zLHey357/UMJbDardx1YE85baMI10F/QUScbBv/z64Mhe2Rv 1fQHhYE4SSkATfmK0K+sTBxv2pYnopJB7zXLs1cxA8gXZtY33li6NNGoPceptmsRW0xu zziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=txwgTi4jhYFtUuTq2MVbriaY0fGBeUWMFsaKc0zHjRU=; b=GgUjG7odJTE+4HuGnxh31DTUqVkhfZYqW/S+LqtMWo3p8f5rlLUiW1LUKUST58GJIE bkDeH00Ca63kYem/FopkaYSSreZ+MM43udP72L69aURNZOKwp9YXkbOiGrg/TqeC8dld ty4JgfjiSwiSrwje92S+N3r+mTzsdU4CrSxRSeC+gY+OwZCIn7VG5N0emU/xGSxutc79 WLNQtorEPeUM2oMOo/B9ZwUiEI6DaJPoLzoYVbeaZeTh+DCvgq8ia3vIEmVTUsn1UeG0 6wGJRkMBDEnU818NKoT1L13npNPESy0V4D4smlr/y3WzPfGUizJ9mT/zC/j/tmMfpfeO LZIA== X-Gm-Message-State: AHYfb5iAOgzc8wkcIOUAmW8K+5G6ejrwWEVetmcJHEDop0nOwVDOHP0F OKbMsqLHQTgERQ== X-Received: by 10.28.26.5 with SMTP id a5mr2954056wma.80.1502636176057; Sun, 13 Aug 2017 07:56:16 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-8ddc-b80d-a658-c5ed.holly.idiocy.org. [2001:8b0:3f8:8129:8ddc:b80d:a658:c5ed]) by smtp.gmail.com with ESMTPSA id 69sm1339105wrk.2.2017.08.13.07.56.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Aug 2017 07:56:15 -0700 (PDT) Date: Sun, 13 Aug 2017 15:56:12 +0100 From: Alan Third To: npostavs@users.sourceforge.net Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) Message-ID: <20170813145612.GA47351@breton.holly.idiocy.org> References: <20170813005818.GA27146@breton.holly.idiocy.org> <87bmnj1u3b.fsf@users.sourceforge.net> <20170813133745.GA45884@breton.holly.idiocy.org> <878tin1skg.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878tin1skg.fsf@users.sourceforge.net> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 21714 Cc: Keith David Bershatsky , 21714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On Sun, Aug 13, 2017 at 09:54:39AM -0400, npostavs@users.sourceforge.net wrote: > Alan Third writes: > > > On Sun, Aug 13, 2017 at 09:21:44AM -0400, npostavs@users.sourceforge.net wrote: > >> Alan Third writes: > >> > >> > +static Lisp_Object > >> > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found) > >> > +{ > >> > + Lisp_Object tail; > >> > + > >> > + eassert (valid_image_p (spec)); > >> > + > >> > + for (tail = XCDR (spec); > >> > + CONSP (tail) && CONSP (XCDR (tail)); > >> > + tail = XCDR (XCDR (tail))) > >> > + { > >> > + if (EQ (XCAR (tail), key)) > >> > + { > >> > + if (found) > >> > + *found = 1; > >> > + return XCAR (XCDR (tail)); > >> > + } > >> > + } > >> > >> Wouldn't it be clearer to call Fplist_get here? > > Actually we would need Fplist_member to set the 'found' parameter > correctly in case the value is Qnil. Hmm, that one can signal an error, > so potentially it's not the right thing. In this particular case I’m not using the found parameter anyway so Fplist_get will work fine. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 14 12:02:36 2017 Received: (at 21714) by debbugs.gnu.org; 14 Aug 2017 16:02:36 +0000 Received: from localhost ([127.0.0.1]:35667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhHp5-0004rE-UU for submit@debbugs.gnu.org; Mon, 14 Aug 2017 12:02:36 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:32800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhHp4-0004r8-EB for 21714@debbugs.gnu.org; Mon, 14 Aug 2017 12:02:35 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id EECE4224F4 for <21714@debbugs.gnu.org>; Mon, 14 Aug 2017 15:56:45 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1502726205; x=1503590206; bh=6LXySsejLzUtb bxUQd166JjxSRvpCd0SbsD1mh290HU=; b=jV729bWYEvzZRFc7d9KNMPmD2GKpZ VsTw1h2jRiWZfVQPa37NRAKKPnu7MptqQ1fLgQGzjDx4twfZGI2/krMvVU83Yitd 2op8TIClPhpvWMwKWpRvzL+36200kG/1DvVdSM256AI/kel+jhNVL1hi+bi26OW6 Bsn4d1w4kYPUu0= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gkAaUv7q7ebj for <21714@debbugs.gnu.org>; Mon, 14 Aug 2017 15:56:45 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id B9665224F2; Mon, 14 Aug 2017 15:56:44 +0000 (UTC) Date: Mon, 14 Aug 2017 18:02:26 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Alan Third In-reply-to: <20170813005818.GA27146@breton.holly.idiocy.org> (message from Alan Third on Sun, 13 Aug 2017 01:58:18 +0100) Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) References: <20170813005818.GA27146@breton.holly.idiocy.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21714 Cc: esq@lawlist.com, 21714@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Thanks for adding this feature. It's working on my end. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 16:27:29 2017 Received: (at 21714-done) by debbugs.gnu.org; 16 Aug 2017 20:27:29 +0000 Received: from localhost ([127.0.0.1]:41580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di4uW-0002Hc-T7 for submit@debbugs.gnu.org; Wed, 16 Aug 2017 16:27:29 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:33414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di4uV-0002HP-Qy for 21714-done@debbugs.gnu.org; Wed, 16 Aug 2017 16:27:28 -0400 Received: by mail-wr0-f182.google.com with SMTP id b65so26165414wrd.0 for <21714-done@debbugs.gnu.org>; Wed, 16 Aug 2017 13:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lJy/ua8ckOUdM9N04M3RqJjhi3kf5TITPg6j+conhT0=; b=DWf58KfPyvYbIVViltCCirNAFIMJ6bmUv47YtsViIaIXKlflcNVlrVdzPyb5xIvQe0 cBthaO1xJU9qgVkarP5u1FydA145AfoziGXu36TQKj5IaA43s8OpXcX7csYB3L8uh1H3 rRJGj5l5bDALksNZKXt/1pACqJAgHZgnky7LmZQ6i2O2kTV9H3ZvudR43iJJGp1t+FTj BXFP1oxe+OKwziXbqHS6n4k8V7j8+aPjvBN+7HOAsAQ09xuebQfdiCXyt3B+LUQ9/Ma4 rFfGI2dA2S8Nnxzx0abv5Y4MfIr6IKSctADzzXBG8o4WzDtEqo+Pozer9Xs7uHIsurvp MG5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=lJy/ua8ckOUdM9N04M3RqJjhi3kf5TITPg6j+conhT0=; b=mz2aJtGztedzJpoyciFMxEoO+TMyLf9W+qOxAEDbcd5+ZgfXIwR57VFY9pMfnGEoqK b9mc8yGMRJ24gt5Y2UGn7bp9VPATPDo1wk/CuBemj4ADynCtadV0qZ4waAAjP6QIkH0H odgCNaSPulwHqZ25GHF5f6DMrOdrjPRf7X6EeH1ZC1WER/rOp6ISGhF902cz1wuPM7tq 9qMS71cGI284BjG+hEjJGIQ3vTM1I4llVz9e5uPRAXYFCDRB9MVW0byBQ9USwcps++09 0buJXxIaio2Jd299T+BCDd+1NlN6v+/dE62Ey2puejjFa1/ERPZSAwclzw/Oby/Gu7SW N5qw== X-Gm-Message-State: AHYfb5iJihwr0FBgkaJFVY+Ci6uPigk7IlUfUbYP2J/jlLbYQIa42bLd FEDUScHfrzDuZvXrVs4beg== X-Received: by 10.223.150.101 with SMTP id c34mr1815789wra.266.1502915242071; Wed, 16 Aug 2017 13:27:22 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-0595-da88-ef61-e9de.holly.idiocy.org. [2001:8b0:3f8:8129:595:da88:ef61:e9de]) by smtp.gmail.com with ESMTPSA id 80sm2390349wml.23.2017.08.16.13.27.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2017 13:27:21 -0700 (PDT) Date: Wed, 16 Aug 2017 21:27:18 +0100 From: Alan Third To: "Charles A. Roelli" Subject: Re: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) Message-ID: <20170816202718.GA86799@breton.holly.idiocy.org> References: <20170813005818.GA27146@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 21714-done Cc: esq@lawlist.com, 21714-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On Mon, Aug 14, 2017 at 06:02:26PM +0200, Charles A. Roelli wrote: > Thanks for adding this feature. It's working on my end. Thanks. It’s pushed to master now. -- Alan Third From unknown Fri Jun 20 07:17:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Sep 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator