GNU bug report logs - #21707
include-file cleanup for src directory

Previous Next

Full log

Message #8 received at 21707 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21707 <at> debbugs.gnu.org
Subject: Re: bug#21707: include-file cleanup for src directory
Date: Mon, 19 Oct 2015 10:23:02 +0300

> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Mon, 19 Oct 2015 00:05:52 -0700
> 
> Attached is a patch to remove unnecessary #include directives from the src 
> directory, and add a few #include directives that should be there.  I'm not 
> installing this now, to give Eli a heads-up in case this affects the MS-Windows 
> port.

I had compilation warnings and errors due to redisplaying_p and
cancel_hourglass not being declared in eval.c and lread.c.  These two
files need to include dispextern.h to avoid that problem.  (This isn't
Windows specific, so I wonder how it compiled for you.)

Otherwise, LGTM, thanks.

Would someone with MinGW64 installed please try this patch and see
that it works there as well?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.