GNU bug report logs - #21707
include-file cleanup for src directory

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Mon, 19 Oct 2015 07:07:02 UTC

Severity: wishlist

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 21707 <at> debbugs.gnu.org
Subject: bug#21707: include-file cleanup for src directory
Date: Tue, 20 Oct 2015 11:50:34 -0700
Eli Zaretskii wrote:
> Would it help if we avoid including any of our headers in any
> other of our headers, so that the headers included by a particular C
> file are visible by just looking at that single C file?

That would run afoul of a more important design goal, which is that we should be 
able to include headers in any order. And anyway, compiling a typical C file 
ordinarily brings in oodles of system headers that the C file doesn't explicitly 
ask for, so regardless of our style the only practical way to see what headers a 
C file includes is to compile it and see what gcc -E outputs.

Ideally a C source file should include all headers that define symbols the 
source file directly uses, and no headers other than that. This should be true 
for both .h and .c files. We're not there by a long shot, but that should be the 
goal.





This bug report was last modified 9 years and 217 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.