GNU bug report logs - #21707
include-file cleanup for src directory

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 21707 <at> debbugs.gnu.org
Subject: bug#21707: include-file cleanup for src directory
Date: Mon, 19 Oct 2015 22:54:39 -0700

[Message part 1 (text/plain, inline)]

Eli Zaretskii wrote:
> I had compilation warnings and errors due to redisplaying_p and
> cancel_hourglass not being declared in eval.c and lread.c.  These two
> files need to include dispextern.h to avoid that problem.  (This isn't
> Windows specific, so I wonder how it compiled for you.)

It's a problem with platform-specific inclusions: xterm.h includes dispextern.h, 
but eval.c and lread.c don't include xterm.h on MS-Windows. I attempted to 
detect this sort of thing by hand without actually building on MS-Windows, but 
it's an easy thing to get wrong. Revised patch attached. Quite possibly there 
will be similar issues on other platforms, but they should be easy to fix once 
encountered.

[0001-Include-file-cleanup-for-src-directory.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.