GNU bug report logs - #21696
[PATCH 1/2] grep: improvement of performance of grep -Fw

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sat, 17 Oct 2015 01:14:02 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #16 received at 21696-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 21696-done <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#21696: [PATCH 1/2] grep: improvement of performance of grep
 -Fw
Date: Sat, 17 Oct 2015 08:11:21 -0700
On Sat, Oct 17, 2015 at 12:44 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Fri, 16 Oct 2015 22:48:07 -0700
> Paul Eggert <eggert <at> cs.ucla.edu> wrote:
>
>> Thanks for those performance improvements. I installed them, with some minor changes to commentary. I also installed a couple of minor tweaks to the code, to use memrchr and to simplify the multibyte test. Attached are the revised set of patches.
>
> Thanks for review and rewording, Paul.

Thank you both for those fine changes.
I know there are older pending patches from Norihiro Tanaka, and
normally I would have prioritized applying them before the next
release, but now that we know about the false-match fix (echo abc|grep
-E '^b|b$') affecting 2.19..2.21, I would prefer to release the fixed
grep-2.22 ASAP, and integrate those additional changes afterwards.

I would like to make a prerelease snapshot late today or tomorrow, so
if you know of any quick/trivial improvements or anything
bug-fix-related, please let me know soon.




This bug report was last modified 9 years and 275 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.