From unknown Tue Sep 09 17:57:28 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2169: [Orgmode] TODO progress regression in org-mode in Emacs pretest Reply-To: Carsten Dominik , 2169@debbugs.gnu.org Resent-From: Carsten Dominik Original-Sender: Carsten Dominik Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 02 Feb 2009 21:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 2169 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123360870528887 (code B ref -1); Mon, 02 Feb 2009 21:15:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 2 Feb 2009 21:05:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12L4vXC028024 for ; Mon, 2 Feb 2009 13:04:59 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU5yS-0003c7-An for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 16:04:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU5yQ-0003as-9x for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 16:04:55 -0500 Received: from [199.232.76.173] (port=50634 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU5yH-0003ZM-6E; Mon, 02 Feb 2009 16:04:45 -0500 Received: from mail-ew0-f20.google.com ([209.85.219.20]:61829) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LU5yF-0006rD-IW; Mon, 02 Feb 2009 16:04:44 -0500 Received: by mail-ew0-f20.google.com with SMTP id 13so2251877ewy.18 for ; Mon, 02 Feb 2009 13:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=mo12+zpJ5N2UHquHfPyrLW7Dsm/d5rr6w5Tt1kF+L3U=; b=fjAAkBwwy5lBfuiqMrTryqeL03Z7AbCzZGv+xQXpP4F3wi8iHpUDfbKxiWhAFSvxjb P9j0WC8kdivzkQJbyuvjBcpWC2BbW0jS/6kMMfI49EcQkiNgFm/nCc4ExBMm7ecdoFf0 l0TNZXH16xVugQMi+YcUOUDcTC2w7soJ1mxls= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=cq9h9h5+m2W5xlAnn293A6013GOX4/g0SVyAGTvXE9QYn1d6PeBS0R9azedZlK0F69 3x36j9TeEnY/AsnYQS+xQI8NNaQX9EcyRkvZibAN3ezs5An0TuhpJ21GhWPnh8+f0JxR HHy+B6PK/9lCJU3oyc7TvhE/+WbSwwo3nJ6uY= Received: by 10.210.92.8 with SMTP id p8mr66538ebb.6.1233608680423; Mon, 02 Feb 2009 13:04:40 -0800 (PST) Received: from ?192.168.1.10? (dc5146846e.adsl.wanadoo.nl [81.70.132.110]) by mx.google.com with ESMTPS id 28sm3871726eyg.45.2009.02.02.13.04.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 13:04:39 -0800 (PST) Sender: Carsten Dominik Cc: emacs-orgmode@gnu.org, bug-gnu-emacs@gnu.org Message-Id: From: Carsten Dominik To: Michael Ekstrand In-Reply-To: <87fxiwlmgp.fsf@elehack.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Mon, 2 Feb 2009 22:04:37 +0100 References: <87fxiwlmgp.fsf@elehack.net> X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Hi Michael, I have fixed this bug and checked the changes into Emacs CVS, so they should be part of the next pretest. Thank you for the report! - Carsten On Feb 2, 2009, at 7:31 PM, Michael Ekstrand wrote: > I upgraded this morning from an Emacs CVS build from Jan 28 or 19 to > the > pretest release, and noticed a regression or undocumented change with > respect to org-after-todo-statistics-hook. I am using the org-mode > which is included in the pretest distribution. > > I have a function based on the code in section 5.5 of the Org manual > to > close projects when their subtasks are complete. Now, if I have a > headline which does not have a subtask counter in it and toggle one of > its children to DONE, my org-after-todo-statistics-hook function gets > called with n-done and n-not-done values of 0. The parent headline > thus > has its TODO status changed. > > I don't think it matters too much, as my code worked before, but my > hook > function is `org-summary-todo' from the following. The first case of > the cond is being activated. > > (defun mde-org-entry-is-project-p () > "Query whether the current headline is a project, returning > non-`nil' if it is and `nil' otherwise." > (member "PROJECT" (org-get-tags-at))) > > ;;; Taken from Org Mode manual chapter 5.5 > (defun org-summary-todo (n-done n-not-done) > "Switch entry to DONE when all subentries are done, to TODO > otherwise." > (let ((org-log-done nil) > (org-log-states nil)) > (cond > ((and (or (org-entry-is-todo-p) > (mde-org-entry-is-project-p)) > (= n-not-done 0)) > (org-todo > (if (mde-org-entry-is-project-p) > "FINISHED" > "DONE"))) > ;; Entry is a project that is marked done > ((and (mde-org-entry-is-project-p) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo 'none)) > ;; Entry is a task > ((and (not (mde-org-entry-is-project-p)) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo (org-get-todo-sequence-head)))))) > > There is a small chance that the problem was actually introduced a bit > earlier, perhaps since my Jan 20 build, but I think I would have > noticed > it after at least the Jan 28 build. > > I have CC'd bug-gnu-emacs to get this in as a bug report there as > well. > > - Michael > > -- > mouse, n: A device for pointing at the xterm in which you want to > type. > Confused by the strange files? I cryptographically sign my messages. > For more information see . > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode From unknown Tue Sep 09 17:57:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Carsten Dominik Subject: bug#2169 closed by Carsten Dominik (Re: [Orgmode] TODO progress regression in org-mode in Emacs pretest) Message-ID: References: <12B14995-9201-4A56-8289-31B4498484D3@uva.nl> X-Emacs-PR-Message: they-closed 2169 X-Emacs-PR-Package: emacs Reply-To: 2169@debbugs.gnu.org Date: Mon, 02 Feb 2009 21:35:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1233610504-3635-1" This is a multi-part message in MIME format... ------------=_1233610504-3635-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #2169: [Orgmode] TODO progress regression in org-mode in Emacs pretest It has been closed by Carsten Dominik . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Carsten Dominik by replying to this email. --=20 2169: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D2169 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1233610504-3635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2169-done) by emacsbugs.donarmstrong.com; 2 Feb 2009 21:28:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12LSowP002269 for <2169-done@emacsbugs.donarmstrong.com>; Mon, 2 Feb 2009 13:28:52 -0800 Received: by ewy3 with SMTP id 3so2271988ewy.1 for <2169-done@emacsbugs.donarmstrong.com>; Mon, 02 Feb 2009 13:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=mo12+zpJ5N2UHquHfPyrLW7Dsm/d5rr6w5Tt1kF+L3U=; b=XEn/rthFKD3ySwr/hr8ax3vF7GRWDa7/UVIABT1xZsJXxEMk/fqI0GjHJMrS35pppH ry1sEfxTwc1aZpXF0O3S+HpEIeS6RXfiM6/GUzWxxzPKFPYIAcnwD159nAwMNCa997io p5QHHEa0aO7m0I5ewKUH5CnDM5tvB763Jr+Yo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=Xs5t8kO7qwxTJTxXd2CFYS2h+7nDcE9gY+3uD0SMOv9OzNuUEz80jQ/LKUod6bpkTJ 1560YP1NLL0fx/6gZszQadDPV67Icinol9c18CcNeGfGzsNHCewVlc84b21IBReuoAv9 rZXWnQ6Oc48M4XxSgKD6CH5Ygb3ydYkdm4c0E= Received: by 10.210.54.17 with SMTP id c17mr5346331eba.35.1233610125270; Mon, 02 Feb 2009 13:28:45 -0800 (PST) Received: from ?192.168.1.10? (dc5146846e.adsl.wanadoo.nl [81.70.132.110]) by mx.google.com with ESMTPS id 28sm487840eyg.55.2009.02.02.13.28.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 13:28:44 -0800 (PST) Sender: Carsten Dominik Message-Id: <12B14995-9201-4A56-8289-31B4498484D3@uva.nl> From: Carsten Dominik To: 2169-done@debbugs.gnu.org In-Reply-To: <87fxiwlmgp.fsf@elehack.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [Orgmode] TODO progress regression in org-mode in Emacs pretest Date: Mon, 2 Feb 2009 22:28:42 +0100 References: <87fxiwlmgp.fsf@elehack.net> X-Mailer: Apple Mail (2.930.3) Hi Michael, I have fixed this bug and checked the changes into Emacs CVS, so they should be part of the next pretest. Thank you for the report! - Carsten On Feb 2, 2009, at 7:31 PM, Michael Ekstrand wrote: > I upgraded this morning from an Emacs CVS build from Jan 28 or 19 to > the > pretest release, and noticed a regression or undocumented change with > respect to org-after-todo-statistics-hook. I am using the org-mode > which is included in the pretest distribution. > > I have a function based on the code in section 5.5 of the Org manual > to > close projects when their subtasks are complete. Now, if I have a > headline which does not have a subtask counter in it and toggle one of > its children to DONE, my org-after-todo-statistics-hook function gets > called with n-done and n-not-done values of 0. The parent headline > thus > has its TODO status changed. > > I don't think it matters too much, as my code worked before, but my > hook > function is `org-summary-todo' from the following. The first case of > the cond is being activated. > > (defun mde-org-entry-is-project-p () > "Query whether the current headline is a project, returning > non-`nil' if it is and `nil' otherwise." > (member "PROJECT" (org-get-tags-at))) > > ;;; Taken from Org Mode manual chapter 5.5 > (defun org-summary-todo (n-done n-not-done) > "Switch entry to DONE when all subentries are done, to TODO > otherwise." > (let ((org-log-done nil) > (org-log-states nil)) > (cond > ((and (or (org-entry-is-todo-p) > (mde-org-entry-is-project-p)) > (= n-not-done 0)) > (org-todo > (if (mde-org-entry-is-project-p) > "FINISHED" > "DONE"))) > ;; Entry is a project that is marked done > ((and (mde-org-entry-is-project-p) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo 'none)) > ;; Entry is a task > ((and (not (mde-org-entry-is-project-p)) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo (org-get-todo-sequence-head)))))) > > There is a small chance that the problem was actually introduced a bit > earlier, perhaps since my Jan 20 build, but I think I would have > noticed > it after at least the Jan 28 build. > > I have CC'd bug-gnu-emacs to get this in as a bug report there as > well. > > - Michael > > -- > mouse, n: A device for pointing at the xterm in which you want to > type. > Confused by the strange files? I cryptographically sign my messages. > For more information see . > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode ------------=_1233610504-3635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 2 Feb 2009 21:05:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12L4vXC028024 for ; Mon, 2 Feb 2009 13:04:59 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU5yS-0003c7-An for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 16:04:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU5yQ-0003as-9x for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 16:04:55 -0500 Received: from [199.232.76.173] (port=50634 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU5yH-0003ZM-6E; Mon, 02 Feb 2009 16:04:45 -0500 Received: from mail-ew0-f20.google.com ([209.85.219.20]:61829) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LU5yF-0006rD-IW; Mon, 02 Feb 2009 16:04:44 -0500 Received: by mail-ew0-f20.google.com with SMTP id 13so2251877ewy.18 for ; Mon, 02 Feb 2009 13:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=mo12+zpJ5N2UHquHfPyrLW7Dsm/d5rr6w5Tt1kF+L3U=; b=fjAAkBwwy5lBfuiqMrTryqeL03Z7AbCzZGv+xQXpP4F3wi8iHpUDfbKxiWhAFSvxjb P9j0WC8kdivzkQJbyuvjBcpWC2BbW0jS/6kMMfI49EcQkiNgFm/nCc4ExBMm7ecdoFf0 l0TNZXH16xVugQMi+YcUOUDcTC2w7soJ1mxls= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=cq9h9h5+m2W5xlAnn293A6013GOX4/g0SVyAGTvXE9QYn1d6PeBS0R9azedZlK0F69 3x36j9TeEnY/AsnYQS+xQI8NNaQX9EcyRkvZibAN3ezs5An0TuhpJ21GhWPnh8+f0JxR HHy+B6PK/9lCJU3oyc7TvhE/+WbSwwo3nJ6uY= Received: by 10.210.92.8 with SMTP id p8mr66538ebb.6.1233608680423; Mon, 02 Feb 2009 13:04:40 -0800 (PST) Received: from ?192.168.1.10? (dc5146846e.adsl.wanadoo.nl [81.70.132.110]) by mx.google.com with ESMTPS id 28sm3871726eyg.45.2009.02.02.13.04.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 13:04:39 -0800 (PST) Sender: Carsten Dominik Cc: emacs-orgmode@gnu.org, bug-gnu-emacs@gnu.org Message-Id: From: Carsten Dominik To: Michael Ekstrand In-Reply-To: <87fxiwlmgp.fsf@elehack.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [Orgmode] TODO progress regression in org-mode in Emacs pretest Date: Mon, 2 Feb 2009 22:04:37 +0100 References: <87fxiwlmgp.fsf@elehack.net> X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Hi Michael, I have fixed this bug and checked the changes into Emacs CVS, so they should be part of the next pretest. Thank you for the report! - Carsten On Feb 2, 2009, at 7:31 PM, Michael Ekstrand wrote: > I upgraded this morning from an Emacs CVS build from Jan 28 or 19 to > the > pretest release, and noticed a regression or undocumented change with > respect to org-after-todo-statistics-hook. I am using the org-mode > which is included in the pretest distribution. > > I have a function based on the code in section 5.5 of the Org manual > to > close projects when their subtasks are complete. Now, if I have a > headline which does not have a subtask counter in it and toggle one of > its children to DONE, my org-after-todo-statistics-hook function gets > called with n-done and n-not-done values of 0. The parent headline > thus > has its TODO status changed. > > I don't think it matters too much, as my code worked before, but my > hook > function is `org-summary-todo' from the following. The first case of > the cond is being activated. > > (defun mde-org-entry-is-project-p () > "Query whether the current headline is a project, returning > non-`nil' if it is and `nil' otherwise." > (member "PROJECT" (org-get-tags-at))) > > ;;; Taken from Org Mode manual chapter 5.5 > (defun org-summary-todo (n-done n-not-done) > "Switch entry to DONE when all subentries are done, to TODO > otherwise." > (let ((org-log-done nil) > (org-log-states nil)) > (cond > ((and (or (org-entry-is-todo-p) > (mde-org-entry-is-project-p)) > (= n-not-done 0)) > (org-todo > (if (mde-org-entry-is-project-p) > "FINISHED" > "DONE"))) > ;; Entry is a project that is marked done > ((and (mde-org-entry-is-project-p) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo 'none)) > ;; Entry is a task > ((and (not (mde-org-entry-is-project-p)) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo (org-get-todo-sequence-head)))))) > > There is a small chance that the problem was actually introduced a bit > earlier, perhaps since my Jan 20 build, but I think I would have > noticed > it after at least the Jan 28 build. > > I have CC'd bug-gnu-emacs to get this in as a bug report there as > well. > > - Michael > > -- > mouse, n: A device for pointing at the xterm in which you want to > type. > Confused by the strange files? I cryptographically sign my messages. > For more information see . > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode ------------=_1233610504-3635-1-- From rgm@gnu.org Mon Feb 2 15:36:50 2009 Received: (at control) by emacsbugs.donarmstrong.com; 2 Feb 2009 23:36:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12NalTw002258 for ; Mon, 2 Feb 2009 15:36:48 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LU8Jg-00032K-OT; Mon, 02 Feb 2009 18:35:00 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18823.33572.703006.102797@fencepost.gnu.org> Date: Mon, 2 Feb 2009 18:35:00 -0500 From: Glenn Morris To: control Subject: control message reassign 2169 emacs,org-mode forcemerge 2169 2167 close 2109