From unknown Fri Jun 20 07:20:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#21681 <21681@debbugs.gnu.org> To: bug#21681 <21681@debbugs.gnu.org> Subject: Status: [PATCH] Fix formatting of lexical-binding at eof warning Reply-To: bug#21681 <21681@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:20:02 +0000 retitle 21681 [PATCH] Fix formatting of lexical-binding at eof warning reassign 21681 emacs submitter 21681 Noam Postavsky severity 21681 wishlist tag 21681 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 18:53:07 2015 Received: (at submit) by debbugs.gnu.org; 13 Oct 2015 22:53:07 +0000 Received: from localhost ([127.0.0.1]:39189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zm8RO-0004qA-9O for submit@debbugs.gnu.org; Tue, 13 Oct 2015 18:53:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34377) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zm8Pt-0004mq-Io for submit@debbugs.gnu.org; Tue, 13 Oct 2015 18:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm8Ps-0006Wo-CJ for submit@debbugs.gnu.org; Tue, 13 Oct 2015 18:51:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm8Ps-0006Wc-8q for submit@debbugs.gnu.org; Tue, 13 Oct 2015 18:51:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm8Pr-00019v-AI for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2015 18:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm8Pp-0006Rn-O9 for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2015 18:51:31 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:36393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm8Pp-0006QN-I6 for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2015 18:51:29 -0400 Received: by wicgb1 with SMTP id gb1so208018718wic.1 for ; Tue, 13 Oct 2015 15:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=NfAjSFUgKbklNvJzhcE4kGeChpnGQ3nJz0pPHWvjWz8=; b=Xy7DFPl/hg0eC0AqXju4Xl67LzFSUrZ3//JoBnXKC2sxsyW3JIFf9oj5fcXJ5eB9VI DaAZyQhZ0F5tmfG8pdWzrTCHLkHkd0fG6445/c+GawE1XjvvlyMEDcUhGeK4sZunjS/t hhFqUY6qa+X/44iJpWcV6saVqxRu7N3tC+hiUfiohkeP5eD4bfyphEKJqYI+kMWCHXAu EqcnmbdTZdltzS31dgKPIRVcltyHycNCQZG9vpgzrMPc/8kr48dDs7mFMEDrypOy/BsB ZfVWZVu8myZxp4Pn97PtvxMjkXEwwzjVN8lSuwlDHiFoTKAtluV3mIAV/6InS1h+Stg7 E0gA== MIME-Version: 1.0 X-Received: by 10.194.6.66 with SMTP id y2mr30429149wjy.82.1444776688673; Tue, 13 Oct 2015 15:51:28 -0700 (PDT) Received: by 10.28.210.68 with HTTP; Tue, 13 Oct 2015 15:51:28 -0700 (PDT) Date: Tue, 13 Oct 2015 18:51:28 -0400 Message-ID: Subject: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=047d7b5d33884eeca90522044990 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 13 Oct 2015 18:53:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --047d7b5d33884eeca90522044990 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Before: Warning (:warning): : =E2=80=98lexical-binding=E2=80=99 at end of file unre= liable After: Warning (files): foo.el: =E2=80=98lexical-binding=E2=80=99 at end of file u= nreliable --047d7b5d33884eeca90522044990 Content-Type: text/x-diff; charset=US-ASCII; name="0001-Fix-formatting-of-lexical-binding-at-eof-warning.patch" Content-Disposition: attachment; filename="0001-Fix-formatting-of-lexical-binding-at-eof-warning.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 RnJvbSAzYzNjMWJkMWQ1NjcyOTMwYjk1ZDlhYzAwYmE3ZTQ4NjM2YjdmZjdmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAdXNlcnMuc291cmNl Zm9yZ2UubmV0PgpEYXRlOiBUdWUsIDEzIE9jdCAyMDE1IDE4OjI5OjU2IC0wNDAwClN1YmplY3Q6 IFtQQVRDSF0gRml4IGZvcm1hdHRpbmcgb2YgbGV4aWNhbC1iaW5kaW5nIGF0IGVvZiB3YXJuaW5n CgoqIGxpc3AvZmlsZXMuZWwgKGhhY2stbG9jYWwtdmFyaWFibGVzKTogR2V0IGJ1ZmZlciBuYW1l IGZyb20gdGhlCiAgdmlzaXRpbmcgYnVmZmVyLCBhbmQgcGFzcyAnZmlsZXMgYXMgZmlyc3QgYXJn IHRvIGBkaXNwbGF5LXdhcm5pbmcnLgotLS0KIGxpc3AvZmlsZXMuZWwgfCA0ICsrLS0KIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv bGlzcC9maWxlcy5lbCBiL2xpc3AvZmlsZXMuZWwKaW5kZXggODU2NWFhOC4uZDk3OWE0MiAxMDA2 NDQKLS0tIGEvbGlzcC9maWxlcy5lbAorKysgYi9saXNwL2ZpbGVzLmVsCkBAIC0zNDE4LDExICsz NDE4LDExIEBAIChkZWZ1biBoYWNrLWxvY2FsLXZhcmlhYmxlcyAoJm9wdGlvbmFsIG1vZGUtb25s eSkKIAkJCSAgICAgICAodW5sZXNzIGhhY2stbG9jYWwtdmFyaWFibGVzLS13YXJuZWQtbGV4aWNh bAogCQkJCSAoc2V0cSBoYWNrLWxvY2FsLXZhcmlhYmxlcy0td2FybmVkLWxleGljYWwgdCkKIAkJ CQkgKGRpc3BsYXktd2FybmluZwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDp3 YXJuaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2ZpbGVzCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZvcm1hdC1tZXNzYWdlCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICIlczogYGxleGljYWwtYmluZGluZycgYXQgZW5kIG9mIGZp bGUgdW5yZWxpYWJsZSIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZpbGUt bmFtZS1ub25kaXJlY3RvcnkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChv ciBidWZmZXItZmlsZS1uYW1lICIiKSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAob3IgKGJ1ZmZlci1maWxlLW5hbWUgdGhpc2J1ZikgIiIpKSkpKSkKIAkJCSAgICAg ICh0CiAJCQkgICAgICAgKGlnbm9yZS1lcnJvcnMKIAkJCQkgKHB1c2ggKGNvbnMgKGlmIChlcSB2 YXIgJ2V2YWwpCi0tIAoyLjUuMwoK --047d7b5d33884eeca90522044990-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 18:55:20 2015 Received: (at control) by debbugs.gnu.org; 13 Oct 2015 22:55:20 +0000 Received: from localhost ([127.0.0.1]:39194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zm8TY-0004ut-5h for submit@debbugs.gnu.org; Tue, 13 Oct 2015 18:55:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36617) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zm8TW-0004ul-06 for control@debbugs.gnu.org; Tue, 13 Oct 2015 18:55:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm8TV-0000ZJ-4P for control@debbugs.gnu.org; Tue, 13 Oct 2015 18:55:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm8TV-0000ZD-1e for control@debbugs.gnu.org; Tue, 13 Oct 2015 18:55:17 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Zm8TU-0005lJ-PR for control@debbugs.gnu.org; Tue, 13 Oct 2015 18:55:16 -0400 Subject: control message for bug 21681 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 13 Oct 2015 18:55:16 -0400 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) forcemerge 17518 21681 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 12:28:03 2015 Received: (at 21681) by debbugs.gnu.org; 14 Oct 2015 16:28:03 +0000 Received: from localhost ([127.0.0.1]:40463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmOuI-0003oy-NU for submit@debbugs.gnu.org; Wed, 14 Oct 2015 12:28:02 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:37810) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmOuF-0003oX-PM for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 12:28:00 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NW700C00XM5IB00@mtaout28.012.net.il> for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 19:27:18 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW700BGSXPIAB10@mtaout28.012.net.il>; Wed, 14 Oct 2015 19:27:18 +0300 (IDT) Date: Wed, 14 Oct 2015 19:28:13 +0300 From: Eli Zaretskii Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning In-reply-to: X-012-Sender: halo1@inter.net.il To: Noam Postavsky Message-id: <83fv1dxvmq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 13 Oct 2015 18:51:28 -0400 > From: Noam Postavsky > > Before: > > Warning (:warning): : ‘lexical-binding’ at end of file unreliable > > After: > > Warning (files): foo.el: ‘lexical-binding’ at end of file unreliable Why 'files', and not something more concrete, like 'file-local-variables'? Otherwise, LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 12:56:32 2015 Received: (at 21681) by debbugs.gnu.org; 14 Oct 2015 16:56:32 +0000 Received: from localhost ([127.0.0.1]:51063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmPLr-0000dm-L9 for submit@debbugs.gnu.org; Wed, 14 Oct 2015 12:56:32 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:34660) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmPLp-0000dd-EN for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 12:56:30 -0400 Received: by wicgb1 with SMTP id gb1so137863050wic.1 for <21681@debbugs.gnu.org>; Wed, 14 Oct 2015 09:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=GL+vnhGkNxmNJXwdnLe/YErFoh80EH9BomwR0qqbzUo=; b=zMGHBKU8JUGZdTiDfOjET7N38r3SNMR88rSO8O4Ah29u6ZWz9/ZHhDBGHr1HrE7Rtk 6P7sAw68k6ch6/Kc++tYHdxMfgV+8ERUa6J94A4l8oKoo6tCbE+AZI9ME/L1BbiZV/wJ b/dsh9It5bEb/etf5dIzngvN/jofv/k+7rFa7cIyMAAt9rRmNdfNn6D/aLna2Oe9Z18j wYY4wMm5emt4jZRbVDtJQL73O2+rE7nfii21hWjeUXi49PAVYOpiAYim4MO/8jM0XtdH /f070PAoNBXT0PAGgSLrdvLE3DJrdFCf/Wcm2Y2ZvN+LAOOcHZqQu6rlJh4XYEK+wz5Y Nc7Q== MIME-Version: 1.0 X-Received: by 10.180.85.164 with SMTP id i4mr5978262wiz.54.1444841788579; Wed, 14 Oct 2015 09:56:28 -0700 (PDT) Received: by 10.28.210.68 with HTTP; Wed, 14 Oct 2015 09:56:28 -0700 (PDT) In-Reply-To: <83fv1dxvmq.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> Date: Wed, 14 Oct 2015 12:56:28 -0400 X-Google-Sender-Auth: yQf0rYsEKhUgFmxIZgW77sa1_FM Message-ID: Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Oct 14, 2015 at 12:28 PM, Eli Zaretskii wrote: > Why 'files', and not something more concrete, like > 'file-local-variables'? The docstring for display-warning says the TYPE arg should be a custom group. display-warning doesn't actually enforce this, and it looks like the choice of symbol(s) is only relevant to warning-suppress-log-types. Perhaps the TYPE should be '(files local-variables) so the user can suppress it along with all files warnings or just suppress it on it's own, but display-warning only prints the 1st symbol of the list so the warning text itself wouldn't change. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 13:42:31 2015 Received: (at 21681) by debbugs.gnu.org; 14 Oct 2015 17:42:31 +0000 Received: from localhost ([127.0.0.1]:51092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQ4N-0001hg-0J for submit@debbugs.gnu.org; Wed, 14 Oct 2015 13:42:31 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:41343) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQ4J-0001hU-SR for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 13:42:28 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NW8000000QZGK00@a-mtaout23.012.net.il> for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 20:42:26 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW8000SL16PEC40@a-mtaout23.012.net.il>; Wed, 14 Oct 2015 20:42:26 +0300 (IDT) Date: Wed, 14 Oct 2015 20:42:25 +0300 From: Eli Zaretskii Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning In-reply-to: X-012-Sender: halo1@inter.net.il To: Noam Postavsky Message-id: <831tcxxs72.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 14 Oct 2015 12:56:28 -0400 > From: Noam Postavsky > Cc: 21681@debbugs.gnu.org > > On Wed, Oct 14, 2015 at 12:28 PM, Eli Zaretskii wrote: > > Why 'files', and not something more concrete, like > > 'file-local-variables'? > > The docstring for display-warning says the TYPE arg should be a custom group. > > display-warning doesn't actually enforce this, and it looks like the > choice of symbol(s) is only relevant to warning-suppress-log-types. > Perhaps the TYPE should be '(files local-variables) so the user can > suppress it along with all files warnings or just suppress it on it's > own, but display-warning only prints the 1st symbol of the list so the > warning text itself wouldn't change. I find "files" no more explanatory that "warning". If we lack infrastructure to display meaningful messages that unequivocally point to the nature of the problem, let's add the missing infrastructure. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 13:47:43 2015 Received: (at 21681) by debbugs.gnu.org; 14 Oct 2015 17:47:43 +0000 Received: from localhost ([127.0.0.1]:51096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQ9O-0001p5-W2 for submit@debbugs.gnu.org; Wed, 14 Oct 2015 13:47:43 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:33181) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQ9N-0001ox-EO for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 13:47:41 -0400 Received: by wijp11 with SMTP id p11so4977460wij.0 for <21681@debbugs.gnu.org>; Wed, 14 Oct 2015 10:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=qV0+fGQJcBZhKXyH79KokSjW27WkjXLJnP1PGlRyvVg=; b=HTWrvz97GsNyY6J+jzp3Eb06ADQUSzYfsFrK82kSXnJ0anyPbIotLkwkHNTO2allsK wqFnTvkJQOvOWa4EwEz2JAg7IBdpkbtI8ZSJQ1aEggOxZCSEmCtEiqcQmFgGvzyN8B+u yVzH72vX7bu4UmUb1ay1dZv0nd4zyRFlKTE1oKzBqtvkXbeGGOkbwl7eD4szO7kqefA7 c7TJkGoTzlBL+LkKV1pG1LrRbhao2uEEQ7soE7yGvscUo1gcqHKpscUr28zPyj+N7aDO E9TwiXLB2mnRxaxiomVQd4IYKXWfyqRfAfHqyRmVDZsjUe+nKMdGMhaS2sR1imchYcU0 XxbQ== MIME-Version: 1.0 X-Received: by 10.180.85.164 with SMTP id i4mr6248649wiz.54.1444844860398; Wed, 14 Oct 2015 10:47:40 -0700 (PDT) Received: by 10.28.210.68 with HTTP; Wed, 14 Oct 2015 10:47:40 -0700 (PDT) In-Reply-To: <831tcxxs72.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> Date: Wed, 14 Oct 2015 13:47:40 -0400 X-Google-Sender-Auth: MFF4F-oNZ-SFUihIFCV3UVUi6G0 Message-ID: Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Oct 14, 2015 at 1:42 PM, Eli Zaretskii wrote: >> Date: Wed, 14 Oct 2015 12:56:28 -0400 >> From: Noam Postavsky >> own, but display-warning only prints the 1st symbol of the list so the >> warning text itself wouldn't change. > > I find "files" no more explanatory that "warning". If we lack > infrastructure to display meaningful messages that unequivocally point > to the nature of the problem, let's add the missing infrastructure. How about making display-warning print all TYPE symbols then? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 13:53:43 2015 Received: (at 21681) by debbugs.gnu.org; 14 Oct 2015 17:53:43 +0000 Received: from localhost ([127.0.0.1]:51101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQFC-0001xB-Vh for submit@debbugs.gnu.org; Wed, 14 Oct 2015 13:53:43 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:60832) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQFA-0001x2-Q5 for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 13:53:41 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NW8006001374U00@mtaout27.012.net.il> for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 20:49:37 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW800N751IP9J90@mtaout27.012.net.il>; Wed, 14 Oct 2015 20:49:37 +0300 (IDT) Date: Wed, 14 Oct 2015 20:53:39 +0300 From: Eli Zaretskii Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning In-reply-to: X-012-Sender: halo1@inter.net.il To: Noam Postavsky Message-id: <83y4f5wd3w.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 14 Oct 2015 13:47:40 -0400 > From: Noam Postavsky > Cc: 21681@debbugs.gnu.org > > How about making display-warning print all TYPE symbols then? Fine with me, but I don't know enough about display-warning and its uses to tell if this could cause some harm somewhere. Maybe someone else will know; if you hear no objections in a few days, please go ahead. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 15:46:18 2015 Received: (at 21681) by debbugs.gnu.org; 14 Oct 2015 19:46:19 +0000 Received: from localhost ([127.0.0.1]:51165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmS0A-0004y4-IC for submit@debbugs.gnu.org; Wed, 14 Oct 2015 15:46:18 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:51247) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmS08-0004xt-K6 for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 15:46:17 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NW8004006VDCN00@mtaout28.012.net.il> for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 22:45:35 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW8003GD6VZV500@mtaout28.012.net.il>; Wed, 14 Oct 2015 22:45:35 +0300 (IDT) Date: Wed, 14 Oct 2015 22:46:14 +0300 From: Eli Zaretskii Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning In-reply-to: <83y4f5wd3w.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: npostavs@users.sourceforge.net Message-id: <83si5dw7w9.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> <83y4f5wd3w.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 14 Oct 2015 20:53:39 +0300 > From: Eli Zaretskii > Cc: 21681@debbugs.gnu.org > > > Date: Wed, 14 Oct 2015 13:47:40 -0400 > > From: Noam Postavsky > > Cc: 21681@debbugs.gnu.org > > > > How about making display-warning print all TYPE symbols then? > > Fine with me, but I don't know enough about display-warning and its > uses to tell if this could cause some harm somewhere. Maybe someone > else will know; if you hear no objections in a few days, please go > ahead. Having now looked at the code, I actually don't understand why the documentation says the symbol should be a custom group. Nothing in the code enforces that or relies on that, so it sounds like a gratuitous limitation to me. Names of custom group are usually so general that they don't really add any useful information to the message. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 22:30:48 2015 Received: (at 21681) by debbugs.gnu.org; 15 Oct 2015 02:30:48 +0000 Received: from localhost ([127.0.0.1]:51327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmYJb-0007q6-7t for submit@debbugs.gnu.org; Wed, 14 Oct 2015 22:30:48 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:33280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmYJX-0007px-PX for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 22:30:44 -0400 Received: by wijp11 with SMTP id p11so8446529wij.0 for <21681@debbugs.gnu.org>; Wed, 14 Oct 2015 19:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=DZZFVeRNEm6ADuyZgSlU0P2sZwurAlLezBtWAr68LHU=; b=wl2DOR6v615sxQz23f6mpPJZeoHloIoAcq/hcWmv7mTsc0v03YbEj8sd06EMkvVIIu L4TfAUiD4RSMSPIztvDXJkBb3m/PTBxO9rCf902WhRsh99KOTE7tP7zudX7jjUz1+Bid TPlSL5/7w5/8QrEp+4+LZE9C+tPHI30siPzt/eje6gVMFf3yCXl8ZsGIygmrgFQwKOl0 qGbwx+uUgW9A/mRHnaS9+PPuJ38nh4U0lJ/fuD6p8ht6wB1DkomrHd3qALUCVAPWB+W1 ygfihYJKR7XW4Yx9pWZ6Y1ND3vVxAq1X3NDcsSsy71exjhUIgtIfY+SfTCPKrBimqGVp XXhQ== MIME-Version: 1.0 X-Received: by 10.194.185.16 with SMTP id ey16mr8587267wjc.32.1444876243071; Wed, 14 Oct 2015 19:30:43 -0700 (PDT) Received: by 10.28.210.68 with HTTP; Wed, 14 Oct 2015 19:30:43 -0700 (PDT) In-Reply-To: <83si5dw7w9.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> <83y4f5wd3w.fsf@gnu.org> <83si5dw7w9.fsf@gnu.org> Date: Wed, 14 Oct 2015 22:30:43 -0400 X-Google-Sender-Auth: qq8OelYUzc4J5ITRB2zoZBasPKI Message-ID: Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 10/14/15, Eli Zaretskii wrote: > Having now looked at the code, I actually don't understand why the > documentation says the symbol should be a custom group. I would speculate it's a way to encourage some convergence of warning types, so that users are able to suppress several at once. I did an rgrep on the Emacs source tree for display-warning|lwarn, only 2 calls pass a list for TYPE, both in lisp/progmodes/python.el: ./lisp/progmodes/python.el:2247: (lwarn '(python python-shell-prompt-regexp) ./lisp/progmodes/python.el:3443: (t (lwarn '(python python-shell-completion-native-turn-on-maybe) There are several mistaken uses of :warning or :error, and the rest use a general symbol that says little beyond which package a warning might be coming from; around half are custom groups, but none very specific. Symbols used: (get 'alloc 'custom-group) ;=> ((gc-cons-threshold custom-variable) (get 'todo 'custom-group) ;=> nil (get 'org 'custom-group) ;=> ((org-babel custom-group)... (get 'initialization 'custom-group) ;=> ((user-emacs-directory-warning custom-variable)... (get 'url 'custom-group) ;=> ((url-file custom-group)... (get 'gnus-server 'custom-group) ;=> nil (get 'mule 'custom-group) ;=> ((keyboard-coding-system custom-variable)... (get 'server 'custom-group) ;=> ((server-use-tcp custom-variable)... (get 'file-error 'custom-group) ;=> nil (get 'rmail 'custom-group) ;=> nil (get 'check-declare 'custom-group) ;=> nil (get 'smie 'custom-group) ;=> ((smie-blink-matching-inners custom-variable)... (get 'bytecomp 'custom-group) ;=> ((emacs-lisp-file-regexp custom-variable)... (get 'mail 'custom-group) ;=> ((mail-host-address custom-variable)... (get 'python 'custom-group) ;=> nil (get 'erc 'custom-group) ;=> nil (get 'soap-client 'custom-group) ;=> nil (get 'custom 'custom-group) ;=> nil (get 'bzrmerge 'custom-group) ;=> nil From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 31 18:36:44 2015 Received: (at 21681) by debbugs.gnu.org; 31 Oct 2015 22:36:44 +0000 Received: from localhost ([127.0.0.1]:47354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZselP-0001DS-FW for submit@debbugs.gnu.org; Sat, 31 Oct 2015 18:36:43 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35395) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZselN-0001DK-BY for 21681@debbugs.gnu.org; Sat, 31 Oct 2015 18:36:41 -0400 Received: by wmll128 with SMTP id l128so35330057wml.0 for <21681@debbugs.gnu.org>; Sat, 31 Oct 2015 15:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=8fBE7Yms0VMnRv3MqJgam1t0NSGGeNes7w9XUAqKxmg=; b=HI6LWHeN0UPJbvCtamkqfT6SDJvvdoIVwjYpvItA0bRKHKW4lDkm0R7ELP8s3S0ktN 1Ycg0nhvb3la5+oNdSIC6jxR6RmVIy6MN2Qd9+6FNmZadWYnmmw7jA1bHkj+8Q8LDnzV lZIdX1qIMACwvc61cyv2SK/dZ4UoeG5em/aVNceHr+PxPpimL/8oBBCNDXHiRJql5G7r a8qPPVfZOE4Yr7ICQ4RZyAkjI7YjLa/3ZytYBoBI8P9aSmPXqXQEgx8am9V+SDkIUddW 2XJxZYPMvrEDxJx+9eParGDspGQNwNIhwEDgOC+ofvD6L09fMV6gkcNSXIv8X7ZWdHdx /Cyg== MIME-Version: 1.0 X-Received: by 10.28.210.77 with SMTP id j74mr5116000wmg.60.1446331000584; Sat, 31 Oct 2015 15:36:40 -0700 (PDT) Received: by 10.28.29.87 with HTTP; Sat, 31 Oct 2015 15:36:40 -0700 (PDT) In-Reply-To: References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> Date: Sat, 31 Oct 2015 18:36:40 -0400 X-Google-Sender-Auth: ocFdIeDTqfrdcOdGPx9H77yAcO0 Message-ID: Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed, Oct 14, 2015 at 1:47 PM, Noam Postavsky wrote: > On Wed, Oct 14, 2015 at 1:42 PM, Eli Zaretskii wrote: >>> Date: Wed, 14 Oct 2015 12:56:28 -0400 >>> From: Noam Postavsky >>> own, but display-warning only prints the 1st symbol of the list so the >>> warning text itself wouldn't change. >> >> I find "files" no more explanatory that "warning". If we lack >> infrastructure to display meaningful messages that unequivocally point >> to the nature of the problem, let's add the missing infrastructure. > > How about making display-warning print all TYPE symbols then? I've been playing a bit more with display-warning, and I think the part in brackets is not supposed to be part of the warning's explanation, but rather it tells you how to block it. Like gcc's "[-Wfoo]". The problem with printing all the symbols is that it would make the warnings using TYPE lists longer, pushing the actual warning text to the right, and discourage use of more specific TYPEs. Another possiblity is still to truncate to a single item, but show a "..." button to expand it, like `eval-last-sexp' does for long lists. Another thing I've been experimenting with is including buttons with an action to resolve the problem in the warning text. It seems to work pretty well, except that because *Warnings* is in special-mode isn't bound to forward-button. It could be nice to have a warnings-mode which does that. It could also bind e.g. `i' to something like ignore-warning-at-point (which would customize warning-suppress-types). But I know Emacs supposed to be in feature freeze so maybe now is not the time to be adding new modes. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 24 13:43:11 2016 Received: (at 21681) by debbugs.gnu.org; 24 Jan 2016 18:43:11 +0000 Received: from localhost ([127.0.0.1]:35122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNPd1-0004LC-JQ for submit@debbugs.gnu.org; Sun, 24 Jan 2016 13:43:11 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:34105) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNPcz-0004Kx-Sr for 21681@debbugs.gnu.org; Sun, 24 Jan 2016 13:43:10 -0500 Received: by mail-io0-f170.google.com with SMTP id 1so132385218ion.1 for <21681@debbugs.gnu.org>; Sun, 24 Jan 2016 10:43:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=yqI4XuP4WJ51zZcIm2mK5kvDR6qOQV3GhmncnmHlps0=; b=eX95d1eEhMbX4/YL3Ki6pRlKS9YfjS1m2HaE+qLN3OQCK9sWnB5Dmye0ZcMo4w9uOe VypqZgff8JLkOLuxi+K+/iCnfBpnCsEFd0lo5PmpHwBiCOpYjX+uOXxDzr+SsQsTcwub Vw0haDHGl86Z9o6TE66wL2jDRqfDprlvw6LDs8ZKC4JsALdso8o+kmmCxKQ02ABJhWJF 5vIupS48PkwWriPstRoiwIOI0LD6awLYvMnE3qgYTpIsPaF+tV1ARcJTCNYpOoZLswLe fFOT8gfa3eEcHE7IsoVIDl8HhbuBsdYkhhQStXdSj1ca7Mfj8J/1Q4dp70VXLNAHxx/I lqkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=yqI4XuP4WJ51zZcIm2mK5kvDR6qOQV3GhmncnmHlps0=; b=i3se2hdSUFZSdvRyMyzg+4r6AOZpQxKVIuM9Lqp8YJorPSEHiPvHFC6BI62nZ7ax8i SKcVTl/4si7xs1KQ6ht/aidy0V1EbRM731mnwnfVJRuI6MRU9lQw1zU1GQC/Vbpij/9l L2Tip+dMXPjxqaZDd4x7LavaKZhgvsypN+01beb6Amh5EeBGk8i599z9/y32NxUbmqcO hnuFKXeA9E6XZJ0C0jSp6f/Am3E6CWzKAHQstClM/2wBiVR2MCHbVS4Xrt3D3Zm49vw+ BlebhbW/4YRGUne9f8cq4KpdGuWZaYzF7XFJ1h/zXisdbGCRBjgHoRm2mSUbk4mNwg2S Lv9w== X-Gm-Message-State: AG10YOTcnJ/viGMel9m8gpcLOoxkDW83Vle9r7H1Qeoz/LCZNpxDeZ00FvUi9uFPoYGzX2/gWuGCkk9NaZOUNw== MIME-Version: 1.0 X-Received: by 10.107.40.148 with SMTP id o142mr13846751ioo.18.1453660984287; Sun, 24 Jan 2016 10:43:04 -0800 (PST) Received: by 10.79.79.132 with HTTP; Sun, 24 Jan 2016 10:43:04 -0800 (PST) In-Reply-To: References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> Date: Sun, 24 Jan 2016 13:43:04 -0500 X-Google-Sender-Auth: rXe2V_fmAUL-NTdde8so6LOEJO0 Message-ID: Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: Eli Zaretskii Content-Type: multipart/mixed; boundary=001a1141f2a4981ab1052a18d271 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a1141f2a4981ab1052a18d271 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I see in the mean time that Glen Morris has changed :warning to 'files as part of a general display-warnings fix ("Fix some display-warning usage." 741d0afe021fbe0ff4f3933242526c684ed8c806) So can we just fix the filename part (see attached) already, surely this silly bug has been open long enough. Before: Warning (files): : =E2=80=98lexical-binding=E2=80=99 at end of file unrelia= ble After: Warning (files): foo.el: =E2=80=98lexical-binding=E2=80=99 at end of file u= nreliable --001a1141f2a4981ab1052a18d271 Content-Type: application/octet-stream; name="0001-Fix-lexical-binding-at-eof-warning.patch" Content-Disposition: attachment; filename="0001-Fix-lexical-binding-at-eof-warning.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ijsw2vxo0 RnJvbSAyOWViYThjYzgxZDMxNTFmMmVkMmU3NzkxYzdhODEyMDVlZGI0Njg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBTdW4sIDI0IEphbiAyMDE2IDExOjE3OjQ1IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGxleGljYWwgYmluZGluZyBhdCBlb2Ygd2FybmluZwoKKiBmaWxlcy5lbCAoaGFjay1sb2NhbC12 YXJpYWJsZXMpOiBHZXQgYnVmZmVyIG5hbWUgZnJvbSB0aGUKICB2aXNpdGluZyBidWZmZXIuCi0t LQogbGlzcC9maWxlcy5lbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZmlsZXMuZWwgYi9saXNwL2ZpbGVzLmVs CmluZGV4IDVhMTVjNzEuLjA1MWJmYzYgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIv bGlzcC9maWxlcy5lbApAQCAtMzQyNiw3ICszNDI2LDcgQEAgbG9jYWwgdmFyaWFibGVzLCBidXQg ZGlyZWN0b3J5LWxvY2FsIHZhcmlhYmxlcyBtYXkgc3RpbGwgYmUgYXBwbGllZC4iCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZvcm1hdC1tZXNzYWdlCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICIlczogYGxleGljYWwtYmluZGluZycgYXQgZW5kIG9mIGZp bGUgdW5yZWxpYWJsZSIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZpbGUt bmFtZS1ub25kaXJlY3RvcnkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChv ciBidWZmZXItZmlsZS1uYW1lICIiKSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAob3IgKGJ1ZmZlci1maWxlLW5hbWUgdGhpc2J1ZikgIiIpKSkpKSkKIAkJCSAgICAg ICh0CiAJCQkgICAgICAgKGlnbm9yZS1lcnJvcnMKIAkJCQkgKHB1c2ggKGNvbnMgKGlmIChlcSB2 YXIgJ2V2YWwpCi0tIAoyLjYuMi53aW5kb3dzLjEKCg== --001a1141f2a4981ab1052a18d271-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 24 13:51:40 2016 Received: (at 21681) by debbugs.gnu.org; 24 Jan 2016 18:51:40 +0000 Received: from localhost ([127.0.0.1]:35130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNPlE-0004Xf-JY for submit@debbugs.gnu.org; Sun, 24 Jan 2016 13:51:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40708) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNPlD-0004XR-4P for 21681@debbugs.gnu.org; Sun, 24 Jan 2016 13:51:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNPl2-0004Rb-Kd for 21681@debbugs.gnu.org; Sun, 24 Jan 2016 13:51:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNPl2-0004RX-HL; Sun, 24 Jan 2016 13:51:28 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4245 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aNPl1-0002fk-GG; Sun, 24 Jan 2016 13:51:28 -0500 Date: Sun, 24 Jan 2016 20:51:50 +0200 Message-Id: <83si1m3j5l.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sun, 24 Jan 2016 13:43:04 -0500) Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sun, 24 Jan 2016 13:43:04 -0500 > From: Noam Postavsky > Cc: 21681@debbugs.gnu.org > > Warning (files): foo.el: ‘lexical-binding’ at end of file unreliable ^^^^^^^^^^^^^^ But foo.el is not a file in this case. What is the real-life use case where this is needed for a buffer that doesn't visit a file? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 24 14:34:37 2016 Received: (at 21681) by debbugs.gnu.org; 24 Jan 2016 19:34:37 +0000 Received: from localhost ([127.0.0.1]:35142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNQQn-0005YJ-HF for submit@debbugs.gnu.org; Sun, 24 Jan 2016 14:34:37 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:35269) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNQQm-0005Y5-MZ for 21681@debbugs.gnu.org; Sun, 24 Jan 2016 14:34:36 -0500 Received: by mail-ig0-f174.google.com with SMTP id t15so22574664igr.0 for <21681@debbugs.gnu.org>; Sun, 24 Jan 2016 11:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=dZq+d/WXfYfsa4kAs0Z4xPg6dZL1Fam1q+yd/iJjHig=; b=N5aNfvsCPlnF9ncgNQLu1VUnZur31hFEy4oVGDjg/TqD/bNA+PTdS6q1k65JaE/Qx2 9fwPXwFq+hYz4lSTzC2bCLFyOnsl2adMb4+lf/xKvouvnS8cuMzKLixGCz/58yHJmAGu XgoxenZfH2UKlo88eH6MRsWP0SNdAIQN/iaxAokO17ruaqw7aj/UKxR0LL2FokpDwO6T Gu/DVPMLaNA2BK9s3ZqZGuFZWwa/RJmYdwVbHXLIbOVT6VYMzo0Bvwu3+28g0UI2jn5T qWmBicmF3J9fOFzasaMTVbzE98q9wBL0mGqjoOCN+1kc2CDnIedlPOlMR71xlMtobORu 14gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=dZq+d/WXfYfsa4kAs0Z4xPg6dZL1Fam1q+yd/iJjHig=; b=PB6W3BUSdDrrdG6M3lwPgWv+zYUC5vFRezhmomyQ89T0gJIunmX1Wt0qE6xjvEGpO/ tx14k6AD4K1CZ8uGrQF1RnbbWiOOC+OoBFJxfpQPIuEBQKWg3i63tofubxfVa4vwrJq1 3EJfUU9rHF7EryRR9hfdxe5NzauBTpq2v/XoRrgKzOfE+jt6jmwAK9fnNJqHTHr1tBkx YtCmb+LZ5keG26GCF76EQtEIn6y6V6j5gykenBShhQxae04CmatlYxNZ17GFQVOS58fS p3vER/iYwda8wrT5N/j45+aE5thtOFBfzivzzig3OXccahZ/Nf2b0S64AhNtFEkdoEvu 6YKA== X-Gm-Message-State: AG10YOSlahPQMqd9OStyBiEvEaax0Php9dnouRh4iHiWKs2OkUmQG0cOuBGcU0Lm5RHbAbEZcWQ4vFqDEHK0NA== MIME-Version: 1.0 X-Received: by 10.50.60.41 with SMTP id e9mr14311742igr.35.1453664071150; Sun, 24 Jan 2016 11:34:31 -0800 (PST) Received: by 10.79.79.132 with HTTP; Sun, 24 Jan 2016 11:34:31 -0800 (PST) In-Reply-To: <83si1m3j5l.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> <83si1m3j5l.fsf@gnu.org> Date: Sun, 24 Jan 2016 14:34:31 -0500 X-Google-Sender-Auth: dgntMG2EK_Vrk7-NAempxcjJ20A Message-ID: Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, Jan 24, 2016 at 1:51 PM, Eli Zaretskii wrote: >> Date: Sun, 24 Jan 2016 13:43:04 -0500 >> From: Noam Postavsky >> Cc: 21681@debbugs.gnu.org >> >> Warning (files): foo.el: =E2=80=98lexical-binding=E2=80=99 at end of fil= e unreliable > ^^^^^^^^^^^^^^ > But foo.el is not a file in this case. Huh? Yes it is. Perhaps you missed the bug: `display-warning' is called from inside `with-temp-buffer`, so we need to use `thisbuf' to reference the original buffer that we are calling `hack-local-variables' for. Hmm, perhaps my commit message should have explained that better. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 12:07:15 2016 Received: (at 21681) by debbugs.gnu.org; 25 Jan 2016 17:07:15 +0000 Received: from localhost ([127.0.0.1]:36401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNkbj-0005zk-Jg for submit@debbugs.gnu.org; Mon, 25 Jan 2016 12:07:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50073) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNkbi-0005zW-Az for 21681@debbugs.gnu.org; Mon, 25 Jan 2016 12:07:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNkbZ-00027T-9Y for 21681@debbugs.gnu.org; Mon, 25 Jan 2016 12:07:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNkbZ-00027G-6O; Mon, 25 Jan 2016 12:07:05 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4782 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aNkbU-0005It-Ay; Mon, 25 Jan 2016 12:07:00 -0500 Date: Mon, 25 Jan 2016 19:07:26 +0200 Message-Id: <838u3d37w1.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sun, 24 Jan 2016 14:34:31 -0500) Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> <83si1m3j5l.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sun, 24 Jan 2016 14:34:31 -0500 > From: Noam Postavsky > Cc: 21681@debbugs.gnu.org > > On Sun, Jan 24, 2016 at 1:51 PM, Eli Zaretskii wrote: > >> Date: Sun, 24 Jan 2016 13:43:04 -0500 > >> From: Noam Postavsky > >> Cc: 21681@debbugs.gnu.org > >> > >> Warning (files): foo.el: ‘lexical-binding’ at end of file unreliable > > ^^^^^^^^^^^^^^ > > But foo.el is not a file in this case. > > Huh? Yes it is. Perhaps you missed the bug: `display-warning' is > called from inside `with-temp-buffer`, so we need to use `thisbuf' to > reference the original buffer that we are calling > `hack-local-variables' for. Right, sorry. Yes, let's do that. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 10:56:36 2016 Received: (at 21681) by debbugs.gnu.org; 31 Jan 2016 15:56:36 +0000 Received: from localhost ([127.0.0.1]:43274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aPuMe-0004Ek-KJ for submit@debbugs.gnu.org; Sun, 31 Jan 2016 10:56:36 -0500 Received: from mail-ig0-f169.google.com ([209.85.213.169]:33531) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aPuMc-0004EX-GA for 21681@debbugs.gnu.org; Sun, 31 Jan 2016 10:56:34 -0500 Received: by mail-ig0-f169.google.com with SMTP id z14so20279989igp.0 for <21681@debbugs.gnu.org>; Sun, 31 Jan 2016 07:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=YtMqW4mR/nYWhcapJLuT1ZANH16RrjWF8OKZmyUY2DY=; b=e7vGz59SytSoXH70pMOaZrDYXq6Duz6Gi4BFh3skMogiV9qYBK87DU4qDZeiICKydk Ni43tvJy7sgYQxwvrW3VBFyxnInRSTYCdZYK1UC6CQ+ymwUor1vFnXNFz1w9Vp1uLzs1 a0mMlVDk6Vkhr2maslF9x3yEDW9eCP8RtEwbiPVHJTYzuKPU4hG5VN5YuGR9yNMU97vT XD/HUo1BM88oZowRpRxi1/cZmxJau9PigW7/OwuCa2K7s9SjMZ7zzaGWiV1W693mjLTY xgsehSuMDJD1kLMPGnKdvToxu1LwZxFMAzFsMljwSG9Pw0u/JvyloPngP8q+iAnKxuj0 z+zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=YtMqW4mR/nYWhcapJLuT1ZANH16RrjWF8OKZmyUY2DY=; b=UsoeBxr8RAHFHnqcQAUeeWhf7ce9nMYxb75Mk7du/eL5PKsN2Ydg5XVqxYkdsjCRlA 1adFtPy+9ZL3WtsQ2hPTEv9FZEZ32M/itU0KluOX2EqsWCEZ1il1nMKSNgO54ydoAva1 hDKE0mGZi4dmX1v+jC0TZPtytyKtMDsy6OPc4DiEbJs9nbntghIx16ozXKjFTXDSS9yU rtAPJTE2EhK7OUVdd1e0sj1yhHWpCNGracIuZ/DEllcLJMWhe0EJFZKEK4ymoaaj7dVh uD5xKozxYCXFT1aJKpfkdtqhpnkEaUF9FbCypMGc+dyNDKJ68eLO8J4PihwfEaveFj73 zpHw== X-Gm-Message-State: AG10YOQPil6Xal9ftu/5ks3Zzza62FMa55365Xc+g3ACEzDQv/UZ3Op4PtHkCuMcOsyjy3ynLBVXpSOoGC+dDg== MIME-Version: 1.0 X-Received: by 10.50.20.73 with SMTP id l9mr6991047ige.58.1454255788689; Sun, 31 Jan 2016 07:56:28 -0800 (PST) Received: by 10.79.118.131 with HTTP; Sun, 31 Jan 2016 07:56:28 -0800 (PST) In-Reply-To: <838u3d37w1.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> <83si1m3j5l.fsf@gnu.org> <838u3d37w1.fsf@gnu.org> Date: Sun, 31 Jan 2016 10:56:28 -0500 X-Google-Sender-Auth: W9uTeACrgPr22c-tSFrPSuvS6XY Message-ID: Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning From: Noam Postavsky To: Eli Zaretskii Content-Type: multipart/mixed; boundary=047d7bd6b020b2fd7f052aa34f2a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bd6b020b2fd7f052aa34f2a Content-Type: text/plain; charset=UTF-8 On Mon, Jan 25, 2016 at 12:07 PM, Eli Zaretskii wrote: >> Date: Sun, 24 Jan 2016 14:34:31 -0500 >> From: Noam Postavsky >> >> [...] `display-warning' is >> called from inside `with-temp-buffer`, so we need to use `thisbuf' to >> reference the original buffer that we are calling >> `hack-local-variables' for. > > Right, sorry. Yes, let's do that. Ping? Resending with above explanation in commit message. --047d7bd6b020b2fd7f052aa34f2a Content-Type: application/octet-stream; name="0001-Fix-lexical-binding-at-eof-warning.patch" Content-Disposition: attachment; filename="0001-Fix-lexical-binding-at-eof-warning.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ik2qbsdm0 RnJvbSAxZTljMjk0MzIwYjkyMGY2ZjIwZGFhNDkxNDJkZTAxNzNlZDExM2MyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBTdW4sIDI0IEphbiAyMDE2IDExOjE3OjQ1IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGxleGljYWwgYmluZGluZyBhdCBlb2Ygd2FybmluZwoKKiBmaWxlcy5lbCAoaGFjay1sb2NhbC12 YXJpYWJsZXMpOiBgZGlzcGxheS13YXJuaW5nJyBpcyBjYWxsZWQgZnJvbQppbnNpZGUgYHdpdGgt dGVtcC1idWZmZXJgLCBzbyB3ZSBuZWVkIHRvIHVzZSBgdGhpc2J1ZicgdG8gcmVmZXJlbmNlIHRo ZQpvcmlnaW5hbCBidWZmZXIgdGhhdCB3ZSBhcmUgY2FsbGluZyBgaGFjay1sb2NhbC12YXJpYWJs ZXMnIGZvci4KLS0tCiBsaXNwL2ZpbGVzLmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xp c3AvZmlsZXMuZWwKaW5kZXggMzg5OGRmZi4uYjJjOTBiYyAxMDA2NDQKLS0tIGEvbGlzcC9maWxl cy5lbAorKysgYi9saXNwL2ZpbGVzLmVsCkBAIC0zNDI2LDcgKzM0MjYsNyBAQCBsb2NhbCB2YXJp YWJsZXMsIGJ1dCBkaXJlY3RvcnktbG9jYWwgdmFyaWFibGVzIG1heSBzdGlsbCBiZSBhcHBsaWVk LiIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZm9ybWF0LW1lc3NhZ2UKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiVzOiBgbGV4aWNhbC1iaW5kaW5nJyBh dCBlbmQgb2YgZmlsZSB1bnJlbGlhYmxlIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoZmlsZS1uYW1lLW5vbmRpcmVjdG9yeQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKG9yIGJ1ZmZlci1maWxlLW5hbWUgIiIpKSkpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChvciAoYnVmZmVyLWZpbGUtbmFtZSB0aGlzYnVmKSAiIikpKSkp KQogCQkJICAgICAgKHQKIAkJCSAgICAgICAoaWdub3JlLWVycm9ycwogCQkJCSAocHVzaCAoY29u cyAoaWYgKGVxIHZhciAnZXZhbCkKLS0gCjIuNi4yLndpbmRvd3MuMQoK --047d7bd6b020b2fd7f052aa34f2a-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 03 12:50:25 2016 Received: (at 21681) by debbugs.gnu.org; 3 Feb 2016 17:50:25 +0000 Received: from localhost ([127.0.0.1]:58344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aR1ZR-0007fq-9G for submit@debbugs.gnu.org; Wed, 03 Feb 2016 12:50:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54808) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aR1ZO-0007fc-Vh for 21681@debbugs.gnu.org; Wed, 03 Feb 2016 12:50:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR1ZG-0001He-PK for 21681@debbugs.gnu.org; Wed, 03 Feb 2016 12:50:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR1ZG-0001Ha-Li; Wed, 03 Feb 2016 12:50:14 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3255 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aR1ZF-00075W-UT; Wed, 03 Feb 2016 12:50:14 -0500 Date: Wed, 03 Feb 2016 19:49:56 +0200 Message-Id: <837fily98b.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sun, 31 Jan 2016 10:56:28 -0500) Subject: Re: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> <83si1m3j5l.fsf@gnu.org> <838u3d37w1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 21681 Cc: 21681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) > Date: Sun, 31 Jan 2016 10:56:28 -0500 > From: Noam Postavsky > Cc: 21681@debbugs.gnu.org > > Ping? Resending with above explanation in commit message. Thanks, pushed. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 03 13:03:34 2016 Received: (at control) by debbugs.gnu.org; 3 Feb 2016 18:03:34 +0000 Received: from localhost ([127.0.0.1]:58350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aR1mA-0007z2-Eo for submit@debbugs.gnu.org; Wed, 03 Feb 2016 13:03:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57999) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aR1m9-0007yq-VY for control@debbugs.gnu.org; Wed, 03 Feb 2016 13:03:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR1m4-0003aa-DD for control@debbugs.gnu.org; Wed, 03 Feb 2016 13:03:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR1m4-0003aV-9c for control@debbugs.gnu.org; Wed, 03 Feb 2016 13:03:28 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aR1m3-0003fM-VT for control@debbugs.gnu.org; Wed, 03 Feb 2016 13:03:28 -0500 Subject: control message for bug 21681 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 03 Feb 2016 13:03:27 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) close 21681 25.0.91 From unknown Fri Jun 20 07:20:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 Mar 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator