GNU bug report logs - #21669
25.0.50; file-notify-tests failure on Fedora x86-64

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21669 in the body.
You can then email your comments to 21669 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emacs bug reports and feature requests <bug-gnu-emacs <at> gnu.org>
Subject: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Sun, 11 Oct 2015 15:35:49 -0700

[Message part 1 (text/plain, inline)]

This is to some extent a followup to Bug#21668, as it reports a similar kind of 
test failure.

The file-notify-tests test fails for me routinely.  Not always, though; it's not 
reproducible in general.  Attached is a sample log.  I don't want to spend time 
debugging this myself, but thought that whoever wants to know about this test 
failure should know about it.

[file-notify-tests.log (text/x-log, attachment)]

Message #8 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Mon, 12 Oct 2015 13:14:17 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> This is to some extent a followup to Bug#21668, as it reports a
> similar kind of test failure.
>
> The file-notify-tests test fails for me routinely.  Not always,
> though; it's not reproducible in general.  Attached is a sample log.
> I don't want to spend time debugging this myself, but thought that
> whoever wants to know about this test failure should know about it.

Same here; I'll check when possible. This error is related to a Tramp
test case. As silly counter-measure, could you modify
`file-notify--test-timeout' in order to have a larger timeout than 6
seconds?

Best regards, Michael.

Message #11 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Mon, 12 Oct 2015 18:36:35 -0700

Michael Albinus wrote:
> As silly counter-measure, could you modify
> `file-notify--test-timeout' in order to have a larger timeout than 6
> seconds?

Is that something you could do for me, by changing it in master?  To be honest I 
don't want to spend a lot of time worrying about this one....

Message #14 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Tue, 13 Oct 2015 09:46:24 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

>> As silly counter-measure, could you modify
>> `file-notify--test-timeout' in order to have a larger timeout than 6
>> seconds?
>
> Is that something you could do for me, by changing it in master?  To
> be honest I don't want to spend a lot of time worrying about this
> one....

Done. Pls let us know, whether it solves the problem for you.

Best regards, Michael.

Message #17 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Fri, 16 Oct 2015 13:20:48 -0700

[Message part 1 (text/plain, inline)]

On 10/13/2015 12:46 AM, Michael Albinus wrote:
>> Is that something you could do for me, by changing it in master?  To
>> >be honest I don't want to spend a lot of time worrying about this
>> >one....
> Done. Pls let us know, whether it solves the problem for you.
>
> Best regards, Michael.

Unfortunately it does not. Most of the time file-notify-tests succeeds, 
but it occasionally fails. I'm attaching a failure log, generated from 
commit 1e1a326c0f609f403c625bd9082e1099a4d9a52a and built with GCC 5.2 
on Fedora 21 x86-64 with './configure --enable-gcc-warnings'.

[file-notify-tests.log (text/plain, attachment)]

Message #20 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Sat, 17 Oct 2015 11:27:37 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> Unfortunately it does not. Most of the time file-notify-tests
> succeeds, but it occasionally fails. I'm attaching a failure log,
> generated from commit 1e1a326c0f609f403c625bd9082e1099a4d9a52a and
> built with GCC 5.2 on Fedora 21 x86-64 with './configure
> --enable-gcc-warnings'.
>
> Running 12 tests (2015-10-16 13:14:40-0700)
> Local library: `inotify'
>    passed   1/12  file-notify-test00-availability
> Remote command: `gvfs-monitor-dir'
>
> 1 unexpected results:
>    FAILED  file-notify-test02-events-remote

Well, with gfilenotify it is known that there are timimg issues if
events occur in short period. Some of them are suppressed then, likely
as performance feature of gio.

With the local gfilenotify library (not used in your case) I could fix
this; the remote gvfs-monitor-dir process does not offer an argument for
changing the timing.

I've changed file-notify-tests.el in order to handle this. Could you,
pls, check?

Best regards, Michael.

Message #23 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Tue, 20 Oct 2015 18:34:21 -0700

[Message part 1 (text/plain, inline)]

Michael Albinus wrote:
> I've changed file-notify-tests.el in order to handle this. Could you,
> pls, check?

Still not working, I'm afraid. Failures are intermittent. A failing 
file-notify-tests.log is attached.

[file-notify-tests.log (text/x-log, attachment)]

Message #26 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Wed, 21 Oct 2015 10:01:36 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

Hi Paul,

>> I've changed file-notify-tests.el in order to handle this. Could you,
>> pls, check?
>
> Still not working, I'm afraid. Failures are intermittent. A failing
> file-notify-tests.log is attached.

Are you sure you've got the recent 57be62f97b8442218f4fa6979cf27b36d5d5f540
of test/automated/file-notify-tests.el, and it is also compiled? The
test for

>       (proper-lists-of-different-length 1 2
> 					(attribute-changed)
> 					(attribute-changed attribute-changed)
> 					first-mismatch-at 1)))

is NOT part any longer of this file.

Best regards, Michael.

Message #29 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Wed, 21 Oct 2015 09:03:27 -0700

[Message part 1 (text/plain, inline)]

On 10/21/2015 01:01 AM, Michael Albinus wrote:
> Are you sure you've got the recent 57be62f97b8442218f4fa6979cf27b36d5d5f540
> of test/automated/file-notify-tests.el, and it is also compiled? The
> test for
>
>> >       (proper-lists-of-different-length 1 2
>> >					(attribute-changed)
>> >					(attribute-changed attribute-changed)
>> >					first-mismatch-at 1)))
> is NOT part any longer of this file.

I'm not sure for the failure I already sent you since I've git pulled 
since then, but I just now reran the tests in master commit 
f6ece2420c3dc6f3dde06c7f8722f5b0b7e1ef4a (which postdates the commit you 
mention) and am still seeing intermittent failures. Failure log 
attached. test/automated/file-notify-tests.el has been compiled:

 $ ls -l test/automated/file-notify-tests.el*
-rw-r--r--. 1 eggert eggert 22497 Oct 20 18:16 
test/automated/file-notify-tests.el
-rw-r--r--. 1 eggert eggert 37715 Oct 21 08:53 
test/automated/file-notify-tests.elc

[file-notify-tests.log (text/plain, attachment)]

Message #32 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Wed, 21 Oct 2015 20:25:49 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> I'm not sure for the failure I already sent you since I've git pulled
> since then, but I just now reran the tests in master commit
> f6ece2420c3dc6f3dde06c7f8722f5b0b7e1ef4a (which postdates the commit
> you mention) and am still seeing intermittent failures. Failure log
> attached. test/automated/file-notify-tests.el has been compiled:

Running many times the test, I could reproduce the error now once. I
will instrument the code, and see what happens. Hard to debug, likely a
timing issue.

Best regards, Michael.

Message #35 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Fri, 23 Oct 2015 13:31:29 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

Hi Paul,

> I'm not sure for the failure I already sent you since I've git pulled
> since then, but I just now reran the tests in master commit
> f6ece2420c3dc6f3dde06c7f8722f5b0b7e1ef4a (which postdates the commit
> you mention) and am still seeing intermittent failures.

Finally, I could fix it. Puhhh.

In fact, there were two problems:

- `write-region' fires in the local case just `created' and `changed'
  events.  In the remote case, it fires `created', `changed' and
  `attribute-changed' events. This is because Tramp calls internally
  `set-file-modes' on the newly created file.

- In the test case `file-notify-test02-events-remote' not all events did
  arrive in time, because there was a fast sequence `write-region',
  `set-file-modes', `delete-file'. So I had to introduce short
  `sleep-for' calls between those functions.

I've committed a fix for both problems (and for one unrelated error in
filenotify.el I found also). I've run file-notify-tests.el 20 times now,
no error again. Could you, pls, recheck?

Best regards, Michael.

Message #38 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Sat, 31 Oct 2015 09:31:20 +0100

Michael Albinus <michael.albinus <at> gmx.de> writes:

> I've committed a fix for both problems (and for one unrelated error in
> filenotify.el I found also). I've run file-notify-tests.el 20 times now,
> no error again. Could you, pls, recheck?

Ping.

Best regards, Michael.

Message #41 received at 21669 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 21669 <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Sat, 31 Oct 2015 05:49:09 -0700

Michael Albinus wrote:
> I've committed a fix for both problems (and for one unrelated error in
> filenotify.el I found also). I've run file-notify-tests.el 20 times now,
> no error again. Could you, pls, recheck?

It seems to be working for me too.  Thanks.

Message #46 received at 21669-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21669-done <at> debbugs.gnu.org
Subject: Re: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Sat, 31 Oct 2015 14:36:31 +0100

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> Michael Albinus wrote:
>> I've committed a fix for both problems (and for one unrelated error in
>> filenotify.el I found also). I've run file-notify-tests.el 20 times now,
>> no error again. Could you, pls, recheck?
>
> It seems to be working for me too.  Thanks.

So I'm closing this bug, too. Thanks for testing.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.