GNU bug report logs - #21662
25.0.50; visible-bell causes display artifacts on OS X 10.11

Previous Next

Full log

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mustafa Kocaturk <murskt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: K M <murskt <at> gmail.com>
Subject: Re: bug#21662: 25.0.50;
 visible-bell causes display artifacts on OS X 10.11
Date: Thu, 22 Oct 2015 11:07:20 -0500

The patch file had a duplicate of itself; the first half is sufficient.

> diff --git a/src/nsterm.m b/src/nsterm.m
> index c4bfd7c..f16ebe2 100644
> --- src/nsterm.m~
> +++ src/nsterm.m
> @@ -987,6 +987,59 @@ ns_clip_to_row (struct window *w, struct glyph_row *row,
> 
[…]
> -          ns_timeout (150000);

[…]
> }

The rest of the patch, starting with the lines below, should be removed:
> diff --git a/src/nsterm.m b/src/nsterm.m
> index c4bfd7c..f16ebe2 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -987,6 +987,59 @@ ns_clip_to_row (struct window *w, struct glyph_row *row,
[…]
> 


The affected file, nsterm.m, defines a function called ns_timeout (int usecs), whose only use case appears to be removed by this change.
I think there is no other use of this function, but will verify by recompiling and send an updated patch, also removing the definition of ns_timeout if unused.

Best regards,
Mustafa

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.