GNU bug report logs - #21651
25.0.50; [PATCH] Memory leak: auto_fontset_alist has keys that are modified externally by mistake

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dima Kogan <dima <at> secretsauce.net>
Subject: bug#21651: closed (Re: bug#21651: 25.0.50; [PATCH] Memory leak:
 auto_fontset_alist has keys that are modified	externally by mistake)
Date: Tue, 20 Oct 2015 15:15:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#21651: 25.0.50; [PATCH] Memory leak: auto_fontset_alist has keys that are modified externally by mistake

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 21651 <at> debbugs.gnu.org.

-- 
21651: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21651
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 21651-done <at> debbugs.gnu.org
Subject: Re: bug#21651: 25.0.50;
 [PATCH] Memory leak: auto_fontset_alist has keys that are
 modified	externally by mistake
Date: Tue, 20 Oct 2015 18:14:08 +0300

> From: Dima Kogan <dima <at> secretsauce.net>
> Date: Thu, 08 Oct 2015 14:49:11 -0700
> 
> This issue was discussed on the mailing list with the thread starting
> here:
> 
> https://lists.gnu.org/archive/html/emacs-devel/2015-10/msg00550.html
> 
> A patch was proposed here:
> 
> https://lists.gnu.org/archive/html/emacs-devel/2015-10/msg00292.html
> 
> and is copied here as an attachment.

Thanks, pushed.

[Message part 3 (message/rfc822, inline)]

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 [PATCH] Memory leak: auto_fontset_alist has keys that are modified
 externally by mistake
Date: Thu, 08 Oct 2015 14:49:11 -0700

[Message part 4 (text/plain, inline)]

This issue was discussed on the mailing list with the thread starting
here:

https://lists.gnu.org/archive/html/emacs-devel/2015-10/msg00550.html

A patch was proposed here:

https://lists.gnu.org/archive/html/emacs-devel/2015-10/msg00292.html

and is copied here as an attachment.

[0001-copy_font_spec-now-makes-a-deeper-copy-of-its-input.patch (text/x-diff, inline)]

From: Dima Kogan <dima <at> secretsauce.net>
Date: Mon, 5 Oct 2015 11:21:12 -0700
Subject: (copy_font_spec) now makes a deeper copy of its input

---
 src/font.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/font.c b/src/font.c
index a52a653..0b2999e 100644
--- a/src/font.c
+++ b/src/font.c
@@ -3981,7 +3981,12 @@ copy_font_spec (Lisp_Object font)
   pcdr = spec->props + FONT_EXTRA_INDEX;
   for (tail = AREF (font, FONT_EXTRA_INDEX); CONSP (tail); tail = XCDR (tail))
     if (!EQ (XCAR (XCAR (tail)), QCfont_entity))
-      *pcdr = Fcons (XCAR (tail), Qnil), pcdr = xcdr_addr (*pcdr);
+      {
+        *pcdr = Fcons (Fcons( XCAR (XCAR (tail)),
+                              XCDR (XCAR (tail))),
+                       Qnil);
+        pcdr = xcdr_addr (*pcdr);
+      }
 
   XSETFONT (new_spec, spec);
   return new_spec;

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.