GNU bug report logs - #21650
24.5; mh-e keeps trying to open urls

Previous Next

Full log

View this message in rfc822 format

From: Mike Kupfer <m.kupfer <at> acm.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Glenn Morris <rgm <at> gnu.org>, Lars Ingebrigtsen <larsi <at> gnus.org>, 21650 <at> debbugs.gnu.org, Bill Wohler <wohler <at> newt.com>
Subject: bug#21650: fix should be underneath MH-E
Date: Thu, 04 Feb 2016 17:41:54 -0800

Katsumi Yamaoka wrote:

> Implement the new user options in mm:
> `mm-html-inhibit-images' --- boolean
>   Non-nil means inhibit displaying of images inline in the article body.
>   The default is t.
> `mm-html-blocked-images' --- regexp or nil
>   Regexp matching image URLs to be blocked.  The default is "".

This looks okay to me.  And the default looks safe.

Just to confirm, mm-html-blocked-images would block the downloading of
remote images, but images that are embedded in the email and referenced
using a cid would still be displayed?

> Make `mm-inline-text-html-with-images' an obsolete variable alias
> for `mm-html-inhibit-images'.

I'm afraid I don't understand well enough how variable obsolescence
works in Emacs to be sure.  
mm-inline-text-html-with-images is documented in terms of retrieving
messages, and non-nil means to allow retrieval.  mm-html-inhibit-images
would apparently control display of any images (even ones embedded in
the email), and non-nil means *not* to display.

> MH-E doesn't have to do like this if there's no need to have
> options like `mh-inhibit-images'.

Right.  We might want to add a note to the MH-E user guide that mentions
these variables.  But I don't think any changes are needed in the code.

> MH-E doesn't use gnus-html.el, does it?

I don't see any references, no.

thanks,
mike

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.