From unknown Sat Aug 16 18:45:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21638: 25.0.50; font-lock for CSS variables Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21638@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14441543382381 (code B ref -1); Tue, 06 Oct 2015 17:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Oct 2015 17:58:58 +0000 Received: from localhost ([127.0.0.1]:57345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjWVt-0000cI-57 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60131) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjWVp-0000c8-P0 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWVd-0003II-4E for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:39493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWVc-0003I4-Vb for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWVF-0002Ze-3b for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:58:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWUQ-0002Mn-Pu for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:58:17 -0400 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:52575) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ZjWUQ-0002I7-8B for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:57:26 -0400 Received: (qmail 2357 invoked by uid 0); 6 Oct 2015 17:57:17 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy9.mail.unifiedlayer.com with SMTP; 6 Oct 2015 17:57:17 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id Rtx91r00L2f2jeq01txCnl; Tue, 06 Oct 2015 11:57:15 -0600 X-Authority-Analysis: v=2.1 cv=VOBOwb/X c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=meFa6WQr8mcA:10 a=5lJygRwiOn0A:10 a=XgxIVdyZSTaTZ_yyjngA:9 a=CHPn04y0Lino2KIm:21 a=rhVO9XaKcrhFbxXy:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=qdrjs+3gGgMBDZ4MXzBVqd7iV8g0hAkkCj1874AE3DE=; b=pPT52rXTyRCWJHFNXHFrNAGprB+02vKBpuTqxUUK96hMF/s6st53+LtJoTr3p/9g+Og+PezN8eZ5fmJOK+PtoWsBL7kJHnkjEyFQTVNtwUhVzMpkBTsJlvB1AONotw3x; Received: from [65.128.91.114] (port=45252 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1ZjWUA-0007qd-IR; Tue, 06 Oct 2015 11:57:10 -0600 From: Tom Tromey X-Attribution: Tom Date: Tue, 06 Oct 2015 11:57:07 -0600 Message-ID: <87twq3ev7w.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.91.114 authed with tom+tromey.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Right now CSS mode doesn't treat CSS variable definitions as properties. I think it should. Here's the patch that worked for me: diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 5f4eebd..97dd8ab 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -289,7 +289,7 @@ css--font-lock-keywords nil))) ;; Properties. Again, we don't limit ourselves to css-property-ids. (,(concat "\\(?:[{;]\\|^\\)[ \t]*\\(" - "\\(?:\\(" css-proprietary-nmstart-re "\\)\\|" + "\\(?:\\(" css-proprietary-nmstart-re "\\)\\|--\\|" css-nmstart-re "\\)" css-nmchar-re "*" "\\)\\s-*:") (1 (if (match-end 2) 'css-proprietary-property 'css-property))) Tom In GNU Emacs 25.0.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-10-06 Repository revision: b8adff8426a4532a0971e9a470d3347aafd99b35 Windowing system distributor 'Fedora Project', version 11.0.11702000 Configured using: 'configure --prefix=/home/tromey/Emacs/install/ --with-file-notification=no' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: CSS Minor modes in effect: bug-reference-prog-mode: t diff-auto-refine-mode: t erc-spelling-mode: t erc-truncate-mode: t flyspell-mode: t which-function-mode: t projectile-global-mode: t projectile-mode: t erc-notify-mode: t erc-notifications-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: #[128 \300\301\302.#\207 [apply smie-auto-fill #[128 \301\302\300!."\207 [normal-auto-fill-function apply default-value] 4 (fn &rest ARGS)] nil] 5 nil] transient-mark-mode: t Recent messages: ") (put-text-property (point) (match-end 0) (quote font-lock-multiline) t) nil))) ("\\(?:[{;]\\|^\\)[ ]*\\(\\(?:\\([-_]\\(?:khtml\\|m\\(?:oz\\|s\\)\\|o\\|webkit\\)-\\)\\|--\\|\\(?:[[:alpha:]]\\|\\\\\\(?:[^.-]\\|[0-9a-fA-F]+[ . ]?\\)\\)\\)\\(?:[-[:alnum:]]\\|\\\\\\(?:[^.-]\\|[0-9a-fA-F]+[ . ]?\\)\\)*\\)\\s-*:" (1 (if (match-end 2) (quote css-proprietary-property) (quote css-property)))) ("url\\((\\)[[:space:]]*\\(?:\\\\.\\|[^()[:space:] '\"]\\)+[[:space:]]*\\()\\)" (1 (quote default) t) (2 (quote default) t))) Mark set Mark saved where search started Saving file /home/tromey/firefox-git/tree-2/devtools/client/styleinspector/test/doc_copystyles.css... Wrote /home/tromey/firefox-git/tree-2/devtools/client/styleinspector/test/doc_copystyles.css Finding changes in /home/tromey/Emacs/emacs/lisp/textmodes/css-mode.el...done Quit [4 times] funcall-interactively: No recursive edit is in progress Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.0.50/lisp/play/bubbles Features: (shadow mail-hist emacsbug whitespace css-mode texinfo git-commit-mode log-edit pcvs-util smerge-mode gnus-fun eieio-opt speedbar sb-image ezimage dframe dabbrev git-rebase-mode flow-fill misearch multi-isearch add-log bug-reference js json cc-mode cc-fonts cc-guess cc-menus cc-cmds gnus-html url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars shr-color shr dom browse-url mm-archive bbdb-gui bbdb-hooks bbdb-rmail rmailsum rmail sort smiley gnus-cite gnus-bcklg gnus-async qp gnus-ml disp-table copyright vc-mtn vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs term/xterm xterm gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com warnings gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader mail-utils gnutls network-stream nsm starttls tls erc-spelling erc-truncate flyspell ispell diminish appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu projectile ibuf-macs ibuf-ext ibuffer minimap autorevert filenotify desktop frameset cus-start cus-load erc-notify erc-desktop-notifications notifications dbus xml erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio byte-opt bytecomp byte-compile cl-extra cconv gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp status dired-aux dired-x dired advice vc-dir ewoc vc vc-dispatcher flycheck derived easy-mmode cl-seq edmacro kmacro find-func help-mode rx subr-x dash jka-compr sh-script smie executable compile let-alist cc-styles cc-align cc-engine cc-vars cc-defs bbdb cl timezone ange-ftp comint ansi-color ring server savehist finder-inf bbdb-autoloads dwarf-mode-autoloads eieio-core cl-macs gv cl-loaddefs pcase cl-lib lisppaste-autoloads pydoc-info-autoloads info-look weblogger-autoloads info package easymenu epg-config time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1584563 702016) (symbols 48 102069 0) (miscs 40 23022 3346) (strings 32 661191 206096) (string-bytes 1 24535493) (vectors 16 104304) (vector-slots 8 2294514 218530) (floats 8 874 1102) (intervals 56 38889 1534) (buffers 976 98) (heap 1024 301266 64795)) From unknown Sat Aug 16 18:45:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21638: 25.0.50; font-lock for CSS variables Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 21638@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 21638-submit@debbugs.gnu.org id=B21638.144415951910315 (code B ref 21638); Tue, 06 Oct 2015 19:26:02 +0000 Received: (at 21638) by debbugs.gnu.org; 6 Oct 2015 19:25:19 +0000 Received: from localhost ([127.0.0.1]:57373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjXrS-0002gG-6C for submit@debbugs.gnu.org; Tue, 06 Oct 2015 15:25:19 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:34890) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjXr6-0002eL-Ex for 21638@debbugs.gnu.org; Tue, 06 Oct 2015 15:25:16 -0400 Received: by lbwr8 with SMTP id r8so82198139lbw.2 for <21638@debbugs.gnu.org>; Tue, 06 Oct 2015 12:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=oMANvAnzoRnsjb45EdqZaMG6d+hzFTcYQHmHt4kC3KI=; b=Ga2dNn4gGwNCT63XRXjCGv8OhtL7dK5cKm0kToAqcBtNbNqHmerJV9VwXZBJ7N/OkZ qj+iFZ/6uc3Z0HHTwufDkYxqist+mfhFpTQZLt22Ekdx4cVkWBClPwjfFEYt6H5cpeU0 Ym099WzgdA/a68KlLUAlxXkK+cZfLF+GR8AgBmlEnK2Vllr8mBlFQ+PdFICEJWCc4hj9 hYd2mcjiqHVv7d6VCXMjkAbBCcd8Ne5Hgs4/cxTu3DBSZE3NADBJ0ok9BeE83/emnXAC GkdrSysVH69qcn8jH+6FQBDtL0hic4RitQ81MYFsiDVdDqQ8MjBPpSYWqcfd2B4+4Gro 3pDg== X-Received: by 10.25.212.2 with SMTP id l2mr3541679lfg.118.1444159495432; Tue, 06 Oct 2015 12:24:55 -0700 (PDT) Received: from x240 (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id b193sm5610964lfb.46.2015.10.06.12.24.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2015 12:24:54 -0700 (PDT) From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= References: <87twq3ev7w.fsf@tromey.com> Date: Tue, 06 Oct 2015 21:24:53 +0200 In-Reply-To: <87twq3ev7w.fsf@tromey.com> (Tom Tromey's message of "Tue, 06 Oct 2015 11:57:07 -0600") Message-ID: <87mvvvkdfe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Tom Tromey writes: > Right now CSS mode doesn't treat CSS variable definitions as > properties. I think it should. > > Here's the patch that worked for me: > > [...] > > Tom Hi Tom! Good idea. The patch seems to do the job, but it also has the side effect that '---foo', '----foo' and so on are recognized as properties. Putting it instead at the start of 'css-nmstart-re' seems to fix that: diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 5f4eebd..3e84b43 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -215,7 +215,7 @@ (defconst css-escapes-re "\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[ \n\t\r\f]?\\)") (defconst css-nmchar-re (concat "\\(?:[-[:alnum:]]\\|" css-escapes-re "\\)")) -(defconst css-nmstart-re (concat "\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) +(defconst css-nmstart-re (concat "\\(?:--\\)?\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) (defconst css-ident-re ;; (concat css-nmstart-re css-nmchar-re "*") ;; Apparently, "at rules" names can start with a dash, e.g. @-moz-keyframes. (concat css-nmchar-re "+")) Though I'm unsure what 'css-nmstart-re' is intended to contain, since it's missing a docstring. Maybe Stefan knows? -- Simen From unknown Sat Aug 16 18:45:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21638: 25.0.50; font-lock for CSS variables Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: 21638@debbugs.gnu.org, Tom Tromey , monnier@iro.umontreal.ca Received: via spool by 21638-submit@debbugs.gnu.org id=B21638.144416585620367 (code B ref 21638); Tue, 06 Oct 2015 21:11:02 +0000 Received: (at 21638) by debbugs.gnu.org; 6 Oct 2015 21:10:56 +0000 Received: from localhost ([127.0.0.1]:57491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjZVf-0005IR-Q7 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 17:10:56 -0400 Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:55197) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1ZjZVc-0005II-Uv for 21638@debbugs.gnu.org; Tue, 06 Oct 2015 17:10:54 -0400 Received: (qmail 27701 invoked by uid 0); 6 Oct 2015 21:10:47 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy1.mail.unifiedlayer.com with SMTP; 6 Oct 2015 21:10:47 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id RxAe1r00v2f2jeq01xAhHy; Tue, 06 Oct 2015 15:10:46 -0600 X-Authority-Analysis: v=2.1 cv=IekUBwaa c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=meFa6WQr8mcA:10 a=5lJygRwiOn0A:10 a=_gpXLk24pRjj9ZE7u6UA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=etFrD8CDCkSlZjhLq4kKiySYPxZP0JFXNjlwd6QSNeQ=; b=Pk9dxXJaTXCD5GZFQU7kySfMLBDeC2NthburZP6DOFU5UQQf7XuVJtYgoXEjKGFwK5My3nxfFhxjYKAUvkaYUpRCBt93mCUgM0Tc1YPLGFQUAPH0FddfmFpfNsVuHFwi; Received: from [65.128.91.114] (port=46678 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1ZjZVO-0005Sp-B4; Tue, 06 Oct 2015 15:10:38 -0600 From: Tom Tromey References: <87twq3ev7w.fsf@tromey.com> <87mvvvkdfe.fsf@gmail.com> X-Attribution: Tom Date: Tue, 06 Oct 2015 15:10:35 -0600 In-Reply-To: <87mvvvkdfe.fsf@gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\=C3\=B8yl\?\= \=\?utf-8\?Q\?\=22's\?\= message of "Tue, 06 Oct 2015 21:24:53 +0200") Message-ID: <87pp0rem9g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.91.114 authed with tom+tromey.com} X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Simen> Good idea. The patch seems to do the job, but it also has the side Simen> effect that '---foo', '----foo' and so on are recognized as Simen> properties. Yeah, sorry, I forgot that the rest had to look like an identifier. Simen> Though I'm unsure what 'css-nmstart-re' is intended to contain, since Simen> it's missing a docstring. Maybe Stefan knows? Considering that this is the only use I think you are on safe ground. Tom From unknown Sat Aug 16 18:45:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tom Tromey Subject: bug#21638: closed (Re: bug#21638: 25.0.50; font-lock for CSS variables) Message-ID: References: <87k2qyd1vp.fsf@gmail.com> <87twq3ev7w.fsf@tromey.com> X-Gnu-PR-Message: they-closed 21638 X-Gnu-PR-Package: emacs Reply-To: 21638@debbugs.gnu.org Date: Wed, 07 Oct 2015 17:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1444238943-13301-1" This is a multi-part message in MIME format... ------------=_1444238943-13301-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #21638: 25.0.50; font-lock for CSS variables which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 21638@debbugs.gnu.org. --=20 21638: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21638 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1444238943-13301-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 21638-done) by debbugs.gnu.org; 7 Oct 2015 17:28:50 +0000 Received: from localhost ([127.0.0.1]:59217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjsWI-0003S5-Hp for submit@debbugs.gnu.org; Wed, 07 Oct 2015 13:28:50 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:36120) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjsVx-0003RX-Tt for 21638-done@debbugs.gnu.org; Wed, 07 Oct 2015 13:28:48 -0400 Received: by lbcao8 with SMTP id ao8so19911823lbc.3 for <21638-done@debbugs.gnu.org>; Wed, 07 Oct 2015 10:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=g7B5E97FyBTyxrKZI63McguRyKEKiqGvJ8NoBpi0xlc=; b=qz4n5YKVcPBbjtBBsahJll8QmEE+I7tCO6uZdHIWo1HqBs4z6424AzUc5KJ69Fkv1v fEPmsicRgcC5xO56OP/l76YxyWAjHG7zKkZw69rJSPImIefKSmRzluh1J4n1L+8CSu/F quBOyMAGZkK3mQNczSyRSD+q16y9yabL3aqwfmHTgbJkun2NnphnwG1kY526TsBSZp8w tPHKeaJKDClQyznzIb1RgWr57USsCZdNAe1vI+qVXfaJLgmNl6d44AJnQfCgq1cehvx0 +wc1OLOVIHpWiM4MLVuLE+ng5WExD5YdIP4xYKiyR+BGrekqe0RcegHYQDKTmrRnrM+t wMTQ== X-Received: by 10.25.158.84 with SMTP id h81mr874901lfe.58.1444238908945; Wed, 07 Oct 2015 10:28:28 -0700 (PDT) Received: from x240 (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id v19sm6529427lfd.7.2015.10.07.10.28.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Oct 2015 10:28:28 -0700 (PDT) From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Tom Tromey Subject: Re: bug#21638: 25.0.50; font-lock for CSS variables References: <87twq3ev7w.fsf@tromey.com> <87mvvvkdfe.fsf@gmail.com> <87pp0rem9g.fsf@tromey.com> Date: Wed, 07 Oct 2015 19:28:26 +0200 In-Reply-To: <87pp0rem9g.fsf@tromey.com> (Tom Tromey's message of "Tue, 06 Oct 2015 15:10:35 -0600") Message-ID: <87k2qyd1vp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21638-done Cc: 21638-done@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Tom Tromey writes: > Simen> Good idea. The patch seems to do the job, but it also has the side > Simen> effect that '---foo', '----foo' and so on are recognized as > Simen> properties. > > Yeah, sorry, I forgot that the rest had to look like an identifier. > > Simen> Though I'm unsure what 'css-nmstart-re' is intended to contain, > Simen> since > Simen> it's missing a docstring. Maybe Stefan knows? > > Considering that this is the only use I think you are on safe ground. > > Tom Alright Tom, I've installed the fix. Thanks for the report! -- Simen ------------=_1444238943-13301-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Oct 2015 17:58:58 +0000 Received: from localhost ([127.0.0.1]:57345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjWVt-0000cI-57 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60131) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjWVp-0000c8-P0 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWVd-0003II-4E for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:39493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWVc-0003I4-Vb for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWVF-0002Ze-3b for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:58:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWUQ-0002Mn-Pu for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:58:17 -0400 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:52575) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ZjWUQ-0002I7-8B for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:57:26 -0400 Received: (qmail 2357 invoked by uid 0); 6 Oct 2015 17:57:17 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy9.mail.unifiedlayer.com with SMTP; 6 Oct 2015 17:57:17 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id Rtx91r00L2f2jeq01txCnl; Tue, 06 Oct 2015 11:57:15 -0600 X-Authority-Analysis: v=2.1 cv=VOBOwb/X c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=meFa6WQr8mcA:10 a=5lJygRwiOn0A:10 a=XgxIVdyZSTaTZ_yyjngA:9 a=CHPn04y0Lino2KIm:21 a=rhVO9XaKcrhFbxXy:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=qdrjs+3gGgMBDZ4MXzBVqd7iV8g0hAkkCj1874AE3DE=; b=pPT52rXTyRCWJHFNXHFrNAGprB+02vKBpuTqxUUK96hMF/s6st53+LtJoTr3p/9g+Og+PezN8eZ5fmJOK+PtoWsBL7kJHnkjEyFQTVNtwUhVzMpkBTsJlvB1AONotw3x; Received: from [65.128.91.114] (port=45252 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1ZjWUA-0007qd-IR; Tue, 06 Oct 2015 11:57:10 -0600 From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 25.0.50; font-lock for CSS variables X-Attribution: Tom Date: Tue, 06 Oct 2015 11:57:07 -0600 Message-ID: <87twq3ev7w.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.91.114 authed with tom+tromey.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Right now CSS mode doesn't treat CSS variable definitions as properties. I think it should. Here's the patch that worked for me: diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 5f4eebd..97dd8ab 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -289,7 +289,7 @@ css--font-lock-keywords nil))) ;; Properties. Again, we don't limit ourselves to css-property-ids. (,(concat "\\(?:[{;]\\|^\\)[ \t]*\\(" - "\\(?:\\(" css-proprietary-nmstart-re "\\)\\|" + "\\(?:\\(" css-proprietary-nmstart-re "\\)\\|--\\|" css-nmstart-re "\\)" css-nmchar-re "*" "\\)\\s-*:") (1 (if (match-end 2) 'css-proprietary-property 'css-property))) Tom In GNU Emacs 25.0.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-10-06 Repository revision: b8adff8426a4532a0971e9a470d3347aafd99b35 Windowing system distributor 'Fedora Project', version 11.0.11702000 Configured using: 'configure --prefix=/home/tromey/Emacs/install/ --with-file-notification=no' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: CSS Minor modes in effect: bug-reference-prog-mode: t diff-auto-refine-mode: t erc-spelling-mode: t erc-truncate-mode: t flyspell-mode: t which-function-mode: t projectile-global-mode: t projectile-mode: t erc-notify-mode: t erc-notifications-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: #[128 \300\301\302.#\207 [apply smie-auto-fill #[128 \301\302\300!."\207 [normal-auto-fill-function apply default-value] 4 (fn &rest ARGS)] nil] 5 nil] transient-mark-mode: t Recent messages: ") (put-text-property (point) (match-end 0) (quote font-lock-multiline) t) nil))) ("\\(?:[{;]\\|^\\)[ ]*\\(\\(?:\\([-_]\\(?:khtml\\|m\\(?:oz\\|s\\)\\|o\\|webkit\\)-\\)\\|--\\|\\(?:[[:alpha:]]\\|\\\\\\(?:[^.-]\\|[0-9a-fA-F]+[ . ]?\\)\\)\\)\\(?:[-[:alnum:]]\\|\\\\\\(?:[^.-]\\|[0-9a-fA-F]+[ . ]?\\)\\)*\\)\\s-*:" (1 (if (match-end 2) (quote css-proprietary-property) (quote css-property)))) ("url\\((\\)[[:space:]]*\\(?:\\\\.\\|[^()[:space:] '\"]\\)+[[:space:]]*\\()\\)" (1 (quote default) t) (2 (quote default) t))) Mark set Mark saved where search started Saving file /home/tromey/firefox-git/tree-2/devtools/client/styleinspector/test/doc_copystyles.css... Wrote /home/tromey/firefox-git/tree-2/devtools/client/styleinspector/test/doc_copystyles.css Finding changes in /home/tromey/Emacs/emacs/lisp/textmodes/css-mode.el...done Quit [4 times] funcall-interactively: No recursive edit is in progress Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.0.50/lisp/play/bubbles Features: (shadow mail-hist emacsbug whitespace css-mode texinfo git-commit-mode log-edit pcvs-util smerge-mode gnus-fun eieio-opt speedbar sb-image ezimage dframe dabbrev git-rebase-mode flow-fill misearch multi-isearch add-log bug-reference js json cc-mode cc-fonts cc-guess cc-menus cc-cmds gnus-html url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars shr-color shr dom browse-url mm-archive bbdb-gui bbdb-hooks bbdb-rmail rmailsum rmail sort smiley gnus-cite gnus-bcklg gnus-async qp gnus-ml disp-table copyright vc-mtn vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs term/xterm xterm gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com warnings gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader mail-utils gnutls network-stream nsm starttls tls erc-spelling erc-truncate flyspell ispell diminish appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu projectile ibuf-macs ibuf-ext ibuffer minimap autorevert filenotify desktop frameset cus-start cus-load erc-notify erc-desktop-notifications notifications dbus xml erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio byte-opt bytecomp byte-compile cl-extra cconv gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp status dired-aux dired-x dired advice vc-dir ewoc vc vc-dispatcher flycheck derived easy-mmode cl-seq edmacro kmacro find-func help-mode rx subr-x dash jka-compr sh-script smie executable compile let-alist cc-styles cc-align cc-engine cc-vars cc-defs bbdb cl timezone ange-ftp comint ansi-color ring server savehist finder-inf bbdb-autoloads dwarf-mode-autoloads eieio-core cl-macs gv cl-loaddefs pcase cl-lib lisppaste-autoloads pydoc-info-autoloads info-look weblogger-autoloads info package easymenu epg-config time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1584563 702016) (symbols 48 102069 0) (miscs 40 23022 3346) (strings 32 661191 206096) (string-bytes 1 24535493) (vectors 16 104304) (vector-slots 8 2294514 218530) (floats 8 874 1102) (intervals 56 38889 1534) (buffers 976 98) (heap 1024 301266 64795)) ------------=_1444238943-13301-1--