From unknown Fri Jun 20 07:27:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21625: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error. Resent-From: Aaron Ecay Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Oct 2015 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 21625@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144407497330173 (code B ref -1); Mon, 05 Oct 2015 19:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Oct 2015 19:56:13 +0000 Received: from localhost ([127.0.0.1]:55459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjBro-0007qa-OG for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37573) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjBrn-0007qT-D3 for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjBrm-0004zY-1L for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBrl-0004zT-U7 for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBrl-0002uK-2c for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 15:56:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjBrh-0004xG-TK for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 15:56:09 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:33999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBrh-0004wY-O1 for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 15:56:05 -0400 Received: by wicfx3 with SMTP id fx3so136244810wic.1 for ; Mon, 05 Oct 2015 12:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=00VBIOLDCJCoY5xvn3izROa1nl7POVjws5Xb6AGLsBo=; b=X80DwLwN1WGNup8+apA8vCZn51myFWuFqpffrUZ47YkpG6OyJBseSvADYluNbUtDu6 652BKL5fk+nEudpqYLHNuy1ckdpx0pCaQd1G7oDeYGIBEkiLIg0w22J4h043CExQ7qlF 08c/RglRg4o7AQ0fB9gZIColfg4KTObct4ObjKdk/4NDRKnYJdW0kblTf1HFiUv1ihl0 92KUUWpEal+fu9W+9+lonfdtOQl5vdqmUDawca4aSiIN0eQcDa0rC2aed9LxINq25rqF LooqKt2jDJJ+lf8RjJ9whJgqxIGliCXkMuxuwlF4MstRp/LpQeC4submQ8g8AieviQDO cDfA== X-Received: by 10.181.27.138 with SMTP id jg10mr14439615wid.29.1444074964985; Mon, 05 Oct 2015 12:56:04 -0700 (PDT) Received: from haize.york.ac.uk (natvip7.york.ac.uk. [144.32.240.7]) by smtp.gmail.com with ESMTPSA id it4sm28618423wjb.0.2015.10.05.12.56.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Oct 2015 12:56:04 -0700 (PDT) From: Aaron Ecay Date: Mon, 5 Oct 2015 20:55:58 +0100 Message-Id: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> X-Mailer: git-send-email 2.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * lisp/emacs-lisp/package.el (package-install): Fix error when ‘pkg’ is not a ‘package-desc’. Also clarify documentation. Through trial and error, I discovered that for non-interactive use the ‘pkg’ argument of the package-install function should be a symbol, not a string. This can also be discerned by inspecting the (interactive) spec, specifically the call to ‘intern’. However, even when proceeding with a symbol an error is raised if the package is already installed. This patch reuses the name computed earlier in the function to avoid this. --- lisp/emacs-lisp/package.el | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index eb66e8f..89f2a1a 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1887,7 +1887,7 @@ add a call to it along with some explanatory comments." ;;;###autoload (defun package-install (pkg &optional dont-select) "Install the package PKG. -PKG can be a package-desc or the package name of one the available packages +PKG can be a package-desc or a symbol naming one of the available packages in an archive in `package-archives'. Interactively, prompt for its name. If called interactively or if DONT-SELECT nil, add PKG to @@ -1918,15 +1918,15 @@ to install it but still mark it as selected." pkg))) (unless (or dont-select (package--user-selected-p name)) (package--save-selected-packages - (cons name package-selected-packages)))) - (if-let ((transaction - (if (package-desc-p pkg) - (unless (package-installed-p pkg) - (package-compute-transaction (list pkg) - (package-desc-reqs pkg))) - (package-compute-transaction () (list (list pkg)))))) - (package-download-transaction transaction) - (message "`%s' is already installed" (package-desc-full-name pkg)))) + (cons name package-selected-packages))) + (if-let ((transaction + (if (package-desc-p pkg) + (unless (package-installed-p pkg) + (package-compute-transaction (list pkg) + (package-desc-reqs pkg))) + (package-compute-transaction () (list (list pkg)))))) + (package-download-transaction transaction) + (message "`%s' is already installed" name)))) (defun package-strip-rcs-id (str) "Strip RCS version ID from the version string STR. -- 2.6.0 From unknown Fri Jun 20 07:27:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21625: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error. Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 10:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Aaron Ecay Cc: 21625@debbugs.gnu.org Reply-To: bruce.connor.am@gmail.com Received: via spool by 21625-submit@debbugs.gnu.org id=B21625.144412798629386 (code B ref 21625); Tue, 06 Oct 2015 10:40:01 +0000 Received: (at 21625) by debbugs.gnu.org; 6 Oct 2015 10:39:46 +0000 Received: from localhost ([127.0.0.1]:56007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPer-0007dt-6a for submit@debbugs.gnu.org; Tue, 06 Oct 2015 06:39:45 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:33650) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPeo-0007dl-RC for 21625@debbugs.gnu.org; Tue, 06 Oct 2015 06:39:43 -0400 Received: by lafb9 with SMTP id b9so52977956laf.0 for <21625@debbugs.gnu.org>; Tue, 06 Oct 2015 03:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=/mD4/6ucY8FX1ECcyFIdeD8KFPyfhxikmcHt55wtoqU=; b=AquJgGMZlScLIxioY99497MGTbitry+8Om0FuORlX7BRvDkJY5aAwl4LutygQfMqfs fvg/muRdlHp8PFF2aHIVMZGGLXMvTA9k/5l5blBIrZX/T0npEuuuQNxlo2L+5aRT0y7J utS1Cr3GCr3oE+5TJ2kK24KU/pztSFlAOs4t6w9FvWl5xa98fxfmvveXuHvR3oYRKFic f7RNflRDeMHYidx3+FX2dj4RdAB9yMmuGv931QVm5frmtoS1xz+sot6tZufd5fQX9CC5 nY1v7VUZMAB6RXx9S0W6mcx4z0Lsi9owhv9emqu3gQQxq5bj7m+SbxNnFKnenv+Jxtg9 5krA== MIME-Version: 1.0 X-Received: by 10.112.146.104 with SMTP id tb8mr14494877lbb.35.1444127981912; Tue, 06 Oct 2015 03:39:41 -0700 (PDT) Received: by 10.25.27.78 with HTTP; Tue, 6 Oct 2015 03:39:41 -0700 (PDT) In-Reply-To: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> References: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> Date: Tue, 6 Oct 2015 11:39:41 +0100 X-Google-Sender-Auth: MWbF66j1TKc3Epb1YWWxvOH2NGk Message-ID: From: Artur Malabarba Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Looks good to me. Thanks for the patch Aaron. Have you done the copyright paperwork? 2015-10-05 20:55 GMT+01:00 Aaron Ecay : > * lisp/emacs-lisp/package.el (package-install): Fix error when =E2=80=98p= kg=E2=80=99 is > not a =E2=80=98package-desc=E2=80=99. Also clarify documentation. > > Through trial and error, I discovered that for non-interactive use the > =E2=80=98pkg=E2=80=99 argument of the package-install function should be = a symbol, not a > string. This can also be discerned by inspecting the (interactive) > spec, specifically the call to =E2=80=98intern=E2=80=99. However, even w= hen proceeding > with a symbol an error is raised if the package is already installed. > This patch reuses the name computed earlier in the function to avoid > this. > --- > lisp/emacs-lisp/package.el | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index eb66e8f..89f2a1a 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1887,7 +1887,7 @@ add a call to it along with some explanatory commen= ts." > ;;;###autoload > (defun package-install (pkg &optional dont-select) > "Install the package PKG. > -PKG can be a package-desc or the package name of one the available packa= ges > +PKG can be a package-desc or a symbol naming one of the available packag= es > in an archive in `package-archives'. Interactively, prompt for its name= . > > If called interactively or if DONT-SELECT nil, add PKG to > @@ -1918,15 +1918,15 @@ to install it but still mark it as selected." > pkg))) > (unless (or dont-select (package--user-selected-p name)) > (package--save-selected-packages > - (cons name package-selected-packages)))) > - (if-let ((transaction > - (if (package-desc-p pkg) > - (unless (package-installed-p pkg) > - (package-compute-transaction (list pkg) > - (package-desc-reqs pkg))) > - (package-compute-transaction () (list (list pkg)))))) > - (package-download-transaction transaction) > - (message "`%s' is already installed" (package-desc-full-name pkg)))) > + (cons name package-selected-packages))) > + (if-let ((transaction > + (if (package-desc-p pkg) > + (unless (package-installed-p pkg) > + (package-compute-transaction (list pkg) > + (package-desc-reqs pkg)= )) > + (package-compute-transaction () (list (list pkg)))))) > + (package-download-transaction transaction) > + (message "`%s' is already installed" name)))) > > (defun package-strip-rcs-id (str) > "Strip RCS version ID from the version string STR. > -- > 2.6.0 > > > > From unknown Fri Jun 20 07:27:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21625: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error. Resent-From: Aaron Ecay Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 12:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: bruce.connor.am@gmail.com Cc: 21625@debbugs.gnu.org Received: via spool by 21625-submit@debbugs.gnu.org id=B21625.144413290810176 (code B ref 21625); Tue, 06 Oct 2015 12:02:01 +0000 Received: (at 21625) by debbugs.gnu.org; 6 Oct 2015 12:01:48 +0000 Received: from localhost ([127.0.0.1]:56064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjQwF-0002e3-Kq for submit@debbugs.gnu.org; Tue, 06 Oct 2015 08:01:47 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:34377) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjQwE-0002dv-JX for 21625@debbugs.gnu.org; Tue, 06 Oct 2015 08:01:46 -0400 Received: by wicfx3 with SMTP id fx3so162625579wic.1 for <21625@debbugs.gnu.org>; Tue, 06 Oct 2015 05:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=XGkyJRdLTkl5ZtKdz4sf1WFvjnZkoFfpHc7GXO1VNpU=; b=j8/MMZuD69Bltdy82xJnofDPXv/xNS52aqVi76jrPBGW8G6YGKgox/8PYl8bC9qrkt iDqgwpAqMFTUh47XHlehz3bDYj7MhzRgPcqjzXAAYSnXEbedDcK0FItF7ini+iRqc6+T z7rycSF6YHwt3bZ2yJuJ3V+kAwk9xW0NyoHsM76koAIJIebvYzsySKQ9yq0ZZD+tgSfe tLePPaAXHhi6QvV/osQI1vYrHuuzet7DE/KVYazHdgWGwUAKujvfkVAOUQworNfCLval DuGhDub0A6l6b3JFlorRr7B53JxAkUOJn1/1EWoKIEdheAjUphtgk9X0fuN4pa2rTs/t r53w== X-Received: by 10.180.105.196 with SMTP id go4mr15797626wib.36.1444132905829; Tue, 06 Oct 2015 05:01:45 -0700 (PDT) Received: from localhost (natvip7.york.ac.uk. [144.32.240.7]) by smtp.gmail.com with ESMTPSA id q1sm32221068wje.39.2015.10.06.05.01.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2015 05:01:45 -0700 (PDT) From: Aaron Ecay In-Reply-To: References: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> User-Agent: Notmuch/0.20.2+65~gbd5504e (http://notmuchmail.org) Emacs/25.0.50.2 (x86_64-unknown-linux-gnu) X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 06 Oct 2015 13:01:44 +0100 Message-ID: <87k2r0tdcn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Artur, Thanks for taking a look at the patch. My copyright papers are done and on file. -- Aaron Ecay From unknown Fri Jun 20 07:27:57 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Aaron Ecay Subject: bug#21625: closed (Re: bug#21625: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error.) Message-ID: References: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> X-Gnu-PR-Message: they-closed 21625 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 21625@debbugs.gnu.org Date: Tue, 06 Oct 2015 18:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1444157042-6463-1" This is a multi-part message in MIME format... ------------=_1444157042-6463-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #21625: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 21625@debbugs.gnu.org. --=20 21625: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21625 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1444157042-6463-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 21625-done) by debbugs.gnu.org; 6 Oct 2015 18:43:04 +0000 Received: from localhost ([127.0.0.1]:57357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjXCa-0001eh-41 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 14:43:04 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:34085) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjXCY-0001eP-HW for 21625-done@debbugs.gnu.org; Tue, 06 Oct 2015 14:43:03 -0400 Received: by labzv5 with SMTP id zv5so149945019lab.1 for <21625-done@debbugs.gnu.org>; Tue, 06 Oct 2015 11:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=JFspa/rpuhUSuKgN0/BeZRTcumgUJ+6T3/MVaVrpVyw=; b=aGcS14H1xKSBwX286jCy1c9SSoELg05GQesRhoWpN8TEsWgjhStBhFZnAQ+OAl1hPC 12lCGzpJ38/mrFm4Z5OY4DrYyNKitO0oXh/KH8czYnpkRDB7rXyFydFVV6jCKugheyN9 7qT1DmaNg7cncP9DyhdtDNKi2s/FfsKjta6uBRybTKVtHDGdIYkyjZjQUDJGtQrHywnM Npv+75Znxy7yAviRpTiqMYz6mcPsifqtYW22/2NZmc/Xy9x+g0SSASD4xg658nNClPGb WE7xQ8bnx84bp0K7liDS40PFSIobXX9w6+MXwaULheVHo8uPpqCqWEcEeyGy6HIfm4dN 965g== MIME-Version: 1.0 X-Received: by 10.25.207.82 with SMTP id f79mr10369207lfg.73.1444156981595; Tue, 06 Oct 2015 11:43:01 -0700 (PDT) Received: by 10.25.27.78 with HTTP; Tue, 6 Oct 2015 11:43:01 -0700 (PDT) In-Reply-To: <87k2r0tdcn.fsf@gmail.com> References: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> <87k2r0tdcn.fsf@gmail.com> Date: Tue, 6 Oct 2015 19:43:01 +0100 X-Google-Sender-Auth: Mcfior8hUnWTfGBb2xouVdPaQKw Message-ID: Subject: Re: bug#21625: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error. From: Artur Malabarba To: Aaron Ecay Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21625-done Cc: 21625-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Patch applied. Thanks again Aaron 2015-10-06 13:01 GMT+01:00 Aaron Ecay : > Hi Artur, > > Thanks for taking a look at the patch. My copyright papers are done and > on file. > > -- > Aaron Ecay ------------=_1444157042-6463-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Oct 2015 19:56:13 +0000 Received: from localhost ([127.0.0.1]:55459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjBro-0007qa-OG for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37573) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjBrn-0007qT-D3 for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjBrm-0004zY-1L for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBrl-0004zT-U7 for submit@debbugs.gnu.org; Mon, 05 Oct 2015 15:56:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBrl-0002uK-2c for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 15:56:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjBrh-0004xG-TK for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 15:56:09 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:33999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBrh-0004wY-O1 for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 15:56:05 -0400 Received: by wicfx3 with SMTP id fx3so136244810wic.1 for ; Mon, 05 Oct 2015 12:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=00VBIOLDCJCoY5xvn3izROa1nl7POVjws5Xb6AGLsBo=; b=X80DwLwN1WGNup8+apA8vCZn51myFWuFqpffrUZ47YkpG6OyJBseSvADYluNbUtDu6 652BKL5fk+nEudpqYLHNuy1ckdpx0pCaQd1G7oDeYGIBEkiLIg0w22J4h043CExQ7qlF 08c/RglRg4o7AQ0fB9gZIColfg4KTObct4ObjKdk/4NDRKnYJdW0kblTf1HFiUv1ihl0 92KUUWpEal+fu9W+9+lonfdtOQl5vdqmUDawca4aSiIN0eQcDa0rC2aed9LxINq25rqF LooqKt2jDJJ+lf8RjJ9whJgqxIGliCXkMuxuwlF4MstRp/LpQeC4submQ8g8AieviQDO cDfA== X-Received: by 10.181.27.138 with SMTP id jg10mr14439615wid.29.1444074964985; Mon, 05 Oct 2015 12:56:04 -0700 (PDT) Received: from haize.york.ac.uk (natvip7.york.ac.uk. [144.32.240.7]) by smtp.gmail.com with ESMTPSA id it4sm28618423wjb.0.2015.10.05.12.56.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Oct 2015 12:56:04 -0700 (PDT) From: Aaron Ecay To: bug-gnu-emacs@gnu.org Subject: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error. Date: Mon, 5 Oct 2015 20:55:58 +0100 Message-Id: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> X-Mailer: git-send-email 2.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * lisp/emacs-lisp/package.el (package-install): Fix error when ‘pkg’ is not a ‘package-desc’. Also clarify documentation. Through trial and error, I discovered that for non-interactive use the ‘pkg’ argument of the package-install function should be a symbol, not a string. This can also be discerned by inspecting the (interactive) spec, specifically the call to ‘intern’. However, even when proceeding with a symbol an error is raised if the package is already installed. This patch reuses the name computed earlier in the function to avoid this. --- lisp/emacs-lisp/package.el | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index eb66e8f..89f2a1a 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1887,7 +1887,7 @@ add a call to it along with some explanatory comments." ;;;###autoload (defun package-install (pkg &optional dont-select) "Install the package PKG. -PKG can be a package-desc or the package name of one the available packages +PKG can be a package-desc or a symbol naming one of the available packages in an archive in `package-archives'. Interactively, prompt for its name. If called interactively or if DONT-SELECT nil, add PKG to @@ -1918,15 +1918,15 @@ to install it but still mark it as selected." pkg))) (unless (or dont-select (package--user-selected-p name)) (package--save-selected-packages - (cons name package-selected-packages)))) - (if-let ((transaction - (if (package-desc-p pkg) - (unless (package-installed-p pkg) - (package-compute-transaction (list pkg) - (package-desc-reqs pkg))) - (package-compute-transaction () (list (list pkg)))))) - (package-download-transaction transaction) - (message "`%s' is already installed" (package-desc-full-name pkg)))) + (cons name package-selected-packages))) + (if-let ((transaction + (if (package-desc-p pkg) + (unless (package-installed-p pkg) + (package-compute-transaction (list pkg) + (package-desc-reqs pkg))) + (package-compute-transaction () (list (list pkg)))))) + (package-download-transaction transaction) + (message "`%s' is already installed" name)))) (defun package-strip-rcs-id (str) "Strip RCS version ID from the version string STR. -- 2.6.0 ------------=_1444157042-6463-1-- From unknown Fri Jun 20 07:27:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21625: [PATCH] lisp/emacs-lisp/package.el (package-install): Fix error. Resent-From: immerrr again Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Oct 2015 10:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 21625@debbugs.gnu.org Received: via spool by 21625-submit@debbugs.gnu.org id=B21625.144464724116882 (code B ref 21625); Mon, 12 Oct 2015 10:54:01 +0000 Received: (at 21625) by debbugs.gnu.org; 12 Oct 2015 10:54:01 +0000 Received: from localhost ([127.0.0.1]:36880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zlajw-0004OD-Ot for submit@debbugs.gnu.org; Mon, 12 Oct 2015 06:54:00 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:33816) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zlaju-0004O4-Cr for 21625@debbugs.gnu.org; Mon, 12 Oct 2015 06:53:59 -0400 Received: by ykdg206 with SMTP id g206so131084601ykd.1 for <21625@debbugs.gnu.org>; Mon, 12 Oct 2015 03:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=P8h+CDosk06plGTVPVQQz7gkAMMAHf0RChz3RPBKT6U=; b=eiqOKZ7EwxWbhoKjcNhJ2X8RCDPoQjcY+B69gQ8uMpW+Ksi0oW36gLWASHbPaehQJM 5ea8KauqY0OfviECqOKWWRxxdWXwXTle515w/xfJBLg+lJUiuRKVY7Oppzh38NnHuEga ZeymahslynzxISlh8xP7zfVp3/cwE1qanrYwHOprxOrYUpMaSAjTdWDkAxZY6BHzIStC kJef+C9IRaYEV3Rv8/jUOPXBnFUAPsbJlS4b6u69ZFnnnZmplQbsKHM0v/p3Eh/SWOk8 d606B2MqVcflQHD8QtyBNTElb3fetJjNT9iChXN4QWgqAwTUc/yFKkz3eYGXHgkPBPQz xdkQ== MIME-Version: 1.0 X-Received: by 10.129.124.8 with SMTP id x8mr19666991ywc.44.1444647237746; Mon, 12 Oct 2015 03:53:57 -0700 (PDT) Received: by 10.13.212.197 with HTTP; Mon, 12 Oct 2015 03:53:57 -0700 (PDT) In-Reply-To: References: <1444074958-32600-1-git-send-email-aaronecay@gmail.com> <87k2r0tdcn.fsf@gmail.com> Date: Mon, 12 Oct 2015 13:53:57 +0300 Message-ID: From: immerrr again Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This patch should fix 20863, too. On Tue, Oct 6, 2015 at 9:43 PM, Artur Malabarba wrote: > Patch applied. Thanks again Aaron >