GNU bug report logs - #21619
25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#21619: 25.0.50;	Wrong curly quotes in the
 docstring for font-lock-add-keywords
Date: Mon, 5 Oct 2015 16:28:41 +0000 (UTC)

Artur Malabarba <bruce.connor.am <at> gmail.com> writes:

> 
> The docstring for this function (when displayed in a help buffer) has
> the following code-snippet, which clearly has the wrong type of
> quotes.
> 
> (font-lock-add-keywords ’c-mode
>   ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
>     ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
> 
> Instead of fixing this by manually escaping them, how about we change
> the algorithm to only convert `...' quotes if the ... is a single
> symbol?
> 
> 


Looks like it got fixed in this commit:

http://git.savannah.gnu.org/cgit/emacs.git/commit/?
id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce

 
- (sql-add-product-keywords 'ms
-  '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
+ (sql-add-product-keywords \\='ms
+  \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))

But while grepping for "’\([a-z(]+" in the emacs repo base dir, I found 
just this one case that yet needs to be fixed:

Line 1013 of htmlfontify.info

     ’((class color grayscale) (type tty)) would match any of:
            '((class color))
            '((class grayscale))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.