GNU bug report logs - #21619
25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: bruce.connor.am <at> gmail.com
Subject: bug#21619: closed (Re: bug#21619: 25.0.50; Wrong curly quotes in
 the docstring for font-lock-add-keywords)
Date: Tue, 06 Oct 2015 10:42:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 21619 <at> debbugs.gnu.org.

-- 
21619: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21619
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Artur Malabarba <bruce.connor.am <at> gmail.com>
To: Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: 21619-done <at> debbugs.gnu.org
Subject: Re: bug#21619: 25.0.50;
 Wrong curly quotes in the docstring for font-lock-add-keywords
Date: Tue, 6 Oct 2015 11:41:26 +0100

Indeed. I built again today and don't see it anymore. Thanks for the pointer.

2015-10-06 11:20 GMT+01:00 Kaushal Modi <kaushal.modi <at> gmail.com>:
> I copied the wrong snippet.. But in general I saw many instances of quote
> fixes in doc strings in that merge commit.
>
> Also I do not see curvy quotes in the Help buffer that opens when I do C-h f
> font-lock-add-keywords. I am on emacs built on that big merge commit
> yesterday.
>
> On Oct 6, 2015 5:15 AM, "Artur Malabarba" <bruce.connor.am <at> gmail.com> wrote:
>>
>> 2015-10-05 17:28 GMT+01:00 Kaushal Modi <kaushal.modi <at> gmail.com>:
>> > Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>> >
>> >>
>> >> The docstring for this function (when displayed in a help buffer) has
>> >> the following code-snippet, which clearly has the wrong type of
>> >> quotes.
>> >>
>> >> (font-lock-add-keywords ’c-mode
>> >>   ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
>> >>     ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
>> >>
>> >> Instead of fixing this by manually escaping them, how about we change
>> >> the algorithm to only convert `...' quotes if the ... is a single
>> >> symbol?
>> >>
>> >>
>> >
>> >
>> > Looks like it got fixed in this commit:
>> >
>> > http://git.savannah.gnu.org/cgit/emacs.git/commit/?
>> > id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
>> >
>> >
>> > - (sql-add-product-keywords 'ms
>> > -  '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
>> > + (sql-add-product-keywords \\='ms
>> > +  \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
>>
>> I'm confused. That link appears to be a merge commit, and the snippet
>> you quote doesn't apply to the snippet I had quotedl.

[Message part 3 (message/rfc822, inline)]

From: Artur Malabarba <bruce.connor.am <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 Wrong curly quotes in the docstring for font-lock-add-keywords
Date: Mon, 5 Oct 2015 15:24:25 +0100

The docstring for this function (when displayed in a help buffer) has
the following code-snippet, which clearly has the wrong type of
quotes.

(font-lock-add-keywords ’c-mode
  ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
    ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))

Instead of fixing this by manually escaping them, how about we change
the algorithm to only convert `...' quotes if the ... is a single
symbol?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.