From unknown Tue Aug 12 04:07:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Oct 2015 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21619@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: bruce.connor.am@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.1444055118889 (code B ref -1); Mon, 05 Oct 2015 14:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Oct 2015 14:25:18 +0000 Received: from localhost ([127.0.0.1]:55325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zj6ha-0000EG-Dx for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55297) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zj6hY-0000E9-UO for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj6hT-0003Oj-1T for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj6hS-0003ON-V2 for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj6gq-0004HG-4j for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 10:24:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj6gk-000339-No for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 10:24:32 -0400 Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:35404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj6gk-000330-H1 for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 10:24:26 -0400 Received: by ladcb10 with SMTP id cb10so3231175lad.2 for ; Mon, 05 Oct 2015 07:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=H3TOlGRjFHocHkyZI1Z/XVem5mrWJn2MqnjaZXdoMbw=; b=AbFNXW8JX5yYCi1weyexVFg9PXrIZ9D0ufrjjWQeN0ekTR9ICJ0Z2W29gwNjjKP/Ot dfmcUbTfmhk22bUWuPOFqSaMny4Wv0AMvcL4fLROfxdbCa9o7hEvGTe1QItxHjttllIY XPO7e/JafIYr8VVsv+i56XtnaBls1xPUv21Lxp4ED7Oshug0GNERc28PL3e7+NsCie9n 6RhEwo/eEsmiweYirczwVzL5t9Yom21baXf3zS/87WRcecT2izr09893JK310sh+C5lU XK5573xssQAGxwVD5SIRUBOcSZyeilHHfIvQyrjTjUwS/Pd37BGqa/NWSM96SRe9gPTx ZOsw== MIME-Version: 1.0 X-Received: by 10.25.165.4 with SMTP id o4mr7693121lfe.4.1444055065618; Mon, 05 Oct 2015 07:24:25 -0700 (PDT) Received: by 10.25.27.78 with HTTP; Mon, 5 Oct 2015 07:24:25 -0700 (PDT) Date: Mon, 5 Oct 2015 15:24:25 +0100 X-Google-Sender-Auth: c4xgcIJvHARuvGkLHg7kpQcl9V0 Message-ID: From: Artur Malabarba Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The docstring for this function (when displayed in a help buffer) has the following code-snippet, which clearly has the wrong type of quotes. (font-lock-add-keywords =E2=80=99c-mode =E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99font-lock-warning-face prepend) ("\\<\\(and\\|or\\|not\\)\\>" . =E2=80=99font-lock-keyword-face))) Instead of fixing this by manually escaping them, how about we change the algorithm to only convert `...' quotes if the ... is a single symbol? From unknown Tue Aug 12 04:07:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords In-Reply-To: Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Oct 2015 16:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21619@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144406291612488 (code B ref -1); Mon, 05 Oct 2015 16:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Oct 2015 16:35:16 +0000 Received: from localhost ([127.0.0.1]:55385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zj8jL-0003FL-2k for submit@debbugs.gnu.org; Mon, 05 Oct 2015 12:35:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35551) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zj8jJ-0003FD-D1 for submit@debbugs.gnu.org; Mon, 05 Oct 2015 12:35:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj8jH-0003Hj-Vo for submit@debbugs.gnu.org; Mon, 05 Oct 2015 12:35:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BASE64_LENGTH_79_INF, BAYES_00, FREEMAIL_FROM,FSL_HELO_BARE_IP_2,RCVD_NUMERIC_HELO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj8jH-0003Hb-Sy for submit@debbugs.gnu.org; Mon, 05 Oct 2015 12:35:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj8jG-0004zJ-O2 for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 12:35:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj8jC-0003Bc-Oi for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 12:35:10 -0400 Received: from plane.gmane.org ([80.91.229.3]:47134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj8jC-00036G-IY for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 12:35:06 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Zj8j9-0003gq-S3 for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 18:35:04 +0200 Received: from 137.71.23.54 ([137.71.23.54]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Oct 2015 18:35:03 +0200 Received: from kaushal.modi by 137.71.23.54 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Oct 2015 18:35:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Kaushal Modi Date: Mon, 5 Oct 2015 16:28:41 +0000 (UTC) Lines: 1 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 137.71.23.54 (Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) QXJ0dXIgTWFsYWJhcmJhIDxicnVjZS5jb25ub3IuYW0gPGF0PiBnbWFpbC5jb20+IHdyaXRlczoKCj4gCj4gVGhlIGRvY3N0cmluZyBmb3IgdGhpcyBmdW5jdGlvbiAod2hlbiBkaXNwbGF5ZWQgaW4gYSBoZWxwIGJ1ZmZlcikgaGFzCj4gdGhlIGZvbGxvd2luZyBjb2RlLXNuaXBwZXQsIHdoaWNoIGNsZWFybHkgaGFzIHRoZSB3cm9uZyB0eXBlIG9mCj4gcXVvdGVzLgo+IAo+IChmb250LWxvY2stYWRkLWtleXdvcmRzIOKAmWMtbW9kZQo+ICAg4oCZKCgiXFw8XFwoRklYTUVcXCk6IiAxIOKAmWZvbnQtbG9jay13YXJuaW5nLWZhY2UgcHJlcGVuZCkKPiAgICAgKCJcXDxcXChhbmRcXHxvclxcfG5vdFxcKVxcPiIgLiDigJlmb250LWxvY2sta2V5d29yZC1mYWNlKSkpCj4gCj4gSW5zdGVhZCBvZiBmaXhpbmcgdGhpcyBieSBtYW51YWxseSBlc2NhcGluZyB0aGVtLCBob3cgYWJvdXQgd2UgY2hhbmdlCj4gdGhlIGFsZ29yaXRobSB0byBvbmx5IGNvbnZlcnQgYC4uLicgcXVvdGVzIGlmIHRoZSAuLi4gaXMgYSBzaW5nbGUKPiBzeW1ib2w/Cj4gCj4gCgoKTG9va3MgbGlrZSBpdCBnb3QgZml4ZWQgaW4gdGhpcyBjb21taXQ6CgpodHRwOi8vZ2l0LnNhdmFubmFoLmdudS5vcmcvY2dpdC9lbWFjcy5naXQvY29tbWl0Lz8KaWQ9NDdlOTU1NmM3MGE3MDA5ZDdjNzUwZmQ3YmYxMGEwZTZjZjQxY2RjZQoKIAotIChzcWwtYWRkLXByb2R1Y3Qta2V5d29yZHMgJ21zCi0gICcoKFwiXFxcXGJcXFxcdytfdFxcXFxiXCIgLiBmb250LWxvY2stdHlwZS1mYWNlKSkpCisgKHNxbC1hZGQtcHJvZHVjdC1rZXl3b3JkcyBcXD0nbXMKKyAgXFw9JygoXCJcXFxcYlxcXFx3K190XFxcXGJcIiAuIGZvbnQtbG9jay10eXBlLWZhY2UpKSkKCkJ1dCB3aGlsZSBncmVwcGluZyBmb3IgIuKAmVwoW2EteihdKyIgaW4gdGhlIGVtYWNzIHJlcG8gYmFzZSBkaXIsIEkgZm91bmQgCmp1c3QgdGhpcyBvbmUgY2FzZSB0aGF0IHlldCBuZWVkcyB0byBiZSBmaXhlZDoKCkxpbmUgMTAxMyBvZiBodG1sZm9udGlmeS5pbmZvCgogICAgIOKAmSgoY2xhc3MgY29sb3IgZ3JheXNjYWxlKSAodHlwZSB0dHkpKSB3b3VsZCBtYXRjaCBhbnkgb2Y6CiAgICAgICAgICAgICcoKGNsYXNzIGNvbG9yKSkKICAgICAgICAgICAgJygoY2xhc3MgZ3JheXNjYWxlKSkKCgoK From unknown Tue Aug 12 04:07:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 09:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kaushal Modi Cc: 21619@debbugs.gnu.org Reply-To: bruce.connor.am@gmail.com Received: via spool by 21619-submit@debbugs.gnu.org id=B21619.144412294121833 (code B ref 21619); Tue, 06 Oct 2015 09:16:01 +0000 Received: (at 21619) by debbugs.gnu.org; 6 Oct 2015 09:15:41 +0000 Received: from localhost ([127.0.0.1]:55940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjOLV-0005g4-5D for submit@debbugs.gnu.org; Tue, 06 Oct 2015 05:15:41 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:35701) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjOLR-0005fu-OP for 21619@debbugs.gnu.org; Tue, 06 Oct 2015 05:15:38 -0400 Received: by lbwr8 with SMTP id r8so72261684lbw.2 for <21619@debbugs.gnu.org>; Tue, 06 Oct 2015 02:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=yNKXtA6P4cJw6ZKcfAKCOQwg47tWMB7fdotUFS5UKX8=; b=xtOEpiLcIRJdg4b9tD5jZi5ICzqZ1J2NFa43dJd3ChzMLbR39BzboP71Dv0Fae73Ey O93c62UBuxa5C1zZrlz5cTuPj9EHS56ZnnnR2fHJsK1p4mWelGj/rsQf4UQWEiHm006V HyoUFaOiiS8ws7c1jzMBhwd+HhhMRei7ecob146HhBb6jouiwg3/0rMq9JDG7N77IVCs rBdv4TgqN5fnX8MELcJS1REQ4vbs4SqKAB2BSG63f34iHwnSmtKWPxDEl1mjVN9TR+ZF CXhRv4obC+tu251HkYNhG6iXAbhnEb7LSk4C00ZbD9UHxHsoAgMOsg/SrkSZFdwDa2ag 3UyQ== MIME-Version: 1.0 X-Received: by 10.112.146.104 with SMTP id tb8mr14285571lbb.35.1444122936751; Tue, 06 Oct 2015 02:15:36 -0700 (PDT) Received: by 10.25.27.78 with HTTP; Tue, 6 Oct 2015 02:15:36 -0700 (PDT) In-Reply-To: References: Date: Tue, 6 Oct 2015 10:15:36 +0100 X-Google-Sender-Auth: 0wYtxfwnjQTTOtG4fZ0jdq0R-i0 Message-ID: From: Artur Malabarba Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 2015-10-05 17:28 GMT+01:00 Kaushal Modi : > Artur Malabarba gmail.com> writes: > >> >> The docstring for this function (when displayed in a help buffer) has >> the following code-snippet, which clearly has the wrong type of >> quotes. >> >> (font-lock-add-keywords =E2=80=99c-mode >> =E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99font-lock-warning-face prepend= ) >> ("\\<\\(and\\|or\\|not\\)\\>" . =E2=80=99font-lock-keyword-face))) >> >> Instead of fixing this by manually escaping them, how about we change >> the algorithm to only convert `...' quotes if the ... is a single >> symbol? >> >> > > > Looks like it got fixed in this commit: > > http://git.savannah.gnu.org/cgit/emacs.git/commit/? > id=3D47e9556c70a7009d7c750fd7bf10a0e6cf41cdce > > > - (sql-add-product-keywords 'ms > - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) > + (sql-add-product-keywords \\=3D'ms > + \\=3D'((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) I'm confused. That link appears to be a merge commit, and the snippet you quote doesn't apply to the snippet I had quotedl. From unknown Tue Aug 12 04:07:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Bruce Connor Cc: 21619@debbugs.gnu.org Received: via spool by 21619-submit@debbugs.gnu.org id=B21619.144412681327535 (code B ref 21619); Tue, 06 Oct 2015 10:21:01 +0000 Received: (at 21619) by debbugs.gnu.org; 6 Oct 2015 10:20:13 +0000 Received: from localhost ([127.0.0.1]:56002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPLx-0007A2-4p for submit@debbugs.gnu.org; Tue, 06 Oct 2015 06:20:13 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:36285) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPLu-00079u-Ga for 21619@debbugs.gnu.org; Tue, 06 Oct 2015 06:20:11 -0400 Received: by obcgx8 with SMTP id gx8so150114253obc.3 for <21619@debbugs.gnu.org>; Tue, 06 Oct 2015 03:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=UscFMYA3pc+6duYaKf/etZSugfmHclDVOnmiJ36Pnmc=; b=VUFuesqvtqj4Yk4g745Htxtvo/DRX3Ca3wc9ZYeMJXun+tsbU3EaK/aX75AbbLyqVy y9YdSDD9KK1m6+lXHBF2I0agxVaoCx2FI5+QpaifbYAqQieObIUHWUE3c3VoN0aSz0sn 8SZzBhJaPMFrlUVlP/uJfZwEw6fUo7UJT3rJ2+1xpc2OlHvGGBxsVhevETCF2VKdtbpN MmCQjIRz0hNiwF0Ffv0rFKHQf1HOft1gHe1wv1VsYSLHtF42jOFDtdgnjtXTfiy+KIVK iL3AiYM5mNCrTu4jwkZ/uefIJAthqIwkGnR5B9zPZDmkme/eiWKKV/Fg0lFEbM7FM74d AX+A== MIME-Version: 1.0 X-Received: by 10.60.36.202 with SMTP id s10mr20929484oej.0.1444126809777; Tue, 06 Oct 2015 03:20:09 -0700 (PDT) Received: by 10.202.172.205 with HTTP; Tue, 6 Oct 2015 03:20:09 -0700 (PDT) Received: by 10.202.172.205 with HTTP; Tue, 6 Oct 2015 03:20:09 -0700 (PDT) In-Reply-To: References: Date: Tue, 6 Oct 2015 06:20:09 -0400 Message-ID: From: Kaushal Modi Content-Type: multipart/alternative; boundary=089e013a14ea81ede405216cf9c1 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e013a14ea81ede405216cf9c1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I copied the wrong snippet.. But in general I saw many instances of quote fixes in doc strings in that merge commit. Also I do not see curvy quotes in the Help buffer that opens when I do C-h f font-lock-add-keywords. I am on emacs built on that big merge commit yesterday. On Oct 6, 2015 5:15 AM, "Artur Malabarba" wrote= : > 2015-10-05 17:28 GMT+01:00 Kaushal Modi : > > Artur Malabarba gmail.com> writes: > > > >> > >> The docstring for this function (when displayed in a help buffer) has > >> the following code-snippet, which clearly has the wrong type of > >> quotes. > >> > >> (font-lock-add-keywords =E2=80=99c-mode > >> =E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99font-lock-warning-face prepe= nd) > >> ("\\<\\(and\\|or\\|not\\)\\>" . =E2=80=99font-lock-keyword-face))) > >> > >> Instead of fixing this by manually escaping them, how about we change > >> the algorithm to only convert `...' quotes if the ... is a single > >> symbol? > >> > >> > > > > > > Looks like it got fixed in this commit: > > > > http://git.savannah.gnu.org/cgit/emacs.git/commit/? > > id=3D47e9556c70a7009d7c750fd7bf10a0e6cf41cdce > > > > > > - (sql-add-product-keywords 'ms > > - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) > > + (sql-add-product-keywords \\=3D'ms > > + \\=3D'((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) > > I'm confused. That link appears to be a merge commit, and the snippet > you quote doesn't apply to the snippet I had quotedl. > --089e013a14ea81ede405216cf9c1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I copied the wrong snippet.. But in general I saw many insta= nces of quote fixes in doc strings in that merge commit.

Also I do not see curvy quotes in the Help buffer that opens= when I do C-h f font-lock-add-keywords. I am on emacs built on that big me= rge commit yesterday.

On Oct 6, 2015 5:15 AM, "Artur Malabarba&qu= ot; <bruce.connor.am@gmail.= com> wrote:
2= 015-10-05 17:28 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
> Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>
>>
>> The docstring for this function (when displayed in a help buffer) = has
>> the following code-snippet, which clearly has the wrong type of >> quotes.
>>
>> (font-lock-add-keywords =E2=80=99c-mode
>>=C2=A0 =C2=A0=E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99f= ont-lock-warning-face prepend)
>>=C2=A0 =C2=A0 =C2=A0("\\<\\(and\\|or\\|not\\)\\>" .= =E2=80=99font-lock-keyword-face)))
>>
>> Instead of fixing this by manually escaping them, how about we cha= nge
>> the algorithm to only convert `...' quotes if the ... is a sin= gle
>> symbol?
>>
>>
>
>
> Looks like it got fixed in this commit:
>
> http://git.savannah.gnu.org/cgit/emacs.git/co= mmit/?
> id=3D47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
>
>
> - (sql-add-product-keywords 'ms
> -=C2=A0 '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)= ))
> + (sql-add-product-keywords \\=3D'ms
> +=C2=A0 \\=3D'((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-= face)))

I'm confused. That link appears to be a merge commit, and the snippet you quote doesn't apply to the snippet I had quotedl.
--089e013a14ea81ede405216cf9c1-- From unknown Tue Aug 12 04:07:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: bruce.connor.am@gmail.com Subject: bug#21619: closed (Re: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords) Message-ID: References: X-Gnu-PR-Message: they-closed 21619 X-Gnu-PR-Package: emacs Reply-To: 21619@debbugs.gnu.org Date: Tue, 06 Oct 2015 10:42:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1444128123-29600-1" This is a multi-part message in MIME format... ------------=_1444128123-29600-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keyw= ords which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 21619@debbugs.gnu.org. --=20 21619: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21619 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1444128123-29600-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 21619-done) by debbugs.gnu.org; 6 Oct 2015 10:41:29 +0000 Received: from localhost ([127.0.0.1]:56011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPgX-0007gh-85 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 06:41:29 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:35174) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPgV-0007ga-EL for 21619-done@debbugs.gnu.org; Tue, 06 Oct 2015 06:41:28 -0400 Received: by lbwr8 with SMTP id r8so73477820lbw.2 for <21619-done@debbugs.gnu.org>; Tue, 06 Oct 2015 03:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=DVQzFpBCK+NRCZNMtH0EDMqh1Vnz7oaa3WcjCfQ0Bss=; b=ew2eE9leemRayIJn95LrVvkdTek39KDKDbUW7a5tkOyttFh+yDr/8VfbLXRa80jTUc HAaJqDzoEmQmuQeoLXBl414JNqzETKztPV+wN4IWv1a/h3+2FRkEsLbzenZ/ZId4Jfpd r2S4BAB5oWradgfDIHkQRVIlyUiU+DruKKPU3bqGWBSlBPdcsLUzgGxXl4GylFFSkoO9 h8kw73coQdqIm77fcJnYzxj0gn7iWIwroybpLjSVYL2jMAlHIGlyaU5QjnM2980Tu07D uNZ20TnUcDqzVAKaJk2B1qAueMW7qwjPXyq71X8yeTIsbSbEq0hvwk2elz/Tuq6RDWAp x7gQ== MIME-Version: 1.0 X-Received: by 10.112.54.169 with SMTP id k9mr13955839lbp.95.1444128086539; Tue, 06 Oct 2015 03:41:26 -0700 (PDT) Received: by 10.25.27.78 with HTTP; Tue, 6 Oct 2015 03:41:26 -0700 (PDT) In-Reply-To: References: Date: Tue, 6 Oct 2015 11:41:26 +0100 X-Google-Sender-Auth: JiWzWZkH1w8MtMQCBw2Ofj9Aq2U Message-ID: Subject: Re: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords From: Artur Malabarba To: Kaushal Modi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21619-done Cc: 21619-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Indeed. I built again today and don't see it anymore. Thanks for the pointe= r. 2015-10-06 11:20 GMT+01:00 Kaushal Modi : > I copied the wrong snippet.. But in general I saw many instances of quote > fixes in doc strings in that merge commit. > > Also I do not see curvy quotes in the Help buffer that opens when I do C-= h f > font-lock-add-keywords. I am on emacs built on that big merge commit > yesterday. > > On Oct 6, 2015 5:15 AM, "Artur Malabarba" wro= te: >> >> 2015-10-05 17:28 GMT+01:00 Kaushal Modi : >> > Artur Malabarba gmail.com> writes: >> > >> >> >> >> The docstring for this function (when displayed in a help buffer) has >> >> the following code-snippet, which clearly has the wrong type of >> >> quotes. >> >> >> >> (font-lock-add-keywords =E2=80=99c-mode >> >> =E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99font-lock-warning-face prep= end) >> >> ("\\<\\(and\\|or\\|not\\)\\>" . =E2=80=99font-lock-keyword-face))= ) >> >> >> >> Instead of fixing this by manually escaping them, how about we change >> >> the algorithm to only convert `...' quotes if the ... is a single >> >> symbol? >> >> >> >> >> > >> > >> > Looks like it got fixed in this commit: >> > >> > http://git.savannah.gnu.org/cgit/emacs.git/commit/? >> > id=3D47e9556c70a7009d7c750fd7bf10a0e6cf41cdce >> > >> > >> > - (sql-add-product-keywords 'ms >> > - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) >> > + (sql-add-product-keywords \\=3D'ms >> > + \\=3D'((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) >> >> I'm confused. That link appears to be a merge commit, and the snippet >> you quote doesn't apply to the snippet I had quotedl. ------------=_1444128123-29600-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Oct 2015 14:25:18 +0000 Received: from localhost ([127.0.0.1]:55325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zj6ha-0000EG-Dx for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55297) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zj6hY-0000E9-UO for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj6hT-0003Oj-1T for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj6hS-0003ON-V2 for submit@debbugs.gnu.org; Mon, 05 Oct 2015 10:25:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj6gq-0004HG-4j for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 10:24:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj6gk-000339-No for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 10:24:32 -0400 Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:35404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj6gk-000330-H1 for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2015 10:24:26 -0400 Received: by ladcb10 with SMTP id cb10so3231175lad.2 for ; Mon, 05 Oct 2015 07:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=H3TOlGRjFHocHkyZI1Z/XVem5mrWJn2MqnjaZXdoMbw=; b=AbFNXW8JX5yYCi1weyexVFg9PXrIZ9D0ufrjjWQeN0ekTR9ICJ0Z2W29gwNjjKP/Ot dfmcUbTfmhk22bUWuPOFqSaMny4Wv0AMvcL4fLROfxdbCa9o7hEvGTe1QItxHjttllIY XPO7e/JafIYr8VVsv+i56XtnaBls1xPUv21Lxp4ED7Oshug0GNERc28PL3e7+NsCie9n 6RhEwo/eEsmiweYirczwVzL5t9Yom21baXf3zS/87WRcecT2izr09893JK310sh+C5lU XK5573xssQAGxwVD5SIRUBOcSZyeilHHfIvQyrjTjUwS/Pd37BGqa/NWSM96SRe9gPTx ZOsw== MIME-Version: 1.0 X-Received: by 10.25.165.4 with SMTP id o4mr7693121lfe.4.1444055065618; Mon, 05 Oct 2015 07:24:25 -0700 (PDT) Received: by 10.25.27.78 with HTTP; Mon, 5 Oct 2015 07:24:25 -0700 (PDT) Date: Mon, 5 Oct 2015 15:24:25 +0100 X-Google-Sender-Auth: c4xgcIJvHARuvGkLHg7kpQcl9V0 Message-ID: Subject: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords From: Artur Malabarba To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The docstring for this function (when displayed in a help buffer) has the following code-snippet, which clearly has the wrong type of quotes. (font-lock-add-keywords =E2=80=99c-mode =E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99font-lock-warning-face prepend) ("\\<\\(and\\|or\\|not\\)\\>" . =E2=80=99font-lock-keyword-face))) Instead of fixing this by manually escaping them, how about we change the algorithm to only convert `...' quotes if the ... is a single symbol? ------------=_1444128123-29600-1--