GNU bug report logs - #2159
23.0.60; [PATCH] Incorrect fontification of SETF functions.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#2159: closed (23.0.60; [PATCH] Incorrect fontification of
 SETF functions.)
Date: Tue, 08 Mar 2011 04:29:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 07 Mar 2011 23:28:00 -0500
with message-id <2b8vwqutgv.fsf <at> fencepost.gnu.org>
and subject line Re: 23.0.60; [PATCH] Incorrect fontification of SETF functions.
has caused the GNU bug report #2159,
regarding 23.0.60; [PATCH] Incorrect fontification of SETF functions.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
2159: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2159
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: tcr <at> freebits.de
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; [PATCH] Incorrect fontification of SETF functions.
Date: Mon, 02 Feb 2009 12:09:15 +0100

In `lisp-mode', the following forms are fontified incorrectly

  (defun (setf foo) ...)
  (defgeneric (setf foo) ...)
  (defmethod (setf foo) ...)

The closing parenthesis of the function name is fontified in
`font-lock-function-name-face'.

The following patch fixes the issue:

-----------------------------------------------------------
--- font-lock.el	2009-02-02 12:02:12.000000000 +0100
+++ font-lock.el-hacked	2009-02-02 11:45:34.000000000 +0100
@@ -2234,7 +2234,8 @@
 		"\\)\\)\\>"
 		;; Any whitespace and defined object.
 		"[ \t'\(]*"
-		"\\(setf[ \t]+\\sw+)\\|\\sw+\\)?")
+		"\\(setf[ \t]+\\sw+\\|\\sw+\\)?"
+                "[ \t\)]*")
        (1 font-lock-keyword-face)
        (9 (cond ((match-beginning 3) font-lock-function-name-face)
 		((match-beginning 6) font-lock-variable-name-face)

-----------------------------------------------------------

In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-03-19 on vernadsky, modified by Debian
 (emacs-snapshot package, version 1:20080228-1ubuntu1)
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.0.60/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--enable-font-backend' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

-- 
Diese Nachricht wurde auf Viren und andere gefaerliche Inhalte untersucht
und ist - aktuelle Virenscanner vorausgesetzt - sauber.
Freebits E-Mail Virus Scanner

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 2159-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; [PATCH] Incorrect fontification of SETF functions.
Date: Mon, 07 Mar 2011 23:28:00 -0500

Version: 24.1

Thanks for the report, I think this is fixed now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.