From unknown Wed Sep 10 12:14:38 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2159: 23.0.60; [PATCH] Incorrect fontification of SETF functions. Reply-To: tcr@freebits.de, 2159@debbugs.gnu.org Resent-From: tcr@freebits.de Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 02 Feb 2009 11:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 2159 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12335730239281 (code B ref -1); Mon, 02 Feb 2009 11:20:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 2 Feb 2009 11:10:23 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12BAIqo009275 for ; Mon, 2 Feb 2009 03:10:20 -0800 Received: from mail.gnu.org ([199.232.76.166]:56705 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LTwfI-0000If-5f for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 06:08:32 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LTwgu-0007r8-5J for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 06:10:14 -0500 Received: from a022.reverse.yawsp.de ([62.27.20.22]:49064 helo=freebits.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LTwgt-0007oq-Ep for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 06:10:11 -0500 Received: from host145.natpool.mwn.de ([138.246.7.145] helo=thaleron) by freebits.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.44) id 1LTwgT-0006eW-1N for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 11:09:45 +0000 Date: Mon, 02 Feb 2009 12:09:15 +0100 Message-Id: <87bptl6qp0.fsf@freebits.de> To: emacs-pretest-bug@gnu.org MIME-Version: 1.0 X-freebits.de-MailScanner-Information: http://freebits.de X-freebits.de-MailScanner: Sauber X-freebits.de-MailScanner-SpamCheck: not spam, SpamAssassin (notcached, Wertung=1.897, benoetigt 6, FROM_NO_LOWER 1.90) X-freebits.de-MailScanner-SpamScore: s X-MailScanner-From: tcr@freebits.de X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) From: tcr@freebits.de In `lisp-mode', the following forms are fontified incorrectly (defun (setf foo) ...) (defgeneric (setf foo) ...) (defmethod (setf foo) ...) The closing parenthesis of the function name is fontified in `font-lock-function-name-face'. The following patch fixes the issue: ----------------------------------------------------------- --- font-lock.el 2009-02-02 12:02:12.000000000 +0100 +++ font-lock.el-hacked 2009-02-02 11:45:34.000000000 +0100 @@ -2234,7 +2234,8 @@ "\\)\\)\\>" ;; Any whitespace and defined object. "[ \t'\(]*" - "\\(setf[ \t]+\\sw+)\\|\\sw+\\)?") + "\\(setf[ \t]+\\sw+\\|\\sw+\\)?" + "[ \t\)]*") (1 font-lock-keyword-face) (9 (cond ((match-beginning 3) font-lock-function-name-face) ((match-beginning 6) font-lock-variable-name-face) ----------------------------------------------------------- In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9) of 2008-03-19 on vernadsky, modified by Debian (emacs-snapshot package, version 1:20080228-1ubuntu1) Windowing system distributor `The X.Org Foundation', version 11.0.10400090 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.0.60/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--enable-font-backend' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: gnus-topic-mode: t gnus-undo-mode: t shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t -- Diese Nachricht wurde auf Viren und andere gefaerliche Inhalte untersucht und ist - aktuelle Virenscanner vorausgesetzt - sauber. Freebits E-Mail Virus Scanner From rgm@gnu.org Tue Feb 3 19:44:48 2009 Received: (at control) by emacsbugs.donarmstrong.com; 4 Feb 2009 03:44:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n143ij0p005096 for ; Tue, 3 Feb 2009 19:44:46 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LUYfB-0005ye-MS; Tue, 03 Feb 2009 22:42:57 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18825.3777.585548.191552@fencepost.gnu.org> Date: Tue, 3 Feb 2009 22:42:57 -0500 From: Glenn Morris To: control Subject: control message merge 2156 2161 reassign 2184 emacs,ns forcemerge 801 2134 severity 2031 minor severity 2159 minor From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 18:19:15 2010 Received: (at control) by debbugs.gnu.org; 12 Jan 2010 23:19:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUq14-0002zk-Rq for submit@debbugs.gnu.org; Tue, 12 Jan 2010 18:19:15 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUq12-0002zM-ME for control@debbugs.gnu.org; Tue, 12 Jan 2010 18:19:13 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NUq0y-0000P6-Sw; Tue, 12 Jan 2010 18:19:08 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19277.876.873161.909828@fencepost.gnu.org> Date: Tue, 12 Jan 2010 18:19:08 -0500 From: Glenn Morris To: control Subject: reapplying lost changes X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: qz91p)E List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) tags 3597 + patch tags 4951 + patch tags 2159 + patch tags 3175 + patch tags 3887 + patch quit reapplying lost changes from http://lists.gnu.org/archive/html/emacs-bug-tracker/2009-12/msg00029.html http://debbugs.gnu.org/cgi/bugreport.cgi?msg=17;bug=3904 From unknown Wed Sep 10 12:14:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: tcr@freebits.de Subject: bug#2159: closed (Re: 23.0.60; [PATCH] Incorrect fontification of SETF functions.) Message-ID: References: <2b8vwqutgv.fsf@fencepost.gnu.org> <87bptl6qp0.fsf@freebits.de> X-Gnu-PR-Message: they-closed 2159 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 2159@debbugs.gnu.org Date: Tue, 08 Mar 2011 04:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1299558542-28820-1" This is a multi-part message in MIME format... ------------=_1299558542-28820-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #2159: 23.0.60; [PATCH] Incorrect fontification of SETF functions. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 2159@debbugs.gnu.org. --=20 2159: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D2159 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1299558542-28820-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2159-done) by debbugs.gnu.org; 8 Mar 2011 04:28:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwoWn-0007Tf-2o for submit@debbugs.gnu.org; Mon, 07 Mar 2011 23:28:09 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwoWj-0007T8-PY for 2159-done@debbugs.gnu.org; Mon, 07 Mar 2011 23:28:06 -0500 Received: from localhost ([127.0.0.1]:46562) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwoWe-0000x4-7x; Mon, 07 Mar 2011 23:28:00 -0500 From: Glenn Morris To: 2159-done@debbugs.gnu.org Subject: Re: 23.0.60; [PATCH] Incorrect fontification of SETF functions. References: <87bptl6qp0.fsf@freebits.de> X-Spook: Abu Ghraib Audiotel nitrate IMF Marxist BRLO CBNRC LABLINK X-Ran: GjlBN (tcr@freebits.de's message of "Mon, 02 Feb 2009 12:09:15 +0100") Message-ID: <2b8vwqutgv.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 2159-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.1 Thanks for the report, I think this is fixed now. ------------=_1299558542-28820-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 2 Feb 2009 11:10:23 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12BAIqo009275 for ; Mon, 2 Feb 2009 03:10:20 -0800 Received: from mail.gnu.org ([199.232.76.166]:56705 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LTwfI-0000If-5f for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 06:08:32 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LTwgu-0007r8-5J for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 06:10:14 -0500 Received: from a022.reverse.yawsp.de ([62.27.20.22]:49064 helo=freebits.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LTwgt-0007oq-Ep for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 06:10:11 -0500 Received: from host145.natpool.mwn.de ([138.246.7.145] helo=thaleron) by freebits.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.44) id 1LTwgT-0006eW-1N for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 11:09:45 +0000 Date: Mon, 02 Feb 2009 12:09:15 +0100 Message-Id: <87bptl6qp0.fsf@freebits.de> To: emacs-pretest-bug@gnu.org Subject: 23.0.60; [PATCH] Incorrect fontification of SETF functions. MIME-Version: 1.0 X-freebits.de-MailScanner-Information: http://freebits.de X-freebits.de-MailScanner: Sauber X-freebits.de-MailScanner-SpamCheck: not spam, SpamAssassin (notcached, Wertung=1.897, benoetigt 6, FROM_NO_LOWER 1.90) X-freebits.de-MailScanner-SpamScore: s X-MailScanner-From: tcr@freebits.de X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) From: tcr@freebits.de In `lisp-mode', the following forms are fontified incorrectly (defun (setf foo) ...) (defgeneric (setf foo) ...) (defmethod (setf foo) ...) The closing parenthesis of the function name is fontified in `font-lock-function-name-face'. The following patch fixes the issue: ----------------------------------------------------------- --- font-lock.el 2009-02-02 12:02:12.000000000 +0100 +++ font-lock.el-hacked 2009-02-02 11:45:34.000000000 +0100 @@ -2234,7 +2234,8 @@ "\\)\\)\\>" ;; Any whitespace and defined object. "[ \t'\(]*" - "\\(setf[ \t]+\\sw+)\\|\\sw+\\)?") + "\\(setf[ \t]+\\sw+\\|\\sw+\\)?" + "[ \t\)]*") (1 font-lock-keyword-face) (9 (cond ((match-beginning 3) font-lock-function-name-face) ((match-beginning 6) font-lock-variable-name-face) ----------------------------------------------------------- In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9) of 2008-03-19 on vernadsky, modified by Debian (emacs-snapshot package, version 1:20080228-1ubuntu1) Windowing system distributor `The X.Org Foundation', version 11.0.10400090 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.0.60/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--enable-font-backend' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: gnus-topic-mode: t gnus-undo-mode: t shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t -- Diese Nachricht wurde auf Viren und andere gefaerliche Inhalte untersucht und ist - aktuelle Virenscanner vorausgesetzt - sauber. Freebits E-Mail Virus Scanner ------------=_1299558542-28820-1--