GNU bug report logs - #21568
[PATCH] Add prettify-symbols-alist for js-mode

Previous Next

Full log

Message #20 received at 21568 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: xfq.free <at> gmail.com, simenheg <at> gmail.com, 21568 <at> debbugs.gnu.org
Subject: Re: bug#21568: [PATCH] Add prettify-symbols-alist for js-mode
Date: Sun, 27 Sep 2015 09:04:09 +0300

> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Sun, 27 Sep 2015 05:01:51 +0300
> Cc: 21568 <at> debbugs.gnu.org
> 
> On 09/27/2015 03:39 AM, Xue Fuqiao wrote:
> 
> > LGTM.  WDYT, Dmitry and Daniel?
> 
> The patch looks fine to me, but I have no idea if Eli meant to add the 
> cookie at the bottom

I have no preferences in this regard.

> or whether that request really makes sense at all.

In general, ELisp files don't have to have these cookies, but I'd
prefer such changes to trigger adding them, if only for educational
purposes, so our contributors are aware of this subtle issue.

> So I'd prefer if he replies as well.

The patch is fine with me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.