GNU bug report logs - #21554
requesting a new release

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21554 in the body.
You can then email your comments to 21554 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: Grep <bug-grep <at> gnu.org>
Subject: requesting a new release
Date: Thu, 24 Sep 2015 21:50:23 +0200

Hi,

I've run into a bug with grep-2.21 that I can consistently reproduce
with local data, but that I can't find a simple recipe for.  I see
there've been more than a handful of fixes to the source code over
the past ten months; could you make a new release, so that I can
check whether any of those changes fixes my problem?

(I can't get grep to build from git: binary-io.h:53: error:
no previous prototype for 'set_binary_mode'.)

Benno

-- 
http://www.fastmail.com - Same, same, but different...

Message #8 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Benno Schulenberg <bensberg <at> justemail.net>, 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: requesting a new release
Date: Thu, 24 Sep 2015 14:32:41 -0600

[Message part 1 (text/plain, inline)]

On 09/24/2015 01:50 PM, Benno Schulenberg wrote:
> 
> Hi,
> 
> I've run into a bug with grep-2.21 that I can consistently reproduce
> with local data, but that I can't find a simple recipe for.  I see
> there've been more than a handful of fixes to the source code over
> the past ten months; could you make a new release, so that I can
> check whether any of those changes fixes my problem?
> 
> (I can't get grep to build from git: binary-io.h:53: error:
> no previous prototype for 'set_binary_mode'.)

On which platform are you testing? Are you sure you have a matching
gnulib submodule checkout to go along with the grep.git checkout you are
attempting? We should try and fix the reason that is preventing you from
compiling, whether or not there is a release; but that requires more
details.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #11 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Benno Schulenberg <bensberg <at> justemail.net>, 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: requesting a new release
Date: Thu, 24 Sep 2015 13:36:10 -0700

On 09/24/2015 12:50 PM, Benno Schulenberg wrote:
> (I can't get grep to build from git: binary-io.h:53: error:
> no previous prototype for 'set_binary_mode'.)

If you're having that problem with git grep, you'd surely have the same 
problem if we made a new grep release.  Can you please give more 
details?  What are the last few lines of output for 'make V=1'?

Also, can you attach the preprocessor output for the failing command?  
That is, assuming the failing command is something like 'gcc ... -c -o 
binary-io.o binary-io.c', what is the output of 'gcc ... -E 
binary-io.c', where the '...' stands for the same compiler flags in both 
cases?  The preprocessor output may be long, and in that case please 
compress it before attaching it.

Message #14 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: Eric Blake <eblake <at> redhat.com>
Cc: 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: no previous prototype for 'set_binary_mode'
Date: Fri, 25 Sep 2015 09:29:29 +0200

[Message part 1 (text/plain, inline)]

On Thu, Sep 24, 2015, at 22:32, Eric Blake wrote:
> On 09/24/2015 01:50 PM, Benno Schulenberg wrote:
> > (I can't get grep to build from git: binary-io.h:53: error:
> > no previous prototype for 'set_binary_mode'.)
> 
> On which platform are you testing?

Ubuntu Lucid.

$ gcc --version | head -1
gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3

> Are you sure you have a matching
> gnulib submodule checkout to go along with the grep.git checkout you are
> attempting?

I've rerun ./bootstrap.  (I suggest the attached patch to make
the script respond differently when updating an existing checkout 
as opposed to making a full, new checkout.)

> We should try and fix the reason that is preventing you from
> compiling, whether or not there is a release; but that requires more
> details.

Coming up in the next mail.

Benno

-- 
http://www.fastmail.com - Does exactly what it says on the tin

[differentiate-the-wording.patch (text/x-diff, attachment)]

Message #17 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: no previous prototype for 'set_binary_mode'
Date: Fri, 25 Sep 2015 09:40:01 +0200

[Message part 1 (text/plain, inline)]

On Thu, Sep 24, 2015, at 22:36, Paul Eggert wrote:
> On 09/24/2015 12:50 PM, Benno Schulenberg wrote:
> > (I can't get grep to build from git: binary-io.h:53: error:
> > no previous prototype for 'set_binary_mode'.)
> 
> If you're having that problem with git grep, you'd surely have the same 
> problem if we made a new grep release.

Yeah, you're probably right; realized that too later.


>  Can you please give more 
> details?

  [...]
  GEN    time.h
  GEN    unistd.h
  GEN    wchar.h
  GEN    wctype.h
make  all-am
make[3]: Entering directory `/home/ben/Repositories/GREP/lib'
  CC     argmatch.o
cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but not for C
  CC     binary-io.o
cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but not for C
cc1: warnings being treated as errors
In file included from binary-io.c:3:
binary-io.h:53: error: no previous prototype for 'set_binary_mode'
make[3]: *** [binary-io.o] Error 1
make[3]: Leaving directory `/home/ben/Repositories/GREP/lib'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/ben/Repositories/GREP/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/ben/Repositories/GREP'
make: *** [all] Fout 2


>  What are the last few lines of output for 'make V=1'?

make[3]: Entering directory `/home/ben/Repositories/GREP/lib'
depbase=`echo binary-io.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
	gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..    -W -Wabi -Waddress -Wall -Wattributes -Wbad-function-cast -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcomments -Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wenum-compare -Wextra -Wformat-contains-nul -Wformat-extra-args -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wformat-zero-length -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wlogical-op -Wmain -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-parameter-type -Wmissing-prototypes -Wmultichar -Wnested-externs -Wnonnull -Wold-style-declaration -Wold-style-definition -Woverflow -Woverlength-strings -Woverride-init -Wpacked -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wreturn-type -Wsequence-point -Wshadow -Wstrict-aliasing -Wstrict-prototypes -Wswitch -Wsync-nand -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wnormalized=nfc -Wno-missing-field-initializers -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -Wno-logical-op -Wno-format-nonliteral -Werror -g -Os -Wextra -MT binary-io.o -MD -MP -MF $depbase.Tpo -c -o binary-io.o binary-io.c &&\
	mv -f $depbase.Tpo $depbase.Po
cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but not for C
cc1: warnings being treated as errors
In file included from binary-io.c:3:
binary-io.h:53: error: no previous prototype for 'set_binary_mode'


> Also, can you attach the preprocessor output for the failing command?  
> That is, assuming the failing command is something like 'gcc ... -c -o 
> binary-io.o binary-io.c', what is the output of 'gcc ... -E 
> binary-io.c', where the '...' stands for the same compiler flags in both 
> cases?

Attached.

Benno

-- 
http://www.fastmail.com - Access your email from home and the web

[preproc.output.gz (application/x-gzip, attachment)]

Message #20 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: Eric Blake <eblake <at> redhat.com>
Cc: 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: no previous prototype for 'set_binary_mode'
Date: Fri, 25 Sep 2015 12:07:40 +0200

On Fri, Sep 25, 2015, at 09:29, Benno Schulenberg wrote:
> On Thu, Sep 24, 2015, at 22:32, Eric Blake wrote:
> > On which platform are you testing?
> 
> Ubuntu Lucid.
> 
> $ gcc --version | head -1
> gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3
> 
> > Are you sure you have a matching
> > gnulib submodule checkout to go along with the grep.git checkout you are
> > attempting?
> 
> I've rerun ./bootstrap.

Oh -- to get through the bootstrap stage, I've had to make the
following few changes, a slight lowering of the requirements:


diff --git a/Makefile.am b/Makefile.am
index 3a2ed84..e084c9e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,7 +15,9 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
-AUTOMAKE_OPTIONS = gnu 1.12
+AUTOMAKE_OPTIONS = gnu 1.11.1
+
+ACLOCAL_AMFLAGS = -I m4
 
 SUBDIRS = po lib doc src tests gnulib-tests
 
diff --git a/configure.ac b/configure.ac
index 3f6d389..608fff7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -66,7 +66,6 @@ AC_CONFIG_AUX_DIR(build-aux)
 AC_CONFIG_SRCDIR(src/grep.c)
 AC_DEFINE([GREP], 1, [We are building grep])
 AC_PREREQ(2.59)
-AC_CONFIG_MACRO_DIRS([m4])
 
 dnl Automake stuff.
 AM_INIT_AUTOMAKE([1.11 no-dist-gzip dist-xz color-tests parallel-tests
@@ -180,7 +179,7 @@ AC_FUNC_CLOSEDIR_VOID
 AC_CHECK_FUNCS_ONCE(isascii setlocale)
 
 dnl I18N feature
-AM_GNU_GETTEXT_VERSION([0.18.2])
+AM_GNU_GETTEXT_VERSION([0.17])
 AM_GNU_GETTEXT([external])
 
 dnl Some installers want to be informed if we do not use our regex.

Benno

-- 
http://www.fastmail.com - The way an email service should be

Message #23 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: no previous prototype for 'set_binary_mode'
Date: Fri, 25 Sep 2015 12:07:28 -0700

On 09/25/2015 12:40 AM, Benno Schulenberg wrote:
>    CC     argmatch.o
> cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but not for C
>    CC     binary-io.o
> cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but not for C
> cc1: warnings being treated as errors
> In file included from binary-io.c:3:
> binary-io.h:53: error: no previous prototype for 'set_binary_mode'
>

Thanks, I managed to reproduce this on an old RHEL 6 server we have.  It 
uses GCC 4.4.7, which is too old for use with --enable-gcc-warnings.  
Please configure without --enable-gcc-warnings and build it that way; it 
should build fine. That is, a plain './configure; make; make check' 
should work.  (Of course you may run into problems with your old buggy 
libpcre, but that's a different story....)

Nowadays I don't recommend RHEL 6 for use when maintaining GNU software, 
as it has too many old versions of development programs (as you already 
discovered for Autoconf).  It's OK to use it to build from distribution 
tarballs, but not for building from git.

I.e., let's not worry about this build-time problem; instead, let's 
focus on the bug report's original grep-2.21 issue, whatever that issue is.

Message #26 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: no previous prototype for 'set_binary_mode'
Date: Sat, 26 Sep 2015 08:27:54 +0200

On Fri, Sep 25, 2015, at 21:07, Paul Eggert wrote:
> On 09/25/2015 12:40 AM, Benno Schulenberg wrote:
> > In file included from binary-io.c:3:
> > binary-io.h:53: error: no previous prototype for 'set_binary_mode'
> 
> Thanks, I managed to reproduce this on an old RHEL 6 server we have.  It 
> uses GCC 4.4.7, which is too old for use with --enable-gcc-warnings.  
> Please configure without --enable-gcc-warnings and build it that way; it 
> should build fine. That is, a plain './configure; make; make check' 
> should work.

No, a plain ./configure does not work; that's how I've built grep always.
But a './configure --disable-gcc-warnings && make' does work.

$ src/grep --version | head -1
src/grep (GNU grep) 2.21.65-4f89-dirty

Maybe ./configure should detect the compiler version and
automatically add --disable-gcc-warnings for old versions?


>  (Of course you may run into problems with your old buggy 
> libpcre, but that's a different story....)

Well, configure says this:

  checking for PCRE... no
  checking for pcre_compile... no
  configure: WARNING: GNU grep will be built without pcre support.

So it seems I won't have problems there.  :)

Benno

-- 
http://www.fastmail.com - IMAP accessible web-mail

Message #29 received at 21554 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 21554 <at> debbugs.gnu.org
Subject: Re: bug#21554: no previous prototype for 'set_binary_mode'
Date: Sat, 26 Sep 2015 07:35:32 -0700

Benno Schulenberg wrote:
> Maybe ./configure should detect the compiler version and
> automatically add --disable-gcc-warnings for old versions?

That would be one more hassle to maintain.  I'd rather not bother dealing with 
software archaeology.  Just configure with --disable-gcc-warnings.  Or you can 
remove your .git subdirectory, as it's likely to cause other such problems, as 
the assumption is that if you're using bleeding-edge sources you will have 
up-to-date tools.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.