GNU bug report logs - #21513
assertion error in pop_fail_stack

Previous Next

Package: grep;

Reported by: Hanno Böck <hanno <at> hboeck.de>

Date: Fri, 18 Sep 2015 16:38:02 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #48 received at 21513-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Martin Liška <mliska <at> suse.cz>
Cc: 21513-done <at> debbugs.gnu.org, Andreas Schwab <schwab <at> suse.de>
Subject: Re: bug#21513: (now an infinite loop in grep/tests/triple-backref?)
Date: Mon, 20 Jan 2020 09:50:23 -0800
[Message part 1 (text/plain, inline)]
On 1/20/20 2:49 AM, Martin Liška wrote:
> 
> In this case an infinite loop is highly undesirable.

Sure, but the regex code is littered with highly undesirable code like this, as 
it's easy to use a weird regexp to make the code explode exponentially and 
there's little practical difference between that an infinite loop.

Come to think of it, the grep test infrastructure already has a way to deal with 
this sort of thing, so all we need to do to fix this particular glitch is adjust 
triple-backref to use timeout, which I did by installing the attached patch.

Thanks Andreas for diagnosing the problem. I hope there's a gcc bug report about 
it somewhere. I could not use Martin's recipe on Fedora 31 x86-64 because gcc 
-m32 -flto didn't look inside the .a files that the grep build procedure creates 
and uses. I've never had much luck with -flto anyway as it has a habit of 
running into compiler bugs. I now also see that Red Hat has qualms about the 
GOLD linker <https://fedoraproject.org/wiki/Changes/BINUTILS_GOLD> which the 
recipe relies on, as Google has decided not to continue GOLD development (which 
was news to me).

I'll mark Bug#21513 as done again, since the original report is fixed. The 
triple-backref bug is Bug#22793 and also glibc bug 11053, both of which are 
still open.
[0001-tests-work-around-GCC-fprofile-generate-bug.patch (text/x-patch, attachment)]

This bug report was last modified 5 years and 174 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.